[PATCH -next] optprobes: fix kconfig depends/selects

[PATCH -next] optprobes: fix kconfig depends/selects

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.

warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc:	Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc:	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc:	"David S. Miller" <davem@davemloft.net>
Cc:	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
---
 arch/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

--- linux-next-20100810.orig/arch/Kconfig
+++ linux-next-20100810/arch/Kconfig
@@ -45,6 +45,8 @@ config OPTPROBES
 	def_bool y
 	depends on KPROBES && HAVE_OPTPROBES
 	depends on !PREEMPT
+	depends on DEBUG_KERNEL
+	select KALLSYMS
 	select KALLSYMS_ALL
 
 config HAVE_EFFICIENT_UNALIGNED_ACCESS

Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Masami Hiramatsu]

Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.

Indeed, Thanks for pointing it!

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

> 
> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc:	Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Cc:	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
> Cc:	"David S. Miller" <davem@davemloft.net>
> Cc:	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> ---
>  arch/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-next-20100810.orig/arch/Kconfig
> +++ linux-next-20100810/arch/Kconfig
> @@ -45,6 +45,8 @@ config OPTPROBES
>  	def_bool y
>  	depends on KPROBES && HAVE_OPTPROBES
>  	depends on !PREEMPT
> +	depends on DEBUG_KERNEL
> +	select KALLSYMS
>  	select KALLSYMS_ALL
>  
>  config HAVE_EFFICIENT_UNALIGNED_ACCESS

Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Masami Hiramatsu]

Masami Hiramatsu wrote:
> Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
> 
> Indeed, Thanks for pointing it!
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Oops, I meant;
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Sorry:(
> 
>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc:	Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>> Cc:	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
>> Cc:	"David S. Miller" <davem@davemloft.net>
>> Cc:	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>> ---
>>  arch/Kconfig |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> --- linux-next-20100810.orig/arch/Kconfig
>> +++ linux-next-20100810/arch/Kconfig
>> @@ -45,6 +45,8 @@ config OPTPROBES
>>  	def_bool y
>>  	depends on KPROBES && HAVE_OPTPROBES
>>  	depends on !PREEMPT
>> +	depends on DEBUG_KERNEL
>> +	select KALLSYMS
>>  	select KALLSYMS_ALL
>>  
>>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
> 
> 

Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Felipe Contreras]

On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
>
> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc:     Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Cc:     Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
> Cc:     "David S. Miller" <davem@davemloft.net>
> Cc:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> ---
>  arch/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
>
> --- linux-next-20100810.orig/arch/Kconfig
> +++ linux-next-20100810/arch/Kconfig
> @@ -45,6 +45,8 @@ config OPTPROBES
>        def_bool y
>        depends on KPROBES && HAVE_OPTPROBES
>        depends on !PREEMPT
> +       depends on DEBUG_KERNEL
> +       select KALLSYMS
>        select KALLSYMS_ALL
>
>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
> --

This causes another problem:

arch/Kconfig:33:error: recursive dependency detected!
arch/Kconfig:33:	symbol KPROBES depends on KALLSYMS
init/Kconfig:825:	symbol KALLSYMS is selected by OPTPROBES
arch/Kconfig:44:	symbol OPTPROBES depends on KPROBES

The 'select KALLSYMS' is redundant.

Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

-- 
Felipe Contreras

Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Randy Dunlap]

On 09/12/10 03:49, Felipe Contreras wrote:
> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
>>
>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc:     Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>> Cc:     Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
>> Cc:     "David S. Miller" <davem@davemloft.net>
>> Cc:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>> ---
>>  arch/Kconfig |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> --- linux-next-20100810.orig/arch/Kconfig
>> +++ linux-next-20100810/arch/Kconfig
>> @@ -45,6 +45,8 @@ config OPTPROBES
>>        def_bool y
>>        depends on KPROBES && HAVE_OPTPROBES
>>        depends on !PREEMPT
>> +       depends on DEBUG_KERNEL
>> +       select KALLSYMS
>>        select KALLSYMS_ALL
>>
>>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
>> --
> 
> This causes another problem:
> 
> arch/Kconfig:33:error: recursive dependency detected!
> arch/Kconfig:33:	symbol KPROBES depends on KALLSYMS
> init/Kconfig:825:	symbol KALLSYMS is selected by OPTPROBES
> arch/Kconfig:44:	symbol OPTPROBES depends on KPROBES
> 
> The 'select KALLSYMS' is redundant.
> 
> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

Thanks for checking.  I saw this problem just a day or two ago myself.

Dropping the select does not eliminate the kconfig warning.
I'll try something else.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Felipe Contreras]

On Sun, Sep 12, 2010 at 9:34 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On 09/12/10 03:49, Felipe Contreras wrote:
>> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
>>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
>>>
>>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>> Cc:     Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>>> Cc:     Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
>>> Cc:     "David S. Miller" <davem@davemloft.net>
>>> Cc:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>>> ---
>>>  arch/Kconfig |    2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> --- linux-next-20100810.orig/arch/Kconfig
>>> +++ linux-next-20100810/arch/Kconfig
>>> @@ -45,6 +45,8 @@ config OPTPROBES
>>>        def_bool y
>>>        depends on KPROBES && HAVE_OPTPROBES
>>>        depends on !PREEMPT
>>> +       depends on DEBUG_KERNEL
>>> +       select KALLSYMS
>>>        select KALLSYMS_ALL
>>>
>>>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
>>> --
>>
>> This causes another problem:
>>
>> arch/Kconfig:33:error: recursive dependency detected!
>> arch/Kconfig:33:      symbol KPROBES depends on KALLSYMS
>> init/Kconfig:825:     symbol KALLSYMS is selected by OPTPROBES
>> arch/Kconfig:44:      symbol OPTPROBES depends on KPROBES
>>
>> The 'select KALLSYMS' is redundant.
>>
>> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>
> Thanks for checking.  I saw this problem just a day or two ago myself.
>
> Dropping the select does not eliminate the kconfig warning.
> I'll try something else.

Huh? The original warning is gone by just adding 'depends on DEBUG_KERNEL'.

-- 
Felipe Contreras

Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Randy Dunlap]

On Sun, 12 Sep 2010 21:41:07 +0300 Felipe Contreras wrote:

> On Sun, Sep 12, 2010 at 9:34 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > On 09/12/10 03:49, Felipe Contreras wrote:
> >> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> >>> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>>
> >>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
> >>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
> >>>
> >>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
> >>>
> >>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >>> Cc:     Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> >>> Cc:     Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
> >>> Cc:     "David S. Miller" <davem@davemloft.net>
> >>> Cc:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> >>> ---
> >>>  arch/Kconfig |    2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> --- linux-next-20100810.orig/arch/Kconfig
> >>> +++ linux-next-20100810/arch/Kconfig
> >>> @@ -45,6 +45,8 @@ config OPTPROBES
> >>>        def_bool y
> >>>        depends on KPROBES && HAVE_OPTPROBES
> >>>        depends on !PREEMPT
> >>> +       depends on DEBUG_KERNEL
> >>> +       select KALLSYMS
> >>>        select KALLSYMS_ALL
> >>>
> >>>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
> >>> --
> >>
> >> This causes another problem:
> >>
> >> arch/Kconfig:33:error: recursive dependency detected!
> >> arch/Kconfig:33:      symbol KPROBES depends on KALLSYMS
> >> init/Kconfig:825:     symbol KALLSYMS is selected by OPTPROBES
> >> arch/Kconfig:44:      symbol OPTPROBES depends on KPROBES
> >>
> >> The 'select KALLSYMS' is redundant.
> >>
> >> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >
> > Thanks for checking.  I saw this problem just a day or two ago myself.
> >
> > Dropping the select does not eliminate the kconfig warning.
> > I'll try something else.
> 
> Huh? The original warning is gone by just adding 'depends on DEBUG_KERNEL'.

not so in my testing.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Masami Hiramatsu]

(2010/09/12 19:49), Felipe Contreras wrote:
> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
>>
>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc:     Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>> Cc:     Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
>> Cc:     "David S. Miller" <davem@davemloft.net>
>> Cc:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>> ---
>>  arch/Kconfig |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> --- linux-next-20100810.orig/arch/Kconfig
>> +++ linux-next-20100810/arch/Kconfig
>> @@ -45,6 +45,8 @@ config OPTPROBES
>>        def_bool y
>>        depends on KPROBES && HAVE_OPTPROBES
>>        depends on !PREEMPT
>> +       depends on DEBUG_KERNEL
>> +       select KALLSYMS
>>        select KALLSYMS_ALL
>>
>>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
>> --
> 
> This causes another problem:
> 
> arch/Kconfig:33:error: recursive dependency detected!
> arch/Kconfig:33:	symbol KPROBES depends on KALLSYMS
> init/Kconfig:825:	symbol KALLSYMS is selected by OPTPROBES
> arch/Kconfig:44:	symbol OPTPROBES depends on KPROBES
> 
> The 'select KALLSYMS' is redundant.
> 
> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> 

Thanks, let me clear the dependency;
Kprobes uses kallsyms_lookup for finding target function and checking
instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS
and CONFIG_KALLSYMS_ALL.
Optprobe is a optional feature which is supported on x86 arch, and
it also uses kallsyms_lookup for checking instructions in the target
function. Anyway, since optprobe itself is depends on kprobes, it doesn't
need to select both of KALLSYMS/KALLSYMS_ALL.

Thank you,

-- 
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com

Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Masami Hiramatsu]

(2010/09/13 10:06), Masami Hiramatsu wrote:
> (2010/09/12 19:49), Felipe Contreras wrote:
>> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
>>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
>>>
>>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>> Cc:     Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>>> Cc:     Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
>>> Cc:     "David S. Miller" <davem@davemloft.net>
>>> Cc:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>>> ---
>>>  arch/Kconfig |    2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> --- linux-next-20100810.orig/arch/Kconfig
>>> +++ linux-next-20100810/arch/Kconfig
>>> @@ -45,6 +45,8 @@ config OPTPROBES
>>>        def_bool y
>>>        depends on KPROBES && HAVE_OPTPROBES
>>>        depends on !PREEMPT
>>> +       depends on DEBUG_KERNEL
>>> +       select KALLSYMS
>>>        select KALLSYMS_ALL
>>>
>>>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
>>> --
>>
>> This causes another problem:
>>
>> arch/Kconfig:33:error: recursive dependency detected!
>> arch/Kconfig:33:	symbol KPROBES depends on KALLSYMS
>> init/Kconfig:825:	symbol KALLSYMS is selected by OPTPROBES
>> arch/Kconfig:44:	symbol OPTPROBES depends on KPROBES
>>
>> The 'select KALLSYMS' is redundant.
>>
>> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>
> 
> Thanks, let me clear the dependency;
> Kprobes uses kallsyms_lookup for finding target function and checking
> instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS
> and CONFIG_KALLSYMS_ALL.
> Optprobe is a optional feature which is supported on x86 arch, and
> it also uses kallsyms_lookup for checking instructions in the target
> function. Anyway, since optprobe itself is depends on kprobes, it doesn't
> need to select both of KALLSYMS/KALLSYMS_ALL.

Hmm, wait, I might misunderstand something here. I thought
KALLSYMS_ALL added symbols of static functions.
But, does KALLSYMS_ALL just add symbols of variables?
If so, both of KPROBES and OPTPROBES require only KALLSYMS.
It means that they don't need to care about CONFIG_DEBUG_KERNEL.

Thank you,

-- 
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com

Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Felipe Contreras]

On Mon, Sep 13, 2010 at 10:15 AM, Masami Hiramatsu
<masami.hiramatsu.pt@hitachi.com> wrote:
> (2010/09/13 10:06), Masami Hiramatsu wrote:
>> (2010/09/12 19:49), Felipe Contreras wrote:
>>> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>>
>>>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
>>>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
>>>>
>>>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>>>>
>>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>>> Cc:     Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>>>> Cc:     Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
>>>> Cc:     "David S. Miller" <davem@davemloft.net>
>>>> Cc:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>>>> ---
>>>>  arch/Kconfig |    2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> --- linux-next-20100810.orig/arch/Kconfig
>>>> +++ linux-next-20100810/arch/Kconfig
>>>> @@ -45,6 +45,8 @@ config OPTPROBES
>>>>        def_bool y
>>>>        depends on KPROBES && HAVE_OPTPROBES
>>>>        depends on !PREEMPT
>>>> +       depends on DEBUG_KERNEL
>>>> +       select KALLSYMS
>>>>        select KALLSYMS_ALL
>>>>
>>>>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
>>>> --
>>>
>>> This causes another problem:
>>>
>>> arch/Kconfig:33:error: recursive dependency detected!
>>> arch/Kconfig:33:     symbol KPROBES depends on KALLSYMS
>>> init/Kconfig:825:    symbol KALLSYMS is selected by OPTPROBES
>>> arch/Kconfig:44:     symbol OPTPROBES depends on KPROBES
>>>
>>> The 'select KALLSYMS' is redundant.
>>>
>>> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>>
>>
>> Thanks, let me clear the dependency;
>> Kprobes uses kallsyms_lookup for finding target function and checking
>> instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS
>> and CONFIG_KALLSYMS_ALL.
>> Optprobe is a optional feature which is supported on x86 arch, and
>> it also uses kallsyms_lookup for checking instructions in the target
>> function. Anyway, since optprobe itself is depends on kprobes, it doesn't
>> need to select both of KALLSYMS/KALLSYMS_ALL.
>
> Hmm, wait, I might misunderstand something here. I thought
> KALLSYMS_ALL added symbols of static functions.
> But, does KALLSYMS_ALL just add symbols of variables?
> If so, both of KPROBES and OPTPROBES require only KALLSYMS.
> It means that they don't need to care about CONFIG_DEBUG_KERNEL.

So:
-       select KALLSYMS_ALL
+       depends on KALLSYMS_ALL

Because KALLSYMS_ALL depends on DEBUG_KERNEL && KALLSYMS.

-- 
Felipe Contreras

Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Masami Hiramatsu]

(2010/09/13 18:41), Felipe Contreras wrote:
> On Mon, Sep 13, 2010 at 10:15 AM, Masami Hiramatsu
> <masami.hiramatsu.pt@hitachi.com> wrote:
>> (2010/09/13 10:06), Masami Hiramatsu wrote:
>>> (2010/09/12 19:49), Felipe Contreras wrote:
>>>> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>>>
>>>>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
>>>>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
>>>>>
>>>>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>>>>>
>>>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>>>> Cc:     Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>>>>> Cc:     Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
>>>>> Cc:     "David S. Miller" <davem@davemloft.net>
>>>>> Cc:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>>>>> ---
>>>>>  arch/Kconfig |    2 ++
>>>>>  1 file changed, 2 insertions(+)
>>>>>
>>>>> --- linux-next-20100810.orig/arch/Kconfig
>>>>> +++ linux-next-20100810/arch/Kconfig
>>>>> @@ -45,6 +45,8 @@ config OPTPROBES
>>>>>        def_bool y
>>>>>        depends on KPROBES && HAVE_OPTPROBES
>>>>>        depends on !PREEMPT
>>>>> +       depends on DEBUG_KERNEL
>>>>> +       select KALLSYMS
>>>>>        select KALLSYMS_ALL
>>>>>
>>>>>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
>>>>> --
>>>>
>>>> This causes another problem:
>>>>
>>>> arch/Kconfig:33:error: recursive dependency detected!
>>>> arch/Kconfig:33:     symbol KPROBES depends on KALLSYMS
>>>> init/Kconfig:825:    symbol KALLSYMS is selected by OPTPROBES
>>>> arch/Kconfig:44:     symbol OPTPROBES depends on KPROBES
>>>>
>>>> The 'select KALLSYMS' is redundant.
>>>>
>>>> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>>>
>>>
>>> Thanks, let me clear the dependency;
>>> Kprobes uses kallsyms_lookup for finding target function and checking
>>> instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS
>>> and CONFIG_KALLSYMS_ALL.
>>> Optprobe is a optional feature which is supported on x86 arch, and
>>> it also uses kallsyms_lookup for checking instructions in the target
>>> function. Anyway, since optprobe itself is depends on kprobes, it doesn't
>>> need to select both of KALLSYMS/KALLSYMS_ALL.
>>
>> Hmm, wait, I might misunderstand something here. I thought
>> KALLSYMS_ALL added symbols of static functions.
>> But, does KALLSYMS_ALL just add symbols of variables?
>> If so, both of KPROBES and OPTPROBES require only KALLSYMS.
>> It means that they don't need to care about CONFIG_DEBUG_KERNEL.
> 
> So:
> -       select KALLSYMS_ALL
> +       depends on KALLSYMS_ALL
> 
> Because KALLSYMS_ALL depends on DEBUG_KERNEL && KALLSYMS.

No, what I meant is;
-       select KALLSYMS_ALL

:-)



-- 
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com

[PATCH -next,-tip ] kprobes: Fix Kconfig dependency

[Masami Hiramatsu]

Fix Kconfig dependency among Kprobes, optprobe and kallsyms.

Kprobes uses kallsyms_lookup for finding target function and checking
instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS.

Optprobe is an optional feature which is supported on x86 arch, and
it also uses kallsyms_lookup for checking instructions in the target
function. Since KALLSYMS_ALL just adds symbols of kernel variables,
it doesn't need to select KALLSYMS_ALL.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Cc: linux-kernel@vger.kernel.org,
Cc: linux-next@vger.kernel.org,
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Cc: "David S. Miller" <davem@davemloft.net>,
Cc: akpm <akpm@linux-foundation.org>
---

 arch/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index 4877a8c..fe48fc7 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -32,8 +32,9 @@ config HAVE_OPROFILE
 
 config KPROBES
 	bool "Kprobes"
-	depends on KALLSYMS && MODULES
+	depends on MODULES
 	depends on HAVE_KPROBES
+	select KALLSYMS
 	help
 	  Kprobes allows you to trap at almost any kernel address and
 	  execute a callback function.  register_kprobe() establishes
@@ -45,7 +46,6 @@ config OPTPROBES
 	def_bool y
 	depends on KPROBES && HAVE_OPTPROBES
 	depends on !PREEMPT
-	select KALLSYMS_ALL
 
 config HAVE_EFFICIENT_UNALIGNED_ACCESS
 	bool

[PATCH -next,-tip ] kprobes: Fix Kconfig dependency

[Masami Hiramatsu]

Fix Kconfig dependency among Kprobes, optprobe and kallsyms.

Kprobes uses kallsyms_lookup for finding target function and checking
instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS.

Optprobe is an optional feature which is supported on x86 arch, and
it also uses kallsyms_lookup for checking instructions in the target
function. Since KALLSYMS_ALL just adds symbols of kernel variables,
it doesn't need to select KALLSYMS_ALL.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Cc: linux-kernel@vger.kernel.org,
Cc: linux-next@vger.kernel.org,
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
Cc: "David S. Miller" <davem@davemloft.net>,
Cc: akpm <akpm@linux-foundation.org>
---

 arch/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index 4877a8c..fe48fc7 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -32,8 +32,9 @@ config HAVE_OPROFILE
 
 config KPROBES
 	bool "Kprobes"
-	depends on KALLSYMS && MODULES
+	depends on MODULES
 	depends on HAVE_KPROBES
+	select KALLSYMS
 	help
 	  Kprobes allows you to trap at almost any kernel address and
 	  execute a callback function.  register_kprobe() establishes
@@ -45,7 +46,6 @@ config OPTPROBES
 	def_bool y
 	depends on KPROBES && HAVE_OPTPROBES
 	depends on !PREEMPT
-	select KALLSYMS_ALL
 
 config HAVE_EFFICIENT_UNALIGNED_ACCESS
 	bool

Re: [PATCH -next] optprobes: fix kconfig depends/selects

[Felipe Contreras]

On Mon, Sep 13, 2010 at 1:14 PM, Masami Hiramatsu
<masami.hiramatsu.pt@hitachi.com> wrote:
> (2010/09/13 18:41), Felipe Contreras wrote:
>> On Mon, Sep 13, 2010 at 10:15 AM, Masami Hiramatsu
>> <masami.hiramatsu.pt@hitachi.com> wrote:
>>> (2010/09/13 10:06), Masami Hiramatsu wrote:
>>>> (2010/09/12 19:49), Felipe Contreras wrote:
>>>>> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>>>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>>>>
>>>>>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
>>>>>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
>>>>>>
>>>>>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>>>>>>
>>>>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>>>>> Cc:     Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>>>>>> Cc:     Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
>>>>>> Cc:     "David S. Miller" <davem@davemloft.net>
>>>>>> Cc:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>>>>>> ---
>>>>>>  arch/Kconfig |    2 ++
>>>>>>  1 file changed, 2 insertions(+)
>>>>>>
>>>>>> --- linux-next-20100810.orig/arch/Kconfig
>>>>>> +++ linux-next-20100810/arch/Kconfig
>>>>>> @@ -45,6 +45,8 @@ config OPTPROBES
>>>>>>        def_bool y
>>>>>>        depends on KPROBES && HAVE_OPTPROBES
>>>>>>        depends on !PREEMPT
>>>>>> +       depends on DEBUG_KERNEL
>>>>>> +       select KALLSYMS
>>>>>>        select KALLSYMS_ALL
>>>>>>
>>>>>>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
>>>>>> --
>>>>>
>>>>> This causes another problem:
>>>>>
>>>>> arch/Kconfig:33:error: recursive dependency detected!
>>>>> arch/Kconfig:33:     symbol KPROBES depends on KALLSYMS
>>>>> init/Kconfig:825:    symbol KALLSYMS is selected by OPTPROBES
>>>>> arch/Kconfig:44:     symbol OPTPROBES depends on KPROBES
>>>>>
>>>>> The 'select KALLSYMS' is redundant.
>>>>>
>>>>> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>>>>
>>>>
>>>> Thanks, let me clear the dependency;
>>>> Kprobes uses kallsyms_lookup for finding target function and checking
>>>> instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS
>>>> and CONFIG_KALLSYMS_ALL.
>>>> Optprobe is a optional feature which is supported on x86 arch, and
>>>> it also uses kallsyms_lookup for checking instructions in the target
>>>> function. Anyway, since optprobe itself is depends on kprobes, it doesn't
>>>> need to select both of KALLSYMS/KALLSYMS_ALL.
>>>
>>> Hmm, wait, I might misunderstand something here. I thought
>>> KALLSYMS_ALL added symbols of static functions.
>>> But, does KALLSYMS_ALL just add symbols of variables?
>>> If so, both of KPROBES and OPTPROBES require only KALLSYMS.
>>> It means that they don't need to care about CONFIG_DEBUG_KERNEL.
>>
>> So:
>> -       select KALLSYMS_ALL
>> +       depends on KALLSYMS_ALL
>>
>> Because KALLSYMS_ALL depends on DEBUG_KERNEL && KALLSYMS.
>
> No, what I meant is;
> -       select KALLSYMS_ALL
>
> :-)

Ohh, I didn't notice the _ALL. Makes sense.

-- 
Felipe Contreras

Re: [PATCH -next,-tip ] kprobes: Fix Kconfig dependency

[Randy Dunlap]

On 09/13/10 03:25, Masami Hiramatsu wrote:
> Fix Kconfig dependency among Kprobes, optprobe and kallsyms.
> 
> Kprobes uses kallsyms_lookup for finding target function and checking
> instruction boundary, thus CONFIG_KPROBES should select CONFIG_KALLSYMS.
> 
> Optprobe is an optional feature which is supported on x86 arch, and
> it also uses kallsyms_lookup for checking instructions in the target
> function. Since KALLSYMS_ALL just adds symbols of kernel variables,
> it doesn't need to select KALLSYMS_ALL.
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Felipe Contreras <felipe.contreras@gmail.com>
> Cc: Randy Dunlap <randy.dunlap@oracle.com>,
> Cc: linux-kernel@vger.kernel.org,
> Cc: linux-next@vger.kernel.org,
> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
> Cc: "David S. Miller" <davem@davemloft.net>,
> Cc: akpm <akpm@linux-foundation.org>
> ---
> 
>  arch/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/Kconfig b/arch/Kconfig
> index 4877a8c..fe48fc7 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -32,8 +32,9 @@ config HAVE_OPROFILE
>  
>  config KPROBES
>  	bool "Kprobes"
> -	depends on KALLSYMS && MODULES
> +	depends on MODULES
>  	depends on HAVE_KPROBES
> +	select KALLSYMS
>  	help
>  	  Kprobes allows you to trap at almost any kernel address and
>  	  execute a callback function.  register_kprobe() establishes
> @@ -45,7 +46,6 @@ config OPTPROBES
>  	def_bool y
>  	depends on KPROBES && HAVE_OPTPROBES
>  	depends on !PREEMPT
> -	select KALLSYMS_ALL
>  
>  config HAVE_EFFICIENT_UNALIGNED_ACCESS
>  	bool
> 

Fixes the kconfig dependency problem.  Thanks.

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

[tip:perf/urgent] kprobes: Fix Kconfig dependency

[tip-bot for Masami Hiramatsu]

Commit-ID:  05ed160e89baf7f5fb3432d527fec467d2493626
Gitweb:     http://git.kernel.org/tip/05ed160e89baf7f5fb3432d527fec467d2493626
Author:     Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
AuthorDate: Mon, 13 Sep 2010 19:25:41 +0900
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 13 Sep 2010 20:41:31 +0200

kprobes: Fix Kconfig dependency

Fix Kconfig dependency among Kprobes, optprobe and kallsyms.

Kprobes uses kallsyms_lookup for finding target function and
checking instruction boundary, thus CONFIG_KPROBES should select
CONFIG_KALLSYMS.

Optprobe is an optional feature which is supported on x86 arch,
and it also uses kallsyms_lookup for checking instructions in
the target function. Since KALLSYMS_ALL just adds symbols of
kernel variables, it doesn't need to select KALLSYMS_ALL.

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>,
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: akpm <akpm@linux-foundation.org>
LKML-Reference: <20100913102541.20260.85700.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index 4877a8c..fe48fc7 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -32,8 +32,9 @@ config HAVE_OPROFILE
 
 config KPROBES
 	bool "Kprobes"
-	depends on KALLSYMS && MODULES
+	depends on MODULES
 	depends on HAVE_KPROBES
+	select KALLSYMS
 	help
 	  Kprobes allows you to trap at almost any kernel address and
 	  execute a callback function.  register_kprobe() establishes
@@ -45,7 +46,6 @@ config OPTPROBES
 	def_bool y
 	depends on KPROBES && HAVE_OPTPROBES
 	depends on !PREEMPT
-	select KALLSYMS_ALL
 
 config HAVE_EFFICIENT_UNALIGNED_ACCESS
 	bool