From: Anthony Liguori <anthony@codemonkey.ws> To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> Cc: "Michael S. Tsirkin" <mst@redhat.com>, Stefan Weil <weil@mail.berlios.de>, kvm@vger.kernel.org, joro@8bytes.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, yamahata@valinux.co.jp, paul@codesourcery.com, avi@redhat.com Subject: Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support Date: Thu, 02 Sep 2010 08:24:05 -0500 [thread overview] Message-ID: <4C7FA575.8000806@codemonkey.ws> (raw) In-Reply-To: <20100902090812.GA7319@localhost> On 09/02/2010 04:08 AM, Eduard - Gabriel Munteanu wrote: > On Thu, Sep 02, 2010 at 09:00:46AM +0300, Michael S. Tsirkin wrote: > >> On Wed, Sep 01, 2010 at 10:10:30PM +0200, Stefan Weil wrote: >> >>>> +static inline void pci_memory_read(PCIDevice *dev, >>>> + pcibus_t addr, >>>> + uint8_t *buf, >>>> + pcibus_t len) >>>> +{ >>>> + pci_memory_rw(dev, addr, buf, len, 0); >>>> +} >>>> + >>>> +static inline void pci_memory_write(PCIDevice *dev, >>>> + pcibus_t addr, >>>> + const uint8_t *buf, >>>> + pcibus_t len) >>>> +{ >>>> + pci_memory_rw(dev, addr, (uint8_t *) buf, len, 1); >>>> +} >>>> + >>>> #endif >>>> >>> The functions pci_memory_read and pci_memory_write not only read >>> or write byte data but many different data types which leads to >>> a lot of type casts in your other patches. >>> >>> I'd prefer "void *buf" and "const void *buf" in the argument lists. >>> Then all those type casts could be removed. >>> >>> Regards >>> Stefan Weil >>> >> Further, I am not sure pcibus_t is a good type to use here. >> This also forces use of pci specific types in e.g. ide, or resorting to >> casts as this patch does. We probably should use a more generic type >> for this. >> > It only forces use of PCI-specific types in the IDE controller, which is > already a PCI device. > But IDE controllers are not always PCI devices... This isn't an issue with your patch, per-say, but with how we're modelling the IDE controller today. There's no great solution but I think your patch is an improvement over what we have today. I do agree with Stefan though that void * would make a lot more sense. Regards, Anthony Liguori > Eduard > > >> -- >> MST >> > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <anthony@codemonkey.ws> To: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, joro@8bytes.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, paul@codesourcery.com, avi@redhat.com, yamahata@valinux.co.jp Subject: Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support Date: Thu, 02 Sep 2010 08:24:05 -0500 [thread overview] Message-ID: <4C7FA575.8000806@codemonkey.ws> (raw) In-Reply-To: <20100902090812.GA7319@localhost> On 09/02/2010 04:08 AM, Eduard - Gabriel Munteanu wrote: > On Thu, Sep 02, 2010 at 09:00:46AM +0300, Michael S. Tsirkin wrote: > >> On Wed, Sep 01, 2010 at 10:10:30PM +0200, Stefan Weil wrote: >> >>>> +static inline void pci_memory_read(PCIDevice *dev, >>>> + pcibus_t addr, >>>> + uint8_t *buf, >>>> + pcibus_t len) >>>> +{ >>>> + pci_memory_rw(dev, addr, buf, len, 0); >>>> +} >>>> + >>>> +static inline void pci_memory_write(PCIDevice *dev, >>>> + pcibus_t addr, >>>> + const uint8_t *buf, >>>> + pcibus_t len) >>>> +{ >>>> + pci_memory_rw(dev, addr, (uint8_t *) buf, len, 1); >>>> +} >>>> + >>>> #endif >>>> >>> The functions pci_memory_read and pci_memory_write not only read >>> or write byte data but many different data types which leads to >>> a lot of type casts in your other patches. >>> >>> I'd prefer "void *buf" and "const void *buf" in the argument lists. >>> Then all those type casts could be removed. >>> >>> Regards >>> Stefan Weil >>> >> Further, I am not sure pcibus_t is a good type to use here. >> This also forces use of pci specific types in e.g. ide, or resorting to >> casts as this patch does. We probably should use a more generic type >> for this. >> > It only forces use of PCI-specific types in the IDE controller, which is > already a PCI device. > But IDE controllers are not always PCI devices... This isn't an issue with your patch, per-say, but with how we're modelling the IDE controller today. There's no great solution but I think your patch is an improvement over what we have today. I do agree with Stefan though that void * would make a lot more sense. Regards, Anthony Liguori > Eduard > > >> -- >> MST >> > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2010-09-02 13:24 UTC|newest] Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-28 14:54 [PATCH 0/7] AMD IOMMU emulation patchset v4 Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [PATCH 1/7] pci: expand tabs to spaces in pci_regs.h Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-31 20:29 ` Michael S. Tsirkin 2010-08-31 20:29 ` [Qemu-devel] " Michael S. Tsirkin 2010-08-31 22:58 ` Eduard - Gabriel Munteanu 2010-08-31 22:58 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-01 10:39 ` Michael S. Tsirkin 2010-09-01 10:39 ` [Qemu-devel] " Michael S. Tsirkin 2010-08-28 14:54 ` [PATCH 2/7] pci: memory access API and IOMMU support Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-02 5:28 ` Michael S. Tsirkin 2010-09-02 5:28 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-02 8:40 ` Eduard - Gabriel Munteanu 2010-09-02 8:40 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-02 9:49 ` Michael S. Tsirkin 2010-09-02 9:49 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-04 9:01 ` Blue Swirl 2010-09-04 9:01 ` [Qemu-devel] " Blue Swirl 2010-09-05 7:10 ` Michael S. Tsirkin 2010-09-05 7:10 ` [Qemu-devel] " Michael S. Tsirkin 2010-08-28 14:54 ` [PATCH 3/7] AMD IOMMU emulation Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-28 15:58 ` Blue Swirl 2010-08-28 15:58 ` [Qemu-devel] " Blue Swirl 2010-08-28 21:53 ` Eduard - Gabriel Munteanu 2010-08-28 21:53 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-29 20:37 ` Blue Swirl 2010-08-29 20:37 ` [Qemu-devel] " Blue Swirl 2010-08-30 3:07 ` [Qemu-devel] " Isaku Yamahata 2010-08-30 3:07 ` Isaku Yamahata 2010-08-30 5:54 ` Eduard - Gabriel Munteanu 2010-08-30 5:54 ` Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [PATCH 4/7] ide: use the PCI memory access interface Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-02 5:19 ` Michael S. Tsirkin 2010-09-02 5:19 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-02 9:12 ` Eduard - Gabriel Munteanu 2010-09-02 9:12 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-02 9:58 ` Michael S. Tsirkin 2010-09-02 9:58 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-02 15:01 ` Eduard - Gabriel Munteanu 2010-09-02 15:01 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-02 15:24 ` Avi Kivity 2010-09-02 15:24 ` [Qemu-devel] " Avi Kivity 2010-09-02 15:39 ` Michael S. Tsirkin 2010-09-02 15:39 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-02 16:07 ` Avi Kivity 2010-09-02 16:07 ` [Qemu-devel] " Avi Kivity 2010-09-02 15:31 ` Michael S. Tsirkin 2010-09-02 15:31 ` [Qemu-devel] " Michael S. Tsirkin 2010-08-28 14:54 ` [PATCH 5/7] rtl8139: " Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [PATCH 6/7] eepro100: " Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [PATCH 7/7] ac97: " Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-28 16:00 ` [PATCH 0/7] AMD IOMMU emulation patchset v4 Blue Swirl 2010-08-28 16:00 ` [Qemu-devel] " Blue Swirl 2010-08-29 9:55 ` Joerg Roedel 2010-08-29 9:55 ` [Qemu-devel] " Joerg Roedel 2010-08-29 20:44 ` Blue Swirl 2010-08-29 20:44 ` [Qemu-devel] " Blue Swirl 2010-08-29 22:08 ` [PATCH 2/7] pci: memory access API and IOMMU support Eduard - Gabriel Munteanu 2010-08-29 22:08 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-29 22:11 ` Eduard - Gabriel Munteanu 2010-08-29 22:11 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-01 20:10 ` [Qemu-devel] " Stefan Weil 2010-09-01 20:10 ` Stefan Weil 2010-09-02 6:00 ` Michael S. Tsirkin 2010-09-02 6:00 ` Michael S. Tsirkin 2010-09-02 9:08 ` Eduard - Gabriel Munteanu 2010-09-02 9:08 ` Eduard - Gabriel Munteanu 2010-09-02 13:24 ` Anthony Liguori [this message] 2010-09-02 13:24 ` Anthony Liguori 2010-09-02 8:51 ` Eduard - Gabriel Munteanu 2010-09-02 8:51 ` Eduard - Gabriel Munteanu 2010-09-02 16:05 ` Stefan Weil 2010-09-02 16:05 ` Stefan Weil 2010-09-02 16:14 ` Eduard - Gabriel Munteanu 2010-09-02 16:14 ` Eduard - Gabriel Munteanu 2010-09-13 20:01 ` [PATCH RFC] dma_rw.h (was Re: [PATCH 0/7] AMD IOMMU emulation patchset v4) Michael S. Tsirkin 2010-09-13 20:01 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-13 20:45 ` Anthony Liguori 2010-09-13 20:45 ` Anthony Liguori 2010-09-16 7:12 ` Eduard - Gabriel Munteanu 2010-09-16 7:12 ` Eduard - Gabriel Munteanu 2010-09-16 9:35 ` Michael S. Tsirkin 2010-09-16 9:35 ` Michael S. Tsirkin 2010-09-16 7:06 ` Eduard - Gabriel Munteanu 2010-09-16 7:06 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-16 9:20 ` Michael S. Tsirkin 2010-09-16 9:20 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-16 11:15 ` Eduard - Gabriel Munteanu 2010-09-16 11:15 ` [Qemu-devel] " Eduard - Gabriel Munteanu -- strict thread matches above, loose matches on Subject: below -- 2010-08-15 19:27 [PATCH 0/7] AMD IOMMU emulation patches v3 Eduard - Gabriel Munteanu 2010-08-15 19:27 ` [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support Eduard - Gabriel Munteanu 2010-08-18 5:02 ` Isaku Yamahata 2010-08-18 5:02 ` Isaku Yamahata
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4C7FA575.8000806@codemonkey.ws \ --to=anthony@codemonkey.ws \ --cc=avi@redhat.com \ --cc=blauwirbel@gmail.com \ --cc=eduard.munteanu@linux360.ro \ --cc=joro@8bytes.org \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=paul@codesourcery.com \ --cc=qemu-devel@nongnu.org \ --cc=weil@mail.berlios.de \ --cc=yamahata@valinux.co.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.