All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@cfl.rr.com>
To: Tejun Heo <tj@kernel.org>
Cc: Ben Hutchings <ben@decadent.org.uk>,
	Jeff Garzik <jgarzik@redhat.com>,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: libata: implement on-demand HPA unlocking
Date: Tue, 08 Feb 2011 15:23:36 -0500	[thread overview]
Message-ID: <4D51A648.20707@cfl.rr.com> (raw)

Commit d8d9129ea28e2177749627c82962feb26e8d11e9 appears to be an attempt
to fix long standing problems with the Host Protected Area defaulting to
locked/unlocked and the problems that each guess has when it is wrong.

It still causes problems with fakeraid striped arrays however, because
it detects the partition table on the primary disk, sees partitions
beyond the end, and chooses to unlock the HPA to attempt to access those
partitions.  This breaks the fakeraid array since the raid metadata left
by the bios uses the HPA geometry, which becomes incorrect when the HPA
is unlocked.

I propose a slight refinement of the method introduced in this patch.
Rather than unlock the HPA if a partition goes beyond the end of the
current disk, it should check to make sure that doing so will actually
make that partition fully accessible, and don't bother unlocking if it
won't.

Thoughts?

             reply	other threads:[~2011-02-08 20:22 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 20:23 Phillip Susi [this message]
2011-02-09  8:59 ` libata: implement on-demand HPA unlocking Tejun Heo
2011-02-09 15:20   ` Phillip Susi
2011-02-09 15:37     ` Alan Cox
2011-02-09 15:36       ` Tejun Heo
2011-02-09 18:48         ` Jeff Garzik
2011-02-09 19:45           ` Phillip Susi
2011-02-10  9:44             ` Tejun Heo
2011-02-10 18:47               ` Phillip Susi
2011-02-10 19:07                 ` Tejun Heo
2011-02-09 19:39         ` Phillip Susi
2011-02-09 19:36       ` Phillip Susi
2011-02-09 20:47         ` Greg Freemyer
2011-02-09 21:12           ` Phillip Susi
2011-02-09 21:13         ` Alan Cox
2011-02-09 21:28           ` Phillip Susi
2011-02-09 21:39             ` Alan Cox
2011-02-10  0:23               ` Phillip Susi
2011-02-10 12:46                 ` Alan Cox
2011-02-10 18:58                   ` Phillip Susi
2011-02-10 19:19                     ` Tejun Heo
2011-02-11 18:16                       ` Phillip Susi
2011-02-10 12:49                 ` Bartlomiej Zolnierkiewicz
2011-02-10 19:20                   ` Phillip Susi
2011-02-10 19:35                     ` Alan Cox
2011-02-11 18:22                       ` Phillip Susi
2011-02-10 19:37                     ` Alan Cox
2011-02-09 21:41         ` Tejun Heo
2011-02-10  0:35           ` Phillip Susi
2011-02-10  1:46             ` Robert Hancock
2011-02-10  9:13               ` Tejun Heo
2011-02-10 19:11                 ` Phillip Susi
2011-02-10 19:31                   ` Alan Cox
2011-02-11 18:18                     ` Phillip Susi
2011-02-11 18:25                       ` Alan Cox
2011-02-11 18:38                         ` Phillip Susi
2011-02-10 19:32                   ` Tejun Heo
2011-02-10 19:34                     ` Tejun Heo
2011-02-11 18:30                     ` Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D51A648.20707@cfl.rr.com \
    --to=psusi@cfl.rr.com \
    --cc=ben@decadent.org.uk \
    --cc=jgarzik@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.