From: Phillip Susi <psusi@cfl.rr.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Tejun Heo <tj@kernel.org>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Ben Hutchings <ben@decadent.org.uk>,
Jeff Garzik <jgarzik@redhat.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: libata: implement on-demand HPA unlocking
Date: Wed, 09 Feb 2011 14:45:48 -0500 [thread overview]
Message-ID: <4D52EEEC.1020602@cfl.rr.com> (raw)
In-Reply-To: <4D52E180.6020908@garzik.org>
On 2/9/2011 1:48 PM, Jeff Garzik wrote:
> On 02/09/2011 10:36 AM, Tejun Heo wrote:
>> Agreed. We're screwed whether we unlock or leave it alone. I think
>> the best way is to export the original size via sysfs and always
>> unlock and let dmraid and whatever stuff which expects metadata at the
>> end use the bios size.
>
> Agreed...
Then why did you have libata default to NOT unlocking it, which seems to
be the correct thing to do? When Ubuntu switched to libata they patched
it to default to unlocking the HPA because the old ide driver did. This
seems wrong and causes breakage. Tejun's patch seems to be a good
compromise between the two choices: unlock if you think it will help,
otherwise, don't, since it might hurt.
next prev parent reply other threads:[~2011-02-09 19:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 20:23 libata: implement on-demand HPA unlocking Phillip Susi
2011-02-09 8:59 ` Tejun Heo
2011-02-09 15:20 ` Phillip Susi
2011-02-09 15:37 ` Alan Cox
2011-02-09 15:36 ` Tejun Heo
2011-02-09 18:48 ` Jeff Garzik
2011-02-09 19:45 ` Phillip Susi [this message]
2011-02-10 9:44 ` Tejun Heo
2011-02-10 18:47 ` Phillip Susi
2011-02-10 19:07 ` Tejun Heo
2011-02-09 19:39 ` Phillip Susi
2011-02-09 19:36 ` Phillip Susi
2011-02-09 20:47 ` Greg Freemyer
2011-02-09 21:12 ` Phillip Susi
2011-02-09 21:13 ` Alan Cox
2011-02-09 21:28 ` Phillip Susi
2011-02-09 21:39 ` Alan Cox
2011-02-10 0:23 ` Phillip Susi
2011-02-10 12:46 ` Alan Cox
2011-02-10 18:58 ` Phillip Susi
2011-02-10 19:19 ` Tejun Heo
2011-02-11 18:16 ` Phillip Susi
2011-02-10 12:49 ` Bartlomiej Zolnierkiewicz
2011-02-10 19:20 ` Phillip Susi
2011-02-10 19:35 ` Alan Cox
2011-02-11 18:22 ` Phillip Susi
2011-02-10 19:37 ` Alan Cox
2011-02-09 21:41 ` Tejun Heo
2011-02-10 0:35 ` Phillip Susi
2011-02-10 1:46 ` Robert Hancock
2011-02-10 9:13 ` Tejun Heo
2011-02-10 19:11 ` Phillip Susi
2011-02-10 19:31 ` Alan Cox
2011-02-11 18:18 ` Phillip Susi
2011-02-11 18:25 ` Alan Cox
2011-02-11 18:38 ` Phillip Susi
2011-02-10 19:32 ` Tejun Heo
2011-02-10 19:34 ` Tejun Heo
2011-02-11 18:30 ` Phillip Susi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D52EEEC.1020602@cfl.rr.com \
--to=psusi@cfl.rr.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ben@decadent.org.uk \
--cc=jeff@garzik.org \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.