From: Santosh <santosh.shilimkar@ti.com> To: Tarun Kanti DebBarma <tarun.kanti@ti.com> Cc: linux-omap@vger.kernel.org, khilman@ti.com, tony@atomide.com, linux-arm-kernel@lists.infradead.org, Charulatha V <charu@ti.com> Subject: Re: [PATCH v5 01/22] gpio/omap: remove dependency on gpio_bank_count Date: Tue, 23 Aug 2011 18:05:33 +0530 [thread overview] Message-ID: <4E539E95.2080807@ti.com> (raw) In-Reply-To: <1312455893-14922-2-git-send-email-tarun.kanti@ti.com> On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: > From: Charulatha V<charu@ti.com> > > The gpio_bank_count is the count of number of GPIO devices in a SoC. Remove this > dependency from the driver by using list. Also remove the dependency on array of > pointers to gpio_bank struct of all GPIO devices. > > Signed-off-by: Charulatha V<charu@ti.com> > --- > arch/arm/mach-omap1/gpio15xx.c | 1 - > arch/arm/mach-omap1/gpio16xx.c | 2 - > arch/arm/mach-omap1/gpio7xx.c | 2 - > arch/arm/mach-omap2/gpio.c | 1 - > arch/arm/plat-omap/include/plat/gpio.h | 3 - > drivers/gpio/gpio-omap.c | 163 ++++++++++++++++---------------- > 6 files changed, 80 insertions(+), 92 deletions(-) > [...] > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index 34a7110..13d5ca4 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -28,7 +28,10 @@ > #include<mach/gpio.h> > #include<asm/mach/irq.h> > [....] > @@ -1334,17 +1325,17 @@ static int workaround_enabled; > > void omap2_gpio_prepare_for_idle(int off_mode) > { > - int i, c = 0; > - int min = 0; > - > - if (cpu_is_omap34xx()) > - min = 1; > + int c = 0; > + struct gpio_bank *bank; > > - for (i = min; i< gpio_bank_count; i++) { > - struct gpio_bank *bank =&gpio_bank[i]; > + list_for_each_entry(bank,&omap_gpio_list, node) { > u32 l1 = 0, l2 = 0; > int j; > > + /* TODO: Do not use cpu_is_omap34xx */ Is this addressed in subsequent patches ? > + if ((cpu_is_omap34xx())&& (bank->id == 0)) > + continue; > + Rest of the changes looks good to me. After you answer above, you can add my, Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com> Regards Santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 01/22] gpio/omap: remove dependency on gpio_bank_count Date: Tue, 23 Aug 2011 18:05:33 +0530 [thread overview] Message-ID: <4E539E95.2080807@ti.com> (raw) In-Reply-To: <1312455893-14922-2-git-send-email-tarun.kanti@ti.com> On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: > From: Charulatha V<charu@ti.com> > > The gpio_bank_count is the count of number of GPIO devices in a SoC. Remove this > dependency from the driver by using list. Also remove the dependency on array of > pointers to gpio_bank struct of all GPIO devices. > > Signed-off-by: Charulatha V<charu@ti.com> > --- > arch/arm/mach-omap1/gpio15xx.c | 1 - > arch/arm/mach-omap1/gpio16xx.c | 2 - > arch/arm/mach-omap1/gpio7xx.c | 2 - > arch/arm/mach-omap2/gpio.c | 1 - > arch/arm/plat-omap/include/plat/gpio.h | 3 - > drivers/gpio/gpio-omap.c | 163 ++++++++++++++++---------------- > 6 files changed, 80 insertions(+), 92 deletions(-) > [...] > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index 34a7110..13d5ca4 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -28,7 +28,10 @@ > #include<mach/gpio.h> > #include<asm/mach/irq.h> > [....] > @@ -1334,17 +1325,17 @@ static int workaround_enabled; > > void omap2_gpio_prepare_for_idle(int off_mode) > { > - int i, c = 0; > - int min = 0; > - > - if (cpu_is_omap34xx()) > - min = 1; > + int c = 0; > + struct gpio_bank *bank; > > - for (i = min; i< gpio_bank_count; i++) { > - struct gpio_bank *bank =&gpio_bank[i]; > + list_for_each_entry(bank,&omap_gpio_list, node) { > u32 l1 = 0, l2 = 0; > int j; > > + /* TODO: Do not use cpu_is_omap34xx */ Is this addressed in subsequent patches ? > + if ((cpu_is_omap34xx())&& (bank->id == 0)) > + continue; > + Rest of the changes looks good to me. After you answer above, you can add my, Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti.com> Regards Santosh
next prev parent reply other threads:[~2011-08-23 12:35 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-04 11:04 [PATCH v5 00/22] gpio/omap: driver cleanup and fixes Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-04 11:04 ` [PATCH v5 01/22] gpio/omap: remove dependency on gpio_bank_count Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:35 ` Santosh [this message] 2011-08-23 12:35 ` Santosh 2011-08-29 12:18 ` DebBarma, Tarun Kanti 2011-08-29 12:18 ` DebBarma, Tarun Kanti 2011-08-04 11:04 ` [PATCH v5 02/22] gpio/omap: use flag to identify wakeup domain Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:41 ` Santosh 2011-08-23 12:41 ` Santosh 2011-08-04 11:04 ` [PATCH v5 03/22] gpio/omap: make gpio_context part of gpio_bank structure Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:45 ` Santosh 2011-08-23 12:45 ` Santosh 2011-08-25 20:23 ` Kevin Hilman 2011-08-25 20:23 ` Kevin Hilman 2011-08-26 3:57 ` DebBarma, Tarun Kanti 2011-08-26 3:57 ` DebBarma, Tarun Kanti 2011-08-26 14:11 ` Santosh 2011-08-26 14:11 ` Santosh 2011-08-04 11:04 ` [PATCH v5 04/22] gpio/omap: fix pwrdm_post_transition call sequence Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:47 ` Santosh 2011-08-23 12:47 ` Santosh 2011-08-04 11:04 ` [PATCH v5 05/22] gpio/omap: handle save/restore ctx in GPIO driver Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:53 ` Santosh 2011-08-23 12:53 ` Santosh 2011-08-23 14:47 ` Santosh 2011-08-23 14:47 ` Santosh 2011-08-04 11:04 ` [PATCH v5 06/22] gpio/omap: make non-wakeup GPIO part of pdata Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:54 ` Santosh 2011-08-23 12:54 ` Santosh 2011-08-04 11:04 ` [PATCH v5 07/22] gpio/omap: avoid cpu checks during module ena/disable Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:57 ` Santosh 2011-08-23 12:57 ` Santosh 2011-08-04 11:04 ` [PATCH v5 08/22] gpio/omap: further cleanup using wakeup_status register Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:02 ` Santosh 2011-08-23 13:02 ` Santosh 2011-08-04 11:04 ` [PATCH v5 09/22] gpio/omap: cleanup omap1 related macros Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:04 ` Santosh 2011-08-23 13:04 ` Santosh 2011-08-04 11:04 ` [PATCH v5 10/22] gpio/omap: use level/edge detect reg offsets Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:08 ` Santosh 2011-08-23 13:08 ` Santosh 2011-08-04 11:04 ` [PATCH v5 11/22] gpio/omap: remove hardcoded offsets in ctxt save/restore Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:12 ` Santosh 2011-08-23 13:12 ` Santosh 2011-08-04 11:04 ` [PATCH v5 12/22] gpio/omap: cleanup set_gpio_triggering function Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:21 ` Santosh 2011-08-23 13:21 ` Santosh 2011-08-04 11:04 ` [PATCH v5 13/22] gpio/omap: cleanup omap_gpio_mod_init function Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:26 ` Santosh 2011-08-23 13:26 ` Santosh 2011-08-04 11:04 ` [PATCH v5 14/22] gpio/omap: use pinctrl offset instead of macro Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:27 ` Santosh 2011-08-23 13:27 ` Santosh 2011-08-04 11:04 ` [PATCH v5 15/22] gpio/omap: use readl in irq_handler for all access Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:25 ` Santosh 2011-08-23 14:25 ` Santosh 2011-08-04 11:04 ` [PATCH v5 16/22] gpio/omap: remove bank->method & METHOD_* macros Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:27 ` Santosh 2011-08-23 14:27 ` Santosh 2011-08-04 11:04 ` [PATCH v5 17/22] gpio/omap: fix bankwidth for OMAP7xx MPUIO Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:28 ` Santosh 2011-08-23 14:28 ` Santosh 2011-08-04 11:04 ` [PATCH v5 18/22] gpio/omap: use pm-runtime framework Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:34 ` Santosh 2011-08-23 14:34 ` Santosh 2011-08-24 4:02 ` Rajendra Nayak 2011-08-24 4:02 ` Rajendra Nayak 2011-08-24 6:19 ` Santosh 2011-08-24 6:19 ` Santosh 2011-08-04 11:04 ` [PATCH v5 19/22] gpio/omap: optimize suspend and resume functions Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:35 ` Santosh 2011-08-23 14:35 ` Santosh 2011-08-04 11:04 ` [PATCH v5 20/22] gpio/omap: cleanup prepare_for_idle and resume_after_idle Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:40 ` Santosh 2011-08-23 14:40 ` Santosh 2011-08-04 11:04 ` [PATCH v5 21/22] gpio/omap: skip operations in runtime callbacks Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:41 ` Santosh 2011-08-23 14:41 ` Santosh 2011-08-04 11:04 ` [PATCH v5 22/22] gpio/omap: remove omap_gpio_save_context overhead Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:42 ` Santosh 2011-08-23 14:42 ` Santosh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4E539E95.2080807@ti.com \ --to=santosh.shilimkar@ti.com \ --cc=charu@ti.com \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=tarun.kanti@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.