From: Santosh <santosh.shilimkar@ti.com> To: Tarun Kanti DebBarma <tarun.kanti@ti.com> Cc: khilman@ti.com, tony@atomide.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Charulatha V <charu@ti.com> Subject: Re: [PATCH v5 05/22] gpio/omap: handle save/restore ctx in GPIO driver Date: Tue, 23 Aug 2011 18:23:40 +0530 [thread overview] Message-ID: <4E53A2D4.90109@ti.com> (raw) In-Reply-To: <1312455893-14922-6-git-send-email-tarun.kanti@ti.com> On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: > From: Charulatha V<charu@ti.com> > > Modify omap_gpio_prepare_for_idle()& omap_gpio_resume_after_idle() functions > to handle save context& restore context respectively in the OMAP GPIO driver > itself instead of calling these functions from pm specific files. > For this, in gpio_prepare_for_idle(), call *_get_context_loss_count() and in > gpio_resume_after_idle() call it again. If the count is different, do restore > context. The workaround_enabled flag is no more required and is removed. > > Signed-off-by: Charulatha V<charu@ti.com> > Signed-off-by: Tarun Kanti DebBarma<tarun.kanti@ti.com> > --- "ctx" ? Please change it to 'context' is subject and rest of the code. > arch/arm/mach-omap2/gpio.c | 12 +++ > arch/arm/mach-omap2/pm34xx.c | 14 ---- > arch/arm/plat-omap/include/plat/gpio.h | 5 +- > drivers/gpio/gpio-omap.c | 131 ++++++++++++++------------------ > 4 files changed, 73 insertions(+), 89 deletions(-) > > diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c > index 95195a8..2e65377 100644 > --- a/arch/arm/mach-omap2/gpio.c > +++ b/arch/arm/mach-omap2/gpio.c > @@ -23,6 +23,7 @@ > > #include<plat/omap_hwmod.h> > #include<plat/omap_device.h> > +#include<plat/omap-pm.h> > > #include "powerdomain.h" > > @@ -34,6 +35,16 @@ static struct omap_device_pm_latency omap_gpio_latency[] = { > }, > }; > > +#ifdef CONFIG_PM > +static int omap_gpio_get_context_loss(struct device *dev) > +{ > + return omap_pm_get_dev_context_loss_count(dev); > +} Do you really need this wrapper. Use the funtion directly instead. Rest looks fine to me
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 05/22] gpio/omap: handle save/restore ctx in GPIO driver Date: Tue, 23 Aug 2011 18:23:40 +0530 [thread overview] Message-ID: <4E53A2D4.90109@ti.com> (raw) In-Reply-To: <1312455893-14922-6-git-send-email-tarun.kanti@ti.com> On Thursday 04 August 2011 04:34 PM, Tarun Kanti DebBarma wrote: > From: Charulatha V<charu@ti.com> > > Modify omap_gpio_prepare_for_idle()& omap_gpio_resume_after_idle() functions > to handle save context& restore context respectively in the OMAP GPIO driver > itself instead of calling these functions from pm specific files. > For this, in gpio_prepare_for_idle(), call *_get_context_loss_count() and in > gpio_resume_after_idle() call it again. If the count is different, do restore > context. The workaround_enabled flag is no more required and is removed. > > Signed-off-by: Charulatha V<charu@ti.com> > Signed-off-by: Tarun Kanti DebBarma<tarun.kanti@ti.com> > --- "ctx" ? Please change it to 'context' is subject and rest of the code. > arch/arm/mach-omap2/gpio.c | 12 +++ > arch/arm/mach-omap2/pm34xx.c | 14 ---- > arch/arm/plat-omap/include/plat/gpio.h | 5 +- > drivers/gpio/gpio-omap.c | 131 ++++++++++++++------------------ > 4 files changed, 73 insertions(+), 89 deletions(-) > > diff --git a/arch/arm/mach-omap2/gpio.c b/arch/arm/mach-omap2/gpio.c > index 95195a8..2e65377 100644 > --- a/arch/arm/mach-omap2/gpio.c > +++ b/arch/arm/mach-omap2/gpio.c > @@ -23,6 +23,7 @@ > > #include<plat/omap_hwmod.h> > #include<plat/omap_device.h> > +#include<plat/omap-pm.h> > > #include "powerdomain.h" > > @@ -34,6 +35,16 @@ static struct omap_device_pm_latency omap_gpio_latency[] = { > }, > }; > > +#ifdef CONFIG_PM > +static int omap_gpio_get_context_loss(struct device *dev) > +{ > + return omap_pm_get_dev_context_loss_count(dev); > +} Do you really need this wrapper. Use the funtion directly instead. Rest looks fine to me
next prev parent reply other threads:[~2011-08-23 12:53 UTC|newest] Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-04 11:04 [PATCH v5 00/22] gpio/omap: driver cleanup and fixes Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-04 11:04 ` [PATCH v5 01/22] gpio/omap: remove dependency on gpio_bank_count Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:35 ` Santosh 2011-08-23 12:35 ` Santosh 2011-08-29 12:18 ` DebBarma, Tarun Kanti 2011-08-29 12:18 ` DebBarma, Tarun Kanti 2011-08-04 11:04 ` [PATCH v5 02/22] gpio/omap: use flag to identify wakeup domain Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:41 ` Santosh 2011-08-23 12:41 ` Santosh 2011-08-04 11:04 ` [PATCH v5 03/22] gpio/omap: make gpio_context part of gpio_bank structure Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:45 ` Santosh 2011-08-23 12:45 ` Santosh 2011-08-25 20:23 ` Kevin Hilman 2011-08-25 20:23 ` Kevin Hilman 2011-08-26 3:57 ` DebBarma, Tarun Kanti 2011-08-26 3:57 ` DebBarma, Tarun Kanti 2011-08-26 14:11 ` Santosh 2011-08-26 14:11 ` Santosh 2011-08-04 11:04 ` [PATCH v5 04/22] gpio/omap: fix pwrdm_post_transition call sequence Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:47 ` Santosh 2011-08-23 12:47 ` Santosh 2011-08-04 11:04 ` [PATCH v5 05/22] gpio/omap: handle save/restore ctx in GPIO driver Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:53 ` Santosh [this message] 2011-08-23 12:53 ` Santosh 2011-08-23 14:47 ` Santosh 2011-08-23 14:47 ` Santosh 2011-08-04 11:04 ` [PATCH v5 06/22] gpio/omap: make non-wakeup GPIO part of pdata Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:54 ` Santosh 2011-08-23 12:54 ` Santosh 2011-08-04 11:04 ` [PATCH v5 07/22] gpio/omap: avoid cpu checks during module ena/disable Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 12:57 ` Santosh 2011-08-23 12:57 ` Santosh 2011-08-04 11:04 ` [PATCH v5 08/22] gpio/omap: further cleanup using wakeup_status register Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:02 ` Santosh 2011-08-23 13:02 ` Santosh 2011-08-04 11:04 ` [PATCH v5 09/22] gpio/omap: cleanup omap1 related macros Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:04 ` Santosh 2011-08-23 13:04 ` Santosh 2011-08-04 11:04 ` [PATCH v5 10/22] gpio/omap: use level/edge detect reg offsets Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:08 ` Santosh 2011-08-23 13:08 ` Santosh 2011-08-04 11:04 ` [PATCH v5 11/22] gpio/omap: remove hardcoded offsets in ctxt save/restore Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:12 ` Santosh 2011-08-23 13:12 ` Santosh 2011-08-04 11:04 ` [PATCH v5 12/22] gpio/omap: cleanup set_gpio_triggering function Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:21 ` Santosh 2011-08-23 13:21 ` Santosh 2011-08-04 11:04 ` [PATCH v5 13/22] gpio/omap: cleanup omap_gpio_mod_init function Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:26 ` Santosh 2011-08-23 13:26 ` Santosh 2011-08-04 11:04 ` [PATCH v5 14/22] gpio/omap: use pinctrl offset instead of macro Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 13:27 ` Santosh 2011-08-23 13:27 ` Santosh 2011-08-04 11:04 ` [PATCH v5 15/22] gpio/omap: use readl in irq_handler for all access Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:25 ` Santosh 2011-08-23 14:25 ` Santosh 2011-08-04 11:04 ` [PATCH v5 16/22] gpio/omap: remove bank->method & METHOD_* macros Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:27 ` Santosh 2011-08-23 14:27 ` Santosh 2011-08-04 11:04 ` [PATCH v5 17/22] gpio/omap: fix bankwidth for OMAP7xx MPUIO Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:28 ` Santosh 2011-08-23 14:28 ` Santosh 2011-08-04 11:04 ` [PATCH v5 18/22] gpio/omap: use pm-runtime framework Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:34 ` Santosh 2011-08-23 14:34 ` Santosh 2011-08-24 4:02 ` Rajendra Nayak 2011-08-24 4:02 ` Rajendra Nayak 2011-08-24 6:19 ` Santosh 2011-08-24 6:19 ` Santosh 2011-08-04 11:04 ` [PATCH v5 19/22] gpio/omap: optimize suspend and resume functions Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:35 ` Santosh 2011-08-23 14:35 ` Santosh 2011-08-04 11:04 ` [PATCH v5 20/22] gpio/omap: cleanup prepare_for_idle and resume_after_idle Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:40 ` Santosh 2011-08-23 14:40 ` Santosh 2011-08-04 11:04 ` [PATCH v5 21/22] gpio/omap: skip operations in runtime callbacks Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:41 ` Santosh 2011-08-23 14:41 ` Santosh 2011-08-04 11:04 ` [PATCH v5 22/22] gpio/omap: remove omap_gpio_save_context overhead Tarun Kanti DebBarma 2011-08-04 11:04 ` Tarun Kanti DebBarma 2011-08-23 14:42 ` Santosh 2011-08-23 14:42 ` Santosh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4E53A2D4.90109@ti.com \ --to=santosh.shilimkar@ti.com \ --cc=charu@ti.com \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=tarun.kanti@ti.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.