All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@parallels.com>
To: Paul Menage <paul@paulmenage.org>
Cc: Greg Thelen <gthelen@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	containers@lists.osdl.org, netdev@vger.kernel.org,
	xemul@parallels.com, "David S. Miller" <davem@davemloft.net>,
	Hiroyouki Kamezawa <kamezawa.hiroyu@jp.fujitsu.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Suleiman Souhlal <suleiman@google.com>,
	Lennart Poettering <lennart@poettering.net>
Subject: Re: [PATCH] per-cgroup tcp buffer limitation
Date: Tue, 13 Sep 2011 16:08:11 -0300	[thread overview]
Message-ID: <4E6FAA1B.5020102@parallels.com> (raw)
In-Reply-To: <CALdu-PDGpBnVHW7E5NobAwtXop5c03NTmijkk8oB7u-a5LEXww@mail.gmail.com>

On 09/13/2011 03:46 PM, Paul Menage wrote:
> On Tue, Sep 13, 2011 at 11:11 AM, Glauber Costa<glommer@parallels.com>  wrote:
>>
>> What if they are all updated under the same lock ?
>
> Right, that would be the kind of optimization that would remove the
> need for worrying about whether or not to account it. It would
> probably mean creating some memcg-specific structures like
> res-counters that could handle multiple values, since you'd need to
> update both the kernel charge and the total charge, in this cgroup
> *and* its ancestors.
>
> Paul
If we do that, we may have to commit to an intermediary user interface - 
with controls to to determine if kernel memory is billed to kernel or 
total, a enable/disable file, just to later render it pointless by a new 
optimization - that we seem to agree that seems possible.

I think it is preferred to always assume kernel memory is accounted to 
the kernel, and when we optimize it, no changes are made to what's 
exposed to userspace.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Paul Menage <paul@paulmenage.org>
Cc: Greg Thelen <gthelen@google.com>, <linux-kernel@vger.kernel.org>,
	<linux-mm@kvack.org>, <containers@lists.osdl.org>,
	<netdev@vger.kernel.org>, <xemul@parallels.com>,
	"David S. Miller" <davem@davemloft.net>,
	Hiroyouki Kamezawa <kamezawa.hiroyu@jp.fujitsu.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Suleiman Souhlal <suleiman@google.com>,
	Lennart Poettering <lennart@poettering.net>
Subject: Re: [PATCH] per-cgroup tcp buffer limitation
Date: Tue, 13 Sep 2011 16:08:11 -0300	[thread overview]
Message-ID: <4E6FAA1B.5020102@parallels.com> (raw)
In-Reply-To: <CALdu-PDGpBnVHW7E5NobAwtXop5c03NTmijkk8oB7u-a5LEXww@mail.gmail.com>

On 09/13/2011 03:46 PM, Paul Menage wrote:
> On Tue, Sep 13, 2011 at 11:11 AM, Glauber Costa<glommer@parallels.com>  wrote:
>>
>> What if they are all updated under the same lock ?
>
> Right, that would be the kind of optimization that would remove the
> need for worrying about whether or not to account it. It would
> probably mean creating some memcg-specific structures like
> res-counters that could handle multiple values, since you'd need to
> update both the kernel charge and the total charge, in this cgroup
> *and* its ancestors.
>
> Paul
If we do that, we may have to commit to an intermediary user interface - 
with controls to to determine if kernel memory is billed to kernel or 
total, a enable/disable file, just to later render it pointless by a new 
optimization - that we seem to agree that seems possible.

I think it is preferred to always assume kernel memory is accounted to 
the kernel, and when we optimize it, no changes are made to what's 
exposed to userspace.

WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Paul Menage <paul@paulmenage.org>
Cc: Greg Thelen <gthelen@google.com>, <linux-kernel@vger.kernel.org>,
	<linux-mm@kvack.org>, <containers@lists.osdl.org>,
	<netdev@vger.kernel.org>, <xemul@parallels.com>,
	"David S. Miller" <davem@davemloft.net>,
	Hiroyouki Kamezawa <kamezawa.hiroyu@jp.fujitsu.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Suleiman Souhlal <suleiman@google.com>,
	Lennart Poettering <lennart@poettering.net>
Subject: Re: [PATCH] per-cgroup tcp buffer limitation
Date: Tue, 13 Sep 2011 16:08:11 -0300	[thread overview]
Message-ID: <4E6FAA1B.5020102@parallels.com> (raw)
In-Reply-To: <CALdu-PDGpBnVHW7E5NobAwtXop5c03NTmijkk8oB7u-a5LEXww@mail.gmail.com>

On 09/13/2011 03:46 PM, Paul Menage wrote:
> On Tue, Sep 13, 2011 at 11:11 AM, Glauber Costa<glommer@parallels.com>  wrote:
>>
>> What if they are all updated under the same lock ?
>
> Right, that would be the kind of optimization that would remove the
> need for worrying about whether or not to account it. It would
> probably mean creating some memcg-specific structures like
> res-counters that could handle multiple values, since you'd need to
> update both the kernel charge and the total charge, in this cgroup
> *and* its ancestors.
>
> Paul
If we do that, we may have to commit to an intermediary user interface - 
with controls to to determine if kernel memory is billed to kernel or 
total, a enable/disable file, just to later render it pointless by a new 
optimization - that we seem to agree that seems possible.

I think it is preferred to always assume kernel memory is accounted to 
the kernel, and when we optimize it, no changes are made to what's 
exposed to userspace.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-09-13 19:08 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-06  2:35 [PATCH] per-cgroup tcp buffer limitation Glauber Costa
2011-09-06  2:35 ` Glauber Costa
2011-09-06 10:00 ` KAMEZAWA Hiroyuki
2011-09-06 10:00   ` KAMEZAWA Hiroyuki
2011-09-06 15:28   ` Glauber Costa
2011-09-06 15:28     ` Glauber Costa
2011-09-06 15:28     ` Glauber Costa
2011-09-06 22:52   ` Glauber Costa
2011-09-06 22:52     ` Glauber Costa
2011-09-06 22:52     ` Glauber Costa
2011-09-06 16:08 ` Greg Thelen
2011-09-06 16:08   ` Greg Thelen
2011-09-06 16:16   ` Glauber Costa
2011-09-06 16:16     ` Glauber Costa
2011-09-06 16:16     ` Glauber Costa
2011-09-06 22:12     ` Greg Thelen
2011-09-06 22:12       ` Greg Thelen
2011-09-06 22:37       ` Glauber Costa
2011-09-06 22:37         ` Glauber Costa
2011-09-06 22:37         ` Glauber Costa
2011-09-07 21:35         ` Greg Thelen
2011-09-07 21:35           ` Greg Thelen
2011-09-08  4:44           ` Glauber Costa
2011-09-08  4:44             ` Glauber Costa
2011-09-08  4:44             ` Glauber Costa
2011-09-08 21:53             ` Greg Thelen
2011-09-08 21:53               ` Greg Thelen
2011-09-09  4:17               ` Glauber Costa
2011-09-09  4:17                 ` Glauber Costa
2011-09-09  4:17                 ` Glauber Costa
2011-09-09 23:38                 ` Greg Thelen
2011-09-09 23:38                   ` Greg Thelen
2011-09-12 16:30                   ` Glauber Costa
2011-09-12 16:30                     ` Glauber Costa
2011-09-12 16:30                     ` Glauber Costa
2011-09-12  5:03                 ` Paul Menage
2011-09-12  5:03                   ` Paul Menage
2011-09-12 16:57                   ` Glauber Costa
2011-09-12 16:57                     ` Glauber Costa
2011-09-12 16:57                     ` Glauber Costa
2011-09-13  6:56                     ` Greg Thelen
2011-09-13  6:56                       ` Greg Thelen
2011-09-13 18:09                     ` Paul Menage
2011-09-13 18:09                       ` Paul Menage
2011-09-13 18:11                       ` Glauber Costa
2011-09-13 18:11                         ` Glauber Costa
2011-09-13 18:11                         ` Glauber Costa
2011-09-13 18:46                         ` Paul Menage
2011-09-13 18:46                           ` Paul Menage
2011-09-13 19:08                           ` Glauber Costa [this message]
2011-09-13 19:08                             ` Glauber Costa
2011-09-13 19:08                             ` Glauber Costa
2011-09-07  2:38       ` Eric Dumazet
2011-09-07  2:38         ` Eric Dumazet
2011-09-07  2:38         ` Eric Dumazet
2011-09-07  1:08 ` Paul Menage
2011-09-07  1:08   ` Paul Menage
2011-09-07  1:09   ` Glauber Costa
2011-09-07  1:09     ` Glauber Costa
2011-09-07  1:09     ` Glauber Costa
2011-09-07  1:29     ` Paul Menage
2011-09-07  1:29       ` Paul Menage
2011-09-07  1:32       ` Glauber Costa
2011-09-07  1:32         ` Glauber Costa
2011-09-07  1:32         ` Glauber Costa
2011-09-09  0:18 ` Rick Jones
2011-09-09  0:18   ` Rick Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E6FAA1B.5020102@parallels.com \
    --to=glommer@parallels.com \
    --cc=containers@lists.osdl.org \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=gthelen@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=lennart@poettering.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul@paulmenage.org \
    --cc=suleiman@google.com \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.