All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Menage <paul@paulmenage.org>
To: Glauber Costa <glommer@parallels.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	containers@lists.osdl.org, netdev@vger.kernel.org,
	xemul@parallels.com, "David S. Miller" <davem@davemloft.net>,
	Hiroyouki Kamezawa <kamezawa.hiroyu@jp.fujitsu.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] per-cgroup tcp buffer limitation
Date: Tue, 6 Sep 2011 18:08:08 -0700	[thread overview]
Message-ID: <CALdu-PDoPPdcX0bAkVpaP9R-z1yKin=JOjjT3rMuoSHJaywSCg@mail.gmail.com> (raw)
In-Reply-To: <1315276556-10970-1-git-send-email-glommer@parallels.com>

On Mon, Sep 5, 2011 at 7:35 PM, Glauber Costa <glommer@parallels.com> wrote:
> This patch introduces per-cgroup tcp buffers limitation. This allows
> sysadmins to specify a maximum amount of kernel memory that
> tcp connections can use at any point in time. TCP is the main interest
> in this work, but extending it to other protocols would be easy.

The general idea of limiting total socket buffer memory consumed by a
cgroup is a fine idea, but I think it needs to be integrated more
closely with the existing kernel memory cgroup tracking efforts,
especially if you're trying to use as generic a name as "kmem" for it.

I agree with Kamezawa's comments that you need a lot more documentation.

Paul

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Paul Menage <paul@paulmenage.org>
To: Glauber Costa <glommer@parallels.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	containers@lists.osdl.org, netdev@vger.kernel.org,
	xemul@parallels.com, "David S. Miller" <davem@davemloft.net>,
	Hiroyouki Kamezawa <kamezawa.hiroyu@jp.fujitsu.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH] per-cgroup tcp buffer limitation
Date: Tue, 6 Sep 2011 18:08:08 -0700	[thread overview]
Message-ID: <CALdu-PDoPPdcX0bAkVpaP9R-z1yKin=JOjjT3rMuoSHJaywSCg@mail.gmail.com> (raw)
In-Reply-To: <1315276556-10970-1-git-send-email-glommer@parallels.com>

On Mon, Sep 5, 2011 at 7:35 PM, Glauber Costa <glommer@parallels.com> wrote:
> This patch introduces per-cgroup tcp buffers limitation. This allows
> sysadmins to specify a maximum amount of kernel memory that
> tcp connections can use at any point in time. TCP is the main interest
> in this work, but extending it to other protocols would be easy.

The general idea of limiting total socket buffer memory consumed by a
cgroup is a fine idea, but I think it needs to be integrated more
closely with the existing kernel memory cgroup tracking efforts,
especially if you're trying to use as generic a name as "kmem" for it.

I agree with Kamezawa's comments that you need a lot more documentation.

Paul

  parent reply	other threads:[~2011-09-07  1:08 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-06  2:35 [PATCH] per-cgroup tcp buffer limitation Glauber Costa
2011-09-06  2:35 ` Glauber Costa
2011-09-06 10:00 ` KAMEZAWA Hiroyuki
2011-09-06 10:00   ` KAMEZAWA Hiroyuki
2011-09-06 15:28   ` Glauber Costa
2011-09-06 15:28     ` Glauber Costa
2011-09-06 15:28     ` Glauber Costa
2011-09-06 22:52   ` Glauber Costa
2011-09-06 22:52     ` Glauber Costa
2011-09-06 22:52     ` Glauber Costa
2011-09-06 16:08 ` Greg Thelen
2011-09-06 16:08   ` Greg Thelen
2011-09-06 16:16   ` Glauber Costa
2011-09-06 16:16     ` Glauber Costa
2011-09-06 16:16     ` Glauber Costa
2011-09-06 22:12     ` Greg Thelen
2011-09-06 22:12       ` Greg Thelen
2011-09-06 22:37       ` Glauber Costa
2011-09-06 22:37         ` Glauber Costa
2011-09-06 22:37         ` Glauber Costa
2011-09-07 21:35         ` Greg Thelen
2011-09-07 21:35           ` Greg Thelen
2011-09-08  4:44           ` Glauber Costa
2011-09-08  4:44             ` Glauber Costa
2011-09-08  4:44             ` Glauber Costa
2011-09-08 21:53             ` Greg Thelen
2011-09-08 21:53               ` Greg Thelen
2011-09-09  4:17               ` Glauber Costa
2011-09-09  4:17                 ` Glauber Costa
2011-09-09  4:17                 ` Glauber Costa
2011-09-09 23:38                 ` Greg Thelen
2011-09-09 23:38                   ` Greg Thelen
2011-09-12 16:30                   ` Glauber Costa
2011-09-12 16:30                     ` Glauber Costa
2011-09-12 16:30                     ` Glauber Costa
2011-09-12  5:03                 ` Paul Menage
2011-09-12  5:03                   ` Paul Menage
2011-09-12 16:57                   ` Glauber Costa
2011-09-12 16:57                     ` Glauber Costa
2011-09-12 16:57                     ` Glauber Costa
2011-09-13  6:56                     ` Greg Thelen
2011-09-13  6:56                       ` Greg Thelen
2011-09-13 18:09                     ` Paul Menage
2011-09-13 18:09                       ` Paul Menage
2011-09-13 18:11                       ` Glauber Costa
2011-09-13 18:11                         ` Glauber Costa
2011-09-13 18:11                         ` Glauber Costa
2011-09-13 18:46                         ` Paul Menage
2011-09-13 18:46                           ` Paul Menage
2011-09-13 19:08                           ` Glauber Costa
2011-09-13 19:08                             ` Glauber Costa
2011-09-13 19:08                             ` Glauber Costa
2011-09-07  2:38       ` Eric Dumazet
2011-09-07  2:38         ` Eric Dumazet
2011-09-07  2:38         ` Eric Dumazet
2011-09-07  1:08 ` Paul Menage [this message]
2011-09-07  1:08   ` Paul Menage
2011-09-07  1:09   ` Glauber Costa
2011-09-07  1:09     ` Glauber Costa
2011-09-07  1:09     ` Glauber Costa
2011-09-07  1:29     ` Paul Menage
2011-09-07  1:29       ` Paul Menage
2011-09-07  1:32       ` Glauber Costa
2011-09-07  1:32         ` Glauber Costa
2011-09-07  1:32         ` Glauber Costa
2011-09-09  0:18 ` Rick Jones
2011-09-09  0:18   ` Rick Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALdu-PDoPPdcX0bAkVpaP9R-z1yKin=JOjjT3rMuoSHJaywSCg@mail.gmail.com' \
    --to=paul@paulmenage.org \
    --cc=containers@lists.osdl.org \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=glommer@parallels.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.