From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/8] OMAP3/4: Misc fixes and clean-up
Date: Sat, 24 Sep 2011 13:16:35 +0530 [thread overview]
Message-ID: <4E7D8ADB.1080109@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1109240120240.22872@utopia.booyaka.com>
On Saturday 24 September 2011 01:06 PM, Paul Walmsley wrote:
> Hi
>
> On Sat, 24 Sep 2011, Santosh Shilimkar wrote:
>
>> On Saturday 24 September 2011 12:01 PM, Paul Walmsley wrote:
>>> Hi Santosh
>>>
>>> On Sat, 24 Sep 2011, Santosh Shilimkar wrote:
>>>
>>>> On Thursday 08 September 2011 10:51 AM, Santosh Shilimkar wrote:
>>>>>
>>>> I need your ack on below two patches so that I can re-base them and
>>>> send a pull request to Tony.
>>>>
>>>> OMAP4: clock: Add CPU local timer clock node.
>>>> OMAP: Fix sparse warnings in l3 error handler.
>>>
>>> Are you targeting these for 3.1-rc ?
>>>
>> Nope. It's for 3.2 merge window.
>> As such, the series doesn't have any major regression
>> fixes which should make it before 3.2
>
> In that case, patches 1 and 7 should go in through me. The rest should go
> via Tony. So you can just drop 1 and 7 from your branch, I'll pull those
> off the list.
>
Will do.
> Some comments though: Looks like you need to repost patch 1 due to
> comments from Benoît? Also, have the autogeneration scripts been updated
> for patch 7?
>
Ok. Will post updated patch1.
For the patch 7, I will align with Benoit on the autogen script. It has
some differences with mainline OMAP4 clock data file.
> ...
>
> As far as patch 5 goes, you don't need my ack on that one, since I'm not
> the maintainer or original author of that code. But feel free to add a
> Reviewed-by:. I also tested the two L3 files with sparse and they are
> clean now. Thanks very much for taking the initiative on this; I
> personally appreciate it quite a bit, and I think having clean code
> increases our credibility with upstream maintainers.
>
Actually I wanted you to have a look to ensure that we addressed the
all sparce warnings. Will add your reviewed by on that patch.
Couldn't agree more on the clean code remark.
Regards
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/8] OMAP3/4: Misc fixes and clean-up
Date: Sat, 24 Sep 2011 13:16:35 +0530 [thread overview]
Message-ID: <4E7D8ADB.1080109@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1109240120240.22872@utopia.booyaka.com>
On Saturday 24 September 2011 01:06 PM, Paul Walmsley wrote:
> Hi
>
> On Sat, 24 Sep 2011, Santosh Shilimkar wrote:
>
>> On Saturday 24 September 2011 12:01 PM, Paul Walmsley wrote:
>>> Hi Santosh
>>>
>>> On Sat, 24 Sep 2011, Santosh Shilimkar wrote:
>>>
>>>> On Thursday 08 September 2011 10:51 AM, Santosh Shilimkar wrote:
>>>>>
>>>> I need your ack on below two patches so that I can re-base them and
>>>> send a pull request to Tony.
>>>>
>>>> OMAP4: clock: Add CPU local timer clock node.
>>>> OMAP: Fix sparse warnings in l3 error handler.
>>>
>>> Are you targeting these for 3.1-rc ?
>>>
>> Nope. It's for 3.2 merge window.
>> As such, the series doesn't have any major regression
>> fixes which should make it before 3.2
>
> In that case, patches 1 and 7 should go in through me. The rest should go
> via Tony. So you can just drop 1 and 7 from your branch, I'll pull those
> off the list.
>
Will do.
> Some comments though: Looks like you need to repost patch 1 due to
> comments from Beno?t? Also, have the autogeneration scripts been updated
> for patch 7?
>
Ok. Will post updated patch1.
For the patch 7, I will align with Benoit on the autogen script. It has
some differences with mainline OMAP4 clock data file.
> ...
>
> As far as patch 5 goes, you don't need my ack on that one, since I'm not
> the maintainer or original author of that code. But feel free to add a
> Reviewed-by:. I also tested the two L3 files with sparse and they are
> clean now. Thanks very much for taking the initiative on this; I
> personally appreciate it quite a bit, and I think having clean code
> increases our credibility with upstream maintainers.
>
Actually I wanted you to have a look to ensure that we addressed the
all sparce warnings. Will add your reviewed by on that patch.
Couldn't agree more on the clean code remark.
Regards
Santosh
next prev parent reply other threads:[~2011-09-24 7:46 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 5:21 [PATCH 0/8] OMAP3/4: Misc fixes and clean-up Santosh Shilimkar
2011-09-08 5:21 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 1/8] OMAP: hwmod: Fix the addr spaces count API Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 7:47 ` Cousson, Benoit
2011-09-08 7:47 ` Cousson, Benoit
2011-09-08 5:22 ` [PATCH 2/8] OMAP: Improve register access in L3 Error handler Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 3/8] OMAP: Fix a BUG in l3 error handler Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 4/8] OMAP: Fix indentation issues " Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 5/8] OMAP: Fix sparse warnings " Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 6/8] OMAP: Print Initiator name for l3 custom error Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 7/8] OMAP4: clock: Add CPU local timer clock node Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-29 19:12 ` Paul Walmsley
2011-09-29 19:12 ` Paul Walmsley
2011-09-30 9:14 ` Shilimkar, Santosh
2011-09-30 9:14 ` Shilimkar, Santosh
2011-09-29 21:30 ` Linus Walleij
2011-09-29 21:30 ` Linus Walleij
2011-09-30 9:15 ` Shilimkar, Santosh
2011-09-30 9:15 ` Shilimkar, Santosh
2011-12-08 23:02 ` Turquette, Mike
2011-12-08 23:02 ` Turquette, Mike
2011-12-12 8:15 ` Shilimkar, Santosh
2011-12-12 8:15 ` Shilimkar, Santosh
2011-09-08 5:22 ` [PATCH 8/8] OMAP4: Fix the emif and dmm virtual mapping Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-16 17:56 ` Kevin Hilman
2011-09-16 17:56 ` Kevin Hilman
2011-09-20 15:01 ` Santosh Shilimkar
2011-09-20 15:01 ` Santosh Shilimkar
2011-09-21 15:28 ` Santosh Shilimkar
2011-09-21 15:28 ` Santosh Shilimkar
2011-09-21 17:31 ` Kevin Hilman
2011-09-21 17:31 ` Kevin Hilman
2011-09-22 5:53 ` Shilimkar, Santosh
2011-09-22 5:53 ` Shilimkar, Santosh
2011-09-24 6:03 ` [PATCH 0/8] OMAP3/4: Misc fixes and clean-up Santosh Shilimkar
2011-09-24 6:03 ` Santosh Shilimkar
2011-09-24 6:31 ` Paul Walmsley
2011-09-24 6:31 ` Paul Walmsley
2011-09-24 6:35 ` Santosh Shilimkar
2011-09-24 6:35 ` Santosh Shilimkar
2011-09-24 7:36 ` Paul Walmsley
2011-09-24 7:36 ` Paul Walmsley
2011-09-24 7:46 ` Santosh Shilimkar [this message]
2011-09-24 7:46 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7D8ADB.1080109@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.