From: Kevin Hilman <khilman@ti.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Girish S G <girishsg@ti.com>
Subject: Re: [PATCH 8/8] OMAP4: Fix the emif and dmm virtual mapping
Date: Wed, 21 Sep 2011 10:31:11 -0700 [thread overview]
Message-ID: <87zkhx3iqo.fsf@ti.com> (raw)
In-Reply-To: <4E7A0292.4020408@ti.com> (Santosh Shilimkar's message of "Wed, 21 Sep 2011 20:58:18 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> On Tuesday 20 September 2011 08:31 PM, Santosh Shilimkar wrote:
>> On Friday 16 September 2011 11:26 PM, Kevin Hilman wrote:
>>> Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
>>>
>
> [...]
>
>>
>>>> #define OMAP44XX_EMIF2_SIZE SZ_1M
>>>>
>>>> #define OMAP44XX_DMM_PHYS OMAP44XX_DMM_BASE
>>>> /* 0x4e000000 --> 0xfd300000 */
>>>> -#define OMAP44XX_DMM_VIRT (OMAP44XX_DMM_PHYS + OMAP4_L3_PER_IO_OFFSET)
>>>> +#define OMAP44XX_DMM_VIRT (OMAP44XX_EMIF2_VIRT + SZ_1M)
>>>
>>> and '+ OMAP44XX_EMIF2_SIZE' here.
>>>
>> Will add OMAP44XX_EMIF_SIZE since 2 EMIFs instaces are and
>> suppose to be identical.Almost missed this email in other traffic.
>
> OPPs. It was already there. Dumb of me not using it. Below
> is the update what I will do.
>
> diff --git a/arch/arm/plat-omap/include/plat/io.h
> b/arch/arm/plat-omap/include/plat/io.h
> index d72ec85..db36292 100644
> --- a/arch/arm/plat-omap/include/plat/io.h
> +++ b/arch/arm/plat-omap/include/plat/io.h
> @@ -228,13 +228,13 @@
>
> #define OMAP44XX_EMIF2_PHYS OMAP44XX_EMIF2_BASE
> /* 0x4d000000 --> 0xfd200000 */
> -#define OMAP44XX_EMIF2_VIRT (OMAP44XX_EMIF2_PHYS + OMAP4_L3_PER_IO_OFFSET)
> #define OMAP44XX_EMIF2_SIZE SZ_1M
> +#define OMAP44XX_EMIF2_VIRT (OMAP44XX_EMIF1_VIRT + OMAP44XX_EMIF2_SIZE)
This doesn't look right either.
This #define is for the *start* of EMIF2 virtual address space, so
assuming the start address of EMIF2 is immediatly after EMIF1, it should
be EMIF1_VIRT + EMIF1_SIZE (not EMIF2_SIZE.)
> #define OMAP44XX_DMM_PHYS OMAP44XX_DMM_BASE
> /* 0x4e000000 --> 0xfd300000 */
> -#define OMAP44XX_DMM_VIRT (OMAP44XX_DMM_PHYS + OMAP4_L3_PER_IO_OFFSET)
> #define OMAP44XX_DMM_SIZE SZ_1M
> +#define OMAP44XX_DMM_VIRT (OMAP44XX_EMIF2_VIRT + OMAP44XX_DMM_SIZE)
And here, assuming DMM range is immediately after EMIF2, this should be
EMIF2_VIRT + EMFI2_SIZE)
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] OMAP4: Fix the emif and dmm virtual mapping
Date: Wed, 21 Sep 2011 10:31:11 -0700 [thread overview]
Message-ID: <87zkhx3iqo.fsf@ti.com> (raw)
In-Reply-To: <4E7A0292.4020408@ti.com> (Santosh Shilimkar's message of "Wed, 21 Sep 2011 20:58:18 +0530")
Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
> On Tuesday 20 September 2011 08:31 PM, Santosh Shilimkar wrote:
>> On Friday 16 September 2011 11:26 PM, Kevin Hilman wrote:
>>> Santosh Shilimkar <santosh.shilimkar@ti.com> writes:
>>>
>
> [...]
>
>>
>>>> #define OMAP44XX_EMIF2_SIZE SZ_1M
>>>>
>>>> #define OMAP44XX_DMM_PHYS OMAP44XX_DMM_BASE
>>>> /* 0x4e000000 --> 0xfd300000 */
>>>> -#define OMAP44XX_DMM_VIRT (OMAP44XX_DMM_PHYS + OMAP4_L3_PER_IO_OFFSET)
>>>> +#define OMAP44XX_DMM_VIRT (OMAP44XX_EMIF2_VIRT + SZ_1M)
>>>
>>> and '+ OMAP44XX_EMIF2_SIZE' here.
>>>
>> Will add OMAP44XX_EMIF_SIZE since 2 EMIFs instaces are and
>> suppose to be identical.Almost missed this email in other traffic.
>
> OPPs. It was already there. Dumb of me not using it. Below
> is the update what I will do.
>
> diff --git a/arch/arm/plat-omap/include/plat/io.h
> b/arch/arm/plat-omap/include/plat/io.h
> index d72ec85..db36292 100644
> --- a/arch/arm/plat-omap/include/plat/io.h
> +++ b/arch/arm/plat-omap/include/plat/io.h
> @@ -228,13 +228,13 @@
>
> #define OMAP44XX_EMIF2_PHYS OMAP44XX_EMIF2_BASE
> /* 0x4d000000 --> 0xfd200000 */
> -#define OMAP44XX_EMIF2_VIRT (OMAP44XX_EMIF2_PHYS + OMAP4_L3_PER_IO_OFFSET)
> #define OMAP44XX_EMIF2_SIZE SZ_1M
> +#define OMAP44XX_EMIF2_VIRT (OMAP44XX_EMIF1_VIRT + OMAP44XX_EMIF2_SIZE)
This doesn't look right either.
This #define is for the *start* of EMIF2 virtual address space, so
assuming the start address of EMIF2 is immediatly after EMIF1, it should
be EMIF1_VIRT + EMIF1_SIZE (not EMIF2_SIZE.)
> #define OMAP44XX_DMM_PHYS OMAP44XX_DMM_BASE
> /* 0x4e000000 --> 0xfd300000 */
> -#define OMAP44XX_DMM_VIRT (OMAP44XX_DMM_PHYS + OMAP4_L3_PER_IO_OFFSET)
> #define OMAP44XX_DMM_SIZE SZ_1M
> +#define OMAP44XX_DMM_VIRT (OMAP44XX_EMIF2_VIRT + OMAP44XX_DMM_SIZE)
And here, assuming DMM range is immediately after EMIF2, this should be
EMIF2_VIRT + EMFI2_SIZE)
Kevin
next prev parent reply other threads:[~2011-09-21 17:31 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 5:21 [PATCH 0/8] OMAP3/4: Misc fixes and clean-up Santosh Shilimkar
2011-09-08 5:21 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 1/8] OMAP: hwmod: Fix the addr spaces count API Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 7:47 ` Cousson, Benoit
2011-09-08 7:47 ` Cousson, Benoit
2011-09-08 5:22 ` [PATCH 2/8] OMAP: Improve register access in L3 Error handler Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 3/8] OMAP: Fix a BUG in l3 error handler Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 4/8] OMAP: Fix indentation issues " Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 5/8] OMAP: Fix sparse warnings " Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 6/8] OMAP: Print Initiator name for l3 custom error Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-08 5:22 ` [PATCH 7/8] OMAP4: clock: Add CPU local timer clock node Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-29 19:12 ` Paul Walmsley
2011-09-29 19:12 ` Paul Walmsley
2011-09-30 9:14 ` Shilimkar, Santosh
2011-09-30 9:14 ` Shilimkar, Santosh
2011-09-29 21:30 ` Linus Walleij
2011-09-29 21:30 ` Linus Walleij
2011-09-30 9:15 ` Shilimkar, Santosh
2011-09-30 9:15 ` Shilimkar, Santosh
2011-12-08 23:02 ` Turquette, Mike
2011-12-08 23:02 ` Turquette, Mike
2011-12-12 8:15 ` Shilimkar, Santosh
2011-12-12 8:15 ` Shilimkar, Santosh
2011-09-08 5:22 ` [PATCH 8/8] OMAP4: Fix the emif and dmm virtual mapping Santosh Shilimkar
2011-09-08 5:22 ` Santosh Shilimkar
2011-09-16 17:56 ` Kevin Hilman
2011-09-16 17:56 ` Kevin Hilman
2011-09-20 15:01 ` Santosh Shilimkar
2011-09-20 15:01 ` Santosh Shilimkar
2011-09-21 15:28 ` Santosh Shilimkar
2011-09-21 15:28 ` Santosh Shilimkar
2011-09-21 17:31 ` Kevin Hilman [this message]
2011-09-21 17:31 ` Kevin Hilman
2011-09-22 5:53 ` Shilimkar, Santosh
2011-09-22 5:53 ` Shilimkar, Santosh
2011-09-24 6:03 ` [PATCH 0/8] OMAP3/4: Misc fixes and clean-up Santosh Shilimkar
2011-09-24 6:03 ` Santosh Shilimkar
2011-09-24 6:31 ` Paul Walmsley
2011-09-24 6:31 ` Paul Walmsley
2011-09-24 6:35 ` Santosh Shilimkar
2011-09-24 6:35 ` Santosh Shilimkar
2011-09-24 7:36 ` Paul Walmsley
2011-09-24 7:36 ` Paul Walmsley
2011-09-24 7:46 ` Santosh Shilimkar
2011-09-24 7:46 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkhx3iqo.fsf@ti.com \
--to=khilman@ti.com \
--cc=girishsg@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.