From: "Turquette, Mike" <mturquette@ti.com> To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Kevin Hilman <khilman@ti.com>, Paul Walmsley <paul@pwsan.com>, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 7/8] OMAP4: clock: Add CPU local timer clock node. Date: Thu, 8 Dec 2011 15:02:04 -0800 [thread overview] Message-ID: <CAJOA=zP0zs=eKsQXQPt5dj8EHQFnZ50Jnm_Ho425yH-NZkgY5A@mail.gmail.com> (raw) In-Reply-To: <CAMQu2gyBq61jcP1sLDEs8+zGfdAa6Pur1fSec9Wfzs48CX5zjA@mail.gmail.com> On Fri, Sep 30, 2011 at 2:15 AM, Shilimkar, Santosh <santosh.shilimkar@ti.com> wrote: > On Fri, Sep 30, 2011 at 3:00 AM, Linus Walleij <linus.walleij@linaro.org> wrote: >> 2011/9/8 Santosh Shilimkar <santosh.shilimkar@ti.com>: >> >>> Local timer clock is sourced from the CPU clock and hence changes >>> along with CPU clock. These per CPU local timers are used as >>> clock-events, so they need to be reconfigured on CPU frequency >>> change as part of CPUfreq governor. >> >> This requires patch 6956/2 right? >> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6956/2 >> >> Can I add your Tested-by: to the patch as well? >> > Sure. Santosh, I've taken in Linus' patch as well as this patch while testing clk notifiers (part of common clk framework code). Linus' patch matches the clk based on dev_id, but the clkdev entry in your patch populated dev_id with NULL and con_id with "smp_twd" so things never worked correctly. Below changed fixed it for me: diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index ae8c292..0f8cf68 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -4114,7 +4114,7 @@ static struct omap_clk omap44xx_clks[] = { CLK(NULL, "l4_div_ck", &l4_div_ck_hw.clk, CK_443X), CLK(NULL, "lp_clk_div_ck", &lp_clk_div_ck_hw.clk, CK_443X), CLK(NULL, "l4_wkup_clk_mux_ck", &l4_wkup_clk_mux_ck_hw.clk, CK_443X), - CLK(NULL, "smp_twd", &mpu_periphclk_hw.clk, CK_443X), + CLK("smp_twd", NULL, &mpu_periphclk_hw.clk, CK_443X), CLK(NULL, "ocp_abe_iclk", &ocp_abe_iclk_hw.clk, CK_443X), CLK(NULL, "per_abe_24m_fclk", &per_abe_24m_fclk_hw.clk, CK_443X), CLK(NULL, "per_abe_nc_fclk", &per_abe_nc_fclk_hw.clk, CK_443X), A better change might be for the code in smp_twd.c to match on con_id but I'll let you guys sort that out. Regards, Mike
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@ti.com (Turquette, Mike) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 7/8] OMAP4: clock: Add CPU local timer clock node. Date: Thu, 8 Dec 2011 15:02:04 -0800 [thread overview] Message-ID: <CAJOA=zP0zs=eKsQXQPt5dj8EHQFnZ50Jnm_Ho425yH-NZkgY5A@mail.gmail.com> (raw) In-Reply-To: <CAMQu2gyBq61jcP1sLDEs8+zGfdAa6Pur1fSec9Wfzs48CX5zjA@mail.gmail.com> On Fri, Sep 30, 2011 at 2:15 AM, Shilimkar, Santosh <santosh.shilimkar@ti.com> wrote: > On Fri, Sep 30, 2011 at 3:00 AM, Linus Walleij <linus.walleij@linaro.org> wrote: >> 2011/9/8 Santosh Shilimkar <santosh.shilimkar@ti.com>: >> >>> Local timer clock is sourced from the CPU clock and hence changes >>> along with CPU clock. These per CPU local timers are used as >>> clock-events, so they need to be reconfigured on CPU frequency >>> change as part of CPUfreq governor. >> >> This requires patch 6956/2 right? >> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6956/2 >> >> Can I add your Tested-by: to the patch as well? >> > Sure. Santosh, I've taken in Linus' patch as well as this patch while testing clk notifiers (part of common clk framework code). Linus' patch matches the clk based on dev_id, but the clkdev entry in your patch populated dev_id with NULL and con_id with "smp_twd" so things never worked correctly. Below changed fixed it for me: diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index ae8c292..0f8cf68 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -4114,7 +4114,7 @@ static struct omap_clk omap44xx_clks[] = { CLK(NULL, "l4_div_ck", &l4_div_ck_hw.clk, CK_443X), CLK(NULL, "lp_clk_div_ck", &lp_clk_div_ck_hw.clk, CK_443X), CLK(NULL, "l4_wkup_clk_mux_ck", &l4_wkup_clk_mux_ck_hw.clk, CK_443X), - CLK(NULL, "smp_twd", &mpu_periphclk_hw.clk, CK_443X), + CLK("smp_twd", NULL, &mpu_periphclk_hw.clk, CK_443X), CLK(NULL, "ocp_abe_iclk", &ocp_abe_iclk_hw.clk, CK_443X), CLK(NULL, "per_abe_24m_fclk", &per_abe_24m_fclk_hw.clk, CK_443X), CLK(NULL, "per_abe_nc_fclk", &per_abe_nc_fclk_hw.clk, CK_443X), A better change might be for the code in smp_twd.c to match on con_id but I'll let you guys sort that out. Regards, Mike
next prev parent reply other threads:[~2011-12-08 23:02 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-09-08 5:21 [PATCH 0/8] OMAP3/4: Misc fixes and clean-up Santosh Shilimkar 2011-09-08 5:21 ` Santosh Shilimkar 2011-09-08 5:22 ` [PATCH 1/8] OMAP: hwmod: Fix the addr spaces count API Santosh Shilimkar 2011-09-08 5:22 ` Santosh Shilimkar 2011-09-08 7:47 ` Cousson, Benoit 2011-09-08 7:47 ` Cousson, Benoit 2011-09-08 5:22 ` [PATCH 2/8] OMAP: Improve register access in L3 Error handler Santosh Shilimkar 2011-09-08 5:22 ` Santosh Shilimkar 2011-09-08 5:22 ` [PATCH 3/8] OMAP: Fix a BUG in l3 error handler Santosh Shilimkar 2011-09-08 5:22 ` Santosh Shilimkar 2011-09-08 5:22 ` [PATCH 4/8] OMAP: Fix indentation issues " Santosh Shilimkar 2011-09-08 5:22 ` Santosh Shilimkar 2011-09-08 5:22 ` [PATCH 5/8] OMAP: Fix sparse warnings " Santosh Shilimkar 2011-09-08 5:22 ` Santosh Shilimkar 2011-09-08 5:22 ` [PATCH 6/8] OMAP: Print Initiator name for l3 custom error Santosh Shilimkar 2011-09-08 5:22 ` Santosh Shilimkar 2011-09-08 5:22 ` [PATCH 7/8] OMAP4: clock: Add CPU local timer clock node Santosh Shilimkar 2011-09-08 5:22 ` Santosh Shilimkar 2011-09-29 19:12 ` Paul Walmsley 2011-09-29 19:12 ` Paul Walmsley 2011-09-30 9:14 ` Shilimkar, Santosh 2011-09-30 9:14 ` Shilimkar, Santosh 2011-09-29 21:30 ` Linus Walleij 2011-09-29 21:30 ` Linus Walleij 2011-09-30 9:15 ` Shilimkar, Santosh 2011-09-30 9:15 ` Shilimkar, Santosh 2011-12-08 23:02 ` Turquette, Mike [this message] 2011-12-08 23:02 ` Turquette, Mike 2011-12-12 8:15 ` Shilimkar, Santosh 2011-12-12 8:15 ` Shilimkar, Santosh 2011-09-08 5:22 ` [PATCH 8/8] OMAP4: Fix the emif and dmm virtual mapping Santosh Shilimkar 2011-09-08 5:22 ` Santosh Shilimkar 2011-09-16 17:56 ` Kevin Hilman 2011-09-16 17:56 ` Kevin Hilman 2011-09-20 15:01 ` Santosh Shilimkar 2011-09-20 15:01 ` Santosh Shilimkar 2011-09-21 15:28 ` Santosh Shilimkar 2011-09-21 15:28 ` Santosh Shilimkar 2011-09-21 17:31 ` Kevin Hilman 2011-09-21 17:31 ` Kevin Hilman 2011-09-22 5:53 ` Shilimkar, Santosh 2011-09-22 5:53 ` Shilimkar, Santosh 2011-09-24 6:03 ` [PATCH 0/8] OMAP3/4: Misc fixes and clean-up Santosh Shilimkar 2011-09-24 6:03 ` Santosh Shilimkar 2011-09-24 6:31 ` Paul Walmsley 2011-09-24 6:31 ` Paul Walmsley 2011-09-24 6:35 ` Santosh Shilimkar 2011-09-24 6:35 ` Santosh Shilimkar 2011-09-24 7:36 ` Paul Walmsley 2011-09-24 7:36 ` Paul Walmsley 2011-09-24 7:46 ` Santosh Shilimkar 2011-09-24 7:46 ` Santosh Shilimkar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJOA=zP0zs=eKsQXQPt5dj8EHQFnZ50Jnm_Ho425yH-NZkgY5A@mail.gmail.com' \ --to=mturquette@ti.com \ --cc=khilman@ti.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=paul@pwsan.com \ --cc=santosh.shilimkar@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.