From: Shubhrajyoti <shubhrajyoti@ti.com> To: Paul Walmsley <paul@pwsan.com> Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>, linux-omap@vger.kernel.org, Kevin Hilman <khilman@ti.com>, Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org, Olof Johansson <olof@lixom.net> Subject: Re: OMAP34xx Date: Mon, 13 Feb 2012 11:05:53 +0530 [thread overview] Message-ID: <4F38A139.4090501@ti.com> (raw) In-Reply-To: <alpine.DEB.2.00.1202121148210.30322@utopia.booyaka.com> On Monday 13 February 2012 12:42 AM, Paul Walmsley wrote: > Hi > > On Sun, 12 Feb 2012, Russell King - ARM Linux wrote: > >> The other allnoconfig issue is: >> >> arch/arm/mach-omap2/built-in.o:(.data+0xa3d0): undefined reference to `omap_i2c_reset' >> >> which looks like hwmod can't cope with the I2C_OMAP being disabled. >> >> I don't propose these are fixed for v3.3, but they certainly should be >> fixed for v3.4. > Thanks for the report. Here's a patch for this for 3.4. Compile-tested > only; will boot-test it as part of the v2 of the 3.4 hwmod changes. > Boot tested on omap4430 sdp. > - Paul > > From: Paul Walmsley <paul@pwsan.com> > Date: Sun, 12 Feb 2012 11:49:34 -0700 > Subject: [PATCH] ARM: OMAP2+: I2C: always compile I2C reset code, even if I2C > driver is not built > > During kernel init, we reset all IP blocks on the OMAP that we can, > even if there is no driver compiled for that IP block. Unlike most IP > blocks, the I2C block requires some extra programming for this to > work. This reset code is incorrectly omitted when the I2C driver is > deselected. In this circumstance, the build breaks. Fix by compiling > the I2C reset code unconditionally. > > Problem reported by Russell King <linux@arm.linux.org.uk>. > > Signed-off-by: Paul Walmsley <paul@pwsan.com> > Cc: Russell King <linux@arm.linux.org.uk> > --- > arch/arm/mach-omap2/Makefile | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile > index fc9b238..0d5676c 100644 > --- a/arch/arm/mach-omap2/Makefile > +++ b/arch/arm/mach-omap2/Makefile > @@ -4,7 +4,7 @@ > > # Common support > obj-y := id.o io.o control.o mux.o devices.o serial.o gpmc.o timer.o pm.o \ > - common.o gpio.o dma.o wd_timer.o display.o > + common.o gpio.o dma.o wd_timer.o display.o i2c.o > > omap-2-3-common = irq.o sdrc.o > hwmod-common = omap_hwmod.o \ > @@ -182,9 +182,6 @@ obj-$(CONFIG_OMAP_IOMMU) += iommu2.o > iommu-$(CONFIG_OMAP_IOMMU) := omap-iommu.o > obj-y += $(iommu-m) $(iommu-y) > > -i2c-omap-$(CONFIG_I2C_OMAP) := i2c.o > -obj-y += $(i2c-omap-m) $(i2c-omap-y) > - > ifneq ($(CONFIG_TIDSPBRIDGE),) > obj-y += dsp.o > endif
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti) To: linux-arm-kernel@lists.infradead.org Subject: OMAP34xx Date: Mon, 13 Feb 2012 11:05:53 +0530 [thread overview] Message-ID: <4F38A139.4090501@ti.com> (raw) In-Reply-To: <alpine.DEB.2.00.1202121148210.30322@utopia.booyaka.com> On Monday 13 February 2012 12:42 AM, Paul Walmsley wrote: > Hi > > On Sun, 12 Feb 2012, Russell King - ARM Linux wrote: > >> The other allnoconfig issue is: >> >> arch/arm/mach-omap2/built-in.o:(.data+0xa3d0): undefined reference to `omap_i2c_reset' >> >> which looks like hwmod can't cope with the I2C_OMAP being disabled. >> >> I don't propose these are fixed for v3.3, but they certainly should be >> fixed for v3.4. > Thanks for the report. Here's a patch for this for 3.4. Compile-tested > only; will boot-test it as part of the v2 of the 3.4 hwmod changes. > Boot tested on omap4430 sdp. > - Paul > > From: Paul Walmsley <paul@pwsan.com> > Date: Sun, 12 Feb 2012 11:49:34 -0700 > Subject: [PATCH] ARM: OMAP2+: I2C: always compile I2C reset code, even if I2C > driver is not built > > During kernel init, we reset all IP blocks on the OMAP that we can, > even if there is no driver compiled for that IP block. Unlike most IP > blocks, the I2C block requires some extra programming for this to > work. This reset code is incorrectly omitted when the I2C driver is > deselected. In this circumstance, the build breaks. Fix by compiling > the I2C reset code unconditionally. > > Problem reported by Russell King <linux@arm.linux.org.uk>. > > Signed-off-by: Paul Walmsley <paul@pwsan.com> > Cc: Russell King <linux@arm.linux.org.uk> > --- > arch/arm/mach-omap2/Makefile | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile > index fc9b238..0d5676c 100644 > --- a/arch/arm/mach-omap2/Makefile > +++ b/arch/arm/mach-omap2/Makefile > @@ -4,7 +4,7 @@ > > # Common support > obj-y := id.o io.o control.o mux.o devices.o serial.o gpmc.o timer.o pm.o \ > - common.o gpio.o dma.o wd_timer.o display.o > + common.o gpio.o dma.o wd_timer.o display.o i2c.o > > omap-2-3-common = irq.o sdrc.o > hwmod-common = omap_hwmod.o \ > @@ -182,9 +182,6 @@ obj-$(CONFIG_OMAP_IOMMU) += iommu2.o > iommu-$(CONFIG_OMAP_IOMMU) := omap-iommu.o > obj-y += $(iommu-m) $(iommu-y) > > -i2c-omap-$(CONFIG_I2C_OMAP) := i2c.o > -obj-y += $(i2c-omap-m) $(i2c-omap-y) > - > ifneq ($(CONFIG_TIDSPBRIDGE),) > obj-y += dsp.o > endif
next prev parent reply other threads:[~2012-02-13 5:36 UTC|newest] Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-04 18:54 OMAP34xx Russell King - ARM Linux 2012-02-04 19:01 ` OMAP34xx Tony Lindgren 2012-02-04 19:23 ` OMAP34xx Olof Johansson 2012-02-04 20:34 ` OMAP34xx Russell King - ARM Linux 2012-02-04 20:53 ` OMAP34xx Russell King - ARM Linux 2012-02-04 23:09 ` OMAP34xx Tony Lindgren 2012-02-04 21:09 ` OMAP34xx Grazvydas Ignotas 2012-02-05 1:33 ` OMAP34xx Tony Lindgren 2012-02-04 23:05 ` OMAP34xx Tony Lindgren 2012-02-05 0:09 ` OMAP34xx Russell King - ARM Linux 2012-02-05 0:53 ` OMAP34xx Tony Lindgren 2012-02-04 23:14 ` OMAP34xx Russell King - ARM Linux 2012-02-05 1:25 ` OMAP34xx Tony Lindgren 2012-02-05 11:39 ` [PATCH] arm: omap3: cm-t35: fix section mismatch warning Igor Grinberg 2012-02-05 11:39 ` Igor Grinberg 2012-02-08 5:35 ` Tony Lindgren 2012-02-08 5:35 ` Tony Lindgren 2012-02-08 10:16 ` [PATCH] ARM: OMAP: update omap1 and omap2plus defconfigs Igor Grinberg 2012-02-08 10:16 ` Igor Grinberg 2012-02-08 10:19 ` Russell King - ARM Linux 2012-02-08 10:19 ` Russell King - ARM Linux 2012-02-08 11:09 ` Igor Grinberg 2012-02-08 11:09 ` Igor Grinberg 2012-02-08 19:51 ` Tony Lindgren 2012-02-08 19:51 ` Tony Lindgren 2012-02-08 15:37 ` Janusz Krzysztofik 2012-02-08 15:37 ` Janusz Krzysztofik 2012-02-09 11:18 ` [PATCH] ARM: OMAP1: ams-delta: clean up init data section assignments Janusz Krzysztofik 2012-02-09 11:18 ` Janusz Krzysztofik 2012-02-09 11:18 ` Janusz Krzysztofik 2012-02-09 11:18 ` Janusz Krzysztofik 2012-02-09 14:48 ` Russell King - ARM Linux 2012-02-09 14:48 ` Russell King - ARM Linux 2012-02-09 14:48 ` Russell King - ARM Linux 2012-02-09 14:48 ` Russell King - ARM Linux 2012-02-10 16:31 ` [PATCH] ARM: OMAP1: ams-delta: correct " Janusz Krzysztofik 2012-02-10 16:31 ` Janusz Krzysztofik 2012-02-10 16:31 ` Janusz Krzysztofik 2012-02-10 16:31 ` Janusz Krzysztofik 2012-02-10 16:48 ` [PATCH v2] ARM: OMAP1: ams-delta: clean up " Janusz Krzysztofik 2012-02-10 16:48 ` Janusz Krzysztofik 2012-02-10 16:48 ` Janusz Krzysztofik 2012-02-10 16:48 ` Janusz Krzysztofik 2012-02-11 10:24 ` [PATCH] ARM: OMAP1: ams-delta: correct " Russell King - ARM Linux 2012-02-11 10:24 ` Russell King - ARM Linux 2012-02-11 10:24 ` Russell King - ARM Linux 2012-02-11 10:24 ` Russell King - ARM Linux 2012-02-05 12:59 ` OMAP34xx Russell King - ARM Linux 2012-02-05 17:29 ` OMAP34xx Tony Lindgren 2012-02-05 17:58 ` OMAP34xx Russell King - ARM Linux 2012-02-05 18:29 ` OMAP34xx Tony Lindgren 2012-02-07 22:36 ` OMAP34xx Kevin Hilman 2012-02-07 22:49 ` OMAP34xx Víctor M. Jáquez L. [not found] ` <8762fijifc.fsf@ti.com> 2012-02-08 9:45 ` OMAP34xx Russell King - ARM Linux 2012-02-08 19:55 ` OMAP34xx Tony Lindgren 2012-02-08 23:10 ` OMAP34xx Russell King - ARM Linux 2012-02-08 23:27 ` OMAP34xx Tony Lindgren 2012-02-10 11:03 ` OMAP34xx Russell King - ARM Linux 2012-02-08 0:53 ` OMAP34xx Kevin Hilman 2012-02-08 10:46 ` OMAP34xx Grazvydas Ignotas 2012-02-08 17:01 ` OMAP34xx Kevin Hilman 2012-02-08 17:06 ` OMAP34xx Greg KH 2012-02-08 17:23 ` OMAP34xx Grazvydas Ignotas 2012-02-08 19:53 ` OMAP34xx Greg KH 2012-02-08 23:03 ` OMAP34xx Kevin Hilman 2012-02-08 23:15 ` OMAP34xx Greg KH 2012-02-09 0:14 ` OMAP34xx Paul Walmsley 2012-02-09 0:47 ` OMAP34xx Greg KH 2012-02-09 1:39 ` OMAP34xx Kevin Hilman 2012-02-09 18:49 ` OMAP34xx Greg KH 2012-02-09 1:43 ` OMAP34xx Austin, Brian 2012-02-09 7:25 ` OMAP34xx Jarkko Nikula 2012-02-09 13:37 ` OMAP34xx Mark Brown 2012-02-09 18:36 ` OMAP34xx Tony Lindgren 2012-02-09 19:26 ` OMAP34xx Tony Lindgren 2012-02-09 20:44 ` OMAP34xx Paul Walmsley 2012-02-10 1:22 ` OMAP34xx Paul Walmsley 2012-02-09 19:34 ` OMAP34xx Rex Feany 2012-02-09 23:13 ` OMAP34xx Kevin Hilman 2012-02-10 1:41 ` OMAP34xx Rex Feany 2012-02-10 2:19 ` OMAP34xx Paul Walmsley 2012-02-10 7:10 ` OMAP34xx Hiremath, Vaibhav 2012-02-10 14:19 ` OMAP34xx Paul Walmsley 2012-02-10 16:03 ` OMAP34xx Hiremath, Vaibhav 2012-02-10 14:37 ` OMAP34xx Matt Porter 2012-02-10 18:31 ` OMAP34xx Matt Porter 2012-02-10 23:39 ` OMAP34xx Paul Walmsley 2012-02-10 18:58 ` OMAP34xx Tony Lindgren 2012-02-13 16:36 ` OMAP34xx Rex Feany 2012-02-14 8:48 ` OMAP34xx Felipe Balbi 2012-02-14 14:59 ` OMAP34xx Alan Stern 2012-02-10 11:53 ` OMAP34xx Grazvydas Ignotas 2012-02-10 20:06 ` OMAP34xx Russell King - ARM Linux 2012-02-15 21:57 ` OMAP34xx Luciano Coelho 2012-02-15 23:54 ` OMAP34xx Kevin Hilman 2012-02-16 0:13 ` OMAP34xx Kevin Hilman 2012-02-16 0:25 ` OMAP34xx NeilBrown 2012-02-16 1:28 ` OMAP34xx Kevin Hilman 2012-02-16 7:56 ` OMAP34xx Luciano Coelho 2012-02-16 7:52 ` OMAP34xx Luciano Coelho 2012-02-15 15:41 ` OMAP34xx Felipe Contreras 2012-02-08 23:34 ` OMAP34xx Russell King - ARM Linux 2012-02-06 18:13 ` OMAP34xx Tony Lindgren 2012-02-07 10:10 ` OMAP34xx Russell King - ARM Linux 2012-02-08 5:32 ` OMAP34xx Tony Lindgren 2012-02-13 21:17 ` OMAP34xx Tony Lindgren 2012-02-14 0:12 ` OMAP34xx Tony Lindgren 2012-02-06 23:19 ` OMAP34xx Cousson, Benoit 2012-02-06 23:48 ` OMAP34xx Tony Lindgren 2012-02-07 0:24 ` OMAP34xx Russell King - ARM Linux 2012-02-07 0:54 ` OMAP34xx Cousson, Benoit 2012-02-07 8:41 ` OMAP34xx Russell King - ARM Linux 2012-02-08 18:39 ` OMAP34xx Cousson, Benoit 2012-02-07 4:35 ` OMAP34xx Grant Likely 2012-02-07 5:26 ` OMAP34xx Cousson, Benoit 2012-02-07 8:46 ` OMAP34xx Russell King - ARM Linux 2012-02-07 17:28 ` OMAP34xx Mark Brown 2012-02-08 4:54 ` OMAP34xx Tony Lindgren 2012-02-08 16:16 ` OMAP34xx Cousson, Benoit 2012-02-05 1:55 ` OMAP34xx Tony Lindgren 2012-02-05 11:10 ` OMAP34xx Russell King - ARM Linux 2012-02-05 16:57 ` OMAP34xx Tony Lindgren 2012-02-05 12:56 ` OMAP34xx Russell King - ARM Linux 2012-02-05 14:38 ` OMAP34xx Russell King - ARM Linux 2012-02-05 17:40 ` OMAP34xx Tony Lindgren 2012-02-05 18:05 ` OMAP34xx Russell King - ARM Linux 2012-02-05 18:49 ` OMAP34xx Tony Lindgren 2012-02-05 20:04 ` OMAP34xx Russell King - ARM Linux 2012-02-09 6:52 ` OMAP34xx Archit Taneja 2012-02-09 22:34 ` OMAP34xx Russell King - ARM Linux 2012-02-10 6:26 ` OMAP34xx Archit Taneja 2012-04-05 8:24 ` OMAP34xx Russell King - ARM Linux 2012-04-05 8:34 ` OMAP34xx Archit Taneja 2012-04-05 8:49 ` OMAP34xx Russell King - ARM Linux 2012-04-05 9:10 ` OMAP34xx Archit Taneja 2012-02-05 17:25 ` OMAP34xx Russell King - ARM Linux 2012-02-05 17:47 ` OMAP34xx Tony Lindgren 2012-02-05 18:08 ` OMAP34xx Russell King - ARM Linux 2012-02-05 18:33 ` OMAP34xx Tony Lindgren 2012-02-05 18:41 ` OMAP34xx Russell King - ARM Linux 2012-02-05 18:59 ` OMAP34xx Tony Lindgren 2012-02-05 20:11 ` OMAP34xx Russell King - ARM Linux 2012-02-05 20:51 ` OMAP34xx Tony Lindgren 2012-02-06 10:37 ` OMAP34xx Ohad Ben-Cohen 2012-02-06 9:05 ` OMAP34xx Tero Kristo 2012-02-07 22:09 ` OMAP34xx Kevin Hilman 2012-02-08 5:47 ` OMAP34xx Tony Lindgren 2012-02-12 10:41 ` OMAP34xx Russell King - ARM Linux 2012-02-12 19:12 ` OMAP34xx Paul Walmsley 2012-02-12 19:12 ` OMAP34xx Paul Walmsley 2012-02-13 5:35 ` Shubhrajyoti [this message] 2012-02-13 5:35 ` OMAP34xx Shubhrajyoti 2012-02-15 15:52 ` OMAP34xx Paul Walmsley 2012-02-15 15:52 ` OMAP34xx Paul Walmsley 2012-02-15 11:27 ` OMAP34xx Russell King - ARM Linux 2012-02-16 1:34 ` OMAP34xx Kevin Hilman 2012-02-12 11:44 ` OMAP34xx Russell King - ARM Linux 2012-02-13 17:59 ` OMAP34xx Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4F38A139.4090501@ti.com \ --to=shubhrajyoti@ti.com \ --cc=arnd@arndb.de \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=olof@lixom.net \ --cc=paul@pwsan.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.