* [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format()
@ 2012-03-30 9:50 Ren Mingxin
0 siblings, 0 replies; 8+ messages in thread
From: Ren Mingxin @ 2012-03-30 9:50 UTC (permalink / raw)
To: Jens Axboe, Michael S. Tsirkin, Rusty Russell, Tejun Heo
Cc: VIRTUAL, LKML, SCSI, KVM
This patch series renames "sd_format_disk_name()" to
"disk_name_format()" and moves it into block core. So
that who needs formatting disk name can use it, instead
of duplicating these similar help functions.
Ren Mingxin (4):
block: add function disk_name_format() into block core
scsi: replace sd_format_disk_name() to disk_name_format()
block: replace rssd_disk_name_format() to disk_name_format()
virtio_blk: use disk_name_format() to support mass of disks naming
block/genhd.c | 49 ++++++++++++++++++++++++++++++++++++++
drivers/block/mtip32xx/mtip32xx.c | 33 -------------------------
drivers/block/virtio_blk.c | 13 ----------
drivers/scsi/sd.c | 48 -------------------------------------
include/linux/genhd.h | 2 +
5 files changed, 54 insertions(+), 91 deletions(-)
Any comment will be appreciated.
Thanks,
Ren
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format()
@ 2012-03-30 9:50 Ren Mingxin
2012-03-30 9:56 ` James Bottomley
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Ren Mingxin @ 2012-03-30 9:50 UTC (permalink / raw)
To: Jens Axboe, Michael S. Tsirkin, Rusty Russell, Tejun Heo
Cc: LKML, SCSI, KVM, VIRTUAL
This patch series renames "sd_format_disk_name()" to
"disk_name_format()" and moves it into block core. So
that who needs formatting disk name can use it, instead
of duplicating these similar help functions.
Ren Mingxin (4):
block: add function disk_name_format() into block core
scsi: replace sd_format_disk_name() to disk_name_format()
block: replace rssd_disk_name_format() to disk_name_format()
virtio_blk: use disk_name_format() to support mass of disks naming
block/genhd.c | 49 ++++++++++++++++++++++++++++++++++++++
drivers/block/mtip32xx/mtip32xx.c | 33 -------------------------
drivers/block/virtio_blk.c | 13 ----------
drivers/scsi/sd.c | 48 -------------------------------------
include/linux/genhd.h | 2 +
5 files changed, 54 insertions(+), 91 deletions(-)
Any comment will be appreciated.
Thanks,
Ren
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format()
2012-03-30 9:50 Ren Mingxin
@ 2012-03-30 9:56 ` James Bottomley
2012-03-30 9:56 ` James Bottomley
2012-04-01 11:20 ` Michael S. Tsirkin
2 siblings, 0 replies; 8+ messages in thread
From: James Bottomley @ 2012-03-30 9:56 UTC (permalink / raw)
To: Ren Mingxin
Cc: Jens Axboe, KVM, SCSI, Michael S. Tsirkin, LKML, VIRTUAL, Tejun Heo
On Fri, 2012-03-30 at 17:50 +0800, Ren Mingxin wrote:
>
> This patch series renames "sd_format_disk_name()" to
> "disk_name_format()" and moves it into block core. So
> that who needs formatting disk name can use it, instead
> of duplicating these similar help functions.
>
> Ren Mingxin (4):
> block: add function disk_name_format() into block core
> scsi: replace sd_format_disk_name() to disk_name_format()
These two should be a single patch so it makes it obvious to anyone
looking through the change sets that the code is merely being moved.
Other than that, everything looks fine to me.
James
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format()
2012-03-30 9:50 Ren Mingxin
2012-03-30 9:56 ` James Bottomley
@ 2012-03-30 9:56 ` James Bottomley
2012-03-30 10:10 ` Ren Mingxin
2012-03-30 10:10 ` Ren Mingxin
2012-04-01 11:20 ` Michael S. Tsirkin
2 siblings, 2 replies; 8+ messages in thread
From: James Bottomley @ 2012-03-30 9:56 UTC (permalink / raw)
To: Ren Mingxin
Cc: Jens Axboe, Michael S. Tsirkin, Rusty Russell, Tejun Heo, LKML,
SCSI, KVM, VIRTUAL
On Fri, 2012-03-30 at 17:50 +0800, Ren Mingxin wrote:
>
> This patch series renames "sd_format_disk_name()" to
> "disk_name_format()" and moves it into block core. So
> that who needs formatting disk name can use it, instead
> of duplicating these similar help functions.
>
> Ren Mingxin (4):
> block: add function disk_name_format() into block core
> scsi: replace sd_format_disk_name() to disk_name_format()
These two should be a single patch so it makes it obvious to anyone
looking through the change sets that the code is merely being moved.
Other than that, everything looks fine to me.
James
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format()
2012-03-30 9:56 ` James Bottomley
@ 2012-03-30 10:10 ` Ren Mingxin
2012-03-30 10:10 ` Ren Mingxin
1 sibling, 0 replies; 8+ messages in thread
From: Ren Mingxin @ 2012-03-30 10:10 UTC (permalink / raw)
To: James Bottomley
Cc: Jens Axboe, Michael S. Tsirkin, Rusty Russell, Tejun Heo, LKML,
SCSI, KVM, VIRTUAL
Hi, James:
On 03/30/2012 05:56 PM, James Bottomley wrote:
> On Fri, 2012-03-30 at 17:50 +0800, Ren Mingxin wrote:
>> This patch series renames "sd_format_disk_name()" to
>> "disk_name_format()" and moves it into block core. So
>> that who needs formatting disk name can use it, instead
>> of duplicating these similar help functions.
>>
>> Ren Mingxin (4):
>> block: add function disk_name_format() into block core
>> scsi: replace sd_format_disk_name() to disk_name_format()
> These two should be a single patch so it makes it obvious to anyone
> looking through the change sets that the code is merely being moved.
Thank you very much for so quick checking. I'll merge these
two patches into one in the next version.
> Other than that, everything looks fine to me.
>
>
Thanks,
Ren
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format()
2012-03-30 9:56 ` James Bottomley
2012-03-30 10:10 ` Ren Mingxin
@ 2012-03-30 10:10 ` Ren Mingxin
1 sibling, 0 replies; 8+ messages in thread
From: Ren Mingxin @ 2012-03-30 10:10 UTC (permalink / raw)
To: James Bottomley
Cc: Jens Axboe, KVM, SCSI, Michael S. Tsirkin, LKML, VIRTUAL, Tejun Heo
Hi, James:
On 03/30/2012 05:56 PM, James Bottomley wrote:
> On Fri, 2012-03-30 at 17:50 +0800, Ren Mingxin wrote:
>> This patch series renames "sd_format_disk_name()" to
>> "disk_name_format()" and moves it into block core. So
>> that who needs formatting disk name can use it, instead
>> of duplicating these similar help functions.
>>
>> Ren Mingxin (4):
>> block: add function disk_name_format() into block core
>> scsi: replace sd_format_disk_name() to disk_name_format()
> These two should be a single patch so it makes it obvious to anyone
> looking through the change sets that the code is merely being moved.
Thank you very much for so quick checking. I'll merge these
two patches into one in the next version.
> Other than that, everything looks fine to me.
>
>
Thanks,
Ren
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format()
2012-03-30 9:50 Ren Mingxin
@ 2012-04-01 11:20 ` Michael S. Tsirkin
2012-03-30 9:56 ` James Bottomley
2012-04-01 11:20 ` Michael S. Tsirkin
2 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2012-04-01 11:20 UTC (permalink / raw)
To: Ren Mingxin
Cc: Jens Axboe, Rusty Russell, Tejun Heo, LKML, SCSI, KVM, VIRTUAL
On Fri, Mar 30, 2012 at 05:50:12PM +0800, Ren Mingxin wrote:
>
>
> This patch series renames "sd_format_disk_name()" to
> "disk_name_format()" and moves it into block core. So
> that who needs formatting disk name can use it, instead
> of duplicating these similar help functions.
I see there are some responses about naming and comments,
so that would need to be fixed.
Besides this, Jens, would you like to take the patchset
through your tree or prefer for me to merge it through virtio tree?
Block tree seems more appropriate, right?
Also this is a bugfix technically since it fixes setups
with a ton of disks, so 3.4 material?
> Ren Mingxin (4):
> block: add function disk_name_format() into block core
> scsi: replace sd_format_disk_name() to disk_name_format()
> block: replace rssd_disk_name_format() to disk_name_format()
> virtio_blk: use disk_name_format() to support mass of disks naming
>
> block/genhd.c | 49 ++++++++++++++++++++++++++++++++++++++
> drivers/block/mtip32xx/mtip32xx.c | 33 -------------------------
> drivers/block/virtio_blk.c | 13 ----------
> drivers/scsi/sd.c | 48 -------------------------------------
> include/linux/genhd.h | 2 +
> 5 files changed, 54 insertions(+), 91 deletions(-)
>
> Any comment will be appreciated.
>
> Thanks,
> Ren
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format()
@ 2012-04-01 11:20 ` Michael S. Tsirkin
0 siblings, 0 replies; 8+ messages in thread
From: Michael S. Tsirkin @ 2012-04-01 11:20 UTC (permalink / raw)
To: Ren Mingxin; +Cc: Jens Axboe, KVM, SCSI, LKML, VIRTUAL, Tejun Heo
On Fri, Mar 30, 2012 at 05:50:12PM +0800, Ren Mingxin wrote:
>
>
> This patch series renames "sd_format_disk_name()" to
> "disk_name_format()" and moves it into block core. So
> that who needs formatting disk name can use it, instead
> of duplicating these similar help functions.
I see there are some responses about naming and comments,
so that would need to be fixed.
Besides this, Jens, would you like to take the patchset
through your tree or prefer for me to merge it through virtio tree?
Block tree seems more appropriate, right?
Also this is a bugfix technically since it fixes setups
with a ton of disks, so 3.4 material?
> Ren Mingxin (4):
> block: add function disk_name_format() into block core
> scsi: replace sd_format_disk_name() to disk_name_format()
> block: replace rssd_disk_name_format() to disk_name_format()
> virtio_blk: use disk_name_format() to support mass of disks naming
>
> block/genhd.c | 49 ++++++++++++++++++++++++++++++++++++++
> drivers/block/mtip32xx/mtip32xx.c | 33 -------------------------
> drivers/block/virtio_blk.c | 13 ----------
> drivers/scsi/sd.c | 48 -------------------------------------
> include/linux/genhd.h | 2 +
> 5 files changed, 54 insertions(+), 91 deletions(-)
>
> Any comment will be appreciated.
>
> Thanks,
> Ren
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-04-01 11:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-30 9:50 [PATCH 0/4] block: move sd_format_disk_name() into block core as disk_name_format() Ren Mingxin
2012-03-30 9:50 Ren Mingxin
2012-03-30 9:56 ` James Bottomley
2012-03-30 9:56 ` James Bottomley
2012-03-30 10:10 ` Ren Mingxin
2012-03-30 10:10 ` Ren Mingxin
2012-04-01 11:20 ` Michael S. Tsirkin
2012-04-01 11:20 ` Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.