All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	linux-pm@vger.kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	dietmar.eggemann@arm.com, morten.rasmussen@arm.com,
	juri.lelli@redhat.com, tkjos@android.com, joelaf@google.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] cpufreq: schedutil: Don't pass flags to sugov_set_iowait_boost()
Date: Wed, 13 Dec 2017 15:23:22 +0530	[thread overview]
Message-ID: <4ec5562b1a87e146ebab11fb5dde1ca9c763a7fb.1513158452.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1513158452.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1513158452.git.viresh.kumar@linaro.org>

We are already passing sg_cpu as argument to sugov_set_iowait_boost()
helper and the same can be used to retrieve the flags value. Get rid of
the redundant argument.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 kernel/sched/cpufreq_schedutil.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 60a2dea4c8cc..7edfdc59ee8f 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -187,10 +187,9 @@ static void sugov_get_util(unsigned long *util, unsigned long *max, int cpu)
 	*max = cfs_max;
 }
 
-static void sugov_set_iowait_boost(struct sugov_cpu *sg_cpu, u64 time,
-				   unsigned int flags)
+static void sugov_set_iowait_boost(struct sugov_cpu *sg_cpu, u64 time)
 {
-	if (flags & SCHED_CPUFREQ_IOWAIT) {
+	if (sg_cpu->flags & SCHED_CPUFREQ_IOWAIT) {
 		sg_cpu->flags &= ~SCHED_CPUFREQ_IOWAIT;
 
 		if (sg_cpu->iowait_boost_pending)
@@ -273,7 +272,7 @@ static void sugov_update_single(struct update_util_data *hook, u64 time,
 
 	sg_cpu->flags |= flags;
 
-	sugov_set_iowait_boost(sg_cpu, time, flags);
+	sugov_set_iowait_boost(sg_cpu, time);
 	sg_cpu->last_update = time;
 
 	if (!sugov_should_update_freq(sg_policy, time))
@@ -363,7 +362,7 @@ static void sugov_update_shared(struct update_util_data *hook, u64 time,
 	sg_cpu->max = max;
 	sg_cpu->flags |= flags;
 
-	sugov_set_iowait_boost(sg_cpu, time, flags);
+	sugov_set_iowait_boost(sg_cpu, time);
 	sg_cpu->last_update = time;
 
 	if (sugov_should_update_freq(sg_policy, time)) {
-- 
2.15.0.194.g9af6a3dea062

  parent reply	other threads:[~2017-12-13  9:55 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13  9:53 [PATCH 0/4] sched: cpufreq: Track util update flags Viresh Kumar
2017-12-13  9:53 ` [PATCH 1/4] cpufreq: schedutil: Initialize sg_cpu->flags to 0 Viresh Kumar
2017-12-13 11:13   ` Juri Lelli
2017-12-13 11:22     ` Viresh Kumar
2018-01-10 12:15   ` [tip:sched/core] sched/cpufreq: " tip-bot for Viresh Kumar
2017-12-13  9:53 ` [PATCH 2/4] sched: cpufreq: Keep track of cpufreq utilization update flags Viresh Kumar
2017-12-13 11:26   ` Juri Lelli
2017-12-13 11:29     ` Viresh Kumar
2017-12-16 16:40   ` Rafael J. Wysocki
2017-12-16 16:47     ` Viresh Kumar
2017-12-17  0:19       ` Rafael J. Wysocki
2017-12-18  4:59         ` Viresh Kumar
2017-12-18 11:35           ` Rafael J. Wysocki
2017-12-18 11:59             ` Viresh Kumar
2017-12-18 12:14               ` Patrick Bellasi
2017-12-19  3:12                 ` Viresh Kumar
2017-12-19  3:18                   ` Joel Fernandes
2017-12-19  3:22                     ` Viresh Kumar
2017-12-19  3:26                       ` Viresh Kumar
2017-12-19  3:30                         ` Joel Fernandes
2017-12-19  3:41                           ` Viresh Kumar
2017-12-19 10:44                             ` Rafael J. Wysocki
2017-12-18 17:34               ` Rafael J. Wysocki
2017-12-19 19:25   ` Peter Zijlstra
2017-12-20  4:04     ` Viresh Kumar
2017-12-20  8:31       ` Peter Zijlstra
2017-12-20  8:48         ` Viresh Kumar
2017-12-20  9:17           ` Peter Zijlstra
2017-12-20 12:55         ` Patrick Bellasi
2017-12-20 13:28           ` Peter Zijlstra
2017-12-20 14:31             ` Patrick Bellasi
2017-12-20 14:52               ` Rafael J. Wysocki
2017-12-20 15:01                 ` Patrick Bellasi
2017-12-20 14:47             ` Rafael J. Wysocki
2017-12-20 14:51               ` Peter Zijlstra
2017-12-20 17:27               ` Juri Lelli
2017-12-20 18:17                 ` Peter Zijlstra
2017-12-13  9:53 ` Viresh Kumar [this message]
2017-12-13 11:28   ` [PATCH 3/4] cpufreq: schedutil: Don't pass flags to sugov_set_iowait_boost() Juri Lelli
2018-01-10 12:15   ` [tip:sched/core] sched/cpufreq: " tip-bot for Viresh Kumar
2017-12-13  9:53 ` [PATCH 4/4] cpufreq: schedutil: Don't call sugov_get_util() unnecessarily Viresh Kumar
2017-12-13 11:34   ` Juri Lelli
2017-12-13 12:02     ` Viresh Kumar
2017-12-19  3:26   ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ec5562b1a87e146ebab11fb5dde1ca9c763a7fb.1513158452.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=joelaf@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=tkjos@android.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.