* [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header @ 2021-04-07 13:47 Andy Shevchenko 2021-04-07 15:42 ` Jens Axboe 2021-04-07 15:51 ` kernel test robot 0 siblings, 2 replies; 14+ messages in thread From: Andy Shevchenko @ 2021-04-07 13:47 UTC (permalink / raw) To: Andy Shevchenko, linux-ide, linux-kernel; +Cc: Jens Axboe There is no need to have kernel.h included, I do not see any direct users of it in ata.h. Drop unneeded inclusion of kernel.h. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/ata.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/ata.h b/include/linux/ata.h index 6e67aded28f8..21142b17245f 100644 --- a/include/linux/ata.h +++ b/include/linux/ata.h @@ -13,7 +13,6 @@ #ifndef __LINUX_ATA_H__ #define __LINUX_ATA_H__ -#include <linux/kernel.h> #include <linux/string.h> #include <linux/types.h> #include <asm/byteorder.h> -- 2.30.2 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header 2021-04-07 13:47 [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header Andy Shevchenko @ 2021-04-07 15:42 ` Jens Axboe 2021-04-07 15:51 ` kernel test robot 1 sibling, 0 replies; 14+ messages in thread From: Jens Axboe @ 2021-04-07 15:42 UTC (permalink / raw) To: Andy Shevchenko, linux-ide, linux-kernel On 4/7/21 7:47 AM, Andy Shevchenko wrote: > There is no need to have kernel.h included, I do not see any > direct users of it in ata.h. Drop unneeded inclusion of kernel.h. Applied, thanks. -- Jens Axboe ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header 2021-04-07 13:47 [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header Andy Shevchenko @ 2021-04-07 15:51 ` kernel test robot 2021-04-07 15:51 ` kernel test robot 1 sibling, 0 replies; 14+ messages in thread From: kernel test robot @ 2021-04-07 15:51 UTC (permalink / raw) To: Andy Shevchenko, linux-ide, linux-kernel; +Cc: kbuild-all, Jens Axboe [-- Attachment #1: Type: text/plain, Size: 2362 bytes --] Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on v5.12-rc6 next-20210407] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: x86_64-randconfig-s021-20210407 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-279-g6d5d9b42-dirty # https://github.com/0day-ci/linux/commit/d2574103b692b4fc73f1ed36ee9e4d3324902fd9 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 git checkout d2574103b692b4fc73f1ed36ee9e4d3324902fd9 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from drivers/hwmon/drivetemp.c:98: include/linux/ata.h: In function 'ata_id_has_ncq_send_and_recv': >> include/linux/ata.h:929:40: error: implicit declaration of function 'BIT' [-Werror=implicit-function-declaration] 929 | return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); | ^~~ cc1: some warnings being treated as errors vim +/BIT +929 include/linux/ata.h 4bca3286433585 Martin K. Petersen 2009-05-15 926 ed36911c747c18 Marc Carino 2013-08-24 927 static inline bool ata_id_has_ncq_send_and_recv(const u16 *id) ed36911c747c18 Marc Carino 2013-08-24 928 { ed36911c747c18 Marc Carino 2013-08-24 @929 return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); ed36911c747c18 Marc Carino 2013-08-24 930 } ed36911c747c18 Marc Carino 2013-08-24 931 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 35386 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header @ 2021-04-07 15:51 ` kernel test robot 0 siblings, 0 replies; 14+ messages in thread From: kernel test robot @ 2021-04-07 15:51 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 2413 bytes --] Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on v5.12-rc6 next-20210407] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: x86_64-randconfig-s021-20210407 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-279-g6d5d9b42-dirty # https://github.com/0day-ci/linux/commit/d2574103b692b4fc73f1ed36ee9e4d3324902fd9 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 git checkout d2574103b692b4fc73f1ed36ee9e4d3324902fd9 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from drivers/hwmon/drivetemp.c:98: include/linux/ata.h: In function 'ata_id_has_ncq_send_and_recv': >> include/linux/ata.h:929:40: error: implicit declaration of function 'BIT' [-Werror=implicit-function-declaration] 929 | return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); | ^~~ cc1: some warnings being treated as errors vim +/BIT +929 include/linux/ata.h 4bca3286433585 Martin K. Petersen 2009-05-15 926 ed36911c747c18 Marc Carino 2013-08-24 927 static inline bool ata_id_has_ncq_send_and_recv(const u16 *id) ed36911c747c18 Marc Carino 2013-08-24 928 { ed36911c747c18 Marc Carino 2013-08-24 @929 return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); ed36911c747c18 Marc Carino 2013-08-24 930 } ed36911c747c18 Marc Carino 2013-08-24 931 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 35386 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header 2021-04-07 15:51 ` kernel test robot @ 2021-04-07 16:03 ` Andy Shevchenko -1 siblings, 0 replies; 14+ messages in thread From: Andy Shevchenko @ 2021-04-07 16:03 UTC (permalink / raw) To: kernel test robot; +Cc: linux-ide, linux-kernel, kbuild-all, Jens Axboe On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > Hi Andy, > > I love your patch! Yet something to improve: > > [auto build test ERROR on block/for-next] > [also build test ERROR on v5.12-rc6 next-20210407] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 > base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next > config: x86_64-randconfig-s021-20210407 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.3-279-g6d5d9b42-dirty > # https://github.com/0day-ci/linux/commit/d2574103b692b4fc73f1ed36ee9e4d3324902fd9 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 > git checkout d2574103b692b4fc73f1ed36ee9e4d3324902fd9 > # save the attached .config to linux build tree > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): Thanks, we need to include bits.h. (It passed my simple build, but appears I have no such driver included) Jens, I saw your message, should I send a follow up fix, or a v2? > In file included from drivers/hwmon/drivetemp.c:98: > include/linux/ata.h: In function 'ata_id_has_ncq_send_and_recv': > >> include/linux/ata.h:929:40: error: implicit declaration of function 'BIT' [-Werror=implicit-function-declaration] > 929 | return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); > | ^~~ > cc1: some warnings being treated as errors > > > vim +/BIT +929 include/linux/ata.h > > 4bca3286433585 Martin K. Petersen 2009-05-15 926 > ed36911c747c18 Marc Carino 2013-08-24 927 static inline bool ata_id_has_ncq_send_and_recv(const u16 *id) > ed36911c747c18 Marc Carino 2013-08-24 928 { > ed36911c747c18 Marc Carino 2013-08-24 @929 return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); > ed36911c747c18 Marc Carino 2013-08-24 930 } > ed36911c747c18 Marc Carino 2013-08-24 931 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header @ 2021-04-07 16:03 ` Andy Shevchenko 0 siblings, 0 replies; 14+ messages in thread From: Andy Shevchenko @ 2021-04-07 16:03 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 2807 bytes --] On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > Hi Andy, > > I love your patch! Yet something to improve: > > [auto build test ERROR on block/for-next] > [also build test ERROR on v5.12-rc6 next-20210407] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 > base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next > config: x86_64-randconfig-s021-20210407 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.3-279-g6d5d9b42-dirty > # https://github.com/0day-ci/linux/commit/d2574103b692b4fc73f1ed36ee9e4d3324902fd9 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 > git checkout d2574103b692b4fc73f1ed36ee9e4d3324902fd9 > # save the attached .config to linux build tree > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): Thanks, we need to include bits.h. (It passed my simple build, but appears I have no such driver included) Jens, I saw your message, should I send a follow up fix, or a v2? > In file included from drivers/hwmon/drivetemp.c:98: > include/linux/ata.h: In function 'ata_id_has_ncq_send_and_recv': > >> include/linux/ata.h:929:40: error: implicit declaration of function 'BIT' [-Werror=implicit-function-declaration] > 929 | return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); > | ^~~ > cc1: some warnings being treated as errors > > > vim +/BIT +929 include/linux/ata.h > > 4bca3286433585 Martin K. Petersen 2009-05-15 926 > ed36911c747c18 Marc Carino 2013-08-24 927 static inline bool ata_id_has_ncq_send_and_recv(const u16 *id) > ed36911c747c18 Marc Carino 2013-08-24 928 { > ed36911c747c18 Marc Carino 2013-08-24 @929 return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); > ed36911c747c18 Marc Carino 2013-08-24 930 } > ed36911c747c18 Marc Carino 2013-08-24 931 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header 2021-04-07 16:03 ` Andy Shevchenko @ 2021-04-07 16:04 ` Jens Axboe -1 siblings, 0 replies; 14+ messages in thread From: Jens Axboe @ 2021-04-07 16:04 UTC (permalink / raw) To: Andy Shevchenko, kernel test robot; +Cc: linux-ide, linux-kernel, kbuild-all On 4/7/21 10:03 AM, Andy Shevchenko wrote: > On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: >> Hi Andy, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on block/for-next] >> [also build test ERROR on v5.12-rc6 next-20210407] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next >> config: x86_64-randconfig-s021-20210407 (attached as .config) >> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 >> reproduce: >> # apt-get install sparse >> # sparse version: v0.6.3-279-g6d5d9b42-dirty >> # https://github.com/0day-ci/linux/commit/d2574103b692b4fc73f1ed36ee9e4d3324902fd9 >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 >> git checkout d2574103b692b4fc73f1ed36ee9e4d3324902fd9 >> # save the attached .config to linux build tree >> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp@intel.com> >> >> All errors (new ones prefixed by >>): > > Thanks, we need to include bits.h. > (It passed my simple build, but appears I have no such driver included) > > Jens, I saw your message, should I send a follow up fix, or a v2? Let's just drop it, not worth it for the risk imho. -- Jens Axboe ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header @ 2021-04-07 16:04 ` Jens Axboe 0 siblings, 0 replies; 14+ messages in thread From: Jens Axboe @ 2021-04-07 16:04 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 1874 bytes --] On 4/7/21 10:03 AM, Andy Shevchenko wrote: > On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: >> Hi Andy, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on block/for-next] >> [also build test ERROR on v5.12-rc6 next-20210407] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next >> config: x86_64-randconfig-s021-20210407 (attached as .config) >> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 >> reproduce: >> # apt-get install sparse >> # sparse version: v0.6.3-279-g6d5d9b42-dirty >> # https://github.com/0day-ci/linux/commit/d2574103b692b4fc73f1ed36ee9e4d3324902fd9 >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 >> git checkout d2574103b692b4fc73f1ed36ee9e4d3324902fd9 >> # save the attached .config to linux build tree >> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp@intel.com> >> >> All errors (new ones prefixed by >>): > > Thanks, we need to include bits.h. > (It passed my simple build, but appears I have no such driver included) > > Jens, I saw your message, should I send a follow up fix, or a v2? Let's just drop it, not worth it for the risk imho. -- Jens Axboe ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header 2021-04-07 16:04 ` Jens Axboe @ 2021-04-07 16:27 ` Andy Shevchenko -1 siblings, 0 replies; 14+ messages in thread From: Andy Shevchenko @ 2021-04-07 16:27 UTC (permalink / raw) To: Jens Axboe; +Cc: kernel test robot, linux-ide, linux-kernel, kbuild-all On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: > On 4/7/21 10:03 AM, Andy Shevchenko wrote: > > On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: ... > >> All errors (new ones prefixed by >>): > > > > Thanks, we need to include bits.h. > > (It passed my simple build, but appears I have no such driver included) > > > > Jens, I saw your message, should I send a follow up fix, or a v2? > > Let's just drop it, not worth it for the risk imho. Does it mean I may try again in next cycle? Because kernel.h inclusion seems to me too wrong there. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header @ 2021-04-07 16:27 ` Andy Shevchenko 0 siblings, 0 replies; 14+ messages in thread From: Andy Shevchenko @ 2021-04-07 16:27 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 643 bytes --] On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: > On 4/7/21 10:03 AM, Andy Shevchenko wrote: > > On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: ... > >> All errors (new ones prefixed by >>): > > > > Thanks, we need to include bits.h. > > (It passed my simple build, but appears I have no such driver included) > > > > Jens, I saw your message, should I send a follow up fix, or a v2? > > Let's just drop it, not worth it for the risk imho. Does it mean I may try again in next cycle? Because kernel.h inclusion seems to me too wrong there. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header 2021-04-07 16:27 ` Andy Shevchenko @ 2021-04-07 16:43 ` Jens Axboe -1 siblings, 0 replies; 14+ messages in thread From: Jens Axboe @ 2021-04-07 16:43 UTC (permalink / raw) To: Andy Shevchenko; +Cc: kernel test robot, linux-ide, linux-kernel, kbuild-all On 4/7/21 10:27 AM, Andy Shevchenko wrote: > On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: >> On 4/7/21 10:03 AM, Andy Shevchenko wrote: >>> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > > ... > >>>> All errors (new ones prefixed by >>): >>> >>> Thanks, we need to include bits.h. >>> (It passed my simple build, but appears I have no such driver included) >>> >>> Jens, I saw your message, should I send a follow up fix, or a v2? >> >> Let's just drop it, not worth it for the risk imho. > > Does it mean I may try again in next cycle? > > Because kernel.h inclusion seems to me too wrong there. I don't mind taking it, but not on a hunch. If you send something that has been thought about and went through full compilation, then you can resend it. -- Jens Axboe ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header @ 2021-04-07 16:43 ` Jens Axboe 0 siblings, 0 replies; 14+ messages in thread From: Jens Axboe @ 2021-04-07 16:43 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 834 bytes --] On 4/7/21 10:27 AM, Andy Shevchenko wrote: > On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: >> On 4/7/21 10:03 AM, Andy Shevchenko wrote: >>> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > > ... > >>>> All errors (new ones prefixed by >>): >>> >>> Thanks, we need to include bits.h. >>> (It passed my simple build, but appears I have no such driver included) >>> >>> Jens, I saw your message, should I send a follow up fix, or a v2? >> >> Let's just drop it, not worth it for the risk imho. > > Does it mean I may try again in next cycle? > > Because kernel.h inclusion seems to me too wrong there. I don't mind taking it, but not on a hunch. If you send something that has been thought about and went through full compilation, then you can resend it. -- Jens Axboe ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header 2021-04-07 16:43 ` Jens Axboe @ 2021-04-07 17:10 ` Andy Shevchenko -1 siblings, 0 replies; 14+ messages in thread From: Andy Shevchenko @ 2021-04-07 17:10 UTC (permalink / raw) To: Jens Axboe; +Cc: kernel test robot, linux-ide, linux-kernel, kbuild-all On Wed, Apr 07, 2021 at 10:43:53AM -0600, Jens Axboe wrote: > On 4/7/21 10:27 AM, Andy Shevchenko wrote: > > On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: > >> On 4/7/21 10:03 AM, Andy Shevchenko wrote: > >>> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > > > > ... > > > >>>> All errors (new ones prefixed by >>): > >>> > >>> Thanks, we need to include bits.h. > >>> (It passed my simple build, but appears I have no such driver included) > >>> > >>> Jens, I saw your message, should I send a follow up fix, or a v2? > >> > >> Let's just drop it, not worth it for the risk imho. > > > > Does it mean I may try again in next cycle? > > > > Because kernel.h inclusion seems to me too wrong there. > > I don't mind taking it, but not on a hunch. If you send something > that has been thought about and went through full compilation, then > you can resend it. Got it! I think allyesconfig would serve a good job. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header @ 2021-04-07 17:10 ` Andy Shevchenko 0 siblings, 0 replies; 14+ messages in thread From: Andy Shevchenko @ 2021-04-07 17:10 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 1024 bytes --] On Wed, Apr 07, 2021 at 10:43:53AM -0600, Jens Axboe wrote: > On 4/7/21 10:27 AM, Andy Shevchenko wrote: > > On Wed, Apr 07, 2021 at 10:04:49AM -0600, Jens Axboe wrote: > >> On 4/7/21 10:03 AM, Andy Shevchenko wrote: > >>> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > > > > ... > > > >>>> All errors (new ones prefixed by >>): > >>> > >>> Thanks, we need to include bits.h. > >>> (It passed my simple build, but appears I have no such driver included) > >>> > >>> Jens, I saw your message, should I send a follow up fix, or a v2? > >> > >> Let's just drop it, not worth it for the risk imho. > > > > Does it mean I may try again in next cycle? > > > > Because kernel.h inclusion seems to me too wrong there. > > I don't mind taking it, but not on a hunch. If you send something > that has been thought about and went through full compilation, then > you can resend it. Got it! I think allyesconfig would serve a good job. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-04-07 17:10 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-07 13:47 [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header Andy Shevchenko 2021-04-07 15:42 ` Jens Axboe 2021-04-07 15:51 ` kernel test robot 2021-04-07 15:51 ` kernel test robot 2021-04-07 16:03 ` Andy Shevchenko 2021-04-07 16:03 ` Andy Shevchenko 2021-04-07 16:04 ` Jens Axboe 2021-04-07 16:04 ` Jens Axboe 2021-04-07 16:27 ` Andy Shevchenko 2021-04-07 16:27 ` Andy Shevchenko 2021-04-07 16:43 ` Jens Axboe 2021-04-07 16:43 ` Jens Axboe 2021-04-07 17:10 ` Andy Shevchenko 2021-04-07 17:10 ` Andy Shevchenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.