From: Nicolas Ferre <nicolas.ferre@atmel.com> To: Wolfram Sang <wsa@the-dreams.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <linux-serial@vger.kernel.org> Cc: <linux-kernel@vger.kernel.org>, Jiri Slaby <jslaby@suse.cz> Subject: Re: [PATCH 11/12] drivers/tty/serial: don't use devm_pinctrl_get_select_default() in probe Date: Thu, 11 Jul 2013 09:40:46 +0200 [thread overview] Message-ID: <51DE617E.3060908@atmel.com> (raw) In-Reply-To: <1373471889-18107-11-git-send-email-wsa@the-dreams.de> On 10/07/2013 17:57, Wolfram Sang : > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for setting the default pins. Compile tested only. > > Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> > --- > drivers/tty/serial/atmel_serial.c | 8 -------- For atmel_serial.c: Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Thanks. > drivers/tty/serial/imx.c | 9 --------- > drivers/tty/serial/mxs-auart.c | 8 -------- > drivers/tty/serial/omap-serial.c | 9 --------- > 4 files changed, 34 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 691265f..0e39fac 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -39,7 +39,6 @@ > #include <linux/atmel_pdc.h> > #include <linux/atmel_serial.h> > #include <linux/uaccess.h> > -#include <linux/pinctrl/consumer.h> > #include <linux/platform_data/atmel.h> > > #include <asm/io.h> > @@ -1775,7 +1774,6 @@ static int atmel_serial_probe(struct platform_device *pdev) > struct atmel_uart_data *pdata = pdev->dev.platform_data; > void *data; > int ret = -ENODEV; > - struct pinctrl *pinctrl; > > BUILD_BUG_ON(ATMEL_SERIAL_RINGSIZE & (ATMEL_SERIAL_RINGSIZE - 1)); > > @@ -1809,12 +1807,6 @@ static int atmel_serial_probe(struct platform_device *pdev) > if (ret) > goto err; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) { > - ret = PTR_ERR(pinctrl); > - goto err; > - } > - > if (!atmel_use_dma_rx(&port->uart)) { > ret = -ENOMEM; > data = kmalloc(sizeof(struct atmel_uart_char) > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > index 415cec6..2797e55 100644 > --- a/drivers/tty/serial/imx.c > +++ b/drivers/tty/serial/imx.c > @@ -47,7 +47,6 @@ > #include <linux/slab.h> > #include <linux/of.h> > #include <linux/of_device.h> > -#include <linux/pinctrl/consumer.h> > #include <linux/io.h> > > #include <asm/irq.h> > @@ -1507,7 +1506,6 @@ static int serial_imx_probe(struct platform_device *pdev) > void __iomem *base; > int ret = 0; > struct resource *res; > - struct pinctrl *pinctrl; > > sport = devm_kzalloc(&pdev->dev, sizeof(*sport), GFP_KERNEL); > if (!sport) > @@ -1543,13 +1541,6 @@ static int serial_imx_probe(struct platform_device *pdev) > sport->timer.function = imx_timeout; > sport->timer.data = (unsigned long)sport; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) { > - ret = PTR_ERR(pinctrl); > - dev_err(&pdev->dev, "failed to get default pinctrl: %d\n", ret); > - return ret; > - } > - > sport->clk_ipg = devm_clk_get(&pdev->dev, "ipg"); > if (IS_ERR(sport->clk_ipg)) { > ret = PTR_ERR(sport->clk_ipg); > diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c > index 4f5f161..a63a20e 100644 > --- a/drivers/tty/serial/mxs-auart.c > +++ b/drivers/tty/serial/mxs-auart.c > @@ -32,7 +32,6 @@ > #include <linux/clk.h> > #include <linux/delay.h> > #include <linux/io.h> > -#include <linux/pinctrl/consumer.h> > #include <linux/of_device.h> > #include <linux/dma-mapping.h> > #include <linux/dmaengine.h> > @@ -1015,7 +1014,6 @@ static int mxs_auart_probe(struct platform_device *pdev) > u32 version; > int ret = 0; > struct resource *r; > - struct pinctrl *pinctrl; > > s = kzalloc(sizeof(struct mxs_auart_port), GFP_KERNEL); > if (!s) { > @@ -1029,12 +1027,6 @@ static int mxs_auart_probe(struct platform_device *pdev) > else if (ret < 0) > goto out_free; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) { > - ret = PTR_ERR(pinctrl); > - goto out_free; > - } > - > if (of_id) { > pdev->id_entry = of_id->data; > s->devtype = pdev->id_entry->driver_data; > diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c > index b6d1728..eacb0de 100644 > --- a/drivers/tty/serial/omap-serial.c > +++ b/drivers/tty/serial/omap-serial.c > @@ -40,7 +40,6 @@ > #include <linux/pm_runtime.h> > #include <linux/of.h> > #include <linux/gpio.h> > -#include <linux/pinctrl/consumer.h> > #include <linux/platform_data/serial-omap.h> > > #define OMAP_MAX_HSUART_PORTS 6 > @@ -160,7 +159,6 @@ struct uart_omap_port { > u32 latency; > u32 calc_latency; > struct work_struct qos_work; > - struct pinctrl *pins; > bool is_suspending; > }; > > @@ -1468,13 +1466,6 @@ static int serial_omap_probe(struct platform_device *pdev) > goto err_port_line; > } > > - up->pins = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(up->pins)) { > - dev_warn(&pdev->dev, "did not get pins for uart%i error: %li\n", > - up->port.line, PTR_ERR(up->pins)); > - up->pins = NULL; > - } > - > sprintf(up->name, "OMAP UART%d", up->port.line); > up->port.mapbase = mem->start; > up->port.membase = devm_ioremap(&pdev->dev, mem->start, > -- Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com> To: Wolfram Sang <wsa@the-dreams.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz> Subject: Re: [PATCH 11/12] drivers/tty/serial: don't use devm_pinctrl_get_select_default() in probe Date: Thu, 11 Jul 2013 09:40:46 +0200 [thread overview] Message-ID: <51DE617E.3060908@atmel.com> (raw) In-Reply-To: <1373471889-18107-11-git-send-email-wsa@the-dreams.de> On 10/07/2013 17:57, Wolfram Sang : > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for setting the default pins. Compile tested only. > > Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13) > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> > --- > drivers/tty/serial/atmel_serial.c | 8 -------- For atmel_serial.c: Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Thanks. > drivers/tty/serial/imx.c | 9 --------- > drivers/tty/serial/mxs-auart.c | 8 -------- > drivers/tty/serial/omap-serial.c | 9 --------- > 4 files changed, 34 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 691265f..0e39fac 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -39,7 +39,6 @@ > #include <linux/atmel_pdc.h> > #include <linux/atmel_serial.h> > #include <linux/uaccess.h> > -#include <linux/pinctrl/consumer.h> > #include <linux/platform_data/atmel.h> > > #include <asm/io.h> > @@ -1775,7 +1774,6 @@ static int atmel_serial_probe(struct platform_device *pdev) > struct atmel_uart_data *pdata = pdev->dev.platform_data; > void *data; > int ret = -ENODEV; > - struct pinctrl *pinctrl; > > BUILD_BUG_ON(ATMEL_SERIAL_RINGSIZE & (ATMEL_SERIAL_RINGSIZE - 1)); > > @@ -1809,12 +1807,6 @@ static int atmel_serial_probe(struct platform_device *pdev) > if (ret) > goto err; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) { > - ret = PTR_ERR(pinctrl); > - goto err; > - } > - > if (!atmel_use_dma_rx(&port->uart)) { > ret = -ENOMEM; > data = kmalloc(sizeof(struct atmel_uart_char) > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > index 415cec6..2797e55 100644 > --- a/drivers/tty/serial/imx.c > +++ b/drivers/tty/serial/imx.c > @@ -47,7 +47,6 @@ > #include <linux/slab.h> > #include <linux/of.h> > #include <linux/of_device.h> > -#include <linux/pinctrl/consumer.h> > #include <linux/io.h> > > #include <asm/irq.h> > @@ -1507,7 +1506,6 @@ static int serial_imx_probe(struct platform_device *pdev) > void __iomem *base; > int ret = 0; > struct resource *res; > - struct pinctrl *pinctrl; > > sport = devm_kzalloc(&pdev->dev, sizeof(*sport), GFP_KERNEL); > if (!sport) > @@ -1543,13 +1541,6 @@ static int serial_imx_probe(struct platform_device *pdev) > sport->timer.function = imx_timeout; > sport->timer.data = (unsigned long)sport; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) { > - ret = PTR_ERR(pinctrl); > - dev_err(&pdev->dev, "failed to get default pinctrl: %d\n", ret); > - return ret; > - } > - > sport->clk_ipg = devm_clk_get(&pdev->dev, "ipg"); > if (IS_ERR(sport->clk_ipg)) { > ret = PTR_ERR(sport->clk_ipg); > diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c > index 4f5f161..a63a20e 100644 > --- a/drivers/tty/serial/mxs-auart.c > +++ b/drivers/tty/serial/mxs-auart.c > @@ -32,7 +32,6 @@ > #include <linux/clk.h> > #include <linux/delay.h> > #include <linux/io.h> > -#include <linux/pinctrl/consumer.h> > #include <linux/of_device.h> > #include <linux/dma-mapping.h> > #include <linux/dmaengine.h> > @@ -1015,7 +1014,6 @@ static int mxs_auart_probe(struct platform_device *pdev) > u32 version; > int ret = 0; > struct resource *r; > - struct pinctrl *pinctrl; > > s = kzalloc(sizeof(struct mxs_auart_port), GFP_KERNEL); > if (!s) { > @@ -1029,12 +1027,6 @@ static int mxs_auart_probe(struct platform_device *pdev) > else if (ret < 0) > goto out_free; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) { > - ret = PTR_ERR(pinctrl); > - goto out_free; > - } > - > if (of_id) { > pdev->id_entry = of_id->data; > s->devtype = pdev->id_entry->driver_data; > diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c > index b6d1728..eacb0de 100644 > --- a/drivers/tty/serial/omap-serial.c > +++ b/drivers/tty/serial/omap-serial.c > @@ -40,7 +40,6 @@ > #include <linux/pm_runtime.h> > #include <linux/of.h> > #include <linux/gpio.h> > -#include <linux/pinctrl/consumer.h> > #include <linux/platform_data/serial-omap.h> > > #define OMAP_MAX_HSUART_PORTS 6 > @@ -160,7 +159,6 @@ struct uart_omap_port { > u32 latency; > u32 calc_latency; > struct work_struct qos_work; > - struct pinctrl *pins; > bool is_suspending; > }; > > @@ -1468,13 +1466,6 @@ static int serial_omap_probe(struct platform_device *pdev) > goto err_port_line; > } > > - up->pins = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(up->pins)) { > - dev_warn(&pdev->dev, "did not get pins for uart%i error: %li\n", > - up->port.line, PTR_ERR(up->pins)); > - up->pins = NULL; > - } > - > sprintf(up->name, "OMAP UART%d", up->port.line); > up->port.mapbase = mem->start; > up->port.membase = devm_ioremap(&pdev->dev, mem->start, > -- Nicolas Ferre
next prev parent reply other threads:[~2013-07-11 7:40 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-10 15:57 [PATCH 01/12] drivers/gpu/drm/tilcdc: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang 2013-07-10 15:57 ` [PATCH 02/12] drivers/i2c/busses: " Wolfram Sang 2013-07-10 15:57 ` Wolfram Sang 2013-08-07 15:37 ` Wolfram Sang 2013-08-07 15:37 ` Wolfram Sang 2013-07-10 15:57 ` [PATCH 03/12] drivers/misc: " Wolfram Sang 2013-07-10 23:13 ` Arnd Bergmann 2013-07-20 17:45 ` Linus Walleij 2013-07-20 17:50 ` Greg KH 2013-07-10 15:57 ` [PATCH 04/12] drivers/mmc/host: " Wolfram Sang 2013-07-10 15:57 ` Wolfram Sang 2013-07-10 15:57 ` Wolfram Sang 2013-07-10 19:57 ` Marek Vasut 2013-07-10 19:57 ` Marek Vasut 2013-07-12 3:39 ` Barry Song 2013-07-12 3:39 ` Barry Song 2013-07-10 15:57 ` [PATCH 05/12] drivers/mtd/nand: " Wolfram Sang 2013-07-10 15:57 ` Wolfram Sang 2013-08-02 15:51 ` Artem Bityutskiy 2013-08-02 15:51 ` Artem Bityutskiy 2013-07-10 15:57 ` [PATCH 06/12] drivers/mtd/nand/gpmi-nand: " Wolfram Sang 2013-07-10 15:57 ` Wolfram Sang 2013-07-11 2:14 ` Huang Shijie 2013-07-11 2:14 ` Huang Shijie 2013-07-11 2:19 ` Huang Shijie 2013-07-11 2:19 ` Huang Shijie 2013-07-20 17:48 ` Linus Walleij 2013-07-20 17:48 ` Linus Walleij 2013-08-02 15:37 ` Artem Bityutskiy 2013-08-02 15:37 ` Artem Bityutskiy 2013-07-10 15:57 ` [PATCH 07/12] drivers/net/can/c_can: " Wolfram Sang 2013-07-10 21:02 ` Marc Kleine-Budde 2013-07-10 21:14 ` David Miller 2013-07-12 0:18 ` David Miller 2013-07-10 15:57 ` [PATCH 08/12] drivers/net/ethernet/cadence: " Wolfram Sang 2013-07-11 7:40 ` Nicolas Ferre 2013-07-12 0:19 ` David Miller 2013-07-10 15:57 ` [PATCH 09/12] drivers/net/ieee802154: " Wolfram Sang 2013-07-12 0:19 ` David Miller 2013-07-12 0:19 ` David Miller 2013-07-10 15:57 ` [PATCH 10/12] drivers/pwm: " Wolfram Sang 2013-07-10 15:57 ` [PATCH 11/12] drivers/tty/serial: " Wolfram Sang 2013-07-11 7:40 ` Nicolas Ferre [this message] 2013-07-11 7:40 ` Nicolas Ferre 2013-07-20 17:46 ` Linus Walleij 2013-07-20 17:50 ` Greg KH 2013-07-10 15:57 ` [PATCH 12/12] drivers/video: " Wolfram Sang 2013-07-10 15:57 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=51DE617E.3060908@atmel.com \ --to=nicolas.ferre@atmel.com \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.cz \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.