* [PATCH 0/3] ARM: dts: omap3-igep0020: improvements for v3.13
@ 2013-10-05 0:04 Javier Martinez Canillas
2013-10-05 0:04 ` [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support Javier Martinez Canillas
` (2 more replies)
0 siblings, 3 replies; 19+ messages in thread
From: Javier Martinez Canillas @ 2013-10-05 0:04 UTC (permalink / raw)
To: bcousson; +Cc: Tony Lindgren, Enric Balletbo i Serra, Roger Quadros, linux-omap
Hi Benoit,
This series are some enhancements and cleanups for IGEP boards
that it would be great if can make it for v3.13.
The patch-set is composed of the following patches:
[PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support
[PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support
[PATCH 3/3] ARM: dts: omap3-igep0020: use standard constant for IRQ flags
Patch 1 and 2 adds USB OTG and Host support respectively and patch 3
is a small cleanup to get rid of a magic number and use the proper
constant for IRQ edge/level type flags.
Thanks a lot and best regards,
Javier
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support 2013-10-05 0:04 [PATCH 0/3] ARM: dts: omap3-igep0020: improvements for v3.13 Javier Martinez Canillas @ 2013-10-05 0:04 ` Javier Martinez Canillas 2013-10-06 10:26 ` Enric Balletbo Serra 2013-10-07 10:43 ` Roger Quadros 2013-10-05 0:04 ` [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support Javier Martinez Canillas 2013-10-05 0:04 ` [PATCH 3/3] ARM: dts: omap3-igep0020: use standard constant for IRQ flags Javier Martinez Canillas 2 siblings, 2 replies; 19+ messages in thread From: Javier Martinez Canillas @ 2013-10-05 0:04 UTC (permalink / raw) To: bcousson Cc: Tony Lindgren, Enric Balletbo i Serra, Roger Quadros, linux-omap, Javier Martinez Canillas Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards") added USB OTG support for most OMAP boards but some OMAP3 boards such as the IGEPv2 were not updated. This patch adds an USB OTG device node to this board. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/omap3-igep0020.dts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts index eedf0d8..903e944 100644 --- a/arch/arm/boot/dts/omap3-igep0020.dts +++ b/arch/arm/boot/dts/omap3-igep0020.dts @@ -166,3 +166,10 @@ smsc,save-mac-address; }; }; + +&usb_otg_hs { + interface-type = <0>; + usb-phy = <&usb2_phy>; + mode = <3>; + power = <50>; +}; -- 1.8.4.rc3 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support 2013-10-05 0:04 ` [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support Javier Martinez Canillas @ 2013-10-06 10:26 ` Enric Balletbo Serra 2013-10-07 10:43 ` Roger Quadros 1 sibling, 0 replies; 19+ messages in thread From: Enric Balletbo Serra @ 2013-10-06 10:26 UTC (permalink / raw) To: Javier Martinez Canillas Cc: Benoit Cousson, Tony Lindgren, Roger Quadros, linux-omap Hi, 2013/10/5 Javier Martinez Canillas <javier.martinez@collabora.co.uk>: > Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards") > added USB OTG support for most OMAP boards but some OMAP3 boards > such as the IGEPv2 were not updated. This patch adds an USB OTG > device node to this board. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > --- > arch/arm/boot/dts/omap3-igep0020.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts > index eedf0d8..903e944 100644 > --- a/arch/arm/boot/dts/omap3-igep0020.dts > +++ b/arch/arm/boot/dts/omap3-igep0020.dts > @@ -166,3 +166,10 @@ > smsc,save-mac-address; > }; > }; > + > +&usb_otg_hs { > + interface-type = <0>; > + usb-phy = <&usb2_phy>; > + mode = <3>; > + power = <50>; > +}; > -- > 1.8.4.rc3 > Tested-by: Enric Balletbo i Serra <eballetbo@gmail.com> ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support 2013-10-05 0:04 ` [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support Javier Martinez Canillas 2013-10-06 10:26 ` Enric Balletbo Serra @ 2013-10-07 10:43 ` Roger Quadros 2013-10-07 11:54 ` Javier Martinez Canillas 1 sibling, 1 reply; 19+ messages in thread From: Roger Quadros @ 2013-10-07 10:43 UTC (permalink / raw) To: Javier Martinez Canillas Cc: bcousson, Tony Lindgren, Enric Balletbo i Serra, linux-omap Javier, On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote: > Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards") > added USB OTG support for most OMAP boards but some OMAP3 boards > such as the IGEPv2 were not updated. This patch adds an USB OTG > device node to this board. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > --- > arch/arm/boot/dts/omap3-igep0020.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts > index eedf0d8..903e944 100644 > --- a/arch/arm/boot/dts/omap3-igep0020.dts > +++ b/arch/arm/boot/dts/omap3-igep0020.dts > @@ -166,3 +166,10 @@ > smsc,save-mac-address; > }; > }; > + > +&usb_otg_hs { > + interface-type = <0>; > + usb-phy = <&usb2_phy>; With the PHY generic framework in Greg's usb-next branch [1], you will also need to add + phys = <&usb2_phy>; + phy-names = "usb2-phy"; > + mode = <3>; > + power = <50>; > +}; > So it would be good to test with the usb-next branch. cheers, -roger [1] - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support 2013-10-07 10:43 ` Roger Quadros @ 2013-10-07 11:54 ` Javier Martinez Canillas 2013-10-07 11:58 ` Benoit Cousson 0 siblings, 1 reply; 19+ messages in thread From: Javier Martinez Canillas @ 2013-10-07 11:54 UTC (permalink / raw) To: Roger Quadros; +Cc: bcousson, Tony Lindgren, Enric Balletbo i Serra, linux-omap On 10/07/2013 12:43 PM, Roger Quadros wrote: > Javier, > > On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote: >> Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards") >> added USB OTG support for most OMAP boards but some OMAP3 boards >> such as the IGEPv2 were not updated. This patch adds an USB OTG >> device node to this board. >> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >> --- >> arch/arm/boot/dts/omap3-igep0020.dts | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts >> index eedf0d8..903e944 100644 >> --- a/arch/arm/boot/dts/omap3-igep0020.dts >> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >> @@ -166,3 +166,10 @@ >> smsc,save-mac-address; >> }; >> }; >> + >> +&usb_otg_hs { >> + interface-type = <0>; >> + usb-phy = <&usb2_phy>; > > With the PHY generic framework in Greg's usb-next branch [1], you will also need to add > > + phys = <&usb2_phy>; > + phy-names = "usb2-phy"; > >> + mode = <3>; >> + power = <50>; >> +}; >> > > So it would be good to test with the usb-next branch. > > cheers, > -roger > > [1] - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > Hi Roger, Thanks for the pointer, I'll add those properties and test using the PHY generic framework. Thanks a lot and best regards, Javier ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support 2013-10-07 11:54 ` Javier Martinez Canillas @ 2013-10-07 11:58 ` Benoit Cousson 2013-10-07 12:02 ` Javier Martinez Canillas 0 siblings, 1 reply; 19+ messages in thread From: Benoit Cousson @ 2013-10-07 11:58 UTC (permalink / raw) To: Javier Martinez Canillas Cc: Roger Quadros, Tony Lindgren, Enric Balletbo i Serra, linux-omap Hi Javier, On 07/10/2013 13:54, Javier Martinez Canillas wrote: > On 10/07/2013 12:43 PM, Roger Quadros wrote: >> Javier, >> >> On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote: >>> Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards") >>> added USB OTG support for most OMAP boards but some OMAP3 boards >>> such as the IGEPv2 were not updated. This patch adds an USB OTG >>> device node to this board. >>> >>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >>> --- >>> arch/arm/boot/dts/omap3-igep0020.dts | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts >>> index eedf0d8..903e944 100644 >>> --- a/arch/arm/boot/dts/omap3-igep0020.dts >>> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >>> @@ -166,3 +166,10 @@ >>> smsc,save-mac-address; >>> }; >>> }; >>> + >>> +&usb_otg_hs { >>> + interface-type = <0>; >>> + usb-phy = <&usb2_phy>; >> >> With the PHY generic framework in Greg's usb-next branch [1], you will also need to add >> >> + phys = <&usb2_phy>; >> + phy-names = "usb2-phy"; >> >>> + mode = <3>; >>> + power = <50>; >>> +}; >>> >> >> So it would be good to test with the usb-next branch. >> >> cheers, >> -roger >> >> [1] - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git >> > > Hi Roger, > > Thanks for the pointer, I'll add those properties and test using the PHY generic > framework. Should I expect a v3 then? Benoit ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support 2013-10-07 11:58 ` Benoit Cousson @ 2013-10-07 12:02 ` Javier Martinez Canillas 2013-10-07 12:09 ` Benoit Cousson 0 siblings, 1 reply; 19+ messages in thread From: Javier Martinez Canillas @ 2013-10-07 12:02 UTC (permalink / raw) To: Benoit Cousson Cc: Roger Quadros, Tony Lindgren, Enric Balletbo i Serra, linux-omap On 10/07/2013 01:58 PM, Benoit Cousson wrote: > Hi Javier, > > On 07/10/2013 13:54, Javier Martinez Canillas wrote: >> On 10/07/2013 12:43 PM, Roger Quadros wrote: >>> Javier, >>> >>> On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote: >>>> Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards") >>>> added USB OTG support for most OMAP boards but some OMAP3 boards >>>> such as the IGEPv2 were not updated. This patch adds an USB OTG >>>> device node to this board. >>>> >>>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >>>> --- >>>> arch/arm/boot/dts/omap3-igep0020.dts | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts >>>> index eedf0d8..903e944 100644 >>>> --- a/arch/arm/boot/dts/omap3-igep0020.dts >>>> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >>>> @@ -166,3 +166,10 @@ >>>> smsc,save-mac-address; >>>> }; >>>> }; >>>> + >>>> +&usb_otg_hs { >>>> + interface-type = <0>; >>>> + usb-phy = <&usb2_phy>; >>> >>> With the PHY generic framework in Greg's usb-next branch [1], you will also need to add >>> >>> + phys = <&usb2_phy>; >>> + phy-names = "usb2-phy"; >>> >>>> + mode = <3>; >>>> + power = <50>; >>>> +}; >>>> >>> >>> So it would be good to test with the usb-next branch. >>> >>> cheers, >>> -roger >>> >>> [1] - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git >>> >> >> Hi Roger, >> >> Thanks for the pointer, I'll add those properties and test using the PHY generic >> framework. > > Should I expect a v3 then? > Hi Benoit, Yes, I'll test it and send a v3 in the next few hours, sorry for not being clear about that. > Benoit > > > Best regards, Javier ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support 2013-10-07 12:02 ` Javier Martinez Canillas @ 2013-10-07 12:09 ` Benoit Cousson 2013-10-07 16:05 ` Javier Martinez Canillas 0 siblings, 1 reply; 19+ messages in thread From: Benoit Cousson @ 2013-10-07 12:09 UTC (permalink / raw) To: Javier Martinez Canillas Cc: Roger Quadros, Tony Lindgren, Enric Balletbo i Serra, linux-omap On 07/10/2013 14:02, Javier Martinez Canillas wrote: > On 10/07/2013 01:58 PM, Benoit Cousson wrote: >> Hi Javier, >> >> On 07/10/2013 13:54, Javier Martinez Canillas wrote: >>> On 10/07/2013 12:43 PM, Roger Quadros wrote: >>>> Javier, >>>> >>>> On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote: >>>>> Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards") >>>>> added USB OTG support for most OMAP boards but some OMAP3 boards >>>>> such as the IGEPv2 were not updated. This patch adds an USB OTG >>>>> device node to this board. >>>>> >>>>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >>>>> --- >>>>> arch/arm/boot/dts/omap3-igep0020.dts | 7 +++++++ >>>>> 1 file changed, 7 insertions(+) >>>>> >>>>> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts >>>>> index eedf0d8..903e944 100644 >>>>> --- a/arch/arm/boot/dts/omap3-igep0020.dts >>>>> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >>>>> @@ -166,3 +166,10 @@ >>>>> smsc,save-mac-address; >>>>> }; >>>>> }; >>>>> + >>>>> +&usb_otg_hs { >>>>> + interface-type = <0>; >>>>> + usb-phy = <&usb2_phy>; >>>> >>>> With the PHY generic framework in Greg's usb-next branch [1], you will also need to add >>>> >>>> + phys = <&usb2_phy>; >>>> + phy-names = "usb2-phy"; >>>> >>>>> + mode = <3>; >>>>> + power = <50>; >>>>> +}; >>>>> >>>> >>>> So it would be good to test with the usb-next branch. >>>> >>>> cheers, >>>> -roger >>>> >>>> [1] - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git >>>> >>> >>> Hi Roger, >>> >>> Thanks for the pointer, I'll add those properties and test using the PHY generic >>> framework. >> >> Should I expect a v3 then? >> > > Hi Benoit, > > Yes, I'll test it and send a v3 in the next few hours, sorry for not being clear > about that. That's OK, I was applying your series when I saw your email ;-) I'm waiting for the next one. Thanks, Benoit ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support 2013-10-07 12:09 ` Benoit Cousson @ 2013-10-07 16:05 ` Javier Martinez Canillas 0 siblings, 0 replies; 19+ messages in thread From: Javier Martinez Canillas @ 2013-10-07 16:05 UTC (permalink / raw) To: Benoit Cousson Cc: Roger Quadros, Tony Lindgren, Enric Balletbo i Serra, linux-omap On Mon, Oct 7, 2013 at 2:09 PM, Benoit Cousson <bcousson@baylibre.com> wrote: > On 07/10/2013 14:02, Javier Martinez Canillas wrote: >> >> On 10/07/2013 01:58 PM, Benoit Cousson wrote: >>> >>> Hi Javier, >>> >>> On 07/10/2013 13:54, Javier Martinez Canillas wrote: >>>> >>>> On 10/07/2013 12:43 PM, Roger Quadros wrote: >>>>> >>>>> Javier, >>>>> >>>>> On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote: >>>>>> >>>>>> Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ >>>>>> boards") >>>>>> added USB OTG support for most OMAP boards but some OMAP3 boards >>>>>> such as the IGEPv2 were not updated. This patch adds an USB OTG >>>>>> device node to this board. >>>>>> >>>>>> Signed-off-by: Javier Martinez Canillas >>>>>> <javier.martinez@collabora.co.uk> >>>>>> --- >>>>>> arch/arm/boot/dts/omap3-igep0020.dts | 7 +++++++ >>>>>> 1 file changed, 7 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts >>>>>> b/arch/arm/boot/dts/omap3-igep0020.dts >>>>>> index eedf0d8..903e944 100644 >>>>>> --- a/arch/arm/boot/dts/omap3-igep0020.dts >>>>>> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >>>>>> @@ -166,3 +166,10 @@ >>>>>> smsc,save-mac-address; >>>>>> }; >>>>>> }; >>>>>> + >>>>>> +&usb_otg_hs { >>>>>> + interface-type = <0>; >>>>>> + usb-phy = <&usb2_phy>; >>>>> >>>>> >>>>> With the PHY generic framework in Greg's usb-next branch [1], you will >>>>> also need to add >>>>> >>>>> + phys = <&usb2_phy>; >>>>> + phy-names = "usb2-phy"; >>>>> >>>>>> + mode = <3>; >>>>>> + power = <50>; >>>>>> +}; >>>>>> >>>>> >>>>> So it would be good to test with the usb-next branch. >>>>> >>>>> cheers, >>>>> -roger >>>>> >>>>> [1] - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git >>>>> >>>> >>>> Hi Roger, >>>> >>>> Thanks for the pointer, I'll add those properties and test using the PHY >>>> generic >>>> framework. >>> >>> >>> Should I expect a v3 then? >>> >> >> Hi Benoit, >> >> Yes, I'll test it and send a v3 in the next few hours, sorry for not being >> clear >> about that. > > > > That's OK, I was applying your series when I saw your email ;-) > Yes, fortunately Roger pointed out that OMAP otg device node required additional properties to work with the new generic PHY framework that will land on v3.13. Otherwise it would only work until Greg send his pull request to Linus :) > I'm waiting for the next one. > Great, I had already sent the v3 [1] that has the necessary changes for the PHY framework and tested it using usb-next > Thanks, > Benoit > Thanks a lot and best regards, Javier [1]: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg96583.html ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support 2013-10-05 0:04 [PATCH 0/3] ARM: dts: omap3-igep0020: improvements for v3.13 Javier Martinez Canillas 2013-10-05 0:04 ` [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support Javier Martinez Canillas @ 2013-10-05 0:04 ` Javier Martinez Canillas 2013-10-06 10:27 ` Enric Balletbo Serra 2013-10-07 8:33 ` Roger Quadros 2013-10-05 0:04 ` [PATCH 3/3] ARM: dts: omap3-igep0020: use standard constant for IRQ flags Javier Martinez Canillas 2 siblings, 2 replies; 19+ messages in thread From: Javier Martinez Canillas @ 2013-10-05 0:04 UTC (permalink / raw) To: bcousson Cc: Tony Lindgren, Enric Balletbo i Serra, Roger Quadros, linux-omap, Javier Martinez Canillas Add device nodes for the HS USB Host port 1, USB PHY and its required regulator and also pin mux setup for HS USB1 pins. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/omap3-igep.dtsi | 22 ++++++++++++++++++++++ arch/arm/boot/dts/omap3-igep0020.dts | 25 +++++++++++++++++++++++++ 2 files changed, 47 insertions(+) diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi index 0f92224..ec2ecd2 100644 --- a/arch/arm/boot/dts/omap3-igep.dtsi +++ b/arch/arm/boot/dts/omap3-igep.dtsi @@ -27,6 +27,11 @@ }; &omap3_pmx_core { + pinctrl-names = "default"; + pinctrl-0 = < + &hsusbb1_pins + >; + uart1_pins: pinmux_uart1_pins { pinctrl-single,pins = < 0x152 (PIN_INPUT | MUX_MODE0) /* uart1_rx.uart1_rx */ @@ -78,6 +83,23 @@ >; }; + hsusbb1_pins: pinmux_hsusbb1_pins { + pinctrl-single,pins = < + 0x5aa (PIN_OUTPUT | MUX_MODE3) /* etk_ctl.hsusb1_clk */ + 0x5a8 (PIN_OUTPUT | MUX_MODE3) /* etk_clk.hsusb1_stp */ + 0x5bc (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d8.hsusb1_dir */ + 0x5be (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d9.hsusb1_nxt */ + 0x5ac (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d0.hsusb1_data0 */ + 0x5ae (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d1.hsusb1_data1 */ + 0x5b0 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d2.hsusb1_data2 */ + 0x5b2 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d3.hsusb1_data7 */ + 0x5b4 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d4.hsusb1_data4 */ + 0x5b6 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d5.hsusb1_data5 */ + 0x5b8 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d6.hsusb1_data6 */ + 0x5ba (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d7.hsusb1_data3 */ + >; + }; + leds_pins: pinmux_leds_pins { }; }; diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts index 903e944..180b186 100644 --- a/arch/arm/boot/dts/omap3-igep0020.dts +++ b/arch/arm/boot/dts/omap3-igep0020.dts @@ -55,6 +55,23 @@ regulator-name = "vdd33a"; regulator-always-on; }; + + /* HS USB Port 1 Power */ + hsusb1_power: hsusb1_power_reg { + compatible = "regulator-fixed"; + regulator-name = "hsusb1_vbus"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */ + startup-delay-us = <70000>; + }; + + /* HS USB Host PHY on PORT 1 */ + hsusb1_phy: hsusb1_phy { + compatible = "usb-nop-xceiv"; + reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>; /* gpio_24 */ + vcc-supply = <&hsusb1_power>; + }; }; &leds_pins { @@ -173,3 +190,11 @@ mode = <3>; power = <50>; }; + +&usbhshost { + port1-mode = "ehci-phy"; +}; + +&usbhsehci { + phys = <&hsusb1_phy>; +}; -- 1.8.4.rc3 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support 2013-10-05 0:04 ` [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support Javier Martinez Canillas @ 2013-10-06 10:27 ` Enric Balletbo Serra 2013-10-07 8:33 ` Roger Quadros 1 sibling, 0 replies; 19+ messages in thread From: Enric Balletbo Serra @ 2013-10-06 10:27 UTC (permalink / raw) To: Javier Martinez Canillas Cc: Benoit Cousson, Tony Lindgren, Roger Quadros, linux-omap Hi, 2013/10/5 Javier Martinez Canillas <javier.martinez@collabora.co.uk>: > Add device nodes for the HS USB Host port 1, USB PHY and its > required regulator and also pin mux setup for HS USB1 pins. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > --- > arch/arm/boot/dts/omap3-igep.dtsi | 22 ++++++++++++++++++++++ > arch/arm/boot/dts/omap3-igep0020.dts | 25 +++++++++++++++++++++++++ > 2 files changed, 47 insertions(+) > > diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi > index 0f92224..ec2ecd2 100644 > --- a/arch/arm/boot/dts/omap3-igep.dtsi > +++ b/arch/arm/boot/dts/omap3-igep.dtsi > @@ -27,6 +27,11 @@ > }; > > &omap3_pmx_core { > + pinctrl-names = "default"; > + pinctrl-0 = < > + &hsusbb1_pins > + >; > + > uart1_pins: pinmux_uart1_pins { > pinctrl-single,pins = < > 0x152 (PIN_INPUT | MUX_MODE0) /* uart1_rx.uart1_rx */ > @@ -78,6 +83,23 @@ > >; > }; > > + hsusbb1_pins: pinmux_hsusbb1_pins { > + pinctrl-single,pins = < > + 0x5aa (PIN_OUTPUT | MUX_MODE3) /* etk_ctl.hsusb1_clk */ > + 0x5a8 (PIN_OUTPUT | MUX_MODE3) /* etk_clk.hsusb1_stp */ > + 0x5bc (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d8.hsusb1_dir */ > + 0x5be (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d9.hsusb1_nxt */ > + 0x5ac (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d0.hsusb1_data0 */ > + 0x5ae (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d1.hsusb1_data1 */ > + 0x5b0 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d2.hsusb1_data2 */ > + 0x5b2 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d3.hsusb1_data7 */ > + 0x5b4 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d4.hsusb1_data4 */ > + 0x5b6 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d5.hsusb1_data5 */ > + 0x5b8 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d6.hsusb1_data6 */ > + 0x5ba (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d7.hsusb1_data3 */ > + >; > + }; > + > leds_pins: pinmux_leds_pins { }; > }; > > diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts > index 903e944..180b186 100644 > --- a/arch/arm/boot/dts/omap3-igep0020.dts > +++ b/arch/arm/boot/dts/omap3-igep0020.dts > @@ -55,6 +55,23 @@ > regulator-name = "vdd33a"; > regulator-always-on; > }; > + > + /* HS USB Port 1 Power */ > + hsusb1_power: hsusb1_power_reg { > + compatible = "regulator-fixed"; > + regulator-name = "hsusb1_vbus"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */ > + startup-delay-us = <70000>; > + }; > + > + /* HS USB Host PHY on PORT 1 */ > + hsusb1_phy: hsusb1_phy { > + compatible = "usb-nop-xceiv"; > + reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>; /* gpio_24 */ > + vcc-supply = <&hsusb1_power>; > + }; > }; > > &leds_pins { > @@ -173,3 +190,11 @@ > mode = <3>; > power = <50>; > }; > + > +&usbhshost { > + port1-mode = "ehci-phy"; > +}; > + > +&usbhsehci { > + phys = <&hsusb1_phy>; > +}; > -- > 1.8.4.rc3 > Tested-by: Enric Balletbo i Serra <eballetbo@gmail.com> ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support 2013-10-05 0:04 ` [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support Javier Martinez Canillas 2013-10-06 10:27 ` Enric Balletbo Serra @ 2013-10-07 8:33 ` Roger Quadros 2013-10-07 8:50 ` Javier Martinez Canillas 1 sibling, 1 reply; 19+ messages in thread From: Roger Quadros @ 2013-10-07 8:33 UTC (permalink / raw) To: Javier Martinez Canillas Cc: bcousson, Tony Lindgren, Enric Balletbo i Serra, linux-omap Hi Javier, On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote: > Add device nodes for the HS USB Host port 1, USB PHY and its > required regulator and also pin mux setup for HS USB1 pins. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > --- > arch/arm/boot/dts/omap3-igep.dtsi | 22 ++++++++++++++++++++++ > arch/arm/boot/dts/omap3-igep0020.dts | 25 +++++++++++++++++++++++++ > 2 files changed, 47 insertions(+) > > diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi > index 0f92224..ec2ecd2 100644 > --- a/arch/arm/boot/dts/omap3-igep.dtsi > +++ b/arch/arm/boot/dts/omap3-igep.dtsi > @@ -27,6 +27,11 @@ > }; > > &omap3_pmx_core { > + pinctrl-names = "default"; > + pinctrl-0 = < > + &hsusbb1_pins > + >; > + > uart1_pins: pinmux_uart1_pins { > pinctrl-single,pins = < > 0x152 (PIN_INPUT | MUX_MODE0) /* uart1_rx.uart1_rx */ > @@ -78,6 +83,23 @@ > >; > }; > > + hsusbb1_pins: pinmux_hsusbb1_pins { > + pinctrl-single,pins = < > + 0x5aa (PIN_OUTPUT | MUX_MODE3) /* etk_ctl.hsusb1_clk */ > + 0x5a8 (PIN_OUTPUT | MUX_MODE3) /* etk_clk.hsusb1_stp */ > + 0x5bc (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d8.hsusb1_dir */ > + 0x5be (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d9.hsusb1_nxt */ > + 0x5ac (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d0.hsusb1_data0 */ > + 0x5ae (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d1.hsusb1_data1 */ > + 0x5b0 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d2.hsusb1_data2 */ > + 0x5b2 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d3.hsusb1_data7 */ > + 0x5b4 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d4.hsusb1_data4 */ > + 0x5b6 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d5.hsusb1_data5 */ > + 0x5b8 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d6.hsusb1_data6 */ > + 0x5ba (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d7.hsusb1_data3 */ > + >; > + }; > + Is this pin config required for igep0030 as well? If not then you should move these pinmux definitions to omap3-igep0020.dts. All else looks good to me. > leds_pins: pinmux_leds_pins { }; > }; > > diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts > index 903e944..180b186 100644 > --- a/arch/arm/boot/dts/omap3-igep0020.dts > +++ b/arch/arm/boot/dts/omap3-igep0020.dts > @@ -55,6 +55,23 @@ > regulator-name = "vdd33a"; > regulator-always-on; > }; > + > + /* HS USB Port 1 Power */ > + hsusb1_power: hsusb1_power_reg { > + compatible = "regulator-fixed"; > + regulator-name = "hsusb1_vbus"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */ > + startup-delay-us = <70000>; > + }; > + > + /* HS USB Host PHY on PORT 1 */ > + hsusb1_phy: hsusb1_phy { > + compatible = "usb-nop-xceiv"; > + reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>; /* gpio_24 */ > + vcc-supply = <&hsusb1_power>; > + }; > }; > > &leds_pins { > @@ -173,3 +190,11 @@ > mode = <3>; > power = <50>; > }; > + > +&usbhshost { > + port1-mode = "ehci-phy"; > +}; > + > +&usbhsehci { > + phys = <&hsusb1_phy>; > +}; > cheers, -roger ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support 2013-10-07 8:33 ` Roger Quadros @ 2013-10-07 8:50 ` Javier Martinez Canillas [not found] ` <525275C8.2050208-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> 0 siblings, 1 reply; 19+ messages in thread From: Javier Martinez Canillas @ 2013-10-07 8:50 UTC (permalink / raw) To: Roger Quadros; +Cc: bcousson, Tony Lindgren, Enric Balletbo i Serra, linux-omap On Mon, Oct 7, 2013 at 10:33 AM, Roger Quadros <rogerq@ti.com> wrote: > Hi Javier, > > On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote: >> Add device nodes for the HS USB Host port 1, USB PHY and its >> required regulator and also pin mux setup for HS USB1 pins. >> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >> --- >> arch/arm/boot/dts/omap3-igep.dtsi | 22 ++++++++++++++++++++++ >> arch/arm/boot/dts/omap3-igep0020.dts | 25 +++++++++++++++++++++++++ >> 2 files changed, 47 insertions(+) >> >> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi >> index 0f92224..ec2ecd2 100644 >> --- a/arch/arm/boot/dts/omap3-igep.dtsi >> +++ b/arch/arm/boot/dts/omap3-igep.dtsi >> @@ -27,6 +27,11 @@ >> }; >> >> &omap3_pmx_core { >> + pinctrl-names = "default"; >> + pinctrl-0 = < >> + &hsusbb1_pins >> + >; >> + >> uart1_pins: pinmux_uart1_pins { >> pinctrl-single,pins = < >> 0x152 (PIN_INPUT | MUX_MODE0) /* uart1_rx.uart1_rx */ >> @@ -78,6 +83,23 @@ >> >; >> }; >> >> + hsusbb1_pins: pinmux_hsusbb1_pins { >> + pinctrl-single,pins = < >> + 0x5aa (PIN_OUTPUT | MUX_MODE3) /* etk_ctl.hsusb1_clk */ >> + 0x5a8 (PIN_OUTPUT | MUX_MODE3) /* etk_clk.hsusb1_stp */ >> + 0x5bc (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d8.hsusb1_dir */ >> + 0x5be (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d9.hsusb1_nxt */ >> + 0x5ac (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d0.hsusb1_data0 */ >> + 0x5ae (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d1.hsusb1_data1 */ >> + 0x5b0 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d2.hsusb1_data2 */ >> + 0x5b2 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d3.hsusb1_data7 */ >> + 0x5b4 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d4.hsusb1_data4 */ >> + 0x5b6 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d5.hsusb1_data5 */ >> + 0x5b8 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d6.hsusb1_data6 */ >> + 0x5ba (PIN_INPUT_PULLDOWN | MUX_MODE3) /* etk_d7.hsusb1_data3 */ >> + >; >> + }; >> + > > Is this pin config required for igep0030 as well? If not then you should move these pinmux > definitions to omap3-igep0020.dts. > > All else looks good to me. > Hi Roger, Well that's a very good question indeed. The thing is that the IGEP0030 is a Computer-on-Module [1] that is used in conjunction with expansion boards and some of them have USB HOST support such as IGEP Paris [2] and IGEP Berlin [3]. Support for this expansion boards is still not in mainline but there are plans to add them using Device Tree overlays [4] once/if this land on mainline. So, answering your question right now this is not required but I thought it would be good to have it configured by default in case someone using an IGEP0030 and a expansion board wants to extend omap3-igep0030.dts to add support for its expansion board. I've no strong opinion on this though and I can send a new patch with those pins moved to omap3-igep0020.dts though if you think that would be better. >> leds_pins: pinmux_leds_pins { }; >> }; >> >> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts >> index 903e944..180b186 100644 >> --- a/arch/arm/boot/dts/omap3-igep0020.dts >> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >> @@ -55,6 +55,23 @@ >> regulator-name = "vdd33a"; >> regulator-always-on; >> }; >> + >> + /* HS USB Port 1 Power */ >> + hsusb1_power: hsusb1_power_reg { >> + compatible = "regulator-fixed"; >> + regulator-name = "hsusb1_vbus"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */ >> + startup-delay-us = <70000>; >> + }; >> + >> + /* HS USB Host PHY on PORT 1 */ >> + hsusb1_phy: hsusb1_phy { >> + compatible = "usb-nop-xceiv"; >> + reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>; /* gpio_24 */ >> + vcc-supply = <&hsusb1_power>; >> + }; >> }; >> >> &leds_pins { >> @@ -173,3 +190,11 @@ >> mode = <3>; >> power = <50>; >> }; >> + >> +&usbhshost { >> + port1-mode = "ehci-phy"; >> +}; >> + >> +&usbhsehci { >> + phys = <&hsusb1_phy>; >> +}; >> > > cheers, > -roger > -- Thanks a lot and best regards, Javier [1]: http://www.isee.biz/products/processor-boards/igep-com-module [2]: http://www.isee.biz/products/expansion-boards/product-igep-paris [3]: http://www.isee.biz/products/expansion-boards/product-igep-berlin [4]: http://learn.adafruit.com/introduction-to-the-beaglebone-black-device-tree/device-tree-overlays ^ permalink raw reply [flat|nested] 19+ messages in thread
[parent not found: <525275C8.2050208-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>]
* Re: [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support [not found] ` <525275C8.2050208-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> @ 2013-10-07 9:06 ` Roger Quadros 2013-10-07 9:13 ` Javier Martinez Canillas 0 siblings, 1 reply; 19+ messages in thread From: Roger Quadros @ 2013-10-07 9:06 UTC (permalink / raw) To: Javier Martinez Canillas Cc: bcousson-rdvid1DuHRBWk0Htik3J/w, Tony Lindgren, Enric Balletbo i Serra, linux-omap-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA +devicetree Javier, On 10/07/2013 11:50 AM, Javier Martinez Canillas wrote: > On Mon, Oct 7, 2013 at 10:33 AM, Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org> wrote: >> Hi Javier, >> >> On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote: >>> Add device nodes for the HS USB Host port 1, USB PHY and its >>> required regulator and also pin mux setup for HS USB1 pins. >>> >>> Signed-off-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> >>> --- >>> arch/arm/boot/dts/omap3-igep.dtsi | 22 ++++++++++++++++++++++ >>> arch/arm/boot/dts/omap3-igep0020.dts | 25 +++++++++++++++++++++++++ >>> 2 files changed, 47 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi > b/arch/arm/boot/dts/omap3-igep.dtsi >>> index 0f92224..ec2ecd2 100644 >>> --- a/arch/arm/boot/dts/omap3-igep.dtsi >>> +++ b/arch/arm/boot/dts/omap3-igep.dtsi >>> @@ -27,6 +27,11 @@ >>> }; >>> >>> &omap3_pmx_core { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = < >>> + &hsusbb1_pins >>> + >; >>> + >>> uart1_pins: pinmux_uart1_pins { >>> pinctrl-single,pins = < >>> 0x152 (PIN_INPUT | MUX_MODE0) /* > uart1_rx.uart1_rx */ >>> @@ -78,6 +83,23 @@ >>> >; >>> }; >>> >>> + hsusbb1_pins: pinmux_hsusbb1_pins { >>> + pinctrl-single,pins = < >>> + 0x5aa (PIN_OUTPUT | MUX_MODE3) /* > etk_ctl.hsusb1_clk */ >>> + 0x5a8 (PIN_OUTPUT | MUX_MODE3) /* > etk_clk.hsusb1_stp */ >>> + 0x5bc (PIN_INPUT_PULLDOWN | MUX_MODE3) /* > etk_d8.hsusb1_dir */ >>> + 0x5be (PIN_INPUT_PULLDOWN | MUX_MODE3) /* > etk_d9.hsusb1_nxt */ >>> + 0x5ac (PIN_INPUT_PULLDOWN | MUX_MODE3) /* > etk_d0.hsusb1_data0 */ >>> + 0x5ae (PIN_INPUT_PULLDOWN | MUX_MODE3) /* > etk_d1.hsusb1_data1 */ >>> + 0x5b0 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* > etk_d2.hsusb1_data2 */ >>> + 0x5b2 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* > etk_d3.hsusb1_data7 */ >>> + 0x5b4 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* > etk_d4.hsusb1_data4 */ >>> + 0x5b6 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* > etk_d5.hsusb1_data5 */ >>> + 0x5b8 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* > etk_d6.hsusb1_data6 */ >>> + 0x5ba (PIN_INPUT_PULLDOWN | MUX_MODE3) /* > etk_d7.hsusb1_data3 */ >>> + >; >>> + }; >>> + >> >> Is this pin config required for igep0030 as well? If not then you should move > these pinmux >> definitions to omap3-igep0020.dts. >> >> All else looks good to me. >> > > Hi Roger, > > Well that's a very good question indeed. > > The thing is that the IGEP0030 is a Computer-on-Module [1] that is used in > conjunction with expansion boards and some of them have USB HOST support such as > IGEP Paris [2] and IGEP Berlin [3]. > > Support for this expansion boards is still not in mainline but there are plans > to add them using Device Tree overlays [4] once/if this land on mainline. > Why would your boards need Device Tree overlays? From the looks of it, the configuration of SOM + base board don't seem to change at runtime. > So, answering your question right now this is not required but I thought it > would be good to have it configured by default in case someone using an IGEP0030 > and a expansion board wants to extend omap3-igep0030.dts to add support for its > expansion board. I think all you need is a .dts file for each expansion board that extends omap3-iegp0030.dts. That way, the pinmux for USB host pins will come only in those boards that have the USB host port. > > I've no strong opinion on this though and I can send a new patch with those pins > moved to omap3-igep0020.dts though if you think that would be better. If you don't put it in omap3-igep0020.dts, how will you handle the case when a omap3-igep0030 SOM is used with an expansion board that doesn't have USB host port and uses it for something else? > >>> leds_pins: pinmux_leds_pins { }; >>> }; >>> >>> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts > b/arch/arm/boot/dts/omap3-igep0020.dts >>> index 903e944..180b186 100644 >>> --- a/arch/arm/boot/dts/omap3-igep0020.dts >>> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >>> @@ -55,6 +55,23 @@ >>> regulator-name = "vdd33a"; >>> regulator-always-on; >>> }; >>> + >>> + /* HS USB Port 1 Power */ >>> + hsusb1_power: hsusb1_power_reg { >>> + compatible = "regulator-fixed"; >>> + regulator-name = "hsusb1_vbus"; >>> + regulator-min-microvolt = <3300000>; >>> + regulator-max-microvolt = <3300000>; >>> + gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */ >>> + startup-delay-us = <70000>; >>> + }; >>> + >>> + /* HS USB Host PHY on PORT 1 */ >>> + hsusb1_phy: hsusb1_phy { >>> + compatible = "usb-nop-xceiv"; >>> + reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>; /* gpio_24 */ >>> + vcc-supply = <&hsusb1_power>; >>> + }; >>> }; >>> >>> &leds_pins { >>> @@ -173,3 +190,11 @@ >>> mode = <3>; >>> power = <50>; >>> }; >>> + >>> +&usbhshost { >>> + port1-mode = "ehci-phy"; >>> +}; >>> + >>> +&usbhsehci { >>> + phys = <&hsusb1_phy>; >>> +}; >>> >> cheers, -roger >> -- > > Thanks a lot and best regards, > Javier > > [1]: http://www.isee.biz/products/processor-boards/igep-com-module > [2]: http://www.isee.biz/products/expansion-boards/product-igep-paris > [3]: http://www.isee.biz/products/expansion-boards/product-igep-berlin > [4]: > http://learn.adafruit.com/introduction-to-the-beaglebone-black-device-tree/device-tree-overlays > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support 2013-10-07 9:06 ` Roger Quadros @ 2013-10-07 9:13 ` Javier Martinez Canillas 2013-10-07 10:22 ` Javier Martinez Canillas 0 siblings, 1 reply; 19+ messages in thread From: Javier Martinez Canillas @ 2013-10-07 9:13 UTC (permalink / raw) To: Roger Quadros Cc: bcousson, Tony Lindgren, Enric Balletbo i Serra, linux-omap, devicetree On 10/07/2013 11:06 AM, Roger Quadros wrote: > +devicetree > > Javier, > > On 10/07/2013 11:50 AM, Javier Martinez Canillas wrote: >> On Mon, Oct 7, 2013 at 10:33 AM, Roger Quadros <rogerq@ti.com> wrote: >>> Hi Javier, >>> >>> On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote: >>>> Add device nodes for the HS USB Host port 1, USB PHY and its >>>> required regulator and also pin mux setup for HS USB1 pins. >>>> >>>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> >>>> --- >>>> arch/arm/boot/dts/omap3-igep.dtsi | 22 ++++++++++++++++++++++ >>>> arch/arm/boot/dts/omap3-igep0020.dts | 25 +++++++++++++++++++++++++ >>>> 2 files changed, 47 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi >> b/arch/arm/boot/dts/omap3-igep.dtsi >>>> index 0f92224..ec2ecd2 100644 >>>> --- a/arch/arm/boot/dts/omap3-igep.dtsi >>>> +++ b/arch/arm/boot/dts/omap3-igep.dtsi >>>> @@ -27,6 +27,11 @@ >>>> }; >>>> >>>> &omap3_pmx_core { >>>> + pinctrl-names = "default"; >>>> + pinctrl-0 = < >>>> + &hsusbb1_pins >>>> + >; >>>> + >>>> uart1_pins: pinmux_uart1_pins { >>>> pinctrl-single,pins = < >>>> 0x152 (PIN_INPUT | MUX_MODE0) /* >> uart1_rx.uart1_rx */ >>>> @@ -78,6 +83,23 @@ >>>> >; >>>> }; >>>> >>>> + hsusbb1_pins: pinmux_hsusbb1_pins { >>>> + pinctrl-single,pins = < >>>> + 0x5aa (PIN_OUTPUT | MUX_MODE3) /* >> etk_ctl.hsusb1_clk */ >>>> + 0x5a8 (PIN_OUTPUT | MUX_MODE3) /* >> etk_clk.hsusb1_stp */ >>>> + 0x5bc (PIN_INPUT_PULLDOWN | MUX_MODE3) /* >> etk_d8.hsusb1_dir */ >>>> + 0x5be (PIN_INPUT_PULLDOWN | MUX_MODE3) /* >> etk_d9.hsusb1_nxt */ >>>> + 0x5ac (PIN_INPUT_PULLDOWN | MUX_MODE3) /* >> etk_d0.hsusb1_data0 */ >>>> + 0x5ae (PIN_INPUT_PULLDOWN | MUX_MODE3) /* >> etk_d1.hsusb1_data1 */ >>>> + 0x5b0 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* >> etk_d2.hsusb1_data2 */ >>>> + 0x5b2 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* >> etk_d3.hsusb1_data7 */ >>>> + 0x5b4 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* >> etk_d4.hsusb1_data4 */ >>>> + 0x5b6 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* >> etk_d5.hsusb1_data5 */ >>>> + 0x5b8 (PIN_INPUT_PULLDOWN | MUX_MODE3) /* >> etk_d6.hsusb1_data6 */ >>>> + 0x5ba (PIN_INPUT_PULLDOWN | MUX_MODE3) /* >> etk_d7.hsusb1_data3 */ >>>> + >; >>>> + }; >>>> + >>> >>> Is this pin config required for igep0030 as well? If not then you should move >> these pinmux >>> definitions to omap3-igep0020.dts. >>> >>> All else looks good to me. >>> >> >> Hi Roger, >> >> Well that's a very good question indeed. >> >> The thing is that the IGEP0030 is a Computer-on-Module [1] that is used in >> conjunction with expansion boards and some of them have USB HOST support such as >> IGEP Paris [2] and IGEP Berlin [3]. >> >> Support for this expansion boards is still not in mainline but there are plans >> to add them using Device Tree overlays [4] once/if this land on mainline. >> > > Why would your boards need Device Tree overlays? From the looks of it, the configuration > of SOM + base board don't seem to change at runtime. > Indeed, a static configuration (DTS) would be enough now that I think about it. >> So, answering your question right now this is not required but I thought it >> would be good to have it configured by default in case someone using an IGEP0030 >> and a expansion board wants to extend omap3-igep0030.dts to add support for its >> expansion board. > > I think all you need is a .dts file for each expansion board that extends > omap3-iegp0030.dts. > > That way, the pinmux for USB host pins will come only in those boards that have the USB host port. > >> >> I've no strong opinion on this though and I can send a new patch with those pins >> moved to omap3-igep0020.dts though if you think that would be better. > > If you don't put it in omap3-igep0020.dts, how will you handle the case when a omap3-igep0030 > SOM is used with an expansion board that doesn't have USB host port and uses it for something > else? > You are right, will change and post a v2 of the patch-set, thanks a lot for your feedback! >> >>>> leds_pins: pinmux_leds_pins { }; >>>> }; >>>> >>>> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts >> b/arch/arm/boot/dts/omap3-igep0020.dts >>>> index 903e944..180b186 100644 >>>> --- a/arch/arm/boot/dts/omap3-igep0020.dts >>>> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >>>> @@ -55,6 +55,23 @@ >>>> regulator-name = "vdd33a"; >>>> regulator-always-on; >>>> }; >>>> + >>>> + /* HS USB Port 1 Power */ >>>> + hsusb1_power: hsusb1_power_reg { >>>> + compatible = "regulator-fixed"; >>>> + regulator-name = "hsusb1_vbus"; >>>> + regulator-min-microvolt = <3300000>; >>>> + regulator-max-microvolt = <3300000>; >>>> + gpio = <&twl_gpio 18 GPIO_ACTIVE_LOW>; /* GPIO LEDA */ >>>> + startup-delay-us = <70000>; >>>> + }; >>>> + >>>> + /* HS USB Host PHY on PORT 1 */ >>>> + hsusb1_phy: hsusb1_phy { >>>> + compatible = "usb-nop-xceiv"; >>>> + reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>; /* gpio_24 */ >>>> + vcc-supply = <&hsusb1_power>; >>>> + }; >>>> }; >>>> >>>> &leds_pins { >>>> @@ -173,3 +190,11 @@ >>>> mode = <3>; >>>> power = <50>; >>>> }; >>>> + >>>> +&usbhshost { >>>> + port1-mode = "ehci-phy"; >>>> +}; >>>> + >>>> +&usbhsehci { >>>> + phys = <&hsusb1_phy>; >>>> +}; >>>> >>> > > cheers, > -roger > >>> -- >> >> Thanks a lot and best regards, >> Javier >> >> [1]: http://www.isee.biz/products/processor-boards/igep-com-module >> [2]: http://www.isee.biz/products/expansion-boards/product-igep-paris >> [3]: http://www.isee.biz/products/expansion-boards/product-igep-berlin >> [4]: >> http://learn.adafruit.com/introduction-to-the-beaglebone-black-device-tree/device-tree-overlays >> > Best regards, Javier ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support 2013-10-07 9:13 ` Javier Martinez Canillas @ 2013-10-07 10:22 ` Javier Martinez Canillas 2013-10-07 10:42 ` Roger Quadros 0 siblings, 1 reply; 19+ messages in thread From: Javier Martinez Canillas @ 2013-10-07 10:22 UTC (permalink / raw) To: Javier Martinez Canillas Cc: Roger Quadros, Benoit Cousson, Tony Lindgren, Enric Balletbo i Serra, linux-omap, devicetree On Mon, Oct 7, 2013 at 11:13 AM, Javier Martinez Canillas <javier.martinez@collabora.co.uk> wrote: > On 10/07/2013 11:06 AM, Roger Quadros wrote: >>> >>> Well that's a very good question indeed. >>> >>> The thing is that the IGEP0030 is a Computer-on-Module [1] that is used in >>> conjunction with expansion boards and some of them have USB HOST support such as >>> IGEP Paris [2] and IGEP Berlin [3]. >>> >>> Support for this expansion boards is still not in mainline but there are plans >>> to add them using Device Tree overlays [4] once/if this land on mainline. >>> >> >> Why would your boards need Device Tree overlays? From the looks of it, the configuration >> of SOM + base board don't seem to change at runtime. >> > > Indeed, a static configuration (DTS) would be enough now that I think about it. > Hi Roger, Now that I had coffee I remember why I think that even when Device Tree overlays are not strictly required for a SOM + base board it could be handy to use. If we use a static configuration (DTB) then the same firmware can't be used by any IGEP COM Module user. She would have to choose a DTB to pass to the kernel on boot. While using DT overlays the same firmware that provides a minimal DTB can be used regardless of the base board used (as long as there are all the needed fragment/overlays hooks in the DTS). After all the SOM has a NAND flash memory and a uSD/MMC slot so a minimal DTB is needed to boot and the support for all the peripherals present on the base board can be added by triggering a device tree overlay load from user-space. Or maybe I'm misunderstanding the use case for DT overlays since I had just read about it but I don't have practical experience with it. Thanks a lot and best regards, Javier ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support 2013-10-07 10:22 ` Javier Martinez Canillas @ 2013-10-07 10:42 ` Roger Quadros 2013-10-07 11:53 ` Javier Martinez Canillas 0 siblings, 1 reply; 19+ messages in thread From: Roger Quadros @ 2013-10-07 10:42 UTC (permalink / raw) To: Javier Martinez Canillas Cc: Javier Martinez Canillas, Benoit Cousson, Tony Lindgren, Enric Balletbo i Serra, linux-omap, devicetree On 10/07/2013 01:22 PM, Javier Martinez Canillas wrote: > On Mon, Oct 7, 2013 at 11:13 AM, Javier Martinez Canillas > <javier.martinez@collabora.co.uk> wrote: >> On 10/07/2013 11:06 AM, Roger Quadros wrote: >>>> >>>> Well that's a very good question indeed. >>>> >>>> The thing is that the IGEP0030 is a Computer-on-Module [1] that is used in >>>> conjunction with expansion boards and some of them have USB HOST support such as >>>> IGEP Paris [2] and IGEP Berlin [3]. >>>> >>>> Support for this expansion boards is still not in mainline but there are plans >>>> to add them using Device Tree overlays [4] once/if this land on mainline. >>>> >>> >>> Why would your boards need Device Tree overlays? From the looks of it, the configuration >>> of SOM + base board don't seem to change at runtime. >>> >> >> Indeed, a static configuration (DTS) would be enough now that I think about it. >> > > Hi Roger, > > Now that I had coffee I remember why I think that even when Device > Tree overlays are not strictly required for a SOM + base board it > could be handy to use. If we use a static configuration (DTB) then the > same firmware can't be used by any IGEP COM Module user. She would > have to choose a DTB to pass to the kernel on boot. > > While using DT overlays the same firmware that provides a minimal DTB > can be used regardless of the base board used (as long as there are > all the needed fragment/overlays hooks in the DTS). > > After all the SOM has a NAND flash memory and a uSD/MMC slot so a > minimal DTB is needed to boot and the support for all the peripherals > present on the base board can be added by triggering a device tree > overlay load from user-space. Consider this example. You need to boot your board using NFS over ethernet dongle connected to USB host. If you need user space to get that to work, it will be a unnecessary challenge, whereas you can easily do that if you have a static DT blob. > > Or maybe I'm misunderstanding the use case for DT overlays since I had > just read about it but I don't have practical experience with it. > DT overlays is a solution to the problem faced by the beagle bone community. There they have a relatively large number of accessories (called capes). Since the capes don't use a dynamically probed interface like USB/MMC, the hardware information needs to be hard coded somewhere and loaded into the DT at runtime whenever a new cape is connected. Using overlays for a SOM + base board architecture is an overkill IMO. A base board is not an accessory, but the platform board itself, hence qualifies for it's own dts file. It is much easier to use a base dts for the SOM which contains all the information for the SOM and leaves the base board details to the base board specific dts. Each base board can be considered to be a extended variant of the SOM. cheers, -roger ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support 2013-10-07 10:42 ` Roger Quadros @ 2013-10-07 11:53 ` Javier Martinez Canillas 0 siblings, 0 replies; 19+ messages in thread From: Javier Martinez Canillas @ 2013-10-07 11:53 UTC (permalink / raw) To: Roger Quadros Cc: Javier Martinez Canillas, Benoit Cousson, Tony Lindgren, Enric Balletbo i Serra, linux-omap, devicetree On 10/07/2013 12:42 PM, Roger Quadros wrote: > On 10/07/2013 01:22 PM, Javier Martinez Canillas wrote: >> On Mon, Oct 7, 2013 at 11:13 AM, Javier Martinez Canillas >> <javier.martinez@collabora.co.uk> wrote: >>> On 10/07/2013 11:06 AM, Roger Quadros wrote: >>>>> >>>>> Well that's a very good question indeed. >>>>> >>>>> The thing is that the IGEP0030 is a Computer-on-Module [1] that is used in >>>>> conjunction with expansion boards and some of them have USB HOST support such as >>>>> IGEP Paris [2] and IGEP Berlin [3]. >>>>> >>>>> Support for this expansion boards is still not in mainline but there are plans >>>>> to add them using Device Tree overlays [4] once/if this land on mainline. >>>>> >>>> >>>> Why would your boards need Device Tree overlays? From the looks of it, the configuration >>>> of SOM + base board don't seem to change at runtime. >>>> >>> >>> Indeed, a static configuration (DTS) would be enough now that I think about it. >>> >> >> Hi Roger, >> >> Now that I had coffee I remember why I think that even when Device >> Tree overlays are not strictly required for a SOM + base board it >> could be handy to use. If we use a static configuration (DTB) then the >> same firmware can't be used by any IGEP COM Module user. She would >> have to choose a DTB to pass to the kernel on boot. >> >> While using DT overlays the same firmware that provides a minimal DTB >> can be used regardless of the base board used (as long as there are >> all the needed fragment/overlays hooks in the DTS). >> >> After all the SOM has a NAND flash memory and a uSD/MMC slot so a >> minimal DTB is needed to boot and the support for all the peripherals >> present on the base board can be added by triggering a device tree >> overlay load from user-space. > > Consider this example. You need to boot your board using NFS over ethernet > dongle connected to USB host. If you need user space to get that to work, > it will be a unnecessary challenge, whereas you can easily do that if you > have a static DT blob. > >> >> Or maybe I'm misunderstanding the use case for DT overlays since I had >> just read about it but I don't have practical experience with it. >> > > DT overlays is a solution to the problem faced by the beagle bone community. > There they have a relatively large number of accessories (called capes). > Since the capes don't use a dynamically probed interface like USB/MMC, > the hardware information needs to be hard coded somewhere and loaded > into the DT at runtime whenever a new cape is connected. > > Using overlays for a SOM + base board architecture is an overkill IMO. A base board > is not an accessory, but the platform board itself, hence qualifies for it's own > dts file. > > It is much easier to use a base dts for the SOM which contains all the information > for the SOM and leaves the base board details to the base board specific dts. > Each base board can be considered to be a extended variant of the SOM. > > cheers, > -roger > Hi Roger, Thanks a lot for the explanation, is very clear for me now. Best regards, Javier ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] ARM: dts: omap3-igep0020: use standard constant for IRQ flags 2013-10-05 0:04 [PATCH 0/3] ARM: dts: omap3-igep0020: improvements for v3.13 Javier Martinez Canillas 2013-10-05 0:04 ` [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support Javier Martinez Canillas 2013-10-05 0:04 ` [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support Javier Martinez Canillas @ 2013-10-05 0:04 ` Javier Martinez Canillas 2 siblings, 0 replies; 19+ messages in thread From: Javier Martinez Canillas @ 2013-10-05 0:04 UTC (permalink / raw) To: bcousson Cc: Tony Lindgren, Enric Balletbo i Serra, Roger Quadros, linux-omap, Javier Martinez Canillas Commit 840ef8b7 ("ARM: dt: add header to define IRQ flags") added constants for IRQ edge/level triggered types so use it instead of a magic number to enhance the DT readability. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/boot/dts/omap3-igep0020.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts index 180b186..64884fa 100644 --- a/arch/arm/boot/dts/omap3-igep0020.dts +++ b/arch/arm/boot/dts/omap3-igep0020.dts @@ -175,7 +175,7 @@ gpmc,cycle2cycle-diffcsen; interrupt-parent = <&gpio6>; - interrupts = <16 8>; + interrupts = <16 IRQ_TYPE_LEVEL_LOW>; vmmc-supply = <&vddvario>; vmmc_aux-supply = <&vdd33a>; reg-io-width = <4>; -- 1.8.4.rc3 ^ permalink raw reply related [flat|nested] 19+ messages in thread
end of thread, other threads:[~2013-10-07 16:06 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-05 0:04 [PATCH 0/3] ARM: dts: omap3-igep0020: improvements for v3.13 Javier Martinez Canillas
2013-10-05 0:04 ` [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support Javier Martinez Canillas
2013-10-06 10:26 ` Enric Balletbo Serra
2013-10-07 10:43 ` Roger Quadros
2013-10-07 11:54 ` Javier Martinez Canillas
2013-10-07 11:58 ` Benoit Cousson
2013-10-07 12:02 ` Javier Martinez Canillas
2013-10-07 12:09 ` Benoit Cousson
2013-10-07 16:05 ` Javier Martinez Canillas
2013-10-05 0:04 ` [PATCH 2/3] ARM: dts: omap3-igep0020: Add HS USB Host support Javier Martinez Canillas
2013-10-06 10:27 ` Enric Balletbo Serra
2013-10-07 8:33 ` Roger Quadros
2013-10-07 8:50 ` Javier Martinez Canillas
[not found] ` <525275C8.2050208-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2013-10-07 9:06 ` Roger Quadros
2013-10-07 9:13 ` Javier Martinez Canillas
2013-10-07 10:22 ` Javier Martinez Canillas
2013-10-07 10:42 ` Roger Quadros
2013-10-07 11:53 ` Javier Martinez Canillas
2013-10-05 0:04 ` [PATCH 3/3] ARM: dts: omap3-igep0020: use standard constant for IRQ flags Javier Martinez Canillas
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.