From: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
To: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/2] gpio: davinci: don't create irq_domain in case of unbanked irqs
Date: Mon, 16 Dec 2013 11:24:10 -0500 [thread overview]
Message-ID: <52AF292A.4020106@ti.com> (raw)
In-Reply-To: <1386871973-26762-2-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
On Thursday 12 December 2013 01:12 PM, Grygorii Strashko wrote:
> The system may crash if:
> - there are more then 1 bank
> - unbanked irqs are enabled
> - someone will call gpio_to_irq() for GPIO from bank2 or above
>
> Hence, fix it by not creating irq_domain if unbanked irqs are enabled
> and correct gpio_to_irq_banked() to handle this properly.
>
> CC: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> CC: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
> CC: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Sekhar Nori <nsekhar@ti.com>,
Rob Herring <rob.herring@calxeda.com>,
<prabhakar.csengg@gmail.com>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<davinci-linux-open-source@linux.davincidsp.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] gpio: davinci: don't create irq_domain in case of unbanked irqs
Date: Mon, 16 Dec 2013 11:24:10 -0500 [thread overview]
Message-ID: <52AF292A.4020106@ti.com> (raw)
In-Reply-To: <1386871973-26762-2-git-send-email-grygorii.strashko@ti.com>
On Thursday 12 December 2013 01:12 PM, Grygorii Strashko wrote:
> The system may crash if:
> - there are more then 1 bank
> - unbanked irqs are enabled
> - someone will call gpio_to_irq() for GPIO from bank2 or above
>
> Hence, fix it by not creating irq_domain if unbanked irqs are enabled
> and correct gpio_to_irq_banked() to handle this properly.
>
> CC: Linus Walleij <linus.walleij@linaro.org>
> CC: Sekhar Nori <nsekhar@ti.com>
> CC: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] gpio: davinci: don't create irq_domain in case of unbanked irqs
Date: Mon, 16 Dec 2013 11:24:10 -0500 [thread overview]
Message-ID: <52AF292A.4020106@ti.com> (raw)
In-Reply-To: <1386871973-26762-2-git-send-email-grygorii.strashko@ti.com>
On Thursday 12 December 2013 01:12 PM, Grygorii Strashko wrote:
> The system may crash if:
> - there are more then 1 bank
> - unbanked irqs are enabled
> - someone will call gpio_to_irq() for GPIO from bank2 or above
>
> Hence, fix it by not creating irq_domain if unbanked irqs are enabled
> and correct gpio_to_irq_banked() to handle this properly.
>
> CC: Linus Walleij <linus.walleij@linaro.org>
> CC: Sekhar Nori <nsekhar@ti.com>
> CC: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2013-12-16 16:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 18:12 [PATCH 0/2] gpio: davinci: reuse for keystone arch Grygorii Strashko
2013-12-12 18:12 ` Grygorii Strashko
2013-12-12 18:12 ` Grygorii Strashko
2013-12-12 18:12 ` [PATCH 1/2] gpio: davinci: don't create irq_domain in case of unbanked irqs Grygorii Strashko
2013-12-12 18:12 ` Grygorii Strashko
2013-12-12 18:12 ` Grygorii Strashko
[not found] ` <1386871973-26762-2-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2013-12-16 16:24 ` Santosh Shilimkar [this message]
2013-12-16 16:24 ` Santosh Shilimkar
2013-12-16 16:24 ` Santosh Shilimkar
[not found] ` <1386871973-26762-1-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2013-12-12 18:12 ` [PATCH 2/2] gpio: davinci: reuse for Keystone SoC Grygorii Strashko
2013-12-12 18:12 ` Grygorii Strashko
2013-12-12 18:12 ` Grygorii Strashko
2013-12-16 7:29 ` Alexandre Courbot
2013-12-16 7:29 ` Alexandre Courbot
2013-12-16 7:29 ` Alexandre Courbot
[not found] ` <CAAVeFuJSe_BZ+cr8ZVz-etAzsUbe_taS+0EqM+pXhKhTdyuWiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-16 11:18 ` Grygorii Strashko
2013-12-16 11:18 ` Grygorii Strashko
2013-12-16 11:18 ` Grygorii Strashko
[not found] ` <1386871973-26762-3-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2013-12-16 16:38 ` Santosh Shilimkar
2013-12-16 16:38 ` Santosh Shilimkar
2013-12-16 16:38 ` Santosh Shilimkar
2013-12-16 18:02 ` Grygorii Strashko
2013-12-16 18:02 ` Grygorii Strashko
2013-12-16 18:02 ` Grygorii Strashko
2013-12-14 19:11 ` [PATCH 0/2] gpio: davinci: reuse for keystone arch Santosh Shilimkar
2013-12-14 19:11 ` Santosh Shilimkar
2013-12-14 19:11 ` Santosh Shilimkar
[not found] ` <52ACAD50.6060003-l0cyMroinI0@public.gmane.org>
2013-12-15 13:50 ` Sekhar Nori
2013-12-15 13:50 ` Sekhar Nori
2013-12-15 13:50 ` Sekhar Nori
[not found] ` <52ADB3BC.3080605-l0cyMroinI0@public.gmane.org>
2013-12-15 13:54 ` Sekhar Nori
2013-12-15 13:54 ` Sekhar Nori
2013-12-15 13:54 ` Sekhar Nori
[not found] ` <52ADB47E.1080505-l0cyMroinI0@public.gmane.org>
2013-12-16 11:18 ` Grygorii Strashko
2013-12-16 11:18 ` Grygorii Strashko
2013-12-16 11:18 ` Grygorii Strashko
2013-12-16 15:09 ` Santosh Shilimkar
2013-12-16 15:09 ` Santosh Shilimkar
2013-12-16 15:09 ` Santosh Shilimkar
[not found] ` <52AF17A6.3060007-l0cyMroinI0@public.gmane.org>
2013-12-16 16:39 ` Santosh Shilimkar
2013-12-16 16:39 ` Santosh Shilimkar
2013-12-16 16:39 ` Santosh Shilimkar
2013-12-20 9:39 ` Linus Walleij
2013-12-20 9:39 ` Linus Walleij
2013-12-20 9:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF292A.4020106@ti.com \
--to=santosh.shilimkar-l0cymroini0@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=grygorii.strashko-l0cyMroinI0@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.