From: Hans Verkuil <hverkuil@xs4all.nl>
To: Mikhail Ulianov <mikhail.ulyanov@cogentembedded.com>
Cc: m.chehab@samsung.com, horms@verge.net.au, magnus.damm@gmail.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
laurent.pinchart@ideasonboard.com, linux-sh@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/6] V4L2: Add Renesas R-Car JPEG codec driver.
Date: Fri, 22 Aug 2014 17:03:48 +0000 [thread overview]
Message-ID: <53F777F4.30804@xs4all.nl> (raw)
In-Reply-To: <20140822173900.0d3efcd1@bones>
On 08/22/2014 01:39 PM, Mikhail Ulianov wrote:
> Hi Hans,
>
> Thanks for your comments.
>
> I have a question on default width, height and sizeimage values
> m2m driver should return in case when we try to run G_FMT on just
> opened device. Is there any preferable values? v4l2-compliance tool
> want it to be non zero, but at that moment we have no information
> about output and capture, so i see few options here:
> 1) ignore v4l-complince error in such case
>>> v4l2-test-formats.cpp(417): !pix.width || !pix.height"
> 2) set some default values e.g. 640x480
> Do you have a suggestion? \
Use 2: just set a default value. V4L2 should always be in a sane state,
which in this case means that the driver should just pick some default
initial format.
Regards,
Hans
>
> Thanks, Mikhail.
>
>> Hi Mikhail,
>>
>> I did a quick scan over the source code and I noticed a few things
>> that aren't right. The easiest for you is probably to run the
>> v4l2-compliance tool over your driver and it should tell you what
>> needs to be fixed. The things I noticed are: querycap doesn't fill in
>> bus_info (should be 'platform:<foo>') and device_caps, the vid_cap
>> try_fmt fails on a wrong field setting, instead it should just set it.
>>
>> I also have some doubts about g_selection, but I need to look at that
>> again when I have more time next week. It does look like it is not
>> properly separating the capture and output streams. I would expect
>> g_selection to return different things for capture and output. Note
>> that v4l2-compliance doesn't yet check the selection API, so it won't
>> help you there.
>>
>> Regards,
>>
>> Hans
next prev parent reply other threads:[~2014-08-22 17:03 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 12:50 [PATCH 0/6] R-Car JPEG Processing Unit Mikhail Ulyanov
2014-08-19 12:50 ` Mikhail Ulyanov
2014-08-19 12:50 ` Mikhail Ulyanov
2014-08-19 12:50 ` [PATCH 1/6] V4L2: Add Renesas R-Car JPEG codec driver Mikhail Ulyanov
2014-08-19 12:50 ` Mikhail Ulyanov
2014-08-19 13:37 ` Hans Verkuil
2014-08-19 13:37 ` Hans Verkuil
2014-08-22 13:39 ` Mikhail Ulianov
2014-08-22 13:39 ` Mikhail Ulianov
2014-08-22 17:03 ` Hans Verkuil [this message]
2014-08-25 12:29 ` [PATCH v2 " Mikhail Ulyanov
2014-08-25 12:29 ` Mikhail Ulyanov
2014-08-25 12:39 ` Hans Verkuil
2014-08-25 12:39 ` Hans Verkuil
2014-08-25 12:49 ` Hans Verkuil
2014-08-25 12:49 ` Hans Verkuil
2014-09-21 17:56 ` Sergei Shtylyov
2014-09-21 17:56 ` Sergei Shtylyov
2014-09-21 17:56 ` Sergei Shtylyov
2014-09-21 17:56 ` Sergei Shtylyov
2014-09-23 13:31 ` Kamil Debski
2014-09-23 13:31 ` Kamil Debski
2014-09-25 12:49 ` Sergei Shtylyov
2014-09-25 12:49 ` Sergei Shtylyov
2014-09-26 14:01 ` Laurent Pinchart
2014-09-26 14:01 ` Laurent Pinchart
2014-09-23 14:02 ` [PATCH " Geert Uytterhoeven
2014-09-23 14:02 ` Geert Uytterhoeven
2014-08-19 12:50 ` [PATCH 2/6] ARM: shmobile: r8a7790: Add JPU clock dt and CPG define Mikhail Ulyanov
2014-08-19 12:50 ` Mikhail Ulyanov
2014-08-20 23:07 ` Laurent Pinchart
2014-08-20 23:07 ` Laurent Pinchart
2014-08-22 1:57 ` Simon Horman
2014-08-22 1:57 ` Simon Horman
2014-08-19 12:50 ` [PATCH 3/6] ARM: shmobile: r8a7790: Add JPU device node Mikhail Ulyanov
2014-08-19 12:50 ` Mikhail Ulyanov
2014-08-22 1:54 ` [3/6] " Simon Horman
2014-08-22 1:54 ` Simon Horman
2014-08-19 12:50 ` [PATCH 4/6] ARM: shmobile: r8a7791: Add JPU clock dt and CPG define Mikhail Ulyanov
2014-08-19 12:50 ` Mikhail Ulyanov
2014-08-20 23:07 ` Laurent Pinchart
2014-08-20 23:07 ` Laurent Pinchart
2014-08-22 1:56 ` Simon Horman
2014-08-22 1:56 ` Simon Horman
2014-08-19 12:50 ` [PATCH 5/6] ARM: shmobile: r8a7791: Add JPU device node Mikhail Ulyanov
2014-08-19 12:50 ` Mikhail Ulyanov
2014-08-19 12:50 ` [PATCH 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit Mikhail Ulyanov
2014-08-19 12:50 ` Mikhail Ulyanov
2014-08-20 23:01 ` Laurent Pinchart
2014-08-20 23:01 ` Laurent Pinchart
2014-08-22 14:20 ` Mikhail Ulianov
2014-08-22 14:20 ` Mikhail Ulianov
2014-08-25 9:49 ` Laurent Pinchart
2014-08-25 9:49 ` Laurent Pinchart
2014-08-25 12:35 ` [PATCH v2 " Mikhail Ulyanov
2014-08-25 12:35 ` Mikhail Ulyanov
2014-08-25 12:59 ` Geert Uytterhoeven
2014-08-25 12:59 ` Geert Uytterhoeven
2014-08-25 23:57 ` Simon Horman
2014-08-25 23:57 ` Simon Horman
2014-08-26 0:02 ` Laurent Pinchart
2014-08-26 0:02 ` Laurent Pinchart
2014-08-26 2:42 ` Simon Horman
2014-08-26 2:42 ` Simon Horman
2014-09-24 13:38 ` Mikhail Ulianov
2014-09-24 13:38 ` Mikhail Ulianov
2014-08-26 8:03 ` Geert Uytterhoeven
2014-08-26 8:03 ` Geert Uytterhoeven
2014-08-26 9:01 ` Simon Horman
2014-08-26 9:01 ` Simon Horman
2014-08-26 9:27 ` Geert Uytterhoeven
2014-08-26 9:27 ` Geert Uytterhoeven
2014-08-27 5:15 ` Simon Horman
2014-08-27 5:15 ` Simon Horman
2014-08-27 6:06 ` Laurent Pinchart
2014-08-27 6:06 ` Laurent Pinchart
2014-08-27 6:16 ` Simon Horman
2014-08-27 6:16 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F777F4.30804@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mikhail.ulyanov@cogentembedded.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.