From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> To: Kamil Debski <k.debski@samsung.com>, 'Mikhail Ulyanov' <mikhail.ulyanov@cogentembedded.com>, horms@verge.net.au, magnus.damm@gmail.com, m.chehab@samsung.com, robh+dt@kernel.org, grant.likely@linaro.org Cc: laurent.pinchart@ideasonboard.com, hans.verkuil@cisco.com, linux-sh@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/6] V4L2: Add Renesas R-Car JPEG codec driver. Date: Thu, 25 Sep 2014 12:49:43 +0000 [thread overview] Message-ID: <54240F67.90708@cogentembedded.com> (raw) In-Reply-To: <085201cfd732$a2849bd0$e78dd370$%debski@samsung.com> Hello. On 9/23/2014 5:31 PM, Kamil Debski wrote: >> From: linux-media-owner@vger.kernel.org [mailto:linux-media- >> owner@vger.kernel.org] On Behalf Of Mikhail Ulyanov >> Sent: Monday, August 25, 2014 2:30 PM >> This patch contains driver for Renesas R-Car JPEG codec. >> Cnanges since v1: >> - s/g_fmt function simplified >> - default format for queues added >> - dumb vidioc functions added to be in compliance with standard >> api: >> jpu_s_priority, jpu_g_priority >> - standard v4l2_ctrl_subscribe_event and v4l2_event_unsubscribe >> now in use by the same reason > The patch looks good to me. However, I would suggest using the BIT macro I'd prefer not using it since the driver #define's not only bits but also bit values and multi-bit fields. Using BIT() would look inconsistent in this situation. > and making some short functions inline. I think the current trend is to use *inline* only in the headers, and let gcc figure it out itself in the .c files. >> Signed-off-by: Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com> [...] >> diff --git a/drivers/media/platform/jpu.c >> b/drivers/media/platform/jpu.c new file mode 100644 index >> 0000000..da70491 >> --- /dev/null >> +++ b/drivers/media/platform/jpu.c >> @@ -0,0 +1,1628 @@ [...] > Best wishes, WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> To: Kamil Debski <k.debski@samsung.com>, 'Mikhail Ulyanov' <mikhail.ulyanov@cogentembedded.com>, horms@verge.net.au, magnus.damm@gmail.com, m.chehab@samsung.com, robh+dt@kernel.org, grant.likely@linaro.org Cc: laurent.pinchart@ideasonboard.com, hans.verkuil@cisco.com, linux-sh@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/6] V4L2: Add Renesas R-Car JPEG codec driver. Date: Thu, 25 Sep 2014 16:49:43 +0400 [thread overview] Message-ID: <54240F67.90708@cogentembedded.com> (raw) In-Reply-To: <085201cfd732$a2849bd0$e78dd370$%debski@samsung.com> Hello. On 9/23/2014 5:31 PM, Kamil Debski wrote: >> From: linux-media-owner@vger.kernel.org [mailto:linux-media- >> owner@vger.kernel.org] On Behalf Of Mikhail Ulyanov >> Sent: Monday, August 25, 2014 2:30 PM >> This patch contains driver for Renesas R-Car JPEG codec. >> Cnanges since v1: >> - s/g_fmt function simplified >> - default format for queues added >> - dumb vidioc functions added to be in compliance with standard >> api: >> jpu_s_priority, jpu_g_priority >> - standard v4l2_ctrl_subscribe_event and v4l2_event_unsubscribe >> now in use by the same reason > The patch looks good to me. However, I would suggest using the BIT macro I'd prefer not using it since the driver #define's not only bits but also bit values and multi-bit fields. Using BIT() would look inconsistent in this situation. > and making some short functions inline. I think the current trend is to use *inline* only in the headers, and let gcc figure it out itself in the .c files. >> Signed-off-by: Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com> [...] >> diff --git a/drivers/media/platform/jpu.c >> b/drivers/media/platform/jpu.c new file mode 100644 index >> 0000000..da70491 >> --- /dev/null >> +++ b/drivers/media/platform/jpu.c >> @@ -0,0 +1,1628 @@ [...] > Best wishes, WBR, Sergei
next prev parent reply other threads:[~2014-09-25 12:49 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-19 12:50 [PATCH 0/6] R-Car JPEG Processing Unit Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-19 12:50 ` [PATCH 1/6] V4L2: Add Renesas R-Car JPEG codec driver Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-19 13:37 ` Hans Verkuil 2014-08-19 13:37 ` Hans Verkuil 2014-08-22 13:39 ` Mikhail Ulianov 2014-08-22 13:39 ` Mikhail Ulianov 2014-08-22 17:03 ` Hans Verkuil 2014-08-25 12:29 ` [PATCH v2 " Mikhail Ulyanov 2014-08-25 12:29 ` Mikhail Ulyanov 2014-08-25 12:39 ` Hans Verkuil 2014-08-25 12:39 ` Hans Verkuil 2014-08-25 12:49 ` Hans Verkuil 2014-08-25 12:49 ` Hans Verkuil 2014-09-21 17:56 ` Sergei Shtylyov 2014-09-21 17:56 ` Sergei Shtylyov 2014-09-21 17:56 ` Sergei Shtylyov 2014-09-21 17:56 ` Sergei Shtylyov 2014-09-23 13:31 ` Kamil Debski 2014-09-23 13:31 ` Kamil Debski 2014-09-25 12:49 ` Sergei Shtylyov [this message] 2014-09-25 12:49 ` Sergei Shtylyov 2014-09-26 14:01 ` Laurent Pinchart 2014-09-26 14:01 ` Laurent Pinchart 2014-09-23 14:02 ` [PATCH " Geert Uytterhoeven 2014-09-23 14:02 ` Geert Uytterhoeven 2014-08-19 12:50 ` [PATCH 2/6] ARM: shmobile: r8a7790: Add JPU clock dt and CPG define Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-20 23:07 ` Laurent Pinchart 2014-08-20 23:07 ` Laurent Pinchart 2014-08-22 1:57 ` Simon Horman 2014-08-22 1:57 ` Simon Horman 2014-08-19 12:50 ` [PATCH 3/6] ARM: shmobile: r8a7790: Add JPU device node Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-22 1:54 ` [3/6] " Simon Horman 2014-08-22 1:54 ` Simon Horman 2014-08-19 12:50 ` [PATCH 4/6] ARM: shmobile: r8a7791: Add JPU clock dt and CPG define Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-20 23:07 ` Laurent Pinchart 2014-08-20 23:07 ` Laurent Pinchart 2014-08-22 1:56 ` Simon Horman 2014-08-22 1:56 ` Simon Horman 2014-08-19 12:50 ` [PATCH 5/6] ARM: shmobile: r8a7791: Add JPU device node Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-19 12:50 ` [PATCH 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-20 23:01 ` Laurent Pinchart 2014-08-20 23:01 ` Laurent Pinchart 2014-08-22 14:20 ` Mikhail Ulianov 2014-08-22 14:20 ` Mikhail Ulianov 2014-08-25 9:49 ` Laurent Pinchart 2014-08-25 9:49 ` Laurent Pinchart 2014-08-25 12:35 ` [PATCH v2 " Mikhail Ulyanov 2014-08-25 12:35 ` Mikhail Ulyanov 2014-08-25 12:59 ` Geert Uytterhoeven 2014-08-25 12:59 ` Geert Uytterhoeven 2014-08-25 23:57 ` Simon Horman 2014-08-25 23:57 ` Simon Horman 2014-08-26 0:02 ` Laurent Pinchart 2014-08-26 0:02 ` Laurent Pinchart 2014-08-26 2:42 ` Simon Horman 2014-08-26 2:42 ` Simon Horman 2014-09-24 13:38 ` Mikhail Ulianov 2014-09-24 13:38 ` Mikhail Ulianov 2014-08-26 8:03 ` Geert Uytterhoeven 2014-08-26 8:03 ` Geert Uytterhoeven 2014-08-26 9:01 ` Simon Horman 2014-08-26 9:01 ` Simon Horman 2014-08-26 9:27 ` Geert Uytterhoeven 2014-08-26 9:27 ` Geert Uytterhoeven 2014-08-27 5:15 ` Simon Horman 2014-08-27 5:15 ` Simon Horman 2014-08-27 6:06 ` Laurent Pinchart 2014-08-27 6:06 ` Laurent Pinchart 2014-08-27 6:16 ` Simon Horman 2014-08-27 6:16 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=54240F67.90708@cogentembedded.com \ --to=sergei.shtylyov@cogentembedded.com \ --cc=devicetree@vger.kernel.org \ --cc=grant.likely@linaro.org \ --cc=hans.verkuil@cisco.com \ --cc=horms@verge.net.au \ --cc=k.debski@samsung.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=m.chehab@samsung.com \ --cc=magnus.damm@gmail.com \ --cc=mikhail.ulyanov@cogentembedded.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.