From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com> Cc: m.chehab@samsung.com, horms@verge.net.au, magnus.damm@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, linux-sh@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit. Date: Wed, 20 Aug 2014 23:01:43 +0000 [thread overview] Message-ID: <3694359.xqEjcGBlOG@avalon> (raw) In-Reply-To: <1408452653-14067-7-git-send-email-mikhail.ulyanov@cogentembedded.com> Hi Mikhail, Thank you for the patch. On Tuesday 19 August 2014 16:50:53 Mikhail Ulyanov wrote: > Signed-off-by: Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com> > --- > .../devicetree/bindings/media/renesas,jpu.txt | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/renesas,jpu.txt > > diff --git a/Documentation/devicetree/bindings/media/renesas,jpu.txt > b/Documentation/devicetree/bindings/media/renesas,jpu.txt new file mode > 100644 > index 0000000..44b07df > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,jpu.txt > @@ -0,0 +1,23 @@ > +* Renesas VSP1 Video Processing Engine Copy & paste ? :-) > + > +The JPEG processing unit (JPU) incorporates the JPEG codec with an encoding > +and decoding function conforming to the JPEG baseline process, so that the > JPU > +can encode image data and decode JPEG data quickly. > +It can be found in the Renesas R-Car first and second generation SoCs. Is there a difference between the first and second generation JPUs ? > + > +Required properties: > + - compatible: should containg one of the following: > + - "renesas,jpu-r8a7790" for R-Car H2 > + - "renesas,jpu-r8a7791" for R-Car M2 How about adding a "renesas,jpu" generic compatible, and listing both the SoC- specific and the generic values (in that order) in the compatible property ? > + - reg: Base address and length of the registers block for the JPU. > + - interrupts: JPU interrupt specifier. > + - clocks: A phandle + clock-specifier pair for the JPU functional clock. > + > +Example: R8A7790 (R-Car H2) JPU node > + jpeg-codec@fe980000 { > + compatible = "renesas,jpu-r8a7790"; > + reg = <0 0xfe980000 0 0x10300>; > + interrupts = <0 272 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp1_clks R8A7790_CLK_JPU>; > + }; -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com> Cc: m.chehab@samsung.com, horms@verge.net.au, magnus.damm@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, linux-sh@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit. Date: Thu, 21 Aug 2014 01:01:43 +0200 [thread overview] Message-ID: <3694359.xqEjcGBlOG@avalon> (raw) In-Reply-To: <1408452653-14067-7-git-send-email-mikhail.ulyanov@cogentembedded.com> Hi Mikhail, Thank you for the patch. On Tuesday 19 August 2014 16:50:53 Mikhail Ulyanov wrote: > Signed-off-by: Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com> > --- > .../devicetree/bindings/media/renesas,jpu.txt | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/renesas,jpu.txt > > diff --git a/Documentation/devicetree/bindings/media/renesas,jpu.txt > b/Documentation/devicetree/bindings/media/renesas,jpu.txt new file mode > 100644 > index 0000000..44b07df > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,jpu.txt > @@ -0,0 +1,23 @@ > +* Renesas VSP1 Video Processing Engine Copy & paste ? :-) > + > +The JPEG processing unit (JPU) incorporates the JPEG codec with an encoding > +and decoding function conforming to the JPEG baseline process, so that the > JPU > +can encode image data and decode JPEG data quickly. > +It can be found in the Renesas R-Car first and second generation SoCs. Is there a difference between the first and second generation JPUs ? > + > +Required properties: > + - compatible: should containg one of the following: > + - "renesas,jpu-r8a7790" for R-Car H2 > + - "renesas,jpu-r8a7791" for R-Car M2 How about adding a "renesas,jpu" generic compatible, and listing both the SoC- specific and the generic values (in that order) in the compatible property ? > + - reg: Base address and length of the registers block for the JPU. > + - interrupts: JPU interrupt specifier. > + - clocks: A phandle + clock-specifier pair for the JPU functional clock. > + > +Example: R8A7790 (R-Car H2) JPU node > + jpeg-codec@fe980000 { > + compatible = "renesas,jpu-r8a7790"; > + reg = <0 0xfe980000 0 0x10300>; > + interrupts = <0 272 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp1_clks R8A7790_CLK_JPU>; > + }; -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2014-08-20 23:01 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-19 12:50 [PATCH 0/6] R-Car JPEG Processing Unit Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-19 12:50 ` [PATCH 1/6] V4L2: Add Renesas R-Car JPEG codec driver Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-19 13:37 ` Hans Verkuil 2014-08-19 13:37 ` Hans Verkuil 2014-08-22 13:39 ` Mikhail Ulianov 2014-08-22 13:39 ` Mikhail Ulianov 2014-08-22 17:03 ` Hans Verkuil 2014-08-25 12:29 ` [PATCH v2 " Mikhail Ulyanov 2014-08-25 12:29 ` Mikhail Ulyanov 2014-08-25 12:39 ` Hans Verkuil 2014-08-25 12:39 ` Hans Verkuil 2014-08-25 12:49 ` Hans Verkuil 2014-08-25 12:49 ` Hans Verkuil 2014-09-21 17:56 ` Sergei Shtylyov 2014-09-21 17:56 ` Sergei Shtylyov 2014-09-21 17:56 ` Sergei Shtylyov 2014-09-21 17:56 ` Sergei Shtylyov 2014-09-23 13:31 ` Kamil Debski 2014-09-23 13:31 ` Kamil Debski 2014-09-25 12:49 ` Sergei Shtylyov 2014-09-25 12:49 ` Sergei Shtylyov 2014-09-26 14:01 ` Laurent Pinchart 2014-09-26 14:01 ` Laurent Pinchart 2014-09-23 14:02 ` [PATCH " Geert Uytterhoeven 2014-09-23 14:02 ` Geert Uytterhoeven 2014-08-19 12:50 ` [PATCH 2/6] ARM: shmobile: r8a7790: Add JPU clock dt and CPG define Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-20 23:07 ` Laurent Pinchart 2014-08-20 23:07 ` Laurent Pinchart 2014-08-22 1:57 ` Simon Horman 2014-08-22 1:57 ` Simon Horman 2014-08-19 12:50 ` [PATCH 3/6] ARM: shmobile: r8a7790: Add JPU device node Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-22 1:54 ` [3/6] " Simon Horman 2014-08-22 1:54 ` Simon Horman 2014-08-19 12:50 ` [PATCH 4/6] ARM: shmobile: r8a7791: Add JPU clock dt and CPG define Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-20 23:07 ` Laurent Pinchart 2014-08-20 23:07 ` Laurent Pinchart 2014-08-22 1:56 ` Simon Horman 2014-08-22 1:56 ` Simon Horman 2014-08-19 12:50 ` [PATCH 5/6] ARM: shmobile: r8a7791: Add JPU device node Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-19 12:50 ` [PATCH 6/6] devicetree: bindings: Document Renesas JPEG Processing Unit Mikhail Ulyanov 2014-08-19 12:50 ` Mikhail Ulyanov 2014-08-20 23:01 ` Laurent Pinchart [this message] 2014-08-20 23:01 ` Laurent Pinchart 2014-08-22 14:20 ` Mikhail Ulianov 2014-08-22 14:20 ` Mikhail Ulianov 2014-08-25 9:49 ` Laurent Pinchart 2014-08-25 9:49 ` Laurent Pinchart 2014-08-25 12:35 ` [PATCH v2 " Mikhail Ulyanov 2014-08-25 12:35 ` Mikhail Ulyanov 2014-08-25 12:59 ` Geert Uytterhoeven 2014-08-25 12:59 ` Geert Uytterhoeven 2014-08-25 23:57 ` Simon Horman 2014-08-25 23:57 ` Simon Horman 2014-08-26 0:02 ` Laurent Pinchart 2014-08-26 0:02 ` Laurent Pinchart 2014-08-26 2:42 ` Simon Horman 2014-08-26 2:42 ` Simon Horman 2014-09-24 13:38 ` Mikhail Ulianov 2014-09-24 13:38 ` Mikhail Ulianov 2014-08-26 8:03 ` Geert Uytterhoeven 2014-08-26 8:03 ` Geert Uytterhoeven 2014-08-26 9:01 ` Simon Horman 2014-08-26 9:01 ` Simon Horman 2014-08-26 9:27 ` Geert Uytterhoeven 2014-08-26 9:27 ` Geert Uytterhoeven 2014-08-27 5:15 ` Simon Horman 2014-08-27 5:15 ` Simon Horman 2014-08-27 6:06 ` Laurent Pinchart 2014-08-27 6:06 ` Laurent Pinchart 2014-08-27 6:16 ` Simon Horman 2014-08-27 6:16 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3694359.xqEjcGBlOG@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=devicetree@vger.kernel.org \ --cc=horms@verge.net.au \ --cc=linux-media@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=m.chehab@samsung.com \ --cc=magnus.damm@gmail.com \ --cc=mark.rutland@arm.com \ --cc=mikhail.ulyanov@cogentembedded.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.