All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Robert Rosengren <robert.rosengren@axis.com>,
	Jean Delvare <jdelvare@suse.de>,
	lm-sensors@lm-sensors.org
Cc: linux-kernel@vger.kernel.org, Robert Rosengren <robertr@axis.com>,
	Johan Adolfsson <johana@axis.com>
Subject: Re: [PATCH] hwmon: (ads7828) Make sample interval configurable
Date: Fri, 16 Jan 2015 06:52:06 -0800	[thread overview]
Message-ID: <54B92596.2040206@roeck-us.net> (raw)
In-Reply-To: <1421409922-28299-1-git-send-email-robert.rosengren@axis.com>

On 01/16/2015 04:05 AM, Robert Rosengren wrote:
> The default sample interval may be too slow for certain clients. This
> patch makes it configurable via the platform_data.
>
> Signed-off-by: Robert Rosengren <robert.rosengren@axis.com>
> Signed-off-by: Johan Adolfsson <johan.adolfsson@axis.com>

I am basically fine with the patch, though I would prefer replacing
the entire update handling and chip access with regmap. Would you be
interested in doing that ?

Thanks,
Guenter


WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Robert Rosengren <robert.rosengren@axis.com>,
	Jean Delvare <jdelvare@suse.de>,
	lm-sensors@lm-sensors.org
Cc: linux-kernel@vger.kernel.org, Robert Rosengren <robertr@axis.com>,
	Johan Adolfsson <johana@axis.com>
Subject: Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable
Date: Fri, 16 Jan 2015 14:52:06 +0000	[thread overview]
Message-ID: <54B92596.2040206@roeck-us.net> (raw)
In-Reply-To: <1421409922-28299-1-git-send-email-robert.rosengren@axis.com>

On 01/16/2015 04:05 AM, Robert Rosengren wrote:
> The default sample interval may be too slow for certain clients. This
> patch makes it configurable via the platform_data.
>
> Signed-off-by: Robert Rosengren <robert.rosengren@axis.com>
> Signed-off-by: Johan Adolfsson <johan.adolfsson@axis.com>

I am basically fine with the patch, though I would prefer replacing
the entire update handling and chip access with regmap. Would you be
interested in doing that ?

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2015-01-16 14:52 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 12:05 [PATCH] hwmon: (ads7828) Make sample interval configurable Robert Rosengren
2015-01-16 12:05 ` [lm-sensors] " Robert Rosengren
2015-01-16 14:52 ` Guenter Roeck [this message]
2015-01-16 14:52   ` Guenter Roeck
2015-01-16 18:30   ` Guenter Roeck
2015-01-16 18:30     ` Guenter Roeck
2015-01-19 11:14     ` SV: " Robert Rosengren
2015-01-19 11:14       ` Robert Rosengren
2015-01-27  7:59     ` Robert Rosengren
2015-01-27  7:59       ` Robert Rosengren
2015-01-27 10:37       ` Jean Delvare
2015-01-27 10:37         ` Jean Delvare
2015-01-27 14:23         ` Guenter Roeck
2015-01-27 14:23           ` Guenter Roeck
2015-01-27 14:07       ` Guenter Roeck
2015-01-27 14:07         ` Guenter Roeck
2015-01-27 19:54         ` Robert Rosengren
2015-01-27 19:54           ` Robert Rosengren
2015-01-27 20:05           ` Guenter Roeck
2015-01-27 20:05             ` Guenter Roeck
2015-01-27 22:34             ` Jean Delvare
2015-01-27 22:34               ` Jean Delvare
2015-01-28  4:06               ` Guenter Roeck
2015-01-28  4:06                 ` Guenter Roeck
2015-01-27 14:26       ` Guenter Roeck
2015-01-27 14:26         ` Guenter Roeck
2015-01-27 16:37       ` Guenter Roeck
2015-01-27 16:37         ` Guenter Roeck
2015-01-16 20:30 ` Guenter Roeck
2015-01-16 20:30   ` [lm-sensors] " Guenter Roeck
2015-01-28  6:18 ` Robert Rosengren
2015-01-28  6:28   ` Robert Rosengren
2015-01-28  6:28     ` Robert Rosengren
2015-01-28 14:50   ` Guenter Roeck
2015-01-28 14:50     ` Guenter Roeck
2015-01-29  7:00     ` Robert Rosengren
2015-01-29  7:00       ` Robert Rosengren
2015-01-29  7:05       ` Guenter Roeck
2015-01-29  7:05         ` Guenter Roeck
2015-01-29 12:07         ` Robert Rosengren
2015-01-29 12:07           ` Robert Rosengren
2015-01-29 14:10           ` Guenter Roeck
2015-01-29 14:10             ` Guenter Roeck
2015-01-29 19:30           ` Guenter Roeck
2015-01-29 19:30             ` Guenter Roeck
2015-01-31 20:11             ` Guenter Roeck
2015-01-31 20:11               ` Guenter Roeck
2015-02-02  8:12               ` Robert Rosengren
2015-02-02  8:12                 ` Robert Rosengren
2015-02-02 16:21                 ` Guenter Roeck
2015-02-02 16:21                   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B92596.2040206@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.de \
    --cc=johana@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=robert.rosengren@axis.com \
    --cc=robertr@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.