From: Robert Rosengren <robert.rosengren@axis.com> To: Guenter Roeck <linux@roeck-us.net> Cc: Johan Adolfsson <johana@axis.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org> Subject: Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable Date: Mon, 2 Feb 2015 09:12:57 +0100 [thread overview] Message-ID: <54CF3189.8050504@axis.com> (raw) In-Reply-To: <54CD36DF.7010602@roeck-us.net> On 01/31/2015 09:11 PM, Guenter Roeck wrote: > On 01/29/2015 11:30 AM, Guenter Roeck wrote: >> On Thu, Jan 29, 2015 at 01:07:10PM +0100, Robert Rosengren wrote: >>>> Is your hardware big endian or little endian ? >>> CONFIG_CPU_LITTLE_ENDIAN=y >>> >> Hi Robert, >> >> I have another question: What is your i2c controller type ? >> > Robert, > > I now tried both 3.15 and 3.19-rc6. Both kernels require the byte swap code. Agrees, no difference for me when trying with 3.15 and 3.18 version. The i2c is a bit-bang driver, specific for the hardware I am running on. > > The only reason I can imagine why you don't need it in your code would be > that your i2c controller does not support i2c functionality but only SMBus. > This would be the case, for example, with the i801 controller. So it would > be quite helpful to know which controller your system uses to access the > ads7828. > > Thanks, > Guenter > I tried your latest patch set (the 3 patches submitted last night) and it works fine for me. Great work! Please change my Cc-tag in the patches to Reviewed-by or Tested-by (I have done both, but one tag is enough). Thanks :-) BR, Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Rosengren <robert.rosengren@axis.com> To: Guenter Roeck <linux@roeck-us.net> Cc: Johan Adolfsson <johana@axis.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org> Subject: Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable Date: Mon, 02 Feb 2015 08:12:57 +0000 [thread overview] Message-ID: <54CF3189.8050504@axis.com> (raw) In-Reply-To: <54CD36DF.7010602@roeck-us.net> On 01/31/2015 09:11 PM, Guenter Roeck wrote: > On 01/29/2015 11:30 AM, Guenter Roeck wrote: >> On Thu, Jan 29, 2015 at 01:07:10PM +0100, Robert Rosengren wrote: >>>> Is your hardware big endian or little endian ? >>> CONFIG_CPU_LITTLE_ENDIAN=y >>> >> Hi Robert, >> >> I have another question: What is your i2c controller type ? >> > Robert, > > I now tried both 3.15 and 3.19-rc6. Both kernels require the byte swap code. Agrees, no difference for me when trying with 3.15 and 3.18 version. The i2c is a bit-bang driver, specific for the hardware I am running on. > > The only reason I can imagine why you don't need it in your code would be > that your i2c controller does not support i2c functionality but only SMBus. > This would be the case, for example, with the i801 controller. So it would > be quite helpful to know which controller your system uses to access the > ads7828. > > Thanks, > Guenter > I tried your latest patch set (the 3 patches submitted last night) and it works fine for me. Great work! Please change my Cc-tag in the patches to Reviewed-by or Tested-by (I have done both, but one tag is enough). Thanks :-) BR, Robert _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2015-02-02 8:13 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-16 12:05 [PATCH] hwmon: (ads7828) Make sample interval configurable Robert Rosengren 2015-01-16 12:05 ` [lm-sensors] " Robert Rosengren 2015-01-16 14:52 ` Guenter Roeck 2015-01-16 14:52 ` [lm-sensors] " Guenter Roeck 2015-01-16 18:30 ` Guenter Roeck 2015-01-16 18:30 ` Guenter Roeck 2015-01-19 11:14 ` SV: " Robert Rosengren 2015-01-19 11:14 ` Robert Rosengren 2015-01-27 7:59 ` Robert Rosengren 2015-01-27 7:59 ` Robert Rosengren 2015-01-27 10:37 ` Jean Delvare 2015-01-27 10:37 ` Jean Delvare 2015-01-27 14:23 ` Guenter Roeck 2015-01-27 14:23 ` Guenter Roeck 2015-01-27 14:07 ` Guenter Roeck 2015-01-27 14:07 ` Guenter Roeck 2015-01-27 19:54 ` Robert Rosengren 2015-01-27 19:54 ` Robert Rosengren 2015-01-27 20:05 ` Guenter Roeck 2015-01-27 20:05 ` Guenter Roeck 2015-01-27 22:34 ` Jean Delvare 2015-01-27 22:34 ` Jean Delvare 2015-01-28 4:06 ` Guenter Roeck 2015-01-28 4:06 ` Guenter Roeck 2015-01-27 14:26 ` Guenter Roeck 2015-01-27 14:26 ` Guenter Roeck 2015-01-27 16:37 ` Guenter Roeck 2015-01-27 16:37 ` Guenter Roeck 2015-01-16 20:30 ` Guenter Roeck 2015-01-16 20:30 ` [lm-sensors] " Guenter Roeck 2015-01-28 6:18 ` Robert Rosengren 2015-01-28 6:28 ` Robert Rosengren 2015-01-28 6:28 ` Robert Rosengren 2015-01-28 14:50 ` Guenter Roeck 2015-01-28 14:50 ` Guenter Roeck 2015-01-29 7:00 ` Robert Rosengren 2015-01-29 7:00 ` Robert Rosengren 2015-01-29 7:05 ` Guenter Roeck 2015-01-29 7:05 ` Guenter Roeck 2015-01-29 12:07 ` Robert Rosengren 2015-01-29 12:07 ` Robert Rosengren 2015-01-29 14:10 ` Guenter Roeck 2015-01-29 14:10 ` Guenter Roeck 2015-01-29 19:30 ` Guenter Roeck 2015-01-29 19:30 ` Guenter Roeck 2015-01-31 20:11 ` Guenter Roeck 2015-01-31 20:11 ` Guenter Roeck 2015-02-02 8:12 ` Robert Rosengren [this message] 2015-02-02 8:12 ` Robert Rosengren 2015-02-02 16:21 ` Guenter Roeck 2015-02-02 16:21 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=54CF3189.8050504@axis.com \ --to=robert.rosengren@axis.com \ --cc=johana@axis.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=lm-sensors@lm-sensors.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.