* DEBUG_RCU vs RCU_DEBUG
@ 2015-04-20 8:07 Duncan Sands
0 siblings, 0 replies; 3+ messages in thread
From: Duncan Sands @ 2015-04-20 8:07 UTC (permalink / raw)
To: lttng-dev
I noticed that urcu-qsbr.h checks for RCU_DEBUG being defined while the rest of
userspace-rcu (0.8.6) checks DEBUG_RCU. Is this a mistake or a cunning plan?
Ciao, Duncan.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: DEBUG_RCU vs RCU_DEBUG
[not found] ` <1338447584.35237.1429818280158.JavaMail.zimbra@efficios.com>
@ 2015-04-23 19:47 ` Mathieu Desnoyers
0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Desnoyers @ 2015-04-23 19:47 UTC (permalink / raw)
To: Duncan Sands; +Cc: lttng-dev
----- Original Message -----
> ----- Original Message -----
> > I noticed that urcu-qsbr.h checks for RCU_DEBUG being defined while the
> > rest
> > of
> > userspace-rcu (0.8.6) checks DEBUG_RCU. Is this a mistake or a cunning
> > plan?
>
> Good catch! Even urcu/static/urcu-qsbr.h has a ifdef based on
> DEBUG_RCU.
>
> Will rename the urcu-qsbr.[ch] RCU_DEBUG to DEBUG_RCU, and I will
> define RCU_DEBUG if DEBUG_RCU is defined in qsbr (for backward compat).
I rather mean the opposite: we define DEBUG_RCU if RCU_DEBUG
is defined.
Thanks,
Mathieu
> Fixes pushed into master, stable-0.8 and stable-0.7.
>
> Thanks!
>
> Mathieu
>
> >
> > Ciao, Duncan.
> >
> > _______________________________________________
> > lttng-dev mailing list
> > lttng-dev@lists.lttng.org
> > http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
> >
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: DEBUG_RCU vs RCU_DEBUG
[not found] <5534B3CA.6030306@free.fr>
@ 2015-04-23 19:44 ` Mathieu Desnoyers
[not found] ` <1338447584.35237.1429818280158.JavaMail.zimbra@efficios.com>
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Desnoyers @ 2015-04-23 19:44 UTC (permalink / raw)
To: Duncan Sands; +Cc: lttng-dev
----- Original Message -----
> I noticed that urcu-qsbr.h checks for RCU_DEBUG being defined while the rest
> of
> userspace-rcu (0.8.6) checks DEBUG_RCU. Is this a mistake or a cunning plan?
Good catch! Even urcu/static/urcu-qsbr.h has a ifdef based on
DEBUG_RCU.
Will rename the urcu-qsbr.[ch] RCU_DEBUG to DEBUG_RCU, and I will
define RCU_DEBUG if DEBUG_RCU is defined in qsbr (for backward compat).
Fixes pushed into master, stable-0.8 and stable-0.7.
Thanks!
Mathieu
>
> Ciao, Duncan.
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-23 19:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-20 8:07 DEBUG_RCU vs RCU_DEBUG Duncan Sands
[not found] <5534B3CA.6030306@free.fr>
2015-04-23 19:44 ` Mathieu Desnoyers
[not found] ` <1338447584.35237.1429818280158.JavaMail.zimbra@efficios.com>
2015-04-23 19:47 ` Mathieu Desnoyers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.