Re: [Qemu-devel] [PATCH 08/34] block: Add list of children to BlockDriverState

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

On 05/08/2015 11:21 AM, Kevin Wolf wrote:
> This allows iterating over all children of a given BDS, not only
> including bs->file and bs->backing_hd, but also driver-specific
> ones like VMDK extents or Quorum children.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block.c                   | 27 +++++++++++++++++++++++++++
>  include/block/block_int.h |  8 ++++++++
>  2 files changed, 35 insertions(+)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

and now I'm starting to see why you passed a well-named instance of a
struct that contains only a single function pointer, rather than the
function pointer directly, when creating BdrvChildRole in patch 7.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]