From: Ariel D'Alessandro <ariel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> To: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, Ezequiel Garcia <ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>, Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Subject: Re: [PATCH v2 1/4] DT: nvmem: Add NXP LPC18xx EEPROM memory binding documentation Date: Fri, 30 Oct 2015 09:45:16 -0300 [thread overview] Message-ID: <5633665C.5050107@vanguardiasur.com.ar> (raw) In-Reply-To: <CAGhQ9VyCBTWh6qgZ__eNLqooNURsYr9ZVtDz2qCKoa0MoVgXtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> Joachim, El 24/10/15 a las 18:44, Joachim Eastwood escribió: > Hi Ariel, > > On 19 October 2015 at 19:32, Ariel D'Alessandro > <ariel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> wrote: >> Add the devicetree binding document for NXP LPC18xx EEPROM memory. >> >> Signed-off-by: Ariel D'Alessandro <ariel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> >> --- >> .../devicetree/bindings/nvmem/lpc1857-eeprom.txt | 26 ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt >> >> diff --git a/Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt b/Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt >> new file mode 100644 >> index 0000000..01cde0d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt >> @@ -0,0 +1,26 @@ >> +* NXP LPC18xx EEPROM memory NVMEM driver >> + >> +Required properties: >> + - compatible: Should be "nxp,lpc1857-eeprom" >> + - reg: Must contain an entry with the physical base address and length >> + for each entry in reg-names. >> + - reg-names: Must include the following entries. >> + - reg: EEPROM registers. >> + - mem: EEPROM address space. >> + - clocks: Must contain an entry for each entry in clock-names. >> + - clock-names: Must include the following entries. >> + - eeprom: EEPROM operating clock. >> + - interrupts: Should contain EEPROM interrupt. > > You should document the 'reset' property as well. Ok. Will do. > >> +Example: >> + >> + eeprom: eeprom@4000e000 { >> + compatible = "nxp,lpc1857-eeprom"; >> + reg = <0x4000e000 0x1000>, >> + <0x20040000 0x4000>; >> + reg-names = "reg", "mem"; >> + clocks = <&ccu1 CLK_CPU_EEPROM>; >> + clock-names = "eeprom"; >> + resets = <&rgu 27>; >> + interrupts = <4>; >> + }; > > Other than that this looks good to me. > > Acked-by: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > Great, thanks. -- Ariel D'Alessandro, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: ariel@vanguardiasur.com.ar (Ariel D'Alessandro) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/4] DT: nvmem: Add NXP LPC18xx EEPROM memory binding documentation Date: Fri, 30 Oct 2015 09:45:16 -0300 [thread overview] Message-ID: <5633665C.5050107@vanguardiasur.com.ar> (raw) In-Reply-To: <CAGhQ9VyCBTWh6qgZ__eNLqooNURsYr9ZVtDz2qCKoa0MoVgXtA@mail.gmail.com> Joachim, El 24/10/15 a las 18:44, Joachim Eastwood escribi?: > Hi Ariel, > > On 19 October 2015 at 19:32, Ariel D'Alessandro > <ariel@vanguardiasur.com.ar> wrote: >> Add the devicetree binding document for NXP LPC18xx EEPROM memory. >> >> Signed-off-by: Ariel D'Alessandro <ariel@vanguardiasur.com.ar> >> --- >> .../devicetree/bindings/nvmem/lpc1857-eeprom.txt | 26 ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt >> >> diff --git a/Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt b/Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt >> new file mode 100644 >> index 0000000..01cde0d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt >> @@ -0,0 +1,26 @@ >> +* NXP LPC18xx EEPROM memory NVMEM driver >> + >> +Required properties: >> + - compatible: Should be "nxp,lpc1857-eeprom" >> + - reg: Must contain an entry with the physical base address and length >> + for each entry in reg-names. >> + - reg-names: Must include the following entries. >> + - reg: EEPROM registers. >> + - mem: EEPROM address space. >> + - clocks: Must contain an entry for each entry in clock-names. >> + - clock-names: Must include the following entries. >> + - eeprom: EEPROM operating clock. >> + - interrupts: Should contain EEPROM interrupt. > > You should document the 'reset' property as well. Ok. Will do. > >> +Example: >> + >> + eeprom: eeprom at 4000e000 { >> + compatible = "nxp,lpc1857-eeprom"; >> + reg = <0x4000e000 0x1000>, >> + <0x20040000 0x4000>; >> + reg-names = "reg", "mem"; >> + clocks = <&ccu1 CLK_CPU_EEPROM>; >> + clock-names = "eeprom"; >> + resets = <&rgu 27>; >> + interrupts = <4>; >> + }; > > Other than that this looks good to me. > > Acked-by: Joachim Eastwood <manabian@gmail.com> > Great, thanks. -- Ariel D'Alessandro, VanguardiaSur www.vanguardiasur.com.ar
next prev parent reply other threads:[~2015-10-30 12:45 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-10-19 17:32 [PATCH v2 0/4] Add support for NXP LPC18xx EEPROM using nvmem Ariel D'Alessandro 2015-10-19 17:32 ` Ariel D'Alessandro [not found] ` <1445275946-32653-1-git-send-email-ariel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> 2015-10-19 17:32 ` [PATCH v2 1/4] DT: nvmem: Add NXP LPC18xx EEPROM memory binding documentation Ariel D'Alessandro 2015-10-19 17:32 ` Ariel D'Alessandro [not found] ` <1445275946-32653-2-git-send-email-ariel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> 2015-10-24 21:44 ` Joachim Eastwood 2015-10-24 21:44 ` Joachim Eastwood [not found] ` <CAGhQ9VyCBTWh6qgZ__eNLqooNURsYr9ZVtDz2qCKoa0MoVgXtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-10-30 12:45 ` Ariel D'Alessandro [this message] 2015-10-30 12:45 ` Ariel D'Alessandro 2015-10-27 7:49 ` Rob Herring 2015-10-27 7:49 ` Rob Herring 2015-10-19 17:32 ` [PATCH v2 2/4] nvmem: NXP LPC18xx EEPROM memory NVMEM driver Ariel D'Alessandro 2015-10-19 17:32 ` Ariel D'Alessandro [not found] ` <1445275946-32653-3-git-send-email-ariel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> 2015-10-24 22:04 ` Joachim Eastwood 2015-10-24 22:04 ` Joachim Eastwood [not found] ` <CAGhQ9Vyg6sScq7yM=7judsMPHOc5VF2zf=7LPxmbmL7wF=vvgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-10-26 13:37 ` Srinivas Kandagatla 2015-10-26 13:37 ` Srinivas Kandagatla [not found] ` <562E2CB1.80706-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-10-30 14:58 ` Ariel D'Alessandro 2015-10-30 14:58 ` Ariel D'Alessandro [not found] ` <563385B2.90403-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> 2015-11-16 15:33 ` Ariel D'Alessandro 2015-11-16 15:33 ` Ariel D'Alessandro [not found] ` <5649F74A.9020706-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> 2015-11-16 15:37 ` Srinivas Kandagatla 2015-11-16 15:37 ` Srinivas Kandagatla [not found] ` <5649F856.9000101-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-12-03 18:39 ` Ezequiel Garcia 2015-12-03 18:39 ` Ezequiel Garcia 2015-10-30 14:55 ` Ariel D'Alessandro 2015-10-30 14:55 ` Ariel D'Alessandro [not found] ` <563384CB.3070607-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> 2015-11-16 15:24 ` Ariel D'Alessandro 2015-11-16 15:24 ` Ariel D'Alessandro 2015-10-26 14:23 ` Srinivas Kandagatla 2015-10-26 14:23 ` Srinivas Kandagatla [not found] ` <562E377A.3040604-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2015-10-30 15:42 ` Ariel D'Alessandro 2015-10-30 15:42 ` Ariel D'Alessandro [not found] ` <56338FF4.8050102-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> 2015-10-30 16:00 ` Ezequiel Garcia 2015-10-30 16:00 ` Ezequiel Garcia 2015-11-03 8:20 ` Stefan Wahren 2015-11-03 8:20 ` Stefan Wahren [not found] ` <56386E30.4060905-eS4NqCHxEME@public.gmane.org> 2015-11-16 15:29 ` Ariel D'Alessandro 2015-11-16 15:29 ` Ariel D'Alessandro [not found] ` <5649F64B.5050407-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> 2015-11-17 10:01 ` Stefan Wahren 2015-11-17 10:01 ` Stefan Wahren [not found] ` <1526033037.5264.1447754499675.JavaMail.open-xchange-h4m1HHXQYNFdfASV6gReHsgmgJlYmuWJ@public.gmane.org> 2015-11-17 19:53 ` Ariel D'Alessandro 2015-11-17 19:53 ` Ariel D'Alessandro 2015-10-19 17:32 ` [PATCH v2 3/4] ARM: dts: lpc18xx: add EEPROM memory node Ariel D'Alessandro 2015-10-19 17:32 ` Ariel D'Alessandro [not found] ` <1445275946-32653-4-git-send-email-ariel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> 2015-10-24 21:42 ` Joachim Eastwood 2015-10-24 21:42 ` Joachim Eastwood 2015-10-19 17:32 ` [PATCH v2 4/4] ARM: configs: lpc18xx: enable EEPROM NVMEM driver Ariel D'Alessandro 2015-10-19 17:32 ` Ariel D'Alessandro [not found] ` <1445275946-32653-5-git-send-email-ariel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org> 2015-10-24 21:41 ` Joachim Eastwood 2015-10-24 21:41 ` Joachim Eastwood
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5633665C.5050107@vanguardiasur.com.ar \ --to=ariel-30ulvvutt6g51wmpkgsgjgyuob5fgqpz@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org \ --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \ --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.