Re: [PATCH v2] ARM: dts: imx7d: cl-som-imx7: add basic module support

[Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>]

Hi Shawn,

On 12/14/15 04:43, Shawn Guo wrote:
> On Thu, Dec 10, 2015 at 04:01:37PM +0200, Igor Grinberg wrote:
>> From: Ilya Ledvich <ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>

[...]

>> diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
>> index 34c88b0..30b0ba1 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.txt
>> +++ b/Documentation/devicetree/bindings/arm/fsl.txt
>> @@ -53,6 +53,10 @@ i.MX6 Quad SABRE Automotive Board
>>  Required root node properties:
>>      - compatible = "fsl,imx6q-sabreauto", "fsl,imx6q";
>>  
>> +i.MX7D CL-SOM-iMX7 Board
>> +Required root node properties:
>> +    - compatible = "compulab,cl-som-imx7", "fsl,imx7d";
>> +
> 
> This is not a board produced by FSL, so it should be documented in
> fsl.txt.

You mean _should not_ be documented in fsl.txt, right?
Ok, I have no problem with that, we've just used the same approach OMAP
takes - all the OMAP based boards are documented in the same file:
Documentation/devicetree/bindings/arm/omap/omap.txt

Do you think we should document it in:
Documentation/devicetree/bindings/arm/compulab-boards.txt
(this file should already exist in arm-soc/next/dt)?

> 
>>  Generic i.MX boards
>>  -------------------
>>  
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 30bbc37..83ed521 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -350,6 +350,7 @@ dtb-$(CONFIG_SOC_IMX6SX) += \
>>  dtb-$(CONFIG_SOC_IMX6UL) += \
>>  	imx6ul-14x14-evk.dtb
>>  dtb-$(CONFIG_SOC_IMX7D) += \
>> +	imx7d-cl-som-imx7.dtb \
>>  	imx7d-sdb.dtb
>>  dtb-$(CONFIG_SOC_LS1021A) += \
>>  	ls1021a-qds.dtb \
>> diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
>> new file mode 100644
>> index 0000000..ba05198
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
>> @@ -0,0 +1,150 @@
>> +/*
>> + * Support for CompuLab CL-SOM-iMX7 System-on-Module
>> + *
>> + * Copyright (C) 2015 CompuLab Ltd. - http://www.compulab.co.il/
>> + * Author: Ilya Ledvich <ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
>> + *
>> + * This program is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU General Public License version 2 as published by
>> + * the Free Software Foundation.
>> + */
> 
> GPL/X11 dual licence is generally suggested for newly added dts files,
> as it will let non-Linux OS use them.

I don't remember we've used this one before...
Can you please point to an example?

[...]

>> +&iomuxc {
>> +	cl-som-imx7 {
> 
> Since commit (5fcdf6a7ed95 pinctrl: imx: Allow parsing DT without
> function nodes), this level of container node is not really needed any
> more.

Ok. Will be done for the next version. Thanks!

> 
> Shawn
> 
>> +		pinctrl_i2c2: i2c2grp {
>> +			fsl,pins = <
>> +				MX7D_PAD_I2C2_SDA__I2C2_SDA		0x4000007f
>> +				MX7D_PAD_I2C2_SCL__I2C2_SCL		0x4000007f
>> +			>;
>> +		};
>> +
>> +		pinctrl_uart1: uart1grp {
>> +			fsl,pins = <
>> +				MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX	0x79
>> +				MX7D_PAD_UART1_RX_DATA__UART1_DCE_RX	0x79
>> +			>;
>> +		};
>> +	};
>> +};
>> -- 
>> 2.4.10
>>
>>
> 

-- 
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html