[Qemu-devel] [PATCH] block: add missing call to bdrv_drain_recurse

[Qemu-devel] [PATCH] block: add missing call to bdrv_drain_recurse

[Paolo Bonzini]

This is also needed in bdrv_drain_all, not just in bdrv_drain.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/io.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/io.c b/block/io.c
index 841f5b5..bfe2544 100644
--- a/block/io.c
+++ b/block/io.c
@@ -293,6 +293,7 @@ void bdrv_drain_all(void)
         if (bs->job) {
             block_job_pause(bs->job);
         }
+        bdrv_drain_recurse(bs);
         aio_context_release(aio_context);
 
         if (!g_slist_find(aio_ctxs, aio_context)) {
-- 
2.5.0

Re: [Qemu-devel] [PATCH] block: add missing call to bdrv_drain_recurse

[Fam Zheng]

On Wed, 12/23 11:48, Paolo Bonzini wrote:
> This is also needed in bdrv_drain_all, not just in bdrv_drain.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/io.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block/io.c b/block/io.c
> index 841f5b5..bfe2544 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -293,6 +293,7 @@ void bdrv_drain_all(void)
>          if (bs->job) {
>              block_job_pause(bs->job);
>          }
> +        bdrv_drain_recurse(bs);
>          aio_context_release(aio_context);
>  
>          if (!g_slist_find(aio_ctxs, aio_context)) {
> -- 
> 2.5.0
> 
> 

Reviewed-by: Fam Zheng <famz@redhat.com>

Re: [Qemu-devel] [PATCH] block: add missing call to bdrv_drain_recurse

[Paolo Bonzini]

On 25/12/2015 02:55, Fam Zheng wrote:
> On Wed, 12/23 11:48, Paolo Bonzini wrote:
>> This is also needed in bdrv_drain_all, not just in bdrv_drain.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  block/io.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/block/io.c b/block/io.c
>> index 841f5b5..bfe2544 100644
>> --- a/block/io.c
>> +++ b/block/io.c
>> @@ -293,6 +293,7 @@ void bdrv_drain_all(void)
>>          if (bs->job) {
>>              block_job_pause(bs->job);
>>          }
>> +        bdrv_drain_recurse(bs);
>>          aio_context_release(aio_context);
>>  
>>          if (!g_slist_find(aio_ctxs, aio_context)) {
>> -- 
>> 2.5.0
>>
>>
> 
> Reviewed-by: Fam Zheng <famz@redhat.com>
> 
> 

Ping?

Paolo

Re: [Qemu-devel] [PATCH] block: add missing call to bdrv_drain_recurse

[Paolo Bonzini]

On 11/01/2016 09:32, Paolo Bonzini wrote:
> 
> 
> On 25/12/2015 02:55, Fam Zheng wrote:
>> On Wed, 12/23 11:48, Paolo Bonzini wrote:
>>> This is also needed in bdrv_drain_all, not just in bdrv_drain.
>>>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>>  block/io.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/block/io.c b/block/io.c
>>> index 841f5b5..bfe2544 100644
>>> --- a/block/io.c
>>> +++ b/block/io.c
>>> @@ -293,6 +293,7 @@ void bdrv_drain_all(void)
>>>          if (bs->job) {
>>>              block_job_pause(bs->job);
>>>          }
>>> +        bdrv_drain_recurse(bs);
>>>          aio_context_release(aio_context);
>>>  
>>>          if (!g_slist_find(aio_ctxs, aio_context)) {
>>> -- 
>>> 2.5.0
>>>
>>>
>>
>> Reviewed-by: Fam Zheng <famz@redhat.com>
>>
>>
> 
> Ping?

Ping^2?

Re: [Qemu-devel] [Qemu-block] [PATCH] block: add missing call to bdrv_drain_recurse

[Kevin Wolf]

Am 23.12.2015 um 11:48 hat Paolo Bonzini geschrieben:
> This is also needed in bdrv_drain_all, not just in bdrv_drain.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

Re: [Qemu-devel] [Qemu-block] [PATCH] block: add missing call to bdrv_drain_recurse

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

On Wed, Dec 23, 2015 at 11:48:25AM +0100, Paolo Bonzini wrote:
> This is also needed in bdrv_drain_all, not just in bdrv_drain.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/io.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block/io.c b/block/io.c
> index 841f5b5..bfe2544 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -293,6 +293,7 @@ void bdrv_drain_all(void)
>          if (bs->job) {
>              block_job_pause(bs->job);
>          }
> +        bdrv_drain_recurse(bs);
>          aio_context_release(aio_context);

Applied to my block tree.

Thanks,
Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]