* [PATCH 0/5] arm64: dts: apq8016-sbc dt patches.
@ 2016-01-12 13:45 ` Srinivas Kandagatla
0 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:45 UTC (permalink / raw)
To: andy.gross, linux-arm-msm
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
Srinivas Kandagatla
Hi Andy,
Here are some dt patches which I can go on in next patch cycle.
Most of the patches are to do with adding regulators to apq8016-sbc/db410c.
One patch moves up the sdhci node under soc node and other patch is to add
missing regulators and pinctrl to sdhc_1.
thanks,
srini
Srinivas Kandagatla (5):
arm64: dts: apq8016-sbc: add regulators support
arm64: dts: apq8016-sbc: move sdhci node under soc node
arm64: dts: remove s2 regulator from smd regulators.
arm64: dts: apq8016-sbc: make 1.8v available on LS expansion
arm64: dts: apq8016-sbc: Add real regulators and pinctrl for sdhc
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 160 +++++++++++++++++++++++++++++-
arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 -
2 files changed, 156 insertions(+), 5 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 0/5] arm64: dts: apq8016-sbc dt patches.
@ 2016-01-12 13:45 ` Srinivas Kandagatla
0 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:45 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andy,
Here are some dt patches which I can go on in next patch cycle.
Most of the patches are to do with adding regulators to apq8016-sbc/db410c.
One patch moves up the sdhci node under soc node and other patch is to add
missing regulators and pinctrl to sdhc_1.
thanks,
srini
Srinivas Kandagatla (5):
arm64: dts: apq8016-sbc: add regulators support
arm64: dts: apq8016-sbc: move sdhci node under soc node
arm64: dts: remove s2 regulator from smd regulators.
arm64: dts: apq8016-sbc: make 1.8v available on LS expansion
arm64: dts: apq8016-sbc: Add real regulators and pinctrl for sdhc
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 160 +++++++++++++++++++++++++++++-
arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 -
2 files changed, 156 insertions(+), 5 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support
2016-01-12 13:45 ` Srinivas Kandagatla
@ 2016-01-12 13:46 ` Srinivas Kandagatla
-1 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:46 UTC (permalink / raw)
To: andy.gross, linux-arm-msm
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
Srinivas Kandagatla
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 141 ++++++++++++++++++++++++++++++
1 file changed, 141 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index db17c5d..f6cd323 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -30,6 +30,147 @@
stdout-path = "serial0";
};
+ smd {
+ rpm {
+ rpm_requests {
+ pm8916-regulators {
+
+ vdd_l1_l2_l3-supply = <&pm8916_s3>;
+ vdd_l5-supply = <&pm8916_s3>;
+ vdd_l4_l5_l6-supply = <&pm8916_s4>;
+ vdd_l7-supply = <&pm8916_s4>;
+
+ s1 {
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <1562000>;
+
+ };
+
+ s3 {
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <1562000>;
+
+ };
+
+ s4 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ l1 {
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <1525000>;
+
+ };
+
+ l2 {
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <1525000>;
+
+ };
+
+ l3 {
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <1525000>;
+
+ };
+
+ l4 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l5 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l6 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l7 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l8 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l9 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l10 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l11 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l12 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l13 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l14 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l15 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+ };
+
+ l16 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l17 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l18 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+ };
+ };
+ };
+ };
+
soc {
serial@78af000 {
label = "LS-UART0";
--
1.9.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support
@ 2016-01-12 13:46 ` Srinivas Kandagatla
0 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:46 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 141 ++++++++++++++++++++++++++++++
1 file changed, 141 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index db17c5d..f6cd323 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -30,6 +30,147 @@
stdout-path = "serial0";
};
+ smd {
+ rpm {
+ rpm_requests {
+ pm8916-regulators {
+
+ vdd_l1_l2_l3-supply = <&pm8916_s3>;
+ vdd_l5-supply = <&pm8916_s3>;
+ vdd_l4_l5_l6-supply = <&pm8916_s4>;
+ vdd_l7-supply = <&pm8916_s4>;
+
+ s1 {
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <1562000>;
+
+ };
+
+ s3 {
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <1562000>;
+
+ };
+
+ s4 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ l1 {
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <1525000>;
+
+ };
+
+ l2 {
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <1525000>;
+
+ };
+
+ l3 {
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <1525000>;
+
+ };
+
+ l4 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l5 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l6 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l7 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l8 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l9 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l10 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l11 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l12 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l13 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l14 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l15 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+ };
+
+ l16 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l17 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+
+ l18 {
+ regulator-min-microvolt = <1750000>;
+ regulator-max-microvolt = <3337000>;
+
+ };
+ };
+ };
+ };
+ };
+
soc {
serial at 78af000 {
label = "LS-UART0";
--
1.9.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
2016-01-12 13:45 ` Srinivas Kandagatla
@ 2016-01-12 13:46 ` Srinivas Kandagatla
-1 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:46 UTC (permalink / raw)
To: andy.gross, linux-arm-msm
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
Srinivas Kandagatla
To be consistent with other nodes move sdhci node under the soc node,
rather than using lable references.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index f6cd323..b635149 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -268,9 +268,9 @@
default-state = "off";
};
};
- };
-};
-&sdhc_1 {
- status = "okay";
+ sdhci@07824000 {
+ status = "okay";
+ };
+ };
};
--
1.9.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
@ 2016-01-12 13:46 ` Srinivas Kandagatla
0 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:46 UTC (permalink / raw)
To: linux-arm-kernel
To be consistent with other nodes move sdhci node under the soc node,
rather than using lable references.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index f6cd323..b635149 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -268,9 +268,9 @@
default-state = "off";
};
};
- };
-};
-&sdhc_1 {
- status = "okay";
+ sdhci at 07824000 {
+ status = "okay";
+ };
+ };
};
--
1.9.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 3/5] arm64: dts: remove s2 regulator from smd regulators.
2016-01-12 13:45 ` Srinivas Kandagatla
@ 2016-01-12 13:47 ` Srinivas Kandagatla
-1 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:47 UTC (permalink / raw)
To: andy.gross, linux-arm-msm
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
Srinivas Kandagatla
s2 is spmi controller regulator on msm8916 according to downstream 3.10
kernel, so remove it from the dt to avoid confusion an use of it.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 9153214..405ea67 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -519,7 +519,6 @@
compatible = "qcom,rpm-pm8916-regulators";
pm8916_s1: s1 {};
- pm8916_s2: s2 {};
pm8916_s3: s3 {};
pm8916_s4: s4 {};
--
1.9.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 3/5] arm64: dts: remove s2 regulator from smd regulators.
@ 2016-01-12 13:47 ` Srinivas Kandagatla
0 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:47 UTC (permalink / raw)
To: linux-arm-kernel
s2 is spmi controller regulator on msm8916 according to downstream 3.10
kernel, so remove it from the dt to avoid confusion an use of it.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 9153214..405ea67 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -519,7 +519,6 @@
compatible = "qcom,rpm-pm8916-regulators";
pm8916_s1: s1 {};
- pm8916_s2: s2 {};
pm8916_s3: s3 {};
pm8916_s4: s4 {};
--
1.9.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 4/5] arm64: dts: apq8016-sbc: make 1.8v available on LS expansion
2016-01-12 13:45 ` Srinivas Kandagatla
@ 2016-01-12 13:47 ` Srinivas Kandagatla
-1 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:47 UTC (permalink / raw)
To: andy.gross, linux-arm-msm
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
Srinivas Kandagatla
96boards mezzanine boards on LS expansion require 1.8v as per 96boards
specifications, so enable the corresponding regulators and make them
always-on.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index b635149..b87a650 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -143,10 +143,15 @@
regulator-max-microvolt = <3337000>;
};
-
+
+ /**
+ * 1.8v required on LS expansion
+ * for mezzanine boards
+ */
l15 {
regulator-min-microvolt = <1750000>;
regulator-max-microvolt = <3337000>;
+ regulator-always-on;
};
l16 {
--
1.9.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 4/5] arm64: dts: apq8016-sbc: make 1.8v available on LS expansion
@ 2016-01-12 13:47 ` Srinivas Kandagatla
0 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:47 UTC (permalink / raw)
To: linux-arm-kernel
96boards mezzanine boards on LS expansion require 1.8v as per 96boards
specifications, so enable the corresponding regulators and make them
always-on.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index b635149..b87a650 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -143,10 +143,15 @@
regulator-max-microvolt = <3337000>;
};
-
+
+ /**
+ * 1.8v required on LS expansion
+ * for mezzanine boards
+ */
l15 {
regulator-min-microvolt = <1750000>;
regulator-max-microvolt = <3337000>;
+ regulator-always-on;
};
l16 {
--
1.9.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 5/5] arm64: dts: apq8016-sbc: Add real regulators and pinctrl for sdhc
2016-01-12 13:45 ` Srinivas Kandagatla
@ 2016-01-12 13:47 ` Srinivas Kandagatla
-1 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:47 UTC (permalink / raw)
To: andy.gross, linux-arm-msm
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
Srinivas Kandagatla
This patch adds real regulators and pinctrl nodes for sdhc_1.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index b87a650..7d3ba19 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -275,6 +275,12 @@
};
sdhci@07824000 {
+ vmmc-supply = <&pm8916_l8>;
+ vqmmc-supply = <&pm8916_l5>;
+
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&sdc1_clk_on &sdc1_cmd_on &sdc1_data_on>;
+ pinctrl-1 = <&sdc1_clk_off &sdc1_cmd_off &sdc1_data_off>;
status = "okay";
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [PATCH 5/5] arm64: dts: apq8016-sbc: Add real regulators and pinctrl for sdhc
@ 2016-01-12 13:47 ` Srinivas Kandagatla
0 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 13:47 UTC (permalink / raw)
To: linux-arm-kernel
This patch adds real regulators and pinctrl nodes for sdhc_1.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
index b87a650..7d3ba19 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
@@ -275,6 +275,12 @@
};
sdhci at 07824000 {
+ vmmc-supply = <&pm8916_l8>;
+ vqmmc-supply = <&pm8916_l5>;
+
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&sdc1_clk_on &sdc1_cmd_on &sdc1_data_on>;
+ pinctrl-1 = <&sdc1_clk_off &sdc1_cmd_off &sdc1_data_off>;
status = "okay";
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support
2016-01-12 13:46 ` Srinivas Kandagatla
@ 2016-01-12 13:59 ` Arnd Bergmann
-1 siblings, 0 replies; 27+ messages in thread
From: Arnd Bergmann @ 2016-01-12 13:59 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: andy.gross, linux-arm-msm, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel
On Tuesday 12 January 2016 13:46:32 Srinivas Kandagatla wrote:
> };
>
> + smd {
> + rpm {
> + rpm-requests {
> + pm8916-regulators {
> +
> + vdd_l1_l2_l3-supply = <&pm8916_s3>;
> + vdd_l5-supply = <&pm8916_s3>;
> + vdd_l4_l5_l6-supply = <&pm8916_s4>;
> + vdd_l7-supply = <&pm8916_s4>;
> +
>
If you're nested this deeply, you should consider using labels, e.g.
/ {
...
smd {
rpm {
rpm-requests {
regulators: pm8916-regulators {
};
};
};
};
...
};
®ulators {
vdd_l1_l2_l3-supply = <&pm8916_s3>;
vdd_l5-supply = <&pm8916_s3>;
vdd_l4_l5_l6-supply = <&pm8916_s4>;
vdd_l7-supply = <&pm8916_s4>;
s1 {
regulator-min-microvolt = <375000>;
regulator-max-microvolt = <1562000>;
};
s3 {
regulator-min-microvolt = <375000>;
regulator-max-microvolt = <1562000>;
};
...
};
btw, it seems odd to me that all those nodes under 'smd'
have names but no addresses.
Arnd
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support
@ 2016-01-12 13:59 ` Arnd Bergmann
0 siblings, 0 replies; 27+ messages in thread
From: Arnd Bergmann @ 2016-01-12 13:59 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 12 January 2016 13:46:32 Srinivas Kandagatla wrote:
> };
>
> + smd {
> + rpm {
> + rpm-requests {
> + pm8916-regulators {
> +
> + vdd_l1_l2_l3-supply = <&pm8916_s3>;
> + vdd_l5-supply = <&pm8916_s3>;
> + vdd_l4_l5_l6-supply = <&pm8916_s4>;
> + vdd_l7-supply = <&pm8916_s4>;
> +
>
If you're nested this deeply, you should consider using labels, e.g.
/ {
...
smd {
rpm {
rpm-requests {
regulators: pm8916-regulators {
};
};
};
};
...
};
®ulators {
vdd_l1_l2_l3-supply = <&pm8916_s3>;
vdd_l5-supply = <&pm8916_s3>;
vdd_l4_l5_l6-supply = <&pm8916_s4>;
vdd_l7-supply = <&pm8916_s4>;
s1 {
regulator-min-microvolt = <375000>;
regulator-max-microvolt = <1562000>;
};
s3 {
regulator-min-microvolt = <375000>;
regulator-max-microvolt = <1562000>;
};
...
};
btw, it seems odd to me that all those nodes under 'smd'
have names but no addresses.
Arnd
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
2016-01-12 13:46 ` Srinivas Kandagatla
@ 2016-01-12 14:00 ` Arnd Bergmann
-1 siblings, 0 replies; 27+ messages in thread
From: Arnd Bergmann @ 2016-01-12 14:00 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Srinivas Kandagatla, andy.gross, linux-arm-msm, devicetree,
Rob Herring, linux-kernel
On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> To be consistent with other nodes move sdhci node under the soc node,
> rather than using lable references.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
Maybe remove the label as well if you are no longer using it?
Arnd
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
@ 2016-01-12 14:00 ` Arnd Bergmann
0 siblings, 0 replies; 27+ messages in thread
From: Arnd Bergmann @ 2016-01-12 14:00 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> To be consistent with other nodes move sdhci node under the soc node,
> rather than using lable references.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
Maybe remove the label as well if you are no longer using it?
Arnd
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
2016-01-12 14:00 ` Arnd Bergmann
@ 2016-01-12 14:18 ` Srinivas Kandagatla
-1 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 14:18 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel
Cc: andy.gross, linux-arm-msm, devicetree, Rob Herring, linux-kernel,
Stephen Boyd
On 12/01/16 14:00, Arnd Bergmann wrote:
> On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
>> To be consistent with other nodes move sdhci node under the soc node,
>> rather than using lable references.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>
> Maybe remove the label as well if you are no longer using it?
Label "sdhc_1" in this case is used in aliases node.
>
My understanding so far was qcom specific dt want to use hierarchical dt
nodes in the board files, but this brings the question of should we
delete all the unused labels.
IMO, some unused labels are harmless and would give more consistency to
the reader, removing them might not add great value.
Andy/Stephen, any comments?
--srini
> Arnd
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
@ 2016-01-12 14:18 ` Srinivas Kandagatla
0 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 14:18 UTC (permalink / raw)
To: linux-arm-kernel
On 12/01/16 14:00, Arnd Bergmann wrote:
> On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
>> To be consistent with other nodes move sdhci node under the soc node,
>> rather than using lable references.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>
>
> Maybe remove the label as well if you are no longer using it?
Label "sdhc_1" in this case is used in aliases node.
>
My understanding so far was qcom specific dt want to use hierarchical dt
nodes in the board files, but this brings the question of should we
delete all the unused labels.
IMO, some unused labels are harmless and would give more consistency to
the reader, removing them might not add great value.
Andy/Stephen, any comments?
--srini
> Arnd
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support
2016-01-12 13:59 ` Arnd Bergmann
@ 2016-01-12 14:30 ` Srinivas Kandagatla
-1 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 14:30 UTC (permalink / raw)
To: Arnd Bergmann
Cc: andy.gross, linux-arm-msm, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel
On 12/01/16 13:59, Arnd Bergmann wrote:
> On Tuesday 12 January 2016 13:46:32 Srinivas Kandagatla wrote:
>> };
>>
>> + smd {
>> + rpm {
>> + rpm-requests {
>> + pm8916-regulators {
>> +
>> + vdd_l1_l2_l3-supply = <&pm8916_s3>;
>> + vdd_l5-supply = <&pm8916_s3>;
>> + vdd_l4_l5_l6-supply = <&pm8916_s4>;
>> + vdd_l7-supply = <&pm8916_s4>;
>> +
>>
>
> If you're nested this deeply, you should consider using labels, e.g.
>
Labels are good and works for me.
Stephen/Andy are you ok to use labels for such deeply nested nodes in
board dts?
> / {
> ...
>
> smd {
> rpm {
> rpm-requests {
> regulators: pm8916-regulators {
>
> };
> };
> };
> };
>
> ...
> };
>
>
> ®ulators {
> vdd_l1_l2_l3-supply = <&pm8916_s3>;
> vdd_l5-supply = <&pm8916_s3>;
> vdd_l4_l5_l6-supply = <&pm8916_s4>;
> vdd_l7-supply = <&pm8916_s4>;
>
> s1 {
> regulator-min-microvolt = <375000>;
> regulator-max-microvolt = <1562000>;
> };
>
> s3 {
> regulator-min-microvolt = <375000>;
> regulator-max-microvolt = <1562000>;
> };
>
> ...
> };
>
> btw, it seems odd to me that all those nodes under 'smd'
> have names but no addresses.
These regulators are identified by the node names, and have no addresses
associated with it as control goes over SMD based IPC to the rpm.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.txt?id=refs/tags/next-20160112
--srini
>
> Arnd
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support
@ 2016-01-12 14:30 ` Srinivas Kandagatla
0 siblings, 0 replies; 27+ messages in thread
From: Srinivas Kandagatla @ 2016-01-12 14:30 UTC (permalink / raw)
To: linux-arm-kernel
On 12/01/16 13:59, Arnd Bergmann wrote:
> On Tuesday 12 January 2016 13:46:32 Srinivas Kandagatla wrote:
>> };
>>
>> + smd {
>> + rpm {
>> + rpm-requests {
>> + pm8916-regulators {
>> +
>> + vdd_l1_l2_l3-supply = <&pm8916_s3>;
>> + vdd_l5-supply = <&pm8916_s3>;
>> + vdd_l4_l5_l6-supply = <&pm8916_s4>;
>> + vdd_l7-supply = <&pm8916_s4>;
>> +
>>
>
> If you're nested this deeply, you should consider using labels, e.g.
>
Labels are good and works for me.
Stephen/Andy are you ok to use labels for such deeply nested nodes in
board dts?
> / {
> ...
>
> smd {
> rpm {
> rpm-requests {
> regulators: pm8916-regulators {
>
> };
> };
> };
> };
>
> ...
> };
>
>
> ®ulators {
> vdd_l1_l2_l3-supply = <&pm8916_s3>;
> vdd_l5-supply = <&pm8916_s3>;
> vdd_l4_l5_l6-supply = <&pm8916_s4>;
> vdd_l7-supply = <&pm8916_s4>;
>
> s1 {
> regulator-min-microvolt = <375000>;
> regulator-max-microvolt = <1562000>;
> };
>
> s3 {
> regulator-min-microvolt = <375000>;
> regulator-max-microvolt = <1562000>;
> };
>
> ...
> };
>
> btw, it seems odd to me that all those nodes under 'smd'
> have names but no addresses.
These regulators are identified by the node names, and have no addresses
associated with it as control goes over SMD based IPC to the rpm.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.txt?id=refs/tags/next-20160112
--srini
>
> Arnd
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
2016-01-12 14:18 ` Srinivas Kandagatla
@ 2016-01-12 14:49 ` Arnd Bergmann
-1 siblings, 0 replies; 27+ messages in thread
From: Arnd Bergmann @ 2016-01-12 14:49 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: linux-arm-kernel, andy.gross, linux-arm-msm, devicetree,
Rob Herring, linux-kernel, Stephen Boyd
On Tuesday 12 January 2016 14:18:53 Srinivas Kandagatla wrote:
> On 12/01/16 14:00, Arnd Bergmann wrote:
> > On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> >> To be consistent with other nodes move sdhci node under the soc node,
> >> rather than using lable references.
> >>
> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>
> >
> > Maybe remove the label as well if you are no longer using it?
> Label "sdhc_1" in this case is used in aliases node.
>
Ok, nevermind then.
> My understanding so far was qcom specific dt want to use hierarchical dt
> nodes in the board files, but this brings the question of should we
> delete all the unused labels.
>
> IMO, some unused labels are harmless and would give more consistency to
> the reader, removing them might not add great value.
Fair enough.
Arnd
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
@ 2016-01-12 14:49 ` Arnd Bergmann
0 siblings, 0 replies; 27+ messages in thread
From: Arnd Bergmann @ 2016-01-12 14:49 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 12 January 2016 14:18:53 Srinivas Kandagatla wrote:
> On 12/01/16 14:00, Arnd Bergmann wrote:
> > On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> >> To be consistent with other nodes move sdhci node under the soc node,
> >> rather than using lable references.
> >>
> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>
> >
> > Maybe remove the label as well if you are no longer using it?
> Label "sdhc_1" in this case is used in aliases node.
>
Ok, nevermind then.
> My understanding so far was qcom specific dt want to use hierarchical dt
> nodes in the board files, but this brings the question of should we
> delete all the unused labels.
>
> IMO, some unused labels are harmless and would give more consistency to
> the reader, removing them might not add great value.
Fair enough.
Arnd
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support
2016-01-12 14:30 ` Srinivas Kandagatla
@ 2016-01-12 22:22 ` Andy Gross
-1 siblings, 0 replies; 27+ messages in thread
From: Andy Gross @ 2016-01-12 22:22 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Arnd Bergmann, linux-arm-msm, Rob Herring, devicetree,
linux-arm-kernel, linux-kernel
On Tue, Jan 12, 2016 at 02:30:34PM +0000, Srinivas Kandagatla wrote:
>
>
> On 12/01/16 13:59, Arnd Bergmann wrote:
> >On Tuesday 12 January 2016 13:46:32 Srinivas Kandagatla wrote:
> >> };
> >>
> >>+ smd {
> >>+ rpm {
> >>+ rpm-requests {
> >>+ pm8916-regulators {
> >>+
> >>+ vdd_l1_l2_l3-supply = <&pm8916_s3>;
> >>+ vdd_l5-supply = <&pm8916_s3>;
> >>+ vdd_l4_l5_l6-supply = <&pm8916_s4>;
> >>+ vdd_l7-supply = <&pm8916_s4>;
> >>+
> >>
> >
> >If you're nested this deeply, you should consider using labels, e.g.
> >
> Labels are good and works for me.
>
> Stephen/Andy are you ok to use labels for such deeply nested nodes in board
> dts?
I tend to agree with Arnd. I am ok with using labels.
<snip>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support
@ 2016-01-12 22:22 ` Andy Gross
0 siblings, 0 replies; 27+ messages in thread
From: Andy Gross @ 2016-01-12 22:22 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 12, 2016 at 02:30:34PM +0000, Srinivas Kandagatla wrote:
>
>
> On 12/01/16 13:59, Arnd Bergmann wrote:
> >On Tuesday 12 January 2016 13:46:32 Srinivas Kandagatla wrote:
> >> };
> >>
> >>+ smd {
> >>+ rpm {
> >>+ rpm-requests {
> >>+ pm8916-regulators {
> >>+
> >>+ vdd_l1_l2_l3-supply = <&pm8916_s3>;
> >>+ vdd_l5-supply = <&pm8916_s3>;
> >>+ vdd_l4_l5_l6-supply = <&pm8916_s4>;
> >>+ vdd_l7-supply = <&pm8916_s4>;
> >>+
> >>
> >
> >If you're nested this deeply, you should consider using labels, e.g.
> >
> Labels are good and works for me.
>
> Stephen/Andy are you ok to use labels for such deeply nested nodes in board
> dts?
I tend to agree with Arnd. I am ok with using labels.
<snip>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
2016-01-12 14:18 ` Srinivas Kandagatla
(?)
@ 2016-01-12 22:25 ` Andy Gross
-1 siblings, 0 replies; 27+ messages in thread
From: Andy Gross @ 2016-01-12 22:25 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Arnd Bergmann, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, Rob Herring,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Stephen Boyd
On Tue, Jan 12, 2016 at 02:18:53PM +0000, Srinivas Kandagatla wrote:
>
>
> On 12/01/16 14:00, Arnd Bergmann wrote:
> >On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> >>To be consistent with other nodes move sdhci node under the soc node,
> >>rather than using lable references.
> >>
> >>Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> >>
> >
> >Maybe remove the label as well if you are no longer using it?
> Label "sdhc_1" in this case is used in aliases node.
>
> >
> My understanding so far was qcom specific dt want to use hierarchical dt
> nodes in the board files, but this brings the question of should we delete
> all the unused labels.
>
> IMO, some unused labels are harmless and would give more consistency to the
> reader, removing them might not add great value.
>
> Andy/Stephen, any comments?
I tend to lean towards leaving the labels in. But at the same time we don't
want to get cluttered with unused labels. That said, perhaps If the label
makes things more understandable, then leave them in. Otherwise, they really
have no use.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
@ 2016-01-12 22:25 ` Andy Gross
0 siblings, 0 replies; 27+ messages in thread
From: Andy Gross @ 2016-01-12 22:25 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Arnd Bergmann, linux-arm-kernel, linux-arm-msm, devicetree,
Rob Herring, linux-kernel, Stephen Boyd
On Tue, Jan 12, 2016 at 02:18:53PM +0000, Srinivas Kandagatla wrote:
>
>
> On 12/01/16 14:00, Arnd Bergmann wrote:
> >On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> >>To be consistent with other nodes move sdhci node under the soc node,
> >>rather than using lable references.
> >>
> >>Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>
> >
> >Maybe remove the label as well if you are no longer using it?
> Label "sdhc_1" in this case is used in aliases node.
>
> >
> My understanding so far was qcom specific dt want to use hierarchical dt
> nodes in the board files, but this brings the question of should we delete
> all the unused labels.
>
> IMO, some unused labels are harmless and would give more consistency to the
> reader, removing them might not add great value.
>
> Andy/Stephen, any comments?
I tend to lean towards leaving the labels in. But at the same time we don't
want to get cluttered with unused labels. That said, perhaps If the label
makes things more understandable, then leave them in. Otherwise, they really
have no use.
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node
@ 2016-01-12 22:25 ` Andy Gross
0 siblings, 0 replies; 27+ messages in thread
From: Andy Gross @ 2016-01-12 22:25 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 12, 2016 at 02:18:53PM +0000, Srinivas Kandagatla wrote:
>
>
> On 12/01/16 14:00, Arnd Bergmann wrote:
> >On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> >>To be consistent with other nodes move sdhci node under the soc node,
> >>rather than using lable references.
> >>
> >>Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>
> >
> >Maybe remove the label as well if you are no longer using it?
> Label "sdhc_1" in this case is used in aliases node.
>
> >
> My understanding so far was qcom specific dt want to use hierarchical dt
> nodes in the board files, but this brings the question of should we delete
> all the unused labels.
>
> IMO, some unused labels are harmless and would give more consistency to the
> reader, removing them might not add great value.
>
> Andy/Stephen, any comments?
I tend to lean towards leaving the labels in. But at the same time we don't
want to get cluttered with unused labels. That said, perhaps If the label
makes things more understandable, then leave them in. Otherwise, they really
have no use.
^ permalink raw reply [flat|nested] 27+ messages in thread
end of thread, other threads:[~2016-01-12 22:26 UTC | newest]
Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-12 13:45 [PATCH 0/5] arm64: dts: apq8016-sbc dt patches Srinivas Kandagatla
2016-01-12 13:45 ` Srinivas Kandagatla
2016-01-12 13:46 ` [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support Srinivas Kandagatla
2016-01-12 13:46 ` Srinivas Kandagatla
2016-01-12 13:59 ` Arnd Bergmann
2016-01-12 13:59 ` Arnd Bergmann
2016-01-12 14:30 ` Srinivas Kandagatla
2016-01-12 14:30 ` Srinivas Kandagatla
2016-01-12 22:22 ` Andy Gross
2016-01-12 22:22 ` Andy Gross
2016-01-12 13:46 ` [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node Srinivas Kandagatla
2016-01-12 13:46 ` Srinivas Kandagatla
2016-01-12 14:00 ` Arnd Bergmann
2016-01-12 14:00 ` Arnd Bergmann
2016-01-12 14:18 ` Srinivas Kandagatla
2016-01-12 14:18 ` Srinivas Kandagatla
2016-01-12 14:49 ` Arnd Bergmann
2016-01-12 14:49 ` Arnd Bergmann
[not found] ` <56950B4D.3030707-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-01-12 22:25 ` Andy Gross
2016-01-12 22:25 ` Andy Gross
2016-01-12 22:25 ` Andy Gross
2016-01-12 13:47 ` [PATCH 3/5] arm64: dts: remove s2 regulator from smd regulators Srinivas Kandagatla
2016-01-12 13:47 ` Srinivas Kandagatla
2016-01-12 13:47 ` [PATCH 4/5] arm64: dts: apq8016-sbc: make 1.8v available on LS expansion Srinivas Kandagatla
2016-01-12 13:47 ` Srinivas Kandagatla
2016-01-12 13:47 ` [PATCH 5/5] arm64: dts: apq8016-sbc: Add real regulators and pinctrl for sdhc Srinivas Kandagatla
2016-01-12 13:47 ` Srinivas Kandagatla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.