From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Cc: "magnus.damm@gmail.com" <magnus.damm@gmail.com>, "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "horms@verge.net.au" <horms@verge.net.au>, "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "pawel.moll@arm.com" <pawel.moll@arm.com>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>, "galak@codeaurora.org" <galak@codeaurora.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org> Subject: Re: [PATCH] ARM: dts: porter: add MAX3355 support Date: Mon, 1 Feb 2016 22:00:55 +0300 [thread overview] Message-ID: <56AFAB67.20404@cogentembedded.com> (raw) In-Reply-To: <56AF9BE8.4020002@cogentembedded.com> On 02/01/2016 08:54 PM, Sergei Shtylyov wrote: >>>>>> From: linux-renesas-soc-owner@vger.kernel.org >>>>>> [mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Sergei >>>>>> Shtylyov >>>>>> Sent: Wednesday, January 27, 2016 7:14 AM >>>>>> >>>>>> Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings >>>>>> are upstream along with the 'extcon' hook in the Renesas USBHS driver, we >>>>>> can add MAX3355 device node to the Porter device tree and properly refer >>>>>> to it from the USBHS node instead of using "renesas,enable-gpio" property >>>>>> which only allowed checking the USB ID pin at the driver probe time; now >>>>>> this pin's state can be monitored dynamically! >>>>>> >>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>>> >>>>> I tested this patch on Porter, but interrupt of "usb-otg" didn't happened >>>>> even if I connected/disconnected a usb convert cable (usb micro-ab to A). >>>>> Remarks: I confirmed that the usb convert cable worked correctly on other >>>>> board. >>>> >>>> I guess I have the same cable >>> >>> No, I have mini-AB connector here and hence my cable is mini-AB to A. >> >> I checked Porter specification and then I found 2 specifications exist... > > I've looked thru my schematics files and found 3: Rev. 1.1 Update Version > 2, "PORTER_2" Rev. 3.0 Preliminary, and "PORTER_C" Rev. 3.0 Release version! > I'm not sure which of the last 2 should be considered final... Now I've found 5 versions of the Porter schematics... :-) >> Porter "B" : mini AB connecter and Max3355 is on the board. >> Porter "C" : micro AB connect and Max3355 is not on the board. (Select >> host/peripheral by a jumper.) > > Yeah, seeing JP13 in the PORTER_C schematics. > >> I guess that your current target is "B". > > If not earlier. It actually has "Henninger B REV2" printed on it and > "Porter PCB 1 R3" on a pasted sticker. > >> If so, I think this patch is acceptable. > > I'm not so sure now... My boss told me PORTER_C is a final version, so this patch isn't needed. But then another patch is needed instead: to remove "renesas,enable-gpio" prop from the HS-USB device node... >> Best regards, >> Yoshihiro Shimoda MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: dts: porter: add MAX3355 support Date: Mon, 1 Feb 2016 22:00:55 +0300 [thread overview] Message-ID: <56AFAB67.20404@cogentembedded.com> (raw) In-Reply-To: <56AF9BE8.4020002@cogentembedded.com> On 02/01/2016 08:54 PM, Sergei Shtylyov wrote: >>>>>> From: linux-renesas-soc-owner at vger.kernel.org >>>>>> [mailto:linux-renesas-soc-owner at vger.kernel.org] On Behalf Of Sergei >>>>>> Shtylyov >>>>>> Sent: Wednesday, January 27, 2016 7:14 AM >>>>>> >>>>>> Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings >>>>>> are upstream along with the 'extcon' hook in the Renesas USBHS driver, we >>>>>> can add MAX3355 device node to the Porter device tree and properly refer >>>>>> to it from the USBHS node instead of using "renesas,enable-gpio" property >>>>>> which only allowed checking the USB ID pin at the driver probe time; now >>>>>> this pin's state can be monitored dynamically! >>>>>> >>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>>> >>>>> I tested this patch on Porter, but interrupt of "usb-otg" didn't happened >>>>> even if I connected/disconnected a usb convert cable (usb micro-ab to A). >>>>> Remarks: I confirmed that the usb convert cable worked correctly on other >>>>> board. >>>> >>>> I guess I have the same cable >>> >>> No, I have mini-AB connector here and hence my cable is mini-AB to A. >> >> I checked Porter specification and then I found 2 specifications exist... > > I've looked thru my schematics files and found 3: Rev. 1.1 Update Version > 2, "PORTER_2" Rev. 3.0 Preliminary, and "PORTER_C" Rev. 3.0 Release version! > I'm not sure which of the last 2 should be considered final... Now I've found 5 versions of the Porter schematics... :-) >> Porter "B" : mini AB connecter and Max3355 is on the board. >> Porter "C" : micro AB connect and Max3355 is not on the board. (Select >> host/peripheral by a jumper.) > > Yeah, seeing JP13 in the PORTER_C schematics. > >> I guess that your current target is "B". > > If not earlier. It actually has "Henninger B REV2" printed on it and > "Porter PCB 1 R3" on a pasted sticker. > >> If so, I think this patch is acceptable. > > I'm not so sure now... My boss told me PORTER_C is a final version, so this patch isn't needed. But then another patch is needed instead: to remove "renesas,enable-gpio" prop from the HS-USB device node... >> Best regards, >> Yoshihiro Shimoda MBR, Sergei
next prev parent reply other threads:[~2016-02-01 19:00 UTC|newest] Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-10-08 19:53 [PATCH v4 0/2] Add HS-USB device tree support for R8A7790/Lager board Sergei Shtylyov 2014-10-08 19:53 ` Sergei Shtylyov 2014-10-08 19:53 ` Sergei Shtylyov 2014-10-08 19:54 ` [PATCH v4 1/2] ARM: shmobile: r8a7790: add HS-USB device node Sergei Shtylyov 2014-10-08 19:54 ` Sergei Shtylyov 2014-10-08 19:54 ` Sergei Shtylyov 2014-10-08 19:55 ` [PATCH v4 2/2] ARM: shmobile: lager: enable HS-USB Sergei Shtylyov 2014-10-08 19:55 ` Sergei Shtylyov 2014-10-08 19:55 ` Sergei Shtylyov 2014-10-24 5:09 ` [PATCH v4 0/2] Add HS-USB device tree support for R8A7790/Lager board Simon Horman 2014-10-24 5:09 ` Simon Horman 2014-10-24 5:09 ` Simon Horman 2014-10-24 5:22 ` Yoshihiro Shimoda 2014-10-24 5:22 ` Yoshihiro Shimoda 2014-10-24 5:22 ` Yoshihiro Shimoda 2015-09-16 23:53 ` [PATCH] ARM: shmobile: r8a7794: add HS-USB DT support Sergei Shtylyov 2015-09-16 23:53 ` Sergei Shtylyov 2015-09-16 23:53 ` Sergei Shtylyov 2015-10-05 3:02 ` Simon Horman 2015-10-05 3:02 ` Simon Horman 2015-10-05 3:02 ` Simon Horman 2015-10-14 19:35 ` [PATCH] ARM: shmobile: porter: " Sergei Shtylyov 2015-10-14 19:35 ` Sergei Shtylyov 2015-10-14 19:35 ` Sergei Shtylyov 2015-10-15 0:18 ` Simon Horman 2015-10-15 0:18 ` Simon Horman 2015-10-15 0:18 ` Simon Horman 2015-10-15 10:27 ` Sergei Shtylyov 2015-10-15 10:27 ` Sergei Shtylyov 2015-10-15 10:27 ` Sergei Shtylyov 2015-10-27 21:03 ` [PATCH] ARM: shmobile: porter: add CAN0 " Sergei Shtylyov 2015-10-27 21:03 ` Sergei Shtylyov 2015-10-27 21:03 ` Sergei Shtylyov 2015-10-27 22:41 ` Simon Horman 2015-10-27 22:41 ` Simon Horman 2015-10-27 22:41 ` Simon Horman 2015-10-27 22:56 ` Sergei Shtylyov 2015-10-27 22:56 ` Sergei Shtylyov 2015-10-27 22:56 ` Sergei Shtylyov 2015-12-24 22:45 ` [PATCH] ARM: shmobile: porter: add DU " Sergei Shtylyov 2015-12-24 22:45 ` Sergei Shtylyov 2015-12-24 22:45 ` Sergei Shtylyov 2015-12-28 5:29 ` Simon Horman 2015-12-28 5:29 ` Simon Horman 2015-12-28 5:29 ` Simon Horman 2015-12-28 14:35 ` Sergei Shtylyov 2015-12-28 14:35 ` Sergei Shtylyov 2015-12-28 14:35 ` Sergei Shtylyov 2015-12-28 21:43 ` Simon Horman 2015-12-28 21:43 ` Simon Horman 2015-12-28 21:43 ` Simon Horman 2016-01-12 23:06 ` [PATCH] ARM: shmobile: silk: " Sergei Shtylyov 2016-01-12 23:06 ` Sergei Shtylyov 2016-01-12 23:06 ` Sergei Shtylyov 2016-01-18 1:41 ` Simon Horman 2016-01-18 1:41 ` Simon Horman 2016-01-18 1:41 ` Simon Horman 2016-01-21 22:36 ` [PATCH] ARM: dts: porter: add sound support Sergei Shtylyov 2016-01-21 22:36 ` Sergei Shtylyov 2016-01-25 0:35 ` Kuninori Morimoto 2016-01-25 0:35 ` Kuninori Morimoto 2016-01-25 0:35 ` Kuninori Morimoto 2016-01-26 0:43 ` Simon Horman 2016-01-26 0:43 ` Simon Horman 2016-01-26 14:31 ` Sergei Shtylyov 2016-01-26 14:31 ` Sergei Shtylyov 2016-01-26 22:14 ` [PATCH] ARM: dts: porter: add MAX3355 support Sergei Shtylyov 2016-01-26 22:14 ` Sergei Shtylyov 2016-01-28 5:49 ` Yoshihiro Shimoda 2016-01-28 5:49 ` Yoshihiro Shimoda 2016-01-29 20:28 ` Sergei Shtylyov 2016-01-29 20:28 ` Sergei Shtylyov 2016-01-29 20:49 ` Sergei Shtylyov 2016-01-29 20:49 ` Sergei Shtylyov 2016-02-01 11:17 ` Yoshihiro Shimoda 2016-02-01 11:17 ` Yoshihiro Shimoda 2016-02-01 17:54 ` Sergei Shtylyov 2016-02-01 17:54 ` Sergei Shtylyov 2016-02-01 19:00 ` Sergei Shtylyov [this message] 2016-02-01 19:00 ` Sergei Shtylyov 2016-02-15 1:45 ` Simon Horman 2016-02-15 1:45 ` Simon Horman 2016-02-15 10:59 ` Sergei Shtylyov 2016-02-15 10:59 ` Sergei Shtylyov 2016-02-11 20:26 ` [PATCH] ARM: dts: silk: add sound support Sergei Shtylyov 2016-02-11 20:26 ` Sergei Shtylyov 2016-02-15 4:56 ` Kuninori Morimoto 2016-02-15 4:56 ` Kuninori Morimoto 2016-02-15 4:56 ` Kuninori Morimoto 2016-02-11 21:49 ` [PATCH] ARM: dts: porter: fix JP3 jumper description Sergei Shtylyov 2016-02-11 21:49 ` Sergei Shtylyov 2016-02-15 4:50 ` Kuninori Morimoto 2016-02-15 4:50 ` Kuninori Morimoto 2016-02-15 4:50 ` Kuninori Morimoto 2016-02-15 21:55 ` Simon Horman 2016-02-15 21:55 ` Simon Horman 2016-02-13 22:26 ` [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node Sergei Shtylyov 2016-02-13 22:26 ` Sergei Shtylyov 2016-02-26 19:43 ` Sergei Shtylyov 2016-02-26 19:43 ` Sergei Shtylyov 2016-03-02 0:47 ` Simon Horman 2016-03-02 0:47 ` Simon Horman 2016-04-13 19:36 ` [PATCH] ARM: dts: silk: add DU pins Sergei Shtylyov 2016-04-13 19:36 ` Sergei Shtylyov 2016-06-17 20:53 ` Sergei Shtylyov 2016-06-17 20:53 ` Sergei Shtylyov 2016-06-20 8:35 ` Simon Horman 2016-06-20 8:35 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56AFAB67.20404@cogentembedded.com \ --to=sergei.shtylyov@cogentembedded.com \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=horms@verge.net.au \ --cc=ijc+devicetree@hellion.org.uk \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=magnus.damm@gmail.com \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=yoshihiro.shimoda.uh@renesas.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.