* Re: [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-04 12:32 [PATCH] xen: Add comment for missing FROZEN notifier transitions Anna-Maria Gleixner
@ 2016-04-04 16:21 ` Julien Grall
2016-04-04 16:21 ` [Xen-devel] " Julien Grall
` (2 subsequent siblings)
3 siblings, 0 replies; 17+ messages in thread
From: Julien Grall @ 2016-04-04 16:21 UTC (permalink / raw)
To: Anna-Maria Gleixner, linux-kernel
Cc: xen-devel, sstabellini, rt, David Vrabel
(CC Stefano new e-mail address)
Hello Anna-Maria,
On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
> Xen guests do not offline/online CPUs during suspend/resume and
> therefore FROZEN notifier transitions are not required. Add this
> explanation as a comment in the code to get not confused why
> CPU_TASKS_FROZEN masked transitions are not considered.
>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: xen-devel@lists.xenproject.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> ---
> arch/arm/xen/enlighten.c | 6 ++++++
> arch/x86/xen/enlighten.c | 7 +++++++
> drivers/xen/events/events_fifo.c | 6 ++++++
> 3 files changed, 19 insertions(+)
>
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
> unsigned long action,
> void *hcpu)
> {
> + /*
> + * Xen guests do not offline/online CPUs during
> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> + * are not considered.
> + */
> +
> switch (action) {
> case CPU_STARTING:
> xen_percpu_init();
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1788,6 +1788,13 @@ static int xen_hvm_cpu_notify(struct not
> void *hcpu)
> {
> int cpu = (long)hcpu;
> +
> + /*
> + * Xen guests do not offline/online CPUs during
> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> + * are not considered.
> + */
> +
> switch (action) {
> case CPU_UP_PREPARE:
> xen_vcpu_setup(cpu);
> --- a/drivers/xen/events/events_fifo.c
> +++ b/drivers/xen/events/events_fifo.c
> @@ -425,6 +425,12 @@ static int evtchn_fifo_cpu_notification(
> int cpu = (long)hcpu;
> int ret = 0;
>
> + /*
> + * Xen guests do not offline/online CPUs during
> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> + * are not considered.
> + */
NIT: The '*' is not aligned with the others.
> +
> switch (action) {
> case CPU_UP_PREPARE:
> if (!per_cpu(cpu_control_block, cpu))
>
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-04 12:32 [PATCH] xen: Add comment for missing FROZEN notifier transitions Anna-Maria Gleixner
2016-04-04 16:21 ` Julien Grall
@ 2016-04-04 16:21 ` Julien Grall
2016-04-04 16:30 ` David Vrabel
2016-04-04 16:30 ` [Xen-devel] " David Vrabel
2016-04-06 13:09 ` [Xen-devel] " David Vrabel
2016-04-06 13:09 ` David Vrabel
3 siblings, 2 replies; 17+ messages in thread
From: Julien Grall @ 2016-04-04 16:21 UTC (permalink / raw)
To: Anna-Maria Gleixner, linux-kernel
Cc: xen-devel, rt, David Vrabel, sstabellini
(CC Stefano new e-mail address)
Hello Anna-Maria,
On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
> Xen guests do not offline/online CPUs during suspend/resume and
> therefore FROZEN notifier transitions are not required. Add this
> explanation as a comment in the code to get not confused why
> CPU_TASKS_FROZEN masked transitions are not considered.
>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: xen-devel@lists.xenproject.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> ---
> arch/arm/xen/enlighten.c | 6 ++++++
> arch/x86/xen/enlighten.c | 7 +++++++
> drivers/xen/events/events_fifo.c | 6 ++++++
> 3 files changed, 19 insertions(+)
>
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
> unsigned long action,
> void *hcpu)
> {
> + /*
> + * Xen guests do not offline/online CPUs during
> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> + * are not considered.
> + */
> +
> switch (action) {
> case CPU_STARTING:
> xen_percpu_init();
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1788,6 +1788,13 @@ static int xen_hvm_cpu_notify(struct not
> void *hcpu)
> {
> int cpu = (long)hcpu;
> +
> + /*
> + * Xen guests do not offline/online CPUs during
> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> + * are not considered.
> + */
> +
> switch (action) {
> case CPU_UP_PREPARE:
> xen_vcpu_setup(cpu);
> --- a/drivers/xen/events/events_fifo.c
> +++ b/drivers/xen/events/events_fifo.c
> @@ -425,6 +425,12 @@ static int evtchn_fifo_cpu_notification(
> int cpu = (long)hcpu;
> int ret = 0;
>
> + /*
> + * Xen guests do not offline/online CPUs during
> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> + * are not considered.
> + */
NIT: The '*' is not aligned with the others.
> +
> switch (action) {
> case CPU_UP_PREPARE:
> if (!per_cpu(cpu_control_block, cpu))
>
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-04 16:21 ` [Xen-devel] " Julien Grall
@ 2016-04-04 16:30 ` David Vrabel
2016-04-04 16:30 ` [Xen-devel] " David Vrabel
1 sibling, 0 replies; 17+ messages in thread
From: David Vrabel @ 2016-04-04 16:30 UTC (permalink / raw)
To: Julien Grall, Anna-Maria Gleixner, linux-kernel
Cc: Juergen Gross, sstabellini, rt, xen-devel, Boris Ostrovsky, David Vrabel
On 04/04/16 17:21, Julien Grall wrote:
> (CC Stefano new e-mail address)
>
> Hello Anna-Maria,
>
> On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
>> Xen guests do not offline/online CPUs during suspend/resume and
>> therefore FROZEN notifier transitions are not required. Add this
>> explanation as a comment in the code to get not confused why
>> CPU_TASKS_FROZEN masked transitions are not considered.
Alternatively, these could be added even if they are not encountered.
This might be more future-proof but the documentation might be clearer.
Boris, Juergen, any opinion?
David>> --- a/drivers/xen/events/events_fifo.c
>> +++ b/drivers/xen/events/events_fifo.c
>> @@ -425,6 +425,12 @@ static int evtchn_fifo_cpu_notification(
>> int cpu = (long)hcpu;
>> int ret = 0;
>>
>> + /*
>> + * Xen guests do not offline/online CPUs during
>> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
>> + * are not considered.
>> + */
>
> NIT: The '*' is not aligned with the others.
If this doesn't need any other changes, I'll fix this on commit.
David
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-04 16:21 ` [Xen-devel] " Julien Grall
2016-04-04 16:30 ` David Vrabel
@ 2016-04-04 16:30 ` David Vrabel
2016-04-04 16:48 ` Boris Ostrovsky
2016-04-04 16:48 ` [Xen-devel] " Boris Ostrovsky
1 sibling, 2 replies; 17+ messages in thread
From: David Vrabel @ 2016-04-04 16:30 UTC (permalink / raw)
To: Julien Grall, Anna-Maria Gleixner, linux-kernel
Cc: xen-devel, sstabellini, rt, David Vrabel, Boris Ostrovsky, Juergen Gross
On 04/04/16 17:21, Julien Grall wrote:
> (CC Stefano new e-mail address)
>
> Hello Anna-Maria,
>
> On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
>> Xen guests do not offline/online CPUs during suspend/resume and
>> therefore FROZEN notifier transitions are not required. Add this
>> explanation as a comment in the code to get not confused why
>> CPU_TASKS_FROZEN masked transitions are not considered.
Alternatively, these could be added even if they are not encountered.
This might be more future-proof but the documentation might be clearer.
Boris, Juergen, any opinion?
David>> --- a/drivers/xen/events/events_fifo.c
>> +++ b/drivers/xen/events/events_fifo.c
>> @@ -425,6 +425,12 @@ static int evtchn_fifo_cpu_notification(
>> int cpu = (long)hcpu;
>> int ret = 0;
>>
>> + /*
>> + * Xen guests do not offline/online CPUs during
>> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
>> + * are not considered.
>> + */
>
> NIT: The '*' is not aligned with the others.
If this doesn't need any other changes, I'll fix this on commit.
David
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-04 16:30 ` [Xen-devel] " David Vrabel
@ 2016-04-04 16:48 ` Boris Ostrovsky
2016-04-04 16:48 ` [Xen-devel] " Boris Ostrovsky
1 sibling, 0 replies; 17+ messages in thread
From: Boris Ostrovsky @ 2016-04-04 16:48 UTC (permalink / raw)
To: David Vrabel, Julien Grall, Anna-Maria Gleixner, linux-kernel
Cc: Juergen Gross, xen-devel, sstabellini, rt
On 04/04/2016 12:30 PM, David Vrabel wrote:
> On 04/04/16 17:21, Julien Grall wrote:
>> (CC Stefano new e-mail address)
>>
>> Hello Anna-Maria,
>>
>> On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
>>> Xen guests do not offline/online CPUs during suspend/resume and
>>> therefore FROZEN notifier transitions are not required. Add this
>>> explanation as a comment in the code to get not confused why
>>> CPU_TASKS_FROZEN masked transitions are not considered.
> Alternatively, these could be added even if they are not encountered.
> This might be more future-proof but the documentation might be clearer.
>
> Boris, Juergen, any opinion?
Wouldn't the same comment need to be added to xen_hvm_cpu_notify()?
-boris
>
> David>> --- a/drivers/xen/events/events_fifo.c
>>> +++ b/drivers/xen/events/events_fifo.c
>>> @@ -425,6 +425,12 @@ static int evtchn_fifo_cpu_notification(
>>> int cpu = (long)hcpu;
>>> int ret = 0;
>>>
>>> + /*
>>> + * Xen guests do not offline/online CPUs during
>>> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
>>> + * are not considered.
>>> + */
>> NIT: The '*' is not aligned with the others.
> If this doesn't need any other changes, I'll fix this on commit.
>
> David
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-04 16:30 ` [Xen-devel] " David Vrabel
2016-04-04 16:48 ` Boris Ostrovsky
@ 2016-04-04 16:48 ` Boris Ostrovsky
2016-04-05 4:22 ` Juergen Gross
2016-04-05 4:22 ` Juergen Gross
1 sibling, 2 replies; 17+ messages in thread
From: Boris Ostrovsky @ 2016-04-04 16:48 UTC (permalink / raw)
To: David Vrabel, Julien Grall, Anna-Maria Gleixner, linux-kernel
Cc: xen-devel, sstabellini, rt, Juergen Gross
On 04/04/2016 12:30 PM, David Vrabel wrote:
> On 04/04/16 17:21, Julien Grall wrote:
>> (CC Stefano new e-mail address)
>>
>> Hello Anna-Maria,
>>
>> On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
>>> Xen guests do not offline/online CPUs during suspend/resume and
>>> therefore FROZEN notifier transitions are not required. Add this
>>> explanation as a comment in the code to get not confused why
>>> CPU_TASKS_FROZEN masked transitions are not considered.
> Alternatively, these could be added even if they are not encountered.
> This might be more future-proof but the documentation might be clearer.
>
> Boris, Juergen, any opinion?
Wouldn't the same comment need to be added to xen_hvm_cpu_notify()?
-boris
>
> David>> --- a/drivers/xen/events/events_fifo.c
>>> +++ b/drivers/xen/events/events_fifo.c
>>> @@ -425,6 +425,12 @@ static int evtchn_fifo_cpu_notification(
>>> int cpu = (long)hcpu;
>>> int ret = 0;
>>>
>>> + /*
>>> + * Xen guests do not offline/online CPUs during
>>> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
>>> + * are not considered.
>>> + */
>> NIT: The '*' is not aligned with the others.
> If this doesn't need any other changes, I'll fix this on commit.
>
> David
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-04 16:48 ` [Xen-devel] " Boris Ostrovsky
@ 2016-04-05 4:22 ` Juergen Gross
2016-04-06 23:52 ` Stefano Stabellini
2016-04-06 23:52 ` Stefano Stabellini
2016-04-05 4:22 ` Juergen Gross
1 sibling, 2 replies; 17+ messages in thread
From: Juergen Gross @ 2016-04-05 4:22 UTC (permalink / raw)
To: Boris Ostrovsky, David Vrabel, Julien Grall, Anna-Maria Gleixner,
linux-kernel
Cc: xen-devel, sstabellini, rt
On 04/04/16 18:48, Boris Ostrovsky wrote:
> On 04/04/2016 12:30 PM, David Vrabel wrote:
>> On 04/04/16 17:21, Julien Grall wrote:
>>> (CC Stefano new e-mail address)
>>>
>>> Hello Anna-Maria,
>>>
>>> On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
>>>> Xen guests do not offline/online CPUs during suspend/resume and
>>>> therefore FROZEN notifier transitions are not required. Add this
>>>> explanation as a comment in the code to get not confused why
>>>> CPU_TASKS_FROZEN masked transitions are not considered.
>> Alternatively, these could be added even if they are not encountered.
>> This might be more future-proof but the documentation might be clearer.
>>
>> Boris, Juergen, any opinion?
I'd rather do more than a comment:
Either mask CPU_TASKS_FROZEN from action if it really doesn't matter
whether the flag is set or not (which IMHO is the case here), or
BUG_ON(action & CPU_TASKS_FROZEN) if this really should never happen.
> Wouldn't the same comment need to be added to xen_hvm_cpu_notify()?
The patch of Anna-Maria does that.
Juergen
>
>
> -boris
>
>
>>
>> David>> --- a/drivers/xen/events/events_fifo.c
>>>> +++ b/drivers/xen/events/events_fifo.c
>>>> @@ -425,6 +425,12 @@ static int evtchn_fifo_cpu_notification(
>>>> int cpu = (long)hcpu;
>>>> int ret = 0;
>>>>
>>>> + /*
>>>> + * Xen guests do not offline/online CPUs during
>>>> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
>>>> + * are not considered.
>>>> + */
>>> NIT: The '*' is not aligned with the others.
>> If this doesn't need any other changes, I'll fix this on commit.
>>
>> David
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-05 4:22 ` Juergen Gross
@ 2016-04-06 23:52 ` Stefano Stabellini
2016-04-06 23:52 ` Stefano Stabellini
1 sibling, 0 replies; 17+ messages in thread
From: Stefano Stabellini @ 2016-04-06 23:52 UTC (permalink / raw)
To: Juergen Gross
Cc: Boris Ostrovsky, David Vrabel, Julien Grall, Anna-Maria Gleixner,
linux-kernel, xen-devel, sstabellini, rt
On Tue, 5 Apr 2016, Juergen Gross wrote:
> On 04/04/16 18:48, Boris Ostrovsky wrote:
> > On 04/04/2016 12:30 PM, David Vrabel wrote:
> >> On 04/04/16 17:21, Julien Grall wrote:
> >>> (CC Stefano new e-mail address)
> >>>
> >>> Hello Anna-Maria,
> >>>
> >>> On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
> >>>> Xen guests do not offline/online CPUs during suspend/resume and
> >>>> therefore FROZEN notifier transitions are not required. Add this
> >>>> explanation as a comment in the code to get not confused why
> >>>> CPU_TASKS_FROZEN masked transitions are not considered.
> >> Alternatively, these could be added even if they are not encountered.
> >> This might be more future-proof but the documentation might be clearer.
> >>
> >> Boris, Juergen, any opinion?
>
> I'd rather do more than a comment:
>
> Either mask CPU_TASKS_FROZEN from action if it really doesn't matter
> whether the flag is set or not (which IMHO is the case here), or
> BUG_ON(action & CPU_TASKS_FROZEN) if this really should never happen.
I agree
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-05 4:22 ` Juergen Gross
2016-04-06 23:52 ` Stefano Stabellini
@ 2016-04-06 23:52 ` Stefano Stabellini
1 sibling, 0 replies; 17+ messages in thread
From: Stefano Stabellini @ 2016-04-06 23:52 UTC (permalink / raw)
To: Juergen Gross
Cc: sstabellini, linux-kernel, Julien Grall, David Vrabel, xen-devel,
Boris Ostrovsky, Anna-Maria Gleixner, rt
On Tue, 5 Apr 2016, Juergen Gross wrote:
> On 04/04/16 18:48, Boris Ostrovsky wrote:
> > On 04/04/2016 12:30 PM, David Vrabel wrote:
> >> On 04/04/16 17:21, Julien Grall wrote:
> >>> (CC Stefano new e-mail address)
> >>>
> >>> Hello Anna-Maria,
> >>>
> >>> On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
> >>>> Xen guests do not offline/online CPUs during suspend/resume and
> >>>> therefore FROZEN notifier transitions are not required. Add this
> >>>> explanation as a comment in the code to get not confused why
> >>>> CPU_TASKS_FROZEN masked transitions are not considered.
> >> Alternatively, these could be added even if they are not encountered.
> >> This might be more future-proof but the documentation might be clearer.
> >>
> >> Boris, Juergen, any opinion?
>
> I'd rather do more than a comment:
>
> Either mask CPU_TASKS_FROZEN from action if it really doesn't matter
> whether the flag is set or not (which IMHO is the case here), or
> BUG_ON(action & CPU_TASKS_FROZEN) if this really should never happen.
I agree
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-04 16:48 ` [Xen-devel] " Boris Ostrovsky
2016-04-05 4:22 ` Juergen Gross
@ 2016-04-05 4:22 ` Juergen Gross
1 sibling, 0 replies; 17+ messages in thread
From: Juergen Gross @ 2016-04-05 4:22 UTC (permalink / raw)
To: Boris Ostrovsky, David Vrabel, Julien Grall, Anna-Maria Gleixner,
linux-kernel
Cc: xen-devel, sstabellini, rt
On 04/04/16 18:48, Boris Ostrovsky wrote:
> On 04/04/2016 12:30 PM, David Vrabel wrote:
>> On 04/04/16 17:21, Julien Grall wrote:
>>> (CC Stefano new e-mail address)
>>>
>>> Hello Anna-Maria,
>>>
>>> On 04/04/2016 13:32, Anna-Maria Gleixner wrote:
>>>> Xen guests do not offline/online CPUs during suspend/resume and
>>>> therefore FROZEN notifier transitions are not required. Add this
>>>> explanation as a comment in the code to get not confused why
>>>> CPU_TASKS_FROZEN masked transitions are not considered.
>> Alternatively, these could be added even if they are not encountered.
>> This might be more future-proof but the documentation might be clearer.
>>
>> Boris, Juergen, any opinion?
I'd rather do more than a comment:
Either mask CPU_TASKS_FROZEN from action if it really doesn't matter
whether the flag is set or not (which IMHO is the case here), or
BUG_ON(action & CPU_TASKS_FROZEN) if this really should never happen.
> Wouldn't the same comment need to be added to xen_hvm_cpu_notify()?
The patch of Anna-Maria does that.
Juergen
>
>
> -boris
>
>
>>
>> David>> --- a/drivers/xen/events/events_fifo.c
>>>> +++ b/drivers/xen/events/events_fifo.c
>>>> @@ -425,6 +425,12 @@ static int evtchn_fifo_cpu_notification(
>>>> int cpu = (long)hcpu;
>>>> int ret = 0;
>>>>
>>>> + /*
>>>> + * Xen guests do not offline/online CPUs during
>>>> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
>>>> + * are not considered.
>>>> + */
>>> NIT: The '*' is not aligned with the others.
>> If this doesn't need any other changes, I'll fix this on commit.
>>
>> David
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-04 12:32 [PATCH] xen: Add comment for missing FROZEN notifier transitions Anna-Maria Gleixner
2016-04-04 16:21 ` Julien Grall
2016-04-04 16:21 ` [Xen-devel] " Julien Grall
@ 2016-04-06 13:09 ` David Vrabel
2016-04-06 14:08 ` [PREEMPT-RT] " Anna-Maria Gleixner
` (3 more replies)
2016-04-06 13:09 ` David Vrabel
3 siblings, 4 replies; 17+ messages in thread
From: David Vrabel @ 2016-04-06 13:09 UTC (permalink / raw)
To: Anna-Maria Gleixner, linux-kernel
Cc: xen-devel, Stefano Stabellini, rt, David Vrabel
On 04/04/16 13:32, Anna-Maria Gleixner wrote:
> Xen guests do not offline/online CPUs during suspend/resume and
> therefore FROZEN notifier transitions are not required. Add this
> explanation as a comment in the code to get not confused why
> CPU_TASKS_FROZEN masked transitions are not considered.
>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: xen-devel@lists.xenproject.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> ---
> arch/arm/xen/enlighten.c | 6 ++++++
> arch/x86/xen/enlighten.c | 7 +++++++
> drivers/xen/events/events_fifo.c | 6 ++++++
> 3 files changed, 19 insertions(+)
>
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
> unsigned long action,
> void *hcpu)
> {
> + /*
> + * Xen guests do not offline/online CPUs during
> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> + * are not considered.
> + */
This may not be true for arm guests.
David
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PREEMPT-RT] [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-06 13:09 ` [Xen-devel] " David Vrabel
@ 2016-04-06 14:08 ` Anna-Maria Gleixner
2016-04-06 14:08 ` [PREEMPT-RT] " Anna-Maria Gleixner
` (2 subsequent siblings)
3 siblings, 0 replies; 17+ messages in thread
From: Anna-Maria Gleixner @ 2016-04-06 14:08 UTC (permalink / raw)
To: David Vrabel
Cc: linux-kernel, xen-devel, David Vrabel, rt, Stefano Stabellini
On Wed, 6 Apr 2016, David Vrabel wrote:
> On 04/04/16 13:32, Anna-Maria Gleixner wrote:
> > Xen guests do not offline/online CPUs during suspend/resume and
> > therefore FROZEN notifier transitions are not required. Add this
> > explanation as a comment in the code to get not confused why
> > CPU_TASKS_FROZEN masked transitions are not considered.
> >
> > Cc: David Vrabel <david.vrabel@citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: xen-devel@lists.xenproject.org
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> > ---
> > arch/arm/xen/enlighten.c | 6 ++++++
> > arch/x86/xen/enlighten.c | 7 +++++++
> > drivers/xen/events/events_fifo.c | 6 ++++++
> > 3 files changed, 19 insertions(+)
> >
> > --- a/arch/arm/xen/enlighten.c
> > +++ b/arch/arm/xen/enlighten.c
> > @@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
> > unsigned long action,
> > void *hcpu)
> > {
> > + /*
> > + * Xen guests do not offline/online CPUs during
> > + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> > + * are not considered.
> > + */
>
> This may not be true for arm guests.
Ok. Should the frozen transitions be handled the same way than the
corresponding non frozen transitions? If yes and if it doesn't matter
to mask action with ~CPU_TASKS_FROZEN in arch/x86/xen/enlighten.c and
drivers/xen/events/events_fifo.c like Juergen sugessts, I could change
the patch by masking action.
Anna-Maria
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PREEMPT-RT] [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-06 13:09 ` [Xen-devel] " David Vrabel
2016-04-06 14:08 ` [PREEMPT-RT] " Anna-Maria Gleixner
@ 2016-04-06 14:08 ` Anna-Maria Gleixner
2016-04-06 23:53 ` Stefano Stabellini
2016-04-06 23:53 ` [Xen-devel] " Stefano Stabellini
3 siblings, 0 replies; 17+ messages in thread
From: Anna-Maria Gleixner @ 2016-04-06 14:08 UTC (permalink / raw)
To: David Vrabel
Cc: xen-devel, rt, linux-kernel, Stefano Stabellini, David Vrabel
On Wed, 6 Apr 2016, David Vrabel wrote:
> On 04/04/16 13:32, Anna-Maria Gleixner wrote:
> > Xen guests do not offline/online CPUs during suspend/resume and
> > therefore FROZEN notifier transitions are not required. Add this
> > explanation as a comment in the code to get not confused why
> > CPU_TASKS_FROZEN masked transitions are not considered.
> >
> > Cc: David Vrabel <david.vrabel@citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: xen-devel@lists.xenproject.org
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> > ---
> > arch/arm/xen/enlighten.c | 6 ++++++
> > arch/x86/xen/enlighten.c | 7 +++++++
> > drivers/xen/events/events_fifo.c | 6 ++++++
> > 3 files changed, 19 insertions(+)
> >
> > --- a/arch/arm/xen/enlighten.c
> > +++ b/arch/arm/xen/enlighten.c
> > @@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
> > unsigned long action,
> > void *hcpu)
> > {
> > + /*
> > + * Xen guests do not offline/online CPUs during
> > + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> > + * are not considered.
> > + */
>
> This may not be true for arm guests.
Ok. Should the frozen transitions be handled the same way than the
corresponding non frozen transitions? If yes and if it doesn't matter
to mask action with ~CPU_TASKS_FROZEN in arch/x86/xen/enlighten.c and
drivers/xen/events/events_fifo.c like Juergen sugessts, I could change
the patch by masking action.
Anna-Maria
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-06 13:09 ` [Xen-devel] " David Vrabel
2016-04-06 14:08 ` [PREEMPT-RT] " Anna-Maria Gleixner
2016-04-06 14:08 ` [PREEMPT-RT] " Anna-Maria Gleixner
@ 2016-04-06 23:53 ` Stefano Stabellini
2016-04-06 23:53 ` [Xen-devel] " Stefano Stabellini
3 siblings, 0 replies; 17+ messages in thread
From: Stefano Stabellini @ 2016-04-06 23:53 UTC (permalink / raw)
To: David Vrabel
Cc: Stefano Stabellini, linux-kernel, David Vrabel, xen-devel,
Anna-Maria Gleixner, rt
On Wed, 6 Apr 2016, David Vrabel wrote:
> On 04/04/16 13:32, Anna-Maria Gleixner wrote:
> > Xen guests do not offline/online CPUs during suspend/resume and
> > therefore FROZEN notifier transitions are not required. Add this
> > explanation as a comment in the code to get not confused why
> > CPU_TASKS_FROZEN masked transitions are not considered.
> >
> > Cc: David Vrabel <david.vrabel@citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: xen-devel@lists.xenproject.org
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> > ---
> > arch/arm/xen/enlighten.c | 6 ++++++
> > arch/x86/xen/enlighten.c | 7 +++++++
> > drivers/xen/events/events_fifo.c | 6 ++++++
> > 3 files changed, 19 insertions(+)
> >
> > --- a/arch/arm/xen/enlighten.c
> > +++ b/arch/arm/xen/enlighten.c
> > @@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
> > unsigned long action,
> > void *hcpu)
> > {
> > + /*
> > + * Xen guests do not offline/online CPUs during
> > + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> > + * are not considered.
> > + */
>
> This may not be true for arm guests.
ARM guests behave like x86 PV guests in this regard. I expect the
comment to be appropriate for both archs or none.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-06 13:09 ` [Xen-devel] " David Vrabel
` (2 preceding siblings ...)
2016-04-06 23:53 ` Stefano Stabellini
@ 2016-04-06 23:53 ` Stefano Stabellini
3 siblings, 0 replies; 17+ messages in thread
From: Stefano Stabellini @ 2016-04-06 23:53 UTC (permalink / raw)
To: David Vrabel
Cc: Anna-Maria Gleixner, linux-kernel, xen-devel, Stefano Stabellini,
rt, David Vrabel
On Wed, 6 Apr 2016, David Vrabel wrote:
> On 04/04/16 13:32, Anna-Maria Gleixner wrote:
> > Xen guests do not offline/online CPUs during suspend/resume and
> > therefore FROZEN notifier transitions are not required. Add this
> > explanation as a comment in the code to get not confused why
> > CPU_TASKS_FROZEN masked transitions are not considered.
> >
> > Cc: David Vrabel <david.vrabel@citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: xen-devel@lists.xenproject.org
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> > ---
> > arch/arm/xen/enlighten.c | 6 ++++++
> > arch/x86/xen/enlighten.c | 7 +++++++
> > drivers/xen/events/events_fifo.c | 6 ++++++
> > 3 files changed, 19 insertions(+)
> >
> > --- a/arch/arm/xen/enlighten.c
> > +++ b/arch/arm/xen/enlighten.c
> > @@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
> > unsigned long action,
> > void *hcpu)
> > {
> > + /*
> > + * Xen guests do not offline/online CPUs during
> > + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> > + * are not considered.
> > + */
>
> This may not be true for arm guests.
ARM guests behave like x86 PV guests in this regard. I expect the
comment to be appropriate for both archs or none.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] xen: Add comment for missing FROZEN notifier transitions
2016-04-04 12:32 [PATCH] xen: Add comment for missing FROZEN notifier transitions Anna-Maria Gleixner
` (2 preceding siblings ...)
2016-04-06 13:09 ` [Xen-devel] " David Vrabel
@ 2016-04-06 13:09 ` David Vrabel
3 siblings, 0 replies; 17+ messages in thread
From: David Vrabel @ 2016-04-06 13:09 UTC (permalink / raw)
To: Anna-Maria Gleixner, linux-kernel
Cc: xen-devel, David Vrabel, rt, Stefano Stabellini
On 04/04/16 13:32, Anna-Maria Gleixner wrote:
> Xen guests do not offline/online CPUs during suspend/resume and
> therefore FROZEN notifier transitions are not required. Add this
> explanation as a comment in the code to get not confused why
> CPU_TASKS_FROZEN masked transitions are not considered.
>
> Cc: David Vrabel <david.vrabel@citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: xen-devel@lists.xenproject.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> ---
> arch/arm/xen/enlighten.c | 6 ++++++
> arch/x86/xen/enlighten.c | 7 +++++++
> drivers/xen/events/events_fifo.c | 6 ++++++
> 3 files changed, 19 insertions(+)
>
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
> unsigned long action,
> void *hcpu)
> {
> + /*
> + * Xen guests do not offline/online CPUs during
> + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> + * are not considered.
> + */
This may not be true for arm guests.
David
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 17+ messages in thread