From: Suzuki K Poulose <Suzuki.Poulose@arm.com> To: Mathieu Poirier <mathieu.poirier@linaro.org>, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 06/15] coresight: tmc: making prepare/unprepare functions generic Date: Tue, 19 Apr 2016 13:30:55 +0100 [thread overview] Message-ID: <571624FF.1040404@arm.com> (raw) In-Reply-To: <1460483692-25061-7-git-send-email-mathieu.poirier@linaro.org> On 12/04/16 18:54, Mathieu Poirier wrote: > Dealing with HW related matters in tmc_read_prepare/unprepare > becomes convoluted when many cases need to be handled distinctively. > > As such moving processing related to HW setup to individual driver > files and keep the core driver generic. > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> > --- > drivers/hwtracing/coresight/coresight-tmc-etf.c | 62 ++++++++++++++++++++++++- > drivers/hwtracing/coresight/coresight-tmc-etr.c | 42 ++++++++++++++++- > drivers/hwtracing/coresight/coresight-tmc.c | 55 +++++----------------- > drivers/hwtracing/coresight/coresight-tmc.h | 8 ++-- > 4 files changed, 117 insertions(+), 50 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c > index 910d6f3b7d26..495540e9064d 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > @@ -70,7 +70,7 @@ static void tmc_etr_dump_hw(struct tmc_drvdata *drvdata) > drvdata->buf = drvdata->vaddr; > } > > -void tmc_etr_disable_hw(struct tmc_drvdata *drvdata) > +static void tmc_etr_disable_hw(struct tmc_drvdata *drvdata) > { > CS_UNLOCK(drvdata->base); > > @@ -126,3 +126,43 @@ static const struct coresight_ops_sink tmc_etr_sink_ops = { > const struct coresight_ops tmc_etr_cs_ops = { > .sink_ops = &tmc_etr_sink_ops, > }; > + > +int tmc_read_prepare_etr(struct tmc_drvdata *drvdata) > +{ > + unsigned long flags; > + > + /* config types are set a boot time and never change */ > + if (drvdata->config_type != TMC_CONFIG_TYPE_ETR) > + return -EINVAL; ... > + > +int tmc_read_unprepare_etr(struct tmc_drvdata *drvdata) > +{ > + unsigned long flags; > + > + /* config types are set a boot time and never change */ > + if (drvdata->config_type != TMC_CONFIG_TYPE_ETR) > + return -EINVAL; > + For both cases above should we WARN_ON_ONCE() if we encounter such a case ? Irrespective of that, Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki.Poulose@arm.com (Suzuki K Poulose) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V2 06/15] coresight: tmc: making prepare/unprepare functions generic Date: Tue, 19 Apr 2016 13:30:55 +0100 [thread overview] Message-ID: <571624FF.1040404@arm.com> (raw) In-Reply-To: <1460483692-25061-7-git-send-email-mathieu.poirier@linaro.org> On 12/04/16 18:54, Mathieu Poirier wrote: > Dealing with HW related matters in tmc_read_prepare/unprepare > becomes convoluted when many cases need to be handled distinctively. > > As such moving processing related to HW setup to individual driver > files and keep the core driver generic. > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> > --- > drivers/hwtracing/coresight/coresight-tmc-etf.c | 62 ++++++++++++++++++++++++- > drivers/hwtracing/coresight/coresight-tmc-etr.c | 42 ++++++++++++++++- > drivers/hwtracing/coresight/coresight-tmc.c | 55 +++++----------------- > drivers/hwtracing/coresight/coresight-tmc.h | 8 ++-- > 4 files changed, 117 insertions(+), 50 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c > index 910d6f3b7d26..495540e9064d 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > @@ -70,7 +70,7 @@ static void tmc_etr_dump_hw(struct tmc_drvdata *drvdata) > drvdata->buf = drvdata->vaddr; > } > > -void tmc_etr_disable_hw(struct tmc_drvdata *drvdata) > +static void tmc_etr_disable_hw(struct tmc_drvdata *drvdata) > { > CS_UNLOCK(drvdata->base); > > @@ -126,3 +126,43 @@ static const struct coresight_ops_sink tmc_etr_sink_ops = { > const struct coresight_ops tmc_etr_cs_ops = { > .sink_ops = &tmc_etr_sink_ops, > }; > + > +int tmc_read_prepare_etr(struct tmc_drvdata *drvdata) > +{ > + unsigned long flags; > + > + /* config types are set a boot time and never change */ > + if (drvdata->config_type != TMC_CONFIG_TYPE_ETR) > + return -EINVAL; ... > + > +int tmc_read_unprepare_etr(struct tmc_drvdata *drvdata) > +{ > + unsigned long flags; > + > + /* config types are set a boot time and never change */ > + if (drvdata->config_type != TMC_CONFIG_TYPE_ETR) > + return -EINVAL; > + For both cases above should we WARN_ON_ONCE() if we encounter such a case ? Irrespective of that, Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
next prev parent reply other threads:[~2016-04-19 12:30 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-12 17:54 [PATCH V2 00/15] coresight: tmc: make driver usable by Perf Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 01/15] coresight: tmc: modifying naming convention Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-14 17:01 ` Suzuki K Poulose 2016-04-14 17:01 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 02/15] coresight: tmc: waiting for TMCReady bit before programming Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-14 17:05 ` Suzuki K Poulose 2016-04-14 17:05 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 03/15] coresight: tmc: re-implementing tmc_read_prepare/unprepare() functions Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-14 17:11 ` Suzuki K Poulose 2016-04-14 17:11 ` Suzuki K Poulose 2016-04-15 15:40 ` Mathieu Poirier 2016-04-15 15:40 ` Mathieu Poirier 2016-04-15 17:41 ` Suzuki K Poulose 2016-04-15 17:41 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 04/15] coresight: tmc: introducing new header file Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-14 17:33 ` Suzuki K Poulose 2016-04-14 17:33 ` Suzuki K Poulose 2016-04-15 16:03 ` Mathieu Poirier 2016-04-15 16:03 ` Mathieu Poirier 2016-04-15 16:08 ` Suzuki K Poulose 2016-04-15 16:08 ` Suzuki K Poulose 2016-04-15 16:15 ` Mathieu Poirier 2016-04-15 16:15 ` Mathieu Poirier 2016-04-15 16:18 ` Suzuki K Poulose 2016-04-15 16:18 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 05/15] coresight: tmc: splitting driver in ETB/ETF and ETR components Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 12:20 ` Suzuki K Poulose 2016-04-19 12:20 ` Suzuki K Poulose 2016-04-19 15:14 ` Mathieu Poirier 2016-04-19 15:14 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 06/15] coresight: tmc: making prepare/unprepare functions generic Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 12:30 ` Suzuki K Poulose [this message] 2016-04-19 12:30 ` Suzuki K Poulose 2016-04-19 15:22 ` Mathieu Poirier 2016-04-19 15:22 ` Mathieu Poirier 2016-04-19 15:32 ` Suzuki K Poulose 2016-04-19 15:32 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 07/15] coresight: tmc: allocating memory when needed Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 12:55 ` Suzuki K Poulose 2016-04-19 12:55 ` Suzuki K Poulose 2016-04-19 13:14 ` Suzuki K Poulose 2016-04-19 13:14 ` Suzuki K Poulose 2016-04-19 15:39 ` Mathieu Poirier 2016-04-19 15:39 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 08/15] coresight: tmc: getting the right read_count on tmc_open() Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 13:07 ` Suzuki K Poulose 2016-04-19 13:07 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 09/15] coresight: tmc: adding mode of operation for link/sinks Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 13:19 ` Suzuki K Poulose 2016-04-19 13:19 ` Suzuki K Poulose 2016-04-19 15:45 ` Mathieu Poirier 2016-04-19 15:45 ` Mathieu Poirier 2016-04-19 15:49 ` Suzuki K Poulose 2016-04-19 15:49 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 10/15] coresight: tmc: dump system memory content only when needed Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 11/15] coresight: tmc: make sysFS and Perf mode mutually exclusive Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 13:42 ` Suzuki K Poulose 2016-04-19 13:42 ` Suzuki K Poulose 2016-04-19 16:16 ` Mathieu Poirier 2016-04-19 16:16 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 12/15] coresight: tmc: keep track of memory width Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-14 11:19 ` Suzuki K Poulose 2016-04-14 11:19 ` Suzuki K Poulose 2016-04-15 16:10 ` Mathieu Poirier 2016-04-15 16:10 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 13/15] coresight: tmc: implementing TMC-ETF AUX space API Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 16:16 ` Suzuki K Poulose 2016-04-19 16:16 ` Suzuki K Poulose 2016-04-19 16:45 ` Mathieu Poirier 2016-04-19 16:45 ` Mathieu Poirier 2016-04-19 16:50 ` Suzuki K Poulose 2016-04-19 16:50 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 14/15] coresight: tmc: implementing TMC-ETR " Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-21 16:10 ` Suzuki K Poulose 2016-04-21 16:10 ` Suzuki K Poulose 2016-04-21 22:00 ` Mathieu Poirier 2016-04-21 22:00 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 15/15] coresight: configuring ETF in FIFO mode when acting as link Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-21 12:53 ` Suzuki K Poulose 2016-04-21 12:53 ` Suzuki K Poulose
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=571624FF.1040404@arm.com \ --to=suzuki.poulose@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.