From: Mathieu Poirier <mathieu.poirier@linaro.org> To: Suzuki K Poulose <Suzuki.Poulose@arm.com> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH V2 12/15] coresight: tmc: keep track of memory width Date: Fri, 15 Apr 2016 10:10:57 -0600 [thread overview] Message-ID: <CANLsYkyzCFVhdt8kmSYaH=HarfJZ3OUU4UnS6XsmhFs10HhHXA@mail.gmail.com> (raw) In-Reply-To: <570F7CD0.30500@arm.com> On 14 April 2016 at 05:19, Suzuki K Poulose <Suzuki.Poulose@arm.com> wrote: > On 12/04/16 18:54, Mathieu Poirier wrote: >> >> Accessing the HW configuration register each time the memory >> width is needed simply doesn't make sense. It is much more >> efficient to read the value once and keep a reference for >> later use. >> >> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> >> --- >> drivers/hwtracing/coresight/coresight-tmc-etf.c | 8 +++----- >> drivers/hwtracing/coresight/coresight-tmc.c | 1 + >> drivers/hwtracing/coresight/coresight-tmc.h | 2 ++ >> 3 files changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c >> b/drivers/hwtracing/coresight/coresight-tmc-etf.c >> index 50d32e8ef4ea..a440784e3b27 100644 >> --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c >> +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c >> @@ -41,18 +41,16 @@ void tmc_etb_enable_hw(struct tmc_drvdata *drvdata) >> >> static void tmc_etb_dump_hw(struct tmc_drvdata *drvdata) >> { >> - enum tmc_mem_intf_width memwidth; >> u8 memwords; >> char *bufp; >> u32 read_data; >> int i; >> >> - memwidth = BMVAL(readl_relaxed(drvdata->base + CORESIGHT_DEVID), >> 8, 10); >> - if (memwidth == TMC_MEM_INTF_WIDTH_32BITS) >> + if (drvdata->memwidth == TMC_MEM_INTF_WIDTH_32BITS) >> memwords = 1; >> - else if (memwidth == TMC_MEM_INTF_WIDTH_64BITS) >> + else if (drvdata->memwidth == TMC_MEM_INTF_WIDTH_64BITS) >> memwords = 2; >> - else if (memwidth == TMC_MEM_INTF_WIDTH_128BITS) >> + else if (drvdata->memwidth == TMC_MEM_INTF_WIDTH_128BITS) >> memwords = 4; > > > >> struct tmc_drvdata { >> @@ -118,6 +119,7 @@ struct tmc_drvdata { >> u32 size; >> local_t mode; >> enum tmc_config_type config_type; >> + enum tmc_mem_intf_width memwidth; > > > Could we not store the converted memwords here, instead of the enum value > here > and convert it every time we access it ? Sure, I can fix that. Thanks for the review, Mathieu > > Cheers > Suzuki
WARNING: multiple messages have this Message-ID (diff)
From: mathieu.poirier@linaro.org (Mathieu Poirier) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V2 12/15] coresight: tmc: keep track of memory width Date: Fri, 15 Apr 2016 10:10:57 -0600 [thread overview] Message-ID: <CANLsYkyzCFVhdt8kmSYaH=HarfJZ3OUU4UnS6XsmhFs10HhHXA@mail.gmail.com> (raw) In-Reply-To: <570F7CD0.30500@arm.com> On 14 April 2016 at 05:19, Suzuki K Poulose <Suzuki.Poulose@arm.com> wrote: > On 12/04/16 18:54, Mathieu Poirier wrote: >> >> Accessing the HW configuration register each time the memory >> width is needed simply doesn't make sense. It is much more >> efficient to read the value once and keep a reference for >> later use. >> >> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> >> --- >> drivers/hwtracing/coresight/coresight-tmc-etf.c | 8 +++----- >> drivers/hwtracing/coresight/coresight-tmc.c | 1 + >> drivers/hwtracing/coresight/coresight-tmc.h | 2 ++ >> 3 files changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c >> b/drivers/hwtracing/coresight/coresight-tmc-etf.c >> index 50d32e8ef4ea..a440784e3b27 100644 >> --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c >> +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c >> @@ -41,18 +41,16 @@ void tmc_etb_enable_hw(struct tmc_drvdata *drvdata) >> >> static void tmc_etb_dump_hw(struct tmc_drvdata *drvdata) >> { >> - enum tmc_mem_intf_width memwidth; >> u8 memwords; >> char *bufp; >> u32 read_data; >> int i; >> >> - memwidth = BMVAL(readl_relaxed(drvdata->base + CORESIGHT_DEVID), >> 8, 10); >> - if (memwidth == TMC_MEM_INTF_WIDTH_32BITS) >> + if (drvdata->memwidth == TMC_MEM_INTF_WIDTH_32BITS) >> memwords = 1; >> - else if (memwidth == TMC_MEM_INTF_WIDTH_64BITS) >> + else if (drvdata->memwidth == TMC_MEM_INTF_WIDTH_64BITS) >> memwords = 2; >> - else if (memwidth == TMC_MEM_INTF_WIDTH_128BITS) >> + else if (drvdata->memwidth == TMC_MEM_INTF_WIDTH_128BITS) >> memwords = 4; > > > >> struct tmc_drvdata { >> @@ -118,6 +119,7 @@ struct tmc_drvdata { >> u32 size; >> local_t mode; >> enum tmc_config_type config_type; >> + enum tmc_mem_intf_width memwidth; > > > Could we not store the converted memwords here, instead of the enum value > here > and convert it every time we access it ? Sure, I can fix that. Thanks for the review, Mathieu > > Cheers > Suzuki
next prev parent reply other threads:[~2016-04-15 16:11 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-12 17:54 [PATCH V2 00/15] coresight: tmc: make driver usable by Perf Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 01/15] coresight: tmc: modifying naming convention Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-14 17:01 ` Suzuki K Poulose 2016-04-14 17:01 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 02/15] coresight: tmc: waiting for TMCReady bit before programming Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-14 17:05 ` Suzuki K Poulose 2016-04-14 17:05 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 03/15] coresight: tmc: re-implementing tmc_read_prepare/unprepare() functions Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-14 17:11 ` Suzuki K Poulose 2016-04-14 17:11 ` Suzuki K Poulose 2016-04-15 15:40 ` Mathieu Poirier 2016-04-15 15:40 ` Mathieu Poirier 2016-04-15 17:41 ` Suzuki K Poulose 2016-04-15 17:41 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 04/15] coresight: tmc: introducing new header file Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-14 17:33 ` Suzuki K Poulose 2016-04-14 17:33 ` Suzuki K Poulose 2016-04-15 16:03 ` Mathieu Poirier 2016-04-15 16:03 ` Mathieu Poirier 2016-04-15 16:08 ` Suzuki K Poulose 2016-04-15 16:08 ` Suzuki K Poulose 2016-04-15 16:15 ` Mathieu Poirier 2016-04-15 16:15 ` Mathieu Poirier 2016-04-15 16:18 ` Suzuki K Poulose 2016-04-15 16:18 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 05/15] coresight: tmc: splitting driver in ETB/ETF and ETR components Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 12:20 ` Suzuki K Poulose 2016-04-19 12:20 ` Suzuki K Poulose 2016-04-19 15:14 ` Mathieu Poirier 2016-04-19 15:14 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 06/15] coresight: tmc: making prepare/unprepare functions generic Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 12:30 ` Suzuki K Poulose 2016-04-19 12:30 ` Suzuki K Poulose 2016-04-19 15:22 ` Mathieu Poirier 2016-04-19 15:22 ` Mathieu Poirier 2016-04-19 15:32 ` Suzuki K Poulose 2016-04-19 15:32 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 07/15] coresight: tmc: allocating memory when needed Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 12:55 ` Suzuki K Poulose 2016-04-19 12:55 ` Suzuki K Poulose 2016-04-19 13:14 ` Suzuki K Poulose 2016-04-19 13:14 ` Suzuki K Poulose 2016-04-19 15:39 ` Mathieu Poirier 2016-04-19 15:39 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 08/15] coresight: tmc: getting the right read_count on tmc_open() Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 13:07 ` Suzuki K Poulose 2016-04-19 13:07 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 09/15] coresight: tmc: adding mode of operation for link/sinks Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 13:19 ` Suzuki K Poulose 2016-04-19 13:19 ` Suzuki K Poulose 2016-04-19 15:45 ` Mathieu Poirier 2016-04-19 15:45 ` Mathieu Poirier 2016-04-19 15:49 ` Suzuki K Poulose 2016-04-19 15:49 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 10/15] coresight: tmc: dump system memory content only when needed Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 11/15] coresight: tmc: make sysFS and Perf mode mutually exclusive Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 13:42 ` Suzuki K Poulose 2016-04-19 13:42 ` Suzuki K Poulose 2016-04-19 16:16 ` Mathieu Poirier 2016-04-19 16:16 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 12/15] coresight: tmc: keep track of memory width Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-14 11:19 ` Suzuki K Poulose 2016-04-14 11:19 ` Suzuki K Poulose 2016-04-15 16:10 ` Mathieu Poirier [this message] 2016-04-15 16:10 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 13/15] coresight: tmc: implementing TMC-ETF AUX space API Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-19 16:16 ` Suzuki K Poulose 2016-04-19 16:16 ` Suzuki K Poulose 2016-04-19 16:45 ` Mathieu Poirier 2016-04-19 16:45 ` Mathieu Poirier 2016-04-19 16:50 ` Suzuki K Poulose 2016-04-19 16:50 ` Suzuki K Poulose 2016-04-12 17:54 ` [PATCH V2 14/15] coresight: tmc: implementing TMC-ETR " Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-21 16:10 ` Suzuki K Poulose 2016-04-21 16:10 ` Suzuki K Poulose 2016-04-21 22:00 ` Mathieu Poirier 2016-04-21 22:00 ` Mathieu Poirier 2016-04-12 17:54 ` [PATCH V2 15/15] coresight: configuring ETF in FIFO mode when acting as link Mathieu Poirier 2016-04-12 17:54 ` Mathieu Poirier 2016-04-21 12:53 ` Suzuki K Poulose 2016-04-21 12:53 ` Suzuki K Poulose
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CANLsYkyzCFVhdt8kmSYaH=HarfJZ3OUU4UnS6XsmhFs10HhHXA@mail.gmail.com' \ --to=mathieu.poirier@linaro.org \ --cc=Suzuki.Poulose@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.