From: Wan Zongshun <vw@iommu.org> To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org, Wan Zongshun <mcuos.com@gmail.com>, Daniel Lezcano <daniel.lezcano@linaro.org>, Russell King <linux@armlinux.org.uk>, linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900 Date: Tue, 5 Jul 2016 15:47:25 +0800 [thread overview] Message-ID: <577B660D.50908@iommu.org> (raw) In-Reply-To: <8706947.5rzUDVsB2F@wuerfel> On 2016年06月29日 23:27, Arnd Bergmann wrote: > On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote: >> +#define IRQ_WDT W90X900_IRQ(1) >> +#define IRQ_WWDT W90X900_IRQ(2) >> +#define IRQ_LVD W90X900_IRQ(3) >> +#define IRQ_EXT0 W90X900_IRQ(4) >> +#define IRQ_EXT1 W90X900_IRQ(5) >> +#define IRQ_EXT2 W90X900_IRQ(6) >> +#define IRQ_EXT3 W90X900_IRQ(7) >> +#define IRQ_EXT4 W90X900_IRQ(8) >> +#define IRQ_EXT5 W90X900_IRQ(9) >> +#define IRQ_EXT6 W90X900_IRQ(10) > > I'd suggest dropping the list, the contents are now in the dts. Do you think I should put one irqmap header file into this /arch/arm/boot/dts/include/dt-bindings folder, or I should removed those irqnumber map anywhere, just hardcode the irqnumber in dts file? > >> diff --git a/arch/arm/mach-w90x900/include/mach/nuc970-regs-aic.h b/arch/arm/mach-w90x900/include/mach/nuc970-regs-aic.h >> new file mode 100644 >> index 0000000..7a77016 >> --- /dev/null >> +++ b/arch/arm/mach-w90x900/include/mach/nuc970-regs-aic.h >> @@ -0,0 +1,53 @@ >> +#ifndef __ASM_ARCH_REGS_AIC_H >> +#define __ASM_ARCH_REGS_AIC_H >> + >> +/*NUC970 AIC regs*/ >> + >> +#define REG_AIC_SCR1 0x00 >> +#define REG_AIC_SCR2 0x04 >> +#define REG_AIC_SCR3 0x08 >> +#define REG_AIC_SCR4 0x0C >> +#define REG_AIC_SCR5 0x10 > > And like the clk driver, these should all be in the irqchip driver instead > of a separate header. Ok, changed. > >> + >> +static void __iomem *aic_base; >> +static struct irq_domain *aic_domain; >> +#define MAKE_HWIRQ(irqnum) (irqnum) > > The macro appears to be unused. removed it. > >> +static void nuc970_irq_mask(struct irq_data *d) >> +{ >> + if (d->irq < 32) >> + __raw_writel(1 << (d->irq), aic_base + REG_AIC_MDCR); >> + else >> + __raw_writel(1 << (d->irq - 32), aic_base + REG_AIC_MDCRH); >> +} > > writel() > > Arnd > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >
WARNING: multiple messages have this Message-ID (diff)
From: vw@iommu.org (Wan Zongshun) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/6] irqchip: add irqchip driver for nuc900 Date: Tue, 5 Jul 2016 15:47:25 +0800 [thread overview] Message-ID: <577B660D.50908@iommu.org> (raw) In-Reply-To: <8706947.5rzUDVsB2F@wuerfel> On 2016?06?29? 23:27, Arnd Bergmann wrote: > On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote: >> +#define IRQ_WDT W90X900_IRQ(1) >> +#define IRQ_WWDT W90X900_IRQ(2) >> +#define IRQ_LVD W90X900_IRQ(3) >> +#define IRQ_EXT0 W90X900_IRQ(4) >> +#define IRQ_EXT1 W90X900_IRQ(5) >> +#define IRQ_EXT2 W90X900_IRQ(6) >> +#define IRQ_EXT3 W90X900_IRQ(7) >> +#define IRQ_EXT4 W90X900_IRQ(8) >> +#define IRQ_EXT5 W90X900_IRQ(9) >> +#define IRQ_EXT6 W90X900_IRQ(10) > > I'd suggest dropping the list, the contents are now in the dts. Do you think I should put one irqmap header file into this /arch/arm/boot/dts/include/dt-bindings folder, or I should removed those irqnumber map anywhere, just hardcode the irqnumber in dts file? > >> diff --git a/arch/arm/mach-w90x900/include/mach/nuc970-regs-aic.h b/arch/arm/mach-w90x900/include/mach/nuc970-regs-aic.h >> new file mode 100644 >> index 0000000..7a77016 >> --- /dev/null >> +++ b/arch/arm/mach-w90x900/include/mach/nuc970-regs-aic.h >> @@ -0,0 +1,53 @@ >> +#ifndef __ASM_ARCH_REGS_AIC_H >> +#define __ASM_ARCH_REGS_AIC_H >> + >> +/*NUC970 AIC regs*/ >> + >> +#define REG_AIC_SCR1 0x00 >> +#define REG_AIC_SCR2 0x04 >> +#define REG_AIC_SCR3 0x08 >> +#define REG_AIC_SCR4 0x0C >> +#define REG_AIC_SCR5 0x10 > > And like the clk driver, these should all be in the irqchip driver instead > of a separate header. Ok, changed. > >> + >> +static void __iomem *aic_base; >> +static struct irq_domain *aic_domain; >> +#define MAKE_HWIRQ(irqnum) (irqnum) > > The macro appears to be unused. removed it. > >> +static void nuc970_irq_mask(struct irq_data *d) >> +{ >> + if (d->irq < 32) >> + __raw_writel(1 << (d->irq), aic_base + REG_AIC_MDCR); >> + else >> + __raw_writel(1 << (d->irq - 32), aic_base + REG_AIC_MDCRH); >> +} > > writel() > > Arnd > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >
next prev parent reply other threads:[~2016-07-05 7:47 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-25 10:37 [PATCH 0/6] ARM: NUC900: Add NUC970 SoC support Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-25 10:37 ` [PATCH 1/6] ARM: NUC900: Add nuc970 machine support Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-29 15:19 ` Arnd Bergmann 2016-06-29 15:19 ` Arnd Bergmann 2016-06-29 15:19 ` Arnd Bergmann 2016-07-05 7:38 ` Wan Zongshun 2016-07-05 7:38 ` Wan Zongshun 2016-07-05 7:38 ` Wan Zongshun 2016-07-05 8:09 ` Arnd Bergmann 2016-07-05 8:09 ` Arnd Bergmann 2016-07-05 8:09 ` Arnd Bergmann 2016-06-25 10:37 ` [PATCH 2/6] ARM: dts: nuc900: Add nuc970 dts files Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-28 20:56 ` Rob Herring 2016-06-28 20:56 ` Rob Herring 2016-06-29 15:24 ` Arnd Bergmann 2016-06-29 15:24 ` Arnd Bergmann 2016-06-29 15:24 ` Arnd Bergmann 2016-06-25 10:37 ` [PATCH 3/6] Clocksource: add nuc970 clocksource driver Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-27 19:46 ` Daniel Lezcano 2016-06-27 19:46 ` Daniel Lezcano 2016-06-27 19:46 ` Daniel Lezcano 2016-07-05 8:21 ` Wan Zongshun 2016-07-05 8:21 ` Wan Zongshun 2016-07-05 8:21 ` Wan Zongshun 2016-07-05 10:03 ` Daniel Lezcano 2016-07-05 10:03 ` Daniel Lezcano 2016-07-05 10:03 ` Daniel Lezcano 2016-06-29 15:25 ` Arnd Bergmann 2016-06-29 15:25 ` Arnd Bergmann 2016-06-29 15:25 ` Arnd Bergmann 2016-06-29 16:10 ` Daniel Lezcano 2016-06-29 16:10 ` Daniel Lezcano 2016-06-29 16:10 ` Daniel Lezcano 2016-07-05 7:43 ` Wan Zongshun 2016-07-05 7:43 ` Wan Zongshun 2016-07-05 7:43 ` Wan Zongshun 2016-06-25 10:37 ` [PATCH 4/6] irqchip: add irqchip driver for nuc900 Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-29 15:27 ` Arnd Bergmann 2016-06-29 15:27 ` Arnd Bergmann 2016-06-29 15:27 ` Arnd Bergmann 2016-07-05 7:47 ` Wan Zongshun [this message] 2016-07-05 7:47 ` Wan Zongshun 2016-07-05 8:09 ` Arnd Bergmann 2016-07-05 8:09 ` Arnd Bergmann 2016-07-05 8:09 ` Arnd Bergmann 2016-07-09 3:25 ` Wan Zongshun 2016-07-09 3:25 ` Wan Zongshun 2016-07-09 20:17 ` Arnd Bergmann 2016-07-09 20:17 ` Arnd Bergmann 2016-07-09 20:17 ` Arnd Bergmann 2016-07-22 2:37 ` Wan ZongShun 2016-07-22 2:37 ` Wan ZongShun 2016-07-22 2:37 ` Wan ZongShun 2016-06-30 16:30 ` Jason Cooper 2016-06-30 16:30 ` Jason Cooper 2016-06-25 10:37 ` [PATCH 5/6] clk: add Clock driver for nuc970 Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-29 15:28 ` Arnd Bergmann 2016-06-29 15:28 ` Arnd Bergmann 2016-06-29 15:28 ` Arnd Bergmann 2016-06-25 10:37 ` [PATCH 6/6] nuc900: add nuc970 platform defconfig file Wan Zongshun 2016-06-25 10:37 ` Wan Zongshun 2016-06-29 15:29 ` Arnd Bergmann 2016-06-29 15:29 ` Arnd Bergmann 2016-06-29 15:29 ` Arnd Bergmann 2016-06-29 15:32 ` [PATCH 0/6] ARM: NUC900: Add NUC970 SoC support Arnd Bergmann 2016-06-29 15:32 ` Arnd Bergmann 2016-06-29 15:32 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=577B660D.50908@iommu.org \ --to=vw@iommu.org \ --cc=arnd@arndb.de \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mcuos.com@gmail.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.