All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Wan Zongshun <vw@iommu.org>,
	linux-arm-kernel@lists.infradead.org,
	Russell King <linux@armlinux.org.uk>,
	devicetree@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Wan Zongshun <mcuos.com@gmail.com>,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver
Date: Tue, 5 Jul 2016 12:03:29 +0200	[thread overview]
Message-ID: <577B85F1.9010004@linaro.org> (raw)
In-Reply-To: <577B6DFF.9000703@iommu.org>

On 07/05/2016 10:21 AM, Wan Zongshun wrote:

[ ... ]

>>> +    setup_irq(irq, &nuc970_timer0_irq);
>>
>> s/setup_irq/request_irq/
> 
> Do you think I should use request_irq instead of setup_irq?

Yes.


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Wan Zongshun <vw-6ukY98dZOFrYtjvyW6yDsg@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Wan Zongshun <mcuos.com-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Subject: Re: [PATCH 3/6] Clocksource: add nuc970 clocksource driver
Date: Tue, 5 Jul 2016 12:03:29 +0200	[thread overview]
Message-ID: <577B85F1.9010004@linaro.org> (raw)
In-Reply-To: <577B6DFF.9000703-6ukY98dZOFrYtjvyW6yDsg@public.gmane.org>

On 07/05/2016 10:21 AM, Wan Zongshun wrote:

[ ... ]

>>> +    setup_irq(irq, &nuc970_timer0_irq);
>>
>> s/setup_irq/request_irq/
> 
> Do you think I should use request_irq instead of setup_irq?

Yes.


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] Clocksource: add nuc970 clocksource driver
Date: Tue, 5 Jul 2016 12:03:29 +0200	[thread overview]
Message-ID: <577B85F1.9010004@linaro.org> (raw)
In-Reply-To: <577B6DFF.9000703@iommu.org>

On 07/05/2016 10:21 AM, Wan Zongshun wrote:

[ ... ]

>>> +    setup_irq(irq, &nuc970_timer0_irq);
>>
>> s/setup_irq/request_irq/
> 
> Do you think I should use request_irq instead of setup_irq?

Yes.


-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2016-07-05 10:03 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-25 10:37 [PATCH 0/6] ARM: NUC900: Add NUC970 SoC support Wan Zongshun
2016-06-25 10:37 ` Wan Zongshun
2016-06-25 10:37 ` Wan Zongshun
2016-06-25 10:37 ` [PATCH 1/6] ARM: NUC900: Add nuc970 machine support Wan Zongshun
2016-06-25 10:37   ` Wan Zongshun
2016-06-25 10:37   ` Wan Zongshun
2016-06-29 15:19   ` Arnd Bergmann
2016-06-29 15:19     ` Arnd Bergmann
2016-06-29 15:19     ` Arnd Bergmann
2016-07-05  7:38     ` Wan Zongshun
2016-07-05  7:38       ` Wan Zongshun
2016-07-05  7:38       ` Wan Zongshun
2016-07-05  8:09       ` Arnd Bergmann
2016-07-05  8:09         ` Arnd Bergmann
2016-07-05  8:09         ` Arnd Bergmann
2016-06-25 10:37 ` [PATCH 2/6] ARM: dts: nuc900: Add nuc970 dts files Wan Zongshun
2016-06-25 10:37   ` Wan Zongshun
2016-06-25 10:37   ` Wan Zongshun
2016-06-28 20:56   ` Rob Herring
2016-06-28 20:56     ` Rob Herring
2016-06-29 15:24   ` Arnd Bergmann
2016-06-29 15:24     ` Arnd Bergmann
2016-06-29 15:24     ` Arnd Bergmann
2016-06-25 10:37 ` [PATCH 3/6] Clocksource: add nuc970 clocksource driver Wan Zongshun
2016-06-25 10:37   ` Wan Zongshun
2016-06-25 10:37   ` Wan Zongshun
2016-06-27 19:46   ` Daniel Lezcano
2016-06-27 19:46     ` Daniel Lezcano
2016-06-27 19:46     ` Daniel Lezcano
2016-07-05  8:21     ` Wan Zongshun
2016-07-05  8:21       ` Wan Zongshun
2016-07-05  8:21       ` Wan Zongshun
2016-07-05 10:03       ` Daniel Lezcano [this message]
2016-07-05 10:03         ` Daniel Lezcano
2016-07-05 10:03         ` Daniel Lezcano
2016-06-29 15:25   ` Arnd Bergmann
2016-06-29 15:25     ` Arnd Bergmann
2016-06-29 15:25     ` Arnd Bergmann
2016-06-29 16:10     ` Daniel Lezcano
2016-06-29 16:10       ` Daniel Lezcano
2016-06-29 16:10       ` Daniel Lezcano
2016-07-05  7:43     ` Wan Zongshun
2016-07-05  7:43       ` Wan Zongshun
2016-07-05  7:43       ` Wan Zongshun
2016-06-25 10:37 ` [PATCH 4/6] irqchip: add irqchip driver for nuc900 Wan Zongshun
2016-06-25 10:37   ` Wan Zongshun
2016-06-25 10:37   ` Wan Zongshun
2016-06-29 15:27   ` Arnd Bergmann
2016-06-29 15:27     ` Arnd Bergmann
2016-06-29 15:27     ` Arnd Bergmann
2016-07-05  7:47     ` Wan Zongshun
2016-07-05  7:47       ` Wan Zongshun
2016-07-05  8:09       ` Arnd Bergmann
2016-07-05  8:09         ` Arnd Bergmann
2016-07-05  8:09         ` Arnd Bergmann
2016-07-09  3:25     ` Wan Zongshun
2016-07-09  3:25       ` Wan Zongshun
2016-07-09 20:17       ` Arnd Bergmann
2016-07-09 20:17         ` Arnd Bergmann
2016-07-09 20:17         ` Arnd Bergmann
2016-07-22  2:37         ` Wan ZongShun
2016-07-22  2:37           ` Wan ZongShun
2016-07-22  2:37           ` Wan ZongShun
2016-06-30 16:30   ` Jason Cooper
2016-06-30 16:30     ` Jason Cooper
2016-06-25 10:37 ` [PATCH 5/6] clk: add Clock driver for nuc970 Wan Zongshun
2016-06-25 10:37   ` Wan Zongshun
2016-06-29 15:28   ` Arnd Bergmann
2016-06-29 15:28     ` Arnd Bergmann
2016-06-29 15:28     ` Arnd Bergmann
2016-06-25 10:37 ` [PATCH 6/6] nuc900: add nuc970 platform defconfig file Wan Zongshun
2016-06-25 10:37   ` Wan Zongshun
2016-06-29 15:29   ` Arnd Bergmann
2016-06-29 15:29     ` Arnd Bergmann
2016-06-29 15:29     ` Arnd Bergmann
2016-06-29 15:32 ` [PATCH 0/6] ARM: NUC900: Add NUC970 SoC support Arnd Bergmann
2016-06-29 15:32   ` Arnd Bergmann
2016-06-29 15:32   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577B85F1.9010004@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mcuos.com@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=vw@iommu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.