All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: robert.foss@linaro.org, laurent.pinchart@ideasonboard.com,
	jernej.skrabec@gmail.com, jonas@kwiboo.se, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, sam@ravnborg.org,
	maxime@cerno.tech, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org, kernel@pengutronix.de,
	dri-devel@lists.freedesktop.org
Subject: Re: (EXT) [PATCH 5/6] dt-bindings: drm/bridge: ti-sn65dsi83: Add reset controller documentation
Date: Tue, 31 May 2022 09:33:04 +0200	[thread overview]
Message-ID: <5789362.MhkbZ0Pkbq@steina-w> (raw)
In-Reply-To: <20220530150548.1236307-6-m.felsch@pengutronix.de>

Hi Marco,

Am Montag, 30. Mai 2022, 17:05:48 CEST schrieb Marco Felsch:
> The bridge device can now also be enabled/disabled by an external reset
> controller. So the device now supports either enable/disable by simple
> GPIO or by an Reset-Controller.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml    | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index
> 7306b9874dc3..eff8360c184e 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> @@ -35,6 +35,12 @@ properties:
>    vcc-supply:
>      description: A 1.8V power supply (see regulator/regulator.yaml).
> 
> +  resets:
> +    maxItems: 1
> +    description: |
> +      Reset specifier for bridge_en pin. This is required only if the
> brdige_en +      pin is connected to a reset controller.
> +
>    ports:
>      $ref: /schemas/graph.yaml#/properties/ports

Maybe it should be added here, that 'resets' is an alternative to 'enable-
gpios' as both are essentially controlling the same pin from the bridge.

Best regards
Alexander



WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: devicetree@vger.kernel.org, kernel@pengutronix.de,
	jonas@kwiboo.se, robert.foss@linaro.org,
	dri-devel@lists.freedesktop.org, jernej.skrabec@gmail.com,
	robh+dt@kernel.org, laurent.pinchart@ideasonboard.com,
	krzysztof.kozlowski+dt@linaro.org, sam@ravnborg.org,
	maxime@cerno.tech
Subject: Re: (EXT) [PATCH 5/6] dt-bindings: drm/bridge: ti-sn65dsi83: Add reset controller documentation
Date: Tue, 31 May 2022 09:33:04 +0200	[thread overview]
Message-ID: <5789362.MhkbZ0Pkbq@steina-w> (raw)
In-Reply-To: <20220530150548.1236307-6-m.felsch@pengutronix.de>

Hi Marco,

Am Montag, 30. Mai 2022, 17:05:48 CEST schrieb Marco Felsch:
> The bridge device can now also be enabled/disabled by an external reset
> controller. So the device now supports either enable/disable by simple
> GPIO or by an Reset-Controller.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml    | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index
> 7306b9874dc3..eff8360c184e 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> @@ -35,6 +35,12 @@ properties:
>    vcc-supply:
>      description: A 1.8V power supply (see regulator/regulator.yaml).
> 
> +  resets:
> +    maxItems: 1
> +    description: |
> +      Reset specifier for bridge_en pin. This is required only if the
> brdige_en +      pin is connected to a reset controller.
> +
>    ports:
>      $ref: /schemas/graph.yaml#/properties/ports

Maybe it should be added here, that 'resets' is an alternative to 'enable-
gpios' as both are essentially controlling the same pin from the bridge.

Best regards
Alexander



  reply	other threads:[~2022-05-31  7:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-30 15:05 [PATCH 0/6] TI SN65DSI83 Features Marco Felsch
2022-05-30 15:05 ` Marco Felsch
2022-05-30 15:05 ` [PATCH 1/6] drm/bridge: ti-sn65dsi83: make lvds lane register setup more readable Marco Felsch
2022-05-30 15:05   ` Marco Felsch
2022-05-30 15:05 ` [PATCH 2/6] dt-bindings: drm/bridge: ti-sn65dsi83: add documentation for reverse lvds lanes Marco Felsch
2022-05-30 15:05   ` Marco Felsch
2022-06-05 21:09   ` Rob Herring
2022-06-05 21:09     ` Rob Herring
2022-05-30 15:05 ` [PATCH 3/6] drm/bridge: ti-sn65dsi83: add support to swap the LVDS data lanes Marco Felsch
2022-05-30 15:05   ` Marco Felsch
2022-05-30 15:05 ` [PATCH 4/6] drm/bridge: ti-sn65dsi83: make use of dev_err_probe Marco Felsch
2022-05-30 15:05   ` Marco Felsch
2022-05-30 15:05 ` [PATCH 5/6] dt-bindings: drm/bridge: ti-sn65dsi83: Add reset controller documentation Marco Felsch
2022-05-30 15:05   ` Marco Felsch
2022-05-31  7:33   ` Alexander Stein [this message]
2022-05-31  7:33     ` (EXT) " Alexander Stein
2022-05-31  8:29     ` Marco Felsch
2022-05-31  8:29       ` Marco Felsch
2022-05-30 15:05 ` [PATCH 6/6] drm/bridge: ti-sn65dsi83: add support for a external reset controller Marco Felsch
2022-05-30 15:05   ` Marco Felsch
2022-07-26  9:12 ` [PATCH 0/6] TI SN65DSI83 Features Marco Felsch
2022-07-26  9:12   ` Marco Felsch
2022-08-29 15:06   ` Robert Foss
2022-08-29 15:06     ` Robert Foss
2022-08-31  8:13     ` Marco Felsch
2022-08-31  8:13       ` Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5789362.MhkbZ0Pkbq@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=m.felsch@pengutronix.de \
    --cc=maxime@cerno.tech \
    --cc=robert.foss@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.