From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
Mugunthan V N <mugunthanvnm@ti.com>, Sekhar Nori <nsekhar@ti.com>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
Murali Karicheri <m-karicheri2@ti.com>,
Wingman Kwok <w-kwok2@ti.com>
Subject: Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH
Date: Thu, 8 Dec 2016 13:04:11 -0600 [thread overview]
Message-ID: <58eea45f-b8fe-6892-e784-b41638c62fd8@ti.com> (raw)
In-Reply-To: <20161203232130.GA17944@netboy>
On 12/03/2016 05:21 PM, Richard Cochran wrote:
> On Mon, Nov 28, 2016 at 05:04:25PM -0600, Grygorii Strashko wrote:
>> This also change overflow polling period when HW_TS_PUSH feature is
>> enabled - overflow check work will be scheduled more often (every
>> 200ms) for proper HW_TS_PUSH events reporting.
>
> For proper reporting, you should make use of the interrupt. The small
> fifo (16 iirc) could very well overflow in 200 ms. The interrupt
> handler should read out the entire fifo at each interrupt.
>
huh. Seems this is not really good idea, because MISC Irq will be
triggered for *any* CPTS event and there is no way to enable it just for
HW_TS_PUSH. So, this doesn't work will with current code for RX/TX timestamping
(which uses polling mode). + runtime overhead in net RX/TX caused by
triggering more interrupts.
May be, overflow check/polling timeout can be made configurable (module parameter).
--
regards,
-grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
To: Richard Cochran <richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org>,
Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>,
Wingman Kwok <w-kwok2-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH
Date: Thu, 8 Dec 2016 13:04:11 -0600 [thread overview]
Message-ID: <58eea45f-b8fe-6892-e784-b41638c62fd8@ti.com> (raw)
In-Reply-To: <20161203232130.GA17944@netboy>
On 12/03/2016 05:21 PM, Richard Cochran wrote:
> On Mon, Nov 28, 2016 at 05:04:25PM -0600, Grygorii Strashko wrote:
>> This also change overflow polling period when HW_TS_PUSH feature is
>> enabled - overflow check work will be scheduled more often (every
>> 200ms) for proper HW_TS_PUSH events reporting.
>
> For proper reporting, you should make use of the interrupt. The small
> fifo (16 iirc) could very well overflow in 200 ms. The interrupt
> handler should read out the entire fifo at each interrupt.
>
huh. Seems this is not really good idea, because MISC Irq will be
triggered for *any* CPTS event and there is no way to enable it just for
HW_TS_PUSH. So, this doesn't work will with current code for RX/TX timestamping
(which uses polling mode). + runtime overhead in net RX/TX caused by
triggering more interrupts.
May be, overflow check/polling timeout can be made configurable (module parameter).
--
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
To: Richard Cochran <richardcochran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org>,
Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>,
Wingman Kwok <w-kwok2-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH
Date: Thu, 8 Dec 2016 13:04:11 -0600 [thread overview]
Message-ID: <58eea45f-b8fe-6892-e784-b41638c62fd8@ti.com> (raw)
In-Reply-To: <20161203232130.GA17944@netboy>
On 12/03/2016 05:21 PM, Richard Cochran wrote:
> On Mon, Nov 28, 2016 at 05:04:25PM -0600, Grygorii Strashko wrote:
>> This also change overflow polling period when HW_TS_PUSH feature is
>> enabled - overflow check work will be scheduled more often (every
>> 200ms) for proper HW_TS_PUSH events reporting.
>
> For proper reporting, you should make use of the interrupt. The small
> fifo (16 iirc) could very well overflow in 200 ms. The interrupt
> handler should read out the entire fifo at each interrupt.
>
huh. Seems this is not really good idea, because MISC Irq will be
triggered for *any* CPTS event and there is no way to enable it just for
HW_TS_PUSH. So, this doesn't work will with current code for RX/TX timestamping
(which uses polling mode). + runtime overhead in net RX/TX caused by
triggering more interrupts.
May be, overflow check/polling timeout can be made configurable (module parameter).
--
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-12-08 19:04 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 23:04 [PATCH 0/6] net: ethernet: ti: cpts: update and enable support on keystone 2 socs Grygorii Strashko
2016-11-28 23:04 ` Grygorii Strashko
2016-11-28 23:04 ` [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts Grygorii Strashko
2016-11-28 23:04 ` Grygorii Strashko
2016-11-30 9:44 ` Richard Cochran
2016-11-30 17:31 ` Grygorii Strashko
2016-11-30 17:31 ` Grygorii Strashko
2016-11-30 17:31 ` Grygorii Strashko
2016-11-30 18:22 ` Richard Cochran
2016-12-05 14:49 ` Rob Herring
2016-12-05 18:25 ` Grygorii Strashko
2016-12-05 18:25 ` Grygorii Strashko
2016-12-05 19:30 ` Richard Cochran
2016-11-28 23:04 ` [PATCH 2/6] net: ethernet: ti: cpts: add support for ext rftclk selection Grygorii Strashko
2016-11-28 23:04 ` Grygorii Strashko
2016-11-30 9:56 ` Richard Cochran
2016-11-30 9:56 ` Richard Cochran
2016-11-30 17:35 ` Grygorii Strashko
2016-11-30 17:35 ` Grygorii Strashko
2016-11-30 17:35 ` Grygorii Strashko
2016-12-06 19:39 ` Grygorii Strashko
2016-12-06 19:39 ` Grygorii Strashko
2016-12-06 20:25 ` Richard Cochran
2016-12-06 20:40 ` Grygorii Strashko
2016-12-06 20:40 ` Grygorii Strashko
2016-12-06 20:40 ` Grygorii Strashko
2016-12-09 0:47 ` Stephen Boyd
2016-12-09 23:29 ` Grygorii Strashko
2016-12-09 23:29 ` Grygorii Strashko
2016-12-09 23:29 ` Grygorii Strashko
2016-12-05 14:51 ` Rob Herring
2016-11-28 23:04 ` [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH Grygorii Strashko
2016-11-28 23:04 ` Grygorii Strashko
2016-11-30 10:19 ` Richard Cochran
2016-11-30 10:19 ` Richard Cochran
2016-11-30 11:08 ` Jan Lübbe
2016-11-30 20:15 ` Grygorii Strashko
2016-11-30 20:15 ` Grygorii Strashko
2016-12-03 23:21 ` Richard Cochran
2016-12-08 19:04 ` Grygorii Strashko [this message]
2016-12-08 19:04 ` Grygorii Strashko
2016-12-08 19:04 ` Grygorii Strashko
2016-12-09 8:50 ` Richard Cochran
2016-11-28 23:04 ` [PATCH 4/6] net: ethernet: ti: cpts: add ptp pps support Grygorii Strashko
2016-11-28 23:04 ` Grygorii Strashko
2016-11-30 10:05 ` Richard Cochran
2016-12-06 18:08 ` Richard Cochran
2016-12-06 18:08 ` Richard Cochran
2016-12-06 20:43 ` Grygorii Strashko
2016-12-06 20:43 ` Grygorii Strashko
2016-11-30 11:01 ` Jan Lübbe
2016-11-30 18:45 ` Richard Cochran
2016-11-30 20:43 ` Grygorii Strashko
2016-11-30 20:43 ` Grygorii Strashko
2016-11-30 22:17 ` Richard Cochran
2016-12-02 9:58 ` Richard Cochran
2016-12-02 17:58 ` Grygorii Strashko
2016-12-02 17:58 ` Grygorii Strashko
2016-12-02 19:28 ` Richard Cochran
2016-12-02 19:28 ` Richard Cochran
2016-11-28 23:04 ` [PATCH 5/6] ARM: keystone: dts: fix netcp clocks and add names Grygorii Strashko
2016-11-28 23:04 ` Grygorii Strashko
2016-11-28 23:04 ` Grygorii Strashko
2016-11-28 23:04 ` [PATCH 6/6] ARM: dts: keystone: enable time synchronization (cpts) submodule Grygorii Strashko
2016-11-28 23:04 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58eea45f-b8fe-6892-e784-b41638c62fd8@ti.com \
--to=grygorii.strashko@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.