From: Grygorii Strashko <grygorii.strashko@ti.com> To: Rob Herring <robh@kernel.org> Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>, Mugunthan V N <mugunthanvnm@ti.com>, Richard Cochran <richardcochran@gmail.com>, Sekhar Nori <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>, Murali Karicheri <m-karicheri2@ti.com>, Wingman Kwok <w-kwok2@ti.com> Subject: Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts Date: Mon, 5 Dec 2016 12:25:57 -0600 [thread overview] Message-ID: <7a484f9c-a47d-3ccd-9611-d00b86feabdd@ti.com> (raw) In-Reply-To: <20161205144918.oj4jpj65aha3x5gf@rob-hp-laptop> On 12/05/2016 08:49 AM, Rob Herring wrote: > On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: >> From: WingMan Kwok <w-kwok2@ti.com> >> >> This patch adds support of the cpts device found in the >> gbe and 10gbe ethernet switches on the keystone 2 SoCs >> (66AK2E/L/Hx, 66AK2Gx). >> >> Signed-off-by: WingMan Kwok <w-kwok2@ti.com> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> --- >> .../devicetree/bindings/net/keystone-netcp.txt | 9 + >> drivers/net/ethernet/ti/Kconfig | 7 +- >> drivers/net/ethernet/ti/netcp.h | 2 +- >> drivers/net/ethernet/ti/netcp_core.c | 18 +- >> drivers/net/ethernet/ti/netcp_ethss.c | 437 ++++++++++++++++++++- >> 5 files changed, 459 insertions(+), 14 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/keystone-netcp.txt b/Documentation/devicetree/bindings/net/keystone-netcp.txt >> index 04ba1dc..c37b54e 100644 >> --- a/Documentation/devicetree/bindings/net/keystone-netcp.txt >> +++ b/Documentation/devicetree/bindings/net/keystone-netcp.txt >> @@ -113,6 +113,15 @@ Optional properties: >> will only initialize these ports and attach PHY >> driver to them if needed. >> >> + Properties related to cpts configurations. >> + - cpts_clock_mult/cpts_clock_shift: > > Needs vendor prefix. Don't use '_'. This module is used as part of OMAP and Keystone SoCs, so names for this props is ABI already :( > >> + used for converting time counter cycles to ns as in >> + >> + ns = (cycles * clock_mult) >> _shift >> + >> + Defaults: clock_mult, clock_shift = calculated from >> + CPTS refclk > > What does this mean? > I'll add more description here. >> + >> NetCP interface properties: Interface specification for NetCP sub-modules. >> Required properties: >> - rx-channel: the navigator packet dma channel name for rx. -- regards, -grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com> To: Rob Herring <robh@kernel.org> Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>, Richard Cochran <richardcochran@gmail.com>, Sekhar Nori <nsekhar@ti.com>, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Murali Karicheri <m-karicheri2@ti.com>, Wingman Kwok <w-kwok2@ti.com> Subject: Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts Date: Mon, 5 Dec 2016 12:25:57 -0600 [thread overview] Message-ID: <7a484f9c-a47d-3ccd-9611-d00b86feabdd@ti.com> (raw) In-Reply-To: <20161205144918.oj4jpj65aha3x5gf@rob-hp-laptop> On 12/05/2016 08:49 AM, Rob Herring wrote: > On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: >> From: WingMan Kwok <w-kwok2@ti.com> >> >> This patch adds support of the cpts device found in the >> gbe and 10gbe ethernet switches on the keystone 2 SoCs >> (66AK2E/L/Hx, 66AK2Gx). >> >> Signed-off-by: WingMan Kwok <w-kwok2@ti.com> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> --- >> .../devicetree/bindings/net/keystone-netcp.txt | 9 + >> drivers/net/ethernet/ti/Kconfig | 7 +- >> drivers/net/ethernet/ti/netcp.h | 2 +- >> drivers/net/ethernet/ti/netcp_core.c | 18 +- >> drivers/net/ethernet/ti/netcp_ethss.c | 437 ++++++++++++++++++++- >> 5 files changed, 459 insertions(+), 14 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/keystone-netcp.txt b/Documentation/devicetree/bindings/net/keystone-netcp.txt >> index 04ba1dc..c37b54e 100644 >> --- a/Documentation/devicetree/bindings/net/keystone-netcp.txt >> +++ b/Documentation/devicetree/bindings/net/keystone-netcp.txt >> @@ -113,6 +113,15 @@ Optional properties: >> will only initialize these ports and attach PHY >> driver to them if needed. >> >> + Properties related to cpts configurations. >> + - cpts_clock_mult/cpts_clock_shift: > > Needs vendor prefix. Don't use '_'. This module is used as part of OMAP and Keystone SoCs, so names for this props is ABI already :( > >> + used for converting time counter cycles to ns as in >> + >> + ns = (cycles * clock_mult) >> _shift >> + >> + Defaults: clock_mult, clock_shift = calculated from >> + CPTS refclk > > What does this mean? > I'll add more description here. >> + >> NetCP interface properties: Interface specification for NetCP sub-modules. >> Required properties: >> - rx-channel: the navigator packet dma channel name for rx. -- regards, -grygorii
next prev parent reply other threads:[~2016-12-05 18:26 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-28 23:04 [PATCH 0/6] net: ethernet: ti: cpts: update and enable support on keystone 2 socs Grygorii Strashko 2016-11-28 23:04 ` Grygorii Strashko 2016-11-28 23:04 ` [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts Grygorii Strashko 2016-11-28 23:04 ` Grygorii Strashko 2016-11-30 9:44 ` Richard Cochran 2016-11-30 17:31 ` Grygorii Strashko 2016-11-30 17:31 ` Grygorii Strashko 2016-11-30 17:31 ` Grygorii Strashko 2016-11-30 18:22 ` Richard Cochran 2016-12-05 14:49 ` Rob Herring 2016-12-05 18:25 ` Grygorii Strashko [this message] 2016-12-05 18:25 ` Grygorii Strashko 2016-12-05 19:30 ` Richard Cochran 2016-11-28 23:04 ` [PATCH 2/6] net: ethernet: ti: cpts: add support for ext rftclk selection Grygorii Strashko 2016-11-28 23:04 ` Grygorii Strashko 2016-11-30 9:56 ` Richard Cochran 2016-11-30 9:56 ` Richard Cochran 2016-11-30 17:35 ` Grygorii Strashko 2016-11-30 17:35 ` Grygorii Strashko 2016-11-30 17:35 ` Grygorii Strashko 2016-12-06 19:39 ` Grygorii Strashko 2016-12-06 19:39 ` Grygorii Strashko 2016-12-06 20:25 ` Richard Cochran 2016-12-06 20:40 ` Grygorii Strashko 2016-12-06 20:40 ` Grygorii Strashko 2016-12-06 20:40 ` Grygorii Strashko 2016-12-09 0:47 ` Stephen Boyd 2016-12-09 23:29 ` Grygorii Strashko 2016-12-09 23:29 ` Grygorii Strashko 2016-12-09 23:29 ` Grygorii Strashko 2016-12-05 14:51 ` Rob Herring 2016-11-28 23:04 ` [PATCH 3/6] net: ethernet: ti: cpts: add support of cpts HW_TS_PUSH Grygorii Strashko 2016-11-28 23:04 ` Grygorii Strashko 2016-11-30 10:19 ` Richard Cochran 2016-11-30 10:19 ` Richard Cochran 2016-11-30 11:08 ` Jan Lübbe 2016-11-30 20:15 ` Grygorii Strashko 2016-11-30 20:15 ` Grygorii Strashko 2016-12-03 23:21 ` Richard Cochran 2016-12-08 19:04 ` Grygorii Strashko 2016-12-08 19:04 ` Grygorii Strashko 2016-12-08 19:04 ` Grygorii Strashko 2016-12-09 8:50 ` Richard Cochran 2016-11-28 23:04 ` [PATCH 4/6] net: ethernet: ti: cpts: add ptp pps support Grygorii Strashko 2016-11-28 23:04 ` Grygorii Strashko 2016-11-30 10:05 ` Richard Cochran 2016-12-06 18:08 ` Richard Cochran 2016-12-06 18:08 ` Richard Cochran 2016-12-06 20:43 ` Grygorii Strashko 2016-12-06 20:43 ` Grygorii Strashko 2016-11-30 11:01 ` Jan Lübbe 2016-11-30 18:45 ` Richard Cochran 2016-11-30 20:43 ` Grygorii Strashko 2016-11-30 20:43 ` Grygorii Strashko 2016-11-30 22:17 ` Richard Cochran 2016-12-02 9:58 ` Richard Cochran 2016-12-02 17:58 ` Grygorii Strashko 2016-12-02 17:58 ` Grygorii Strashko 2016-12-02 19:28 ` Richard Cochran 2016-12-02 19:28 ` Richard Cochran 2016-11-28 23:04 ` [PATCH 5/6] ARM: keystone: dts: fix netcp clocks and add names Grygorii Strashko 2016-11-28 23:04 ` Grygorii Strashko 2016-11-28 23:04 ` Grygorii Strashko 2016-11-28 23:04 ` [PATCH 6/6] ARM: dts: keystone: enable time synchronization (cpts) submodule Grygorii Strashko 2016-11-28 23:04 ` Grygorii Strashko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7a484f9c-a47d-3ccd-9611-d00b86feabdd@ti.com \ --to=grygorii.strashko@ti.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=m-karicheri2@ti.com \ --cc=mugunthanvnm@ti.com \ --cc=netdev@vger.kernel.org \ --cc=nsekhar@ti.com \ --cc=richardcochran@gmail.com \ --cc=robh@kernel.org \ --cc=w-kwok2@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.