All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state
@ 2022-12-15  3:01 ` Ma Jun
  0 siblings, 0 replies; 5+ messages in thread
From: Ma Jun @ 2022-12-15  3:01 UTC (permalink / raw)
  To: amd-gfx, dri-devel, daniel.vetter; +Cc: majun

Add the missing declaration of struct drm_atomic_state to fix the
compile error below:

error: 'struct drm_atomic_state' declared inside parameter
list will not be visible outside of this definition or declaration [-Werror]

Signed-off-by: Ma Jun <majun@amd.com>
---
 include/drm/drm_plane_helper.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h
index b00ad36cf5b6..530f88176db4 100644
--- a/include/drm/drm_plane_helper.h
+++ b/include/drm/drm_plane_helper.h
@@ -30,6 +30,7 @@ struct drm_crtc;
 struct drm_framebuffer;
 struct drm_modeset_acquire_ctx;
 struct drm_plane;
+struct drm_atomic_state;
 
 int drm_plane_helper_update_primary(struct drm_plane *plane, struct drm_crtc *crtc,
 				    struct drm_framebuffer *fb,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state
@ 2022-12-15  3:01 ` Ma Jun
  0 siblings, 0 replies; 5+ messages in thread
From: Ma Jun @ 2022-12-15  3:01 UTC (permalink / raw)
  To: amd-gfx, dri-devel, daniel.vetter

Add the missing declaration of struct drm_atomic_state to fix the
compile error below:

error: 'struct drm_atomic_state' declared inside parameter
list will not be visible outside of this definition or declaration [-Werror]

Signed-off-by: Ma Jun <majun@amd.com>
---
 include/drm/drm_plane_helper.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h
index b00ad36cf5b6..530f88176db4 100644
--- a/include/drm/drm_plane_helper.h
+++ b/include/drm/drm_plane_helper.h
@@ -30,6 +30,7 @@ struct drm_crtc;
 struct drm_framebuffer;
 struct drm_modeset_acquire_ctx;
 struct drm_plane;
+struct drm_atomic_state;
 
 int drm_plane_helper_update_primary(struct drm_plane *plane, struct drm_crtc *crtc,
 				    struct drm_framebuffer *fb,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state
  2022-12-15  3:01 ` Ma Jun
  (?)
@ 2022-12-15  8:40 ` Thomas Zimmermann
  2022-12-16  1:34     ` Ma, Jun
  -1 siblings, 1 reply; 5+ messages in thread
From: Thomas Zimmermann @ 2022-12-15  8:40 UTC (permalink / raw)
  To: Ma Jun, amd-gfx, dri-devel, daniel.vetter


[-- Attachment #1.1: Type: text/plain, Size: 1205 bytes --]

Hi

Am 15.12.22 um 04:01 schrieb Ma Jun:
> Add the missing declaration of struct drm_atomic_state to fix the
> compile error below:
> 
> error: 'struct drm_atomic_state' declared inside parameter
> list will not be visible outside of this definition or declaration [-Werror]
> 
> Signed-off-by: Ma Jun <majun@amd.com>
> ---
>   include/drm/drm_plane_helper.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h
> index b00ad36cf5b6..530f88176db4 100644
> --- a/include/drm/drm_plane_helper.h
> +++ b/include/drm/drm_plane_helper.h
> @@ -30,6 +30,7 @@ struct drm_crtc;
>   struct drm_framebuffer;
>   struct drm_modeset_acquire_ctx;
>   struct drm_plane;
> +struct drm_atomic_state;

Thanks for the patch. Please sort the forward declarations alphabetically.

Best regards
Thomas

>   
>   int drm_plane_helper_update_primary(struct drm_plane *plane, struct drm_crtc *crtc,
>   				    struct drm_framebuffer *fb,

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state
  2022-12-15  8:40 ` Thomas Zimmermann
@ 2022-12-16  1:34     ` Ma, Jun
  0 siblings, 0 replies; 5+ messages in thread
From: Ma, Jun @ 2022-12-16  1:34 UTC (permalink / raw)
  To: Thomas Zimmermann, amd-gfx, dri-devel, daniel.vetter; +Cc: majun



On 12/15/2022 4:40 PM, Thomas Zimmermann wrote:
> Hi
> 
> Am 15.12.22 um 04:01 schrieb Ma Jun:
>> Add the missing declaration of struct drm_atomic_state to fix the
>> compile error below:
>>
>> error: 'struct drm_atomic_state' declared inside parameter
>> list will not be visible outside of this definition or declaration [-Werror]
>>
>> Signed-off-by: Ma Jun <majun@amd.com>
>> ---
>>   include/drm/drm_plane_helper.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h
>> index b00ad36cf5b6..530f88176db4 100644
>> --- a/include/drm/drm_plane_helper.h
>> +++ b/include/drm/drm_plane_helper.h
>> @@ -30,6 +30,7 @@ struct drm_crtc;
>>   struct drm_framebuffer;
>>   struct drm_modeset_acquire_ctx;
>>   struct drm_plane;
>> +struct drm_atomic_state;
> 
> Thanks for the patch. Please sort the forward declarations alphabetically.
> 
Thanks for review. Will fix in v2

Regards,
Ma Jun
> Best regards
> Thomas
> 
>>   
>>   int drm_plane_helper_update_primary(struct drm_plane *plane, struct drm_crtc *crtc,
>>   				    struct drm_framebuffer *fb,
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state
@ 2022-12-16  1:34     ` Ma, Jun
  0 siblings, 0 replies; 5+ messages in thread
From: Ma, Jun @ 2022-12-16  1:34 UTC (permalink / raw)
  To: Thomas Zimmermann, amd-gfx, dri-devel, daniel.vetter



On 12/15/2022 4:40 PM, Thomas Zimmermann wrote:
> Hi
> 
> Am 15.12.22 um 04:01 schrieb Ma Jun:
>> Add the missing declaration of struct drm_atomic_state to fix the
>> compile error below:
>>
>> error: 'struct drm_atomic_state' declared inside parameter
>> list will not be visible outside of this definition or declaration [-Werror]
>>
>> Signed-off-by: Ma Jun <majun@amd.com>
>> ---
>>   include/drm/drm_plane_helper.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h
>> index b00ad36cf5b6..530f88176db4 100644
>> --- a/include/drm/drm_plane_helper.h
>> +++ b/include/drm/drm_plane_helper.h
>> @@ -30,6 +30,7 @@ struct drm_crtc;
>>   struct drm_framebuffer;
>>   struct drm_modeset_acquire_ctx;
>>   struct drm_plane;
>> +struct drm_atomic_state;
> 
> Thanks for the patch. Please sort the forward declarations alphabetically.
> 
Thanks for review. Will fix in v2

Regards,
Ma Jun
> Best regards
> Thomas
> 
>>   
>>   int drm_plane_helper_update_primary(struct drm_plane *plane, struct drm_crtc *crtc,
>>   				    struct drm_framebuffer *fb,
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-16  1:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-15  3:01 [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state Ma Jun
2022-12-15  3:01 ` Ma Jun
2022-12-15  8:40 ` Thomas Zimmermann
2022-12-16  1:34   ` Ma, Jun
2022-12-16  1:34     ` Ma, Jun

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.