[goto-label] memory: fix label syntax

[goto-label] memory: fix label syntax

[Norbert Manthey]

To be able to compile Xen with gotocc, the label statement has to be
followed by a semicolon.

Reported-by: Elizabeth Polgreen <polgreen@amazon.de>
Signed-off-by: Norbert Manthey <nmanthey@amazon.de>
---
 xen/common/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/memory.c b/xen/common/memory.c
index 75010b7..e29d596 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -387,7 +387,7 @@ int guest_remove_page(struct domain *d, unsigned long gmfn)
         put_page(page);
 
     put_page(page);
- out_put_gfn: __maybe_unused
+ out_put_gfn: __maybe_unused;
     put_gfn(d, gmfn);
 
     /*
-- 
2.7.4

Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [goto-label] memory: fix label syntax

[Jan Beulich]

>>> On 31.07.18 at 09:18, <nmanthey@amazon.de> wrote:
> To be able to compile Xen with gotocc, the label statement has to be
> followed by a semicolon.

Assuming that gotocc aims to be gcc compatible, this looks like a
shortcoming there. As the workaround is simple enough, I'm fine
with the change, but the description should then say so. Or
otherwise it should as well clarify the situation.

Furthermore - please follow patch submission rules: Patches get
sent _To_ the list, with _all_ maintainers _Cc_-ed.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [goto-label] memory: fix label syntax

[Norbert Manthey]

Sorry for putting you in the To field, I'll use Cc in the future.

I agree that the commit message is a little short, and I will iterate on
that. Furthermore, I agree that gcc compatibility would allow to parse
this statement. However, the given sequence is not unique, and the gcc
documentation states that the semicolon is mandatory.

https://gcc.gnu.org/onlinedocs/gcc/Label-Attributes.html

I'll add more details to the commit message.

Best,
Norbert

On 07/31/2018 09:48 AM, Jan Beulich wrote:
>>>> On 31.07.18 at 09:18, <nmanthey@amazon.de> wrote:
>> To be able to compile Xen with gotocc, the label statement has to be
>> followed by a semicolon.
> 
> Assuming that gotocc aims to be gcc compatible, this looks like a
> shortcoming there. As the workaround is simple enough, I'm fine
> with the change, but the description should then say so. Or
> otherwise it should as well clarify the situation.
> 
> Furthermore - please follow patch submission rules: Patches get
> sent _To_ the list, with _all_ maintainers _Cc_-ed.
> 
> Jan
> 
> 
> 
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [goto-label] memory: fix label syntax

[Jan Beulich]

>>> On 31.07.18 at 10:32, <nmanthey@amazon.de> wrote:
> Sorry for putting you in the To field, I'll use Cc in the future.
> 
> I agree that the commit message is a little short, and I will iterate on
> that. Furthermore, I agree that gcc compatibility would allow to parse
> this statement. However, the given sequence is not unique, and the gcc
> documentation states that the semicolon is mandatory.
> 
> https://gcc.gnu.org/onlinedocs/gcc/Label-Attributes.html 

Ah, indeed, modern documentation says so, while older didn't.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[goto-label v2] memory: fix label syntax

[Norbert Manthey]

When compiling this file with gcc, the compiler happily accepts the
sequence of a label followed by an attribute. However, this sequence does
not follow the gcc documentation. Hence, other compilers might stumble
upon this statement.

To be able to compile Xen with goto-cc (the compiler of the CPROVER tool
suite), the missing semicolon is added in this commit.

Reported-by: Elizabeth Polgreen <polgreen@amazon.de>
Signed-off-by: Norbert Manthey <nmanthey@amazon.de>
---
 xen/common/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/common/memory.c b/xen/common/memory.c
index 75010b7..e29d596 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -387,7 +387,7 @@ int guest_remove_page(struct domain *d, unsigned long gmfn)
         put_page(page);
 
     put_page(page);
- out_put_gfn: __maybe_unused
+ out_put_gfn: __maybe_unused;
     put_gfn(d, gmfn);
 
     /*
-- 
2.7.4

Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [goto-label v2] memory: fix label syntax

[Jan Beulich]

>>> On 31.07.18 at 10:56, <nmanthey@amazon.de> wrote:
> When compiling this file with gcc, the compiler happily accepts the
> sequence of a label followed by an attribute. However, this sequence does
> not follow the gcc documentation. Hence, other compilers might stumble
> upon this statement.
> 
> To be able to compile Xen with goto-cc (the compiler of the CPROVER tool
> suite), the missing semicolon is added in this commit.
> 
> Reported-by: Elizabeth Polgreen <polgreen@amazon.de>
> Signed-off-by: Norbert Manthey <nmanthey@amazon.de>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

Btw - you still didn't Cc all relevant maintainers, but I'm sure no one
of them would object to a change like this.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [goto-label v2] memory: fix label syntax

[Wei Liu]

On Tue, Jul 31, 2018 at 03:18:51AM -0600, Jan Beulich wrote:
> >>> On 31.07.18 at 10:56, <nmanthey@amazon.de> wrote:
> > When compiling this file with gcc, the compiler happily accepts the
> > sequence of a label followed by an attribute. However, this sequence does
> > not follow the gcc documentation. Hence, other compilers might stumble
> > upon this statement.
> > 
> > To be able to compile Xen with goto-cc (the compiler of the CPROVER tool
> > suite), the missing semicolon is added in this commit.
> > 
> > Reported-by: Elizabeth Polgreen <polgreen@amazon.de>
> > Signed-off-by: Norbert Manthey <nmanthey@amazon.de>
> 
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> 
> Btw - you still didn't Cc all relevant maintainers, but I'm sure no one
> of them would object to a change like this.

Strangely this patch never showed up in my inbox or xen-devel archive.

Norbert, I wonder if there is something wrong with your email setting?

Wei.

> Jan
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [goto-label v2] memory: fix label syntax

[Jan Beulich]

>>> On 31.07.18 at 11:24, <wei.liu2@citrix.com> wrote:
> On Tue, Jul 31, 2018 at 03:18:51AM -0600, Jan Beulich wrote:
>> >>> On 31.07.18 at 10:56, <nmanthey@amazon.de> wrote:
>> > When compiling this file with gcc, the compiler happily accepts the
>> > sequence of a label followed by an attribute. However, this sequence does
>> > not follow the gcc documentation. Hence, other compilers might stumble
>> > upon this statement.
>> > 
>> > To be able to compile Xen with goto-cc (the compiler of the CPROVER tool
>> > suite), the missing semicolon is added in this commit.
>> > 
>> > Reported-by: Elizabeth Polgreen <polgreen@amazon.de>
>> > Signed-off-by: Norbert Manthey <nmanthey@amazon.de>
>> 
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>> 
>> Btw - you still didn't Cc all relevant maintainers, but I'm sure no one
>> of them would object to a change like this.
> 
> Strangely this patch never showed up in my inbox or xen-devel archive.
> 
> Norbert, I wonder if there is something wrong with your email setting?

Perhaps it's still in moderation?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [goto-label v2] memory: fix label syntax

[Wei Liu]

On Tue, Jul 31, 2018 at 03:27:03AM -0600, Jan Beulich wrote:
> >>> On 31.07.18 at 11:24, <wei.liu2@citrix.com> wrote:
> > On Tue, Jul 31, 2018 at 03:18:51AM -0600, Jan Beulich wrote:
> >> >>> On 31.07.18 at 10:56, <nmanthey@amazon.de> wrote:
> >> > When compiling this file with gcc, the compiler happily accepts the
> >> > sequence of a label followed by an attribute. However, this sequence does
> >> > not follow the gcc documentation. Hence, other compilers might stumble
> >> > upon this statement.
> >> > 
> >> > To be able to compile Xen with goto-cc (the compiler of the CPROVER tool
> >> > suite), the missing semicolon is added in this commit.
> >> > 
> >> > Reported-by: Elizabeth Polgreen <polgreen@amazon.de>
> >> > Signed-off-by: Norbert Manthey <nmanthey@amazon.de>
> >> 
> >> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> >> 
> >> Btw - you still didn't Cc all relevant maintainers, but I'm sure no one
> >> of them would object to a change like this.
> > 
> > Strangely this patch never showed up in my inbox or xen-devel archive.
> > 
> > Norbert, I wonder if there is something wrong with your email setting?
> 
> Perhaps it's still in moderation?
> 

It appears so. Andy just let it through. Sorry for the noise.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel