* Any reason AID is not in the NL80211_STA_INFO enumeration? @ 2020-02-18 1:11 Ben Greear 2020-02-28 10:06 ` Johannes Berg 0 siblings, 1 reply; 7+ messages in thread From: Ben Greear @ 2020-02-18 1:11 UTC (permalink / raw) To: linux-wireless To sniff /AX stations, it is helpful to know their AID. So, any problems with adding it to 'iw station dump' output? Thanks, Ben -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any reason AID is not in the NL80211_STA_INFO enumeration? 2020-02-18 1:11 Any reason AID is not in the NL80211_STA_INFO enumeration? Ben Greear @ 2020-02-28 10:06 ` Johannes Berg 2020-02-28 15:26 ` Ben Greear 0 siblings, 1 reply; 7+ messages in thread From: Johannes Berg @ 2020-02-28 10:06 UTC (permalink / raw) To: Ben Greear, linux-wireless On Mon, 2020-02-17 at 17:11 -0800, Ben Greear wrote: > To sniff /AX stations, it is helpful to know their AID. So, any problems > with adding it to 'iw station dump' output? No, no problem at all. I guess it was just never added because it originally comes from userspace (hostapd), and so didn't really need to be sent back. But yeah, we have trivial infrastructure to send it back, so sure, why not. johannes ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any reason AID is not in the NL80211_STA_INFO enumeration? 2020-02-28 10:06 ` Johannes Berg @ 2020-02-28 15:26 ` Ben Greear 2020-03-03 14:08 ` Johannes Berg 0 siblings, 1 reply; 7+ messages in thread From: Ben Greear @ 2020-02-28 15:26 UTC (permalink / raw) To: Johannes Berg, linux-wireless On 02/28/2020 02:06 AM, Johannes Berg wrote: > On Mon, 2020-02-17 at 17:11 -0800, Ben Greear wrote: >> To sniff /AX stations, it is helpful to know their AID. So, any problems >> with adding it to 'iw station dump' output? > > No, no problem at all. I guess it was just never added because it > originally comes from userspace (hostapd), and so didn't really need to > be sent back. But yeah, we have trivial infrastructure to send it back, > so sure, why not. Ok, thanks for the response. From looking at debugfs for a station device, there is the netdev AID: cat /debug/ieee80211/wiphy0/netdev\:wlan0/aid 1 And there is a peer AID: cat /debug/ieee80211/wiphy0/netdev\:wlan0/stations/04\:f0\:21\:c2\:fd\:b0/aid 0 For sniffing AX, I'd need to use '1' here as far as I can tell. Maybe for station devices the peer is always zero? And for AP devices, the peer IDs are what is useful and the netdev AID is not? Thanks, Ben > > johannes > -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any reason AID is not in the NL80211_STA_INFO enumeration? 2020-02-28 15:26 ` Ben Greear @ 2020-03-03 14:08 ` Johannes Berg 2020-03-03 14:57 ` Ben Greear 0 siblings, 1 reply; 7+ messages in thread From: Johannes Berg @ 2020-03-03 14:08 UTC (permalink / raw) To: Ben Greear, linux-wireless On Fri, 2020-02-28 at 07:26 -0800, Ben Greear wrote: > > On 02/28/2020 02:06 AM, Johannes Berg wrote: > > On Mon, 2020-02-17 at 17:11 -0800, Ben Greear wrote: > > > To sniff /AX stations, it is helpful to know their AID. So, any problems > > > with adding it to 'iw station dump' output? > > > > No, no problem at all. I guess it was just never added because it > > originally comes from userspace (hostapd), and so didn't really need to > > be sent back. But yeah, we have trivial infrastructure to send it back, > > so sure, why not. > > Ok, thanks for the response. > > From looking at debugfs for a station device, there is the netdev AID: > > cat /debug/ieee80211/wiphy0/netdev\:wlan0/aid > 1 > > And there is a peer AID: > > cat /debug/ieee80211/wiphy0/netdev\:wlan0/stations/04\:f0\:21\:c2\:fd\:b0/aid > 0 > > For sniffing AX, I'd need to use '1' here as far as I can tell. Maybe for station > devices the peer is always zero? And for AP devices, the peer IDs are what is useful > and the netdev AID is not? Yeah. The first is u.mgd.aid (i.e. the netdev data), and the latter is the STA AID. It makes sense the latter is not assigned in the client-side case. Arguably, only the *latter* should be in nl80211 per STA, since in the client-side case it's *our* AID, not the APs. johannes ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any reason AID is not in the NL80211_STA_INFO enumeration? 2020-03-03 14:08 ` Johannes Berg @ 2020-03-03 14:57 ` Ben Greear 2020-03-03 14:59 ` Johannes Berg 0 siblings, 1 reply; 7+ messages in thread From: Ben Greear @ 2020-03-03 14:57 UTC (permalink / raw) To: Johannes Berg, linux-wireless On 03/03/2020 06:08 AM, Johannes Berg wrote: > On Fri, 2020-02-28 at 07:26 -0800, Ben Greear wrote: >> >> On 02/28/2020 02:06 AM, Johannes Berg wrote: >>> On Mon, 2020-02-17 at 17:11 -0800, Ben Greear wrote: >>>> To sniff /AX stations, it is helpful to know their AID. So, any problems >>>> with adding it to 'iw station dump' output? >>> >>> No, no problem at all. I guess it was just never added because it >>> originally comes from userspace (hostapd), and so didn't really need to >>> be sent back. But yeah, we have trivial infrastructure to send it back, >>> so sure, why not. >> >> Ok, thanks for the response. >> >> From looking at debugfs for a station device, there is the netdev AID: >> >> cat /debug/ieee80211/wiphy0/netdev\:wlan0/aid >> 1 >> >> And there is a peer AID: >> >> cat /debug/ieee80211/wiphy0/netdev\:wlan0/stations/04\:f0\:21\:c2\:fd\:b0/aid >> 0 >> >> For sniffing AX, I'd need to use '1' here as far as I can tell. Maybe for station >> devices the peer is always zero? And for AP devices, the peer IDs are what is useful >> and the netdev AID is not? > > Yeah. The first is u.mgd.aid (i.e. the netdev data), and the latter is > the STA AID. > > It makes sense the latter is not assigned in the client-side case. > > Arguably, only the *latter* should be in nl80211 per STA, since in the > client-side case it's *our* AID, not the APs. Although it is a bit weird, I was thinking to always return the AID as part of the station dump, and for station netdevs, use the local netdev AID, and for APs, use the remote station AID. That seems a bit cleaner to me than having two separate ways to get the AID for stations and APs, but I can do two separate ways if you prefer that. Thanks, Ben > > johannes > -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any reason AID is not in the NL80211_STA_INFO enumeration? 2020-03-03 14:57 ` Ben Greear @ 2020-03-03 14:59 ` Johannes Berg 2020-03-03 15:02 ` Ben Greear 0 siblings, 1 reply; 7+ messages in thread From: Johannes Berg @ 2020-03-03 14:59 UTC (permalink / raw) To: Ben Greear, linux-wireless On Tue, 2020-03-03 at 06:57 -0800, Ben Greear wrote: > > Although it is a bit weird, I was thinking to always return the AID as part of the station > dump, and for station netdevs, use the local netdev AID, and for APs, use the remote station AID. > > That seems a bit cleaner to me than having two separate ways to get the AID for stations and APs, > but I can do two separate ways if you prefer that. I don't really agree that it's cleaner - by definition, the data in a station is data about that station, not data about "self". We may not have a great way right now to show the latter ('data about self')? But I still don't think we should mix it. johannes ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Any reason AID is not in the NL80211_STA_INFO enumeration? 2020-03-03 14:59 ` Johannes Berg @ 2020-03-03 15:02 ` Ben Greear 0 siblings, 0 replies; 7+ messages in thread From: Ben Greear @ 2020-03-03 15:02 UTC (permalink / raw) To: Johannes Berg, linux-wireless On 03/03/2020 06:59 AM, Johannes Berg wrote: > On Tue, 2020-03-03 at 06:57 -0800, Ben Greear wrote: >> >> Although it is a bit weird, I was thinking to always return the AID as part of the station >> dump, and for station netdevs, use the local netdev AID, and for APs, use the remote station AID. >> >> That seems a bit cleaner to me than having two separate ways to get the AID for stations and APs, >> but I can do two separate ways if you prefer that. > > I don't really agree that it's cleaner - by definition, the data in a > station is data about that station, not data about "self". > > We may not have a great way right now to show the latter ('data about > self')? But I still don't think we should mix it. Ok, I'll go poke at the code and see what I can figure out. Thanks, Ben -- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-03 15:02 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-02-18 1:11 Any reason AID is not in the NL80211_STA_INFO enumeration? Ben Greear 2020-02-28 10:06 ` Johannes Berg 2020-02-28 15:26 ` Ben Greear 2020-03-03 14:08 ` Johannes Berg 2020-03-03 14:57 ` Ben Greear 2020-03-03 14:59 ` Johannes Berg 2020-03-03 15:02 ` Ben Greear
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.