All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Steven Lee" <steven_lee@aspeedtech.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Joel Stanley" <joel@jms.id.au>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT" 
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT" 
	<linux-aspeed@lists.ozlabs.org>,
	"open list" <linux-kernel@vger.kernel.org>
Cc: "Hongwei Zhang" <Hongweiz@ami.com>,
	"Ryan Chen" <ryan_chen@aspeedtech.com>,
	"Billy Tsai" <billy_tsai@aspeedtech.com>
Subject: Re: [PATCH v1 1/4] dt-bindings: aspeed-sgpio: Convert txt bindings to yaml.
Date: Thu, 27 May 2021 10:27:37 +0930	[thread overview]
Message-ID: <5c0670b1-269c-4aae-8639-c0866ac90dc9@www.fastmail.com> (raw)
In-Reply-To: <20210526094609.14068-2-steven_lee@aspeedtech.com>

Hi Steven,

On Wed, 26 May 2021, at 19:16, Steven Lee wrote:
> SGPIO bindings should be converted as yaml format.
> In addition to the file conversion, a new property max-ngpios is
> added in the yaml file as well.
> The new property is required by the enhanced sgpio driver for
> making the configuration of the max number of gpio pins more flexible.

Please add the new property in a separate patch to the YAML conversion. 
Having changes to the properties in addition to switching to dt schema 
makes it harder to catch errors, and it seems Rob's bot has already 
picked up some.

Reviewing the changes as separate patches means its easier to give you 
a Reviewed-by tag on that patches I'm happy with.

Andrew

WARNING: multiple messages have this Message-ID (diff)
From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Steven Lee" <steven_lee@aspeedtech.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Joel Stanley" <joel@jms.id.au>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/ASPEED MACHINE SUPPORT"
	<linux-arm-kernel@lists.infradead.org>,
	 "moderated list:ARM/ASPEED MACHINE SUPPORT"
	<linux-aspeed@lists.ozlabs.org>,
	"open list" <linux-kernel@vger.kernel.org>
Cc: "Hongwei Zhang" <Hongweiz@ami.com>,
	"Ryan Chen" <ryan_chen@aspeedtech.com>,
	"Billy Tsai" <billy_tsai@aspeedtech.com>
Subject: Re: [PATCH v1 1/4] dt-bindings: aspeed-sgpio: Convert txt bindings to yaml.
Date: Thu, 27 May 2021 10:27:37 +0930	[thread overview]
Message-ID: <5c0670b1-269c-4aae-8639-c0866ac90dc9@www.fastmail.com> (raw)
In-Reply-To: <20210526094609.14068-2-steven_lee@aspeedtech.com>

Hi Steven,

On Wed, 26 May 2021, at 19:16, Steven Lee wrote:
> SGPIO bindings should be converted as yaml format.
> In addition to the file conversion, a new property max-ngpios is
> added in the yaml file as well.
> The new property is required by the enhanced sgpio driver for
> making the configuration of the max number of gpio pins more flexible.

Please add the new property in a separate patch to the YAML conversion. 
Having changes to the properties in addition to switching to dt schema 
makes it harder to catch errors, and it seems Rob's bot has already 
picked up some.

Reviewing the changes as separate patches means its easier to give you 
a Reviewed-by tag on that patches I'm happy with.

Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-05-27  0:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  9:46 [PATCH v1 0/4] ASPEED sgpio driver enhancement Steven Lee
2021-05-26  9:46 ` Steven Lee
2021-05-26  9:46 ` [PATCH v1 1/4] dt-bindings: aspeed-sgpio: Convert txt bindings to yaml Steven Lee
2021-05-26  9:46   ` Steven Lee
2021-05-26 12:56   ` Rob Herring
2021-05-26 12:56     ` Rob Herring
2021-05-27  2:45     ` Steven Lee
2021-05-27  2:45       ` Steven Lee
2021-05-27  0:57   ` Andrew Jeffery [this message]
2021-05-27  0:57     ` Andrew Jeffery
2021-05-27  1:03     ` Steven Lee
2021-05-27  1:03       ` Steven Lee
2021-05-27  1:42   ` Jeremy Kerr
2021-05-27  1:42     ` Jeremy Kerr
2021-05-27  2:58     ` Steven Lee
2021-05-27  2:58       ` Steven Lee
2021-05-26  9:46 ` [PATCH v1 2/4] ARM: dts: aspeed-g6: Add SGPIO node Steven Lee
2021-05-26  9:46   ` Steven Lee
2021-05-27  1:27   ` Andrew Jeffery
2021-05-27  1:27     ` Andrew Jeffery
2021-05-27  4:01     ` Steven Lee
2021-05-27  4:01       ` Steven Lee
2021-05-26  9:46 ` [PATCH v1 3/4] ARM: dts: aspeed-g5: Modify sgpio node for the enhanced sgpio driver Steven Lee
2021-05-26  9:46   ` Steven Lee
2021-05-26  9:46 ` [PATCH v1 4/4] gpio: gpio-aspeed-sgpio: Add AST2600 sgpio support Steven Lee
2021-05-26  9:46   ` Steven Lee
2021-05-26 14:04   ` kernel test robot
2021-05-26 14:04     ` kernel test robot
2021-05-26 14:04     ` kernel test robot
2021-05-26 14:05   ` kernel test robot
2021-05-26 14:05     ` kernel test robot
2021-05-26 14:05     ` kernel test robot
2021-05-27  1:26   ` Andrew Jeffery
2021-05-27  1:26     ` Andrew Jeffery
2021-05-27  2:34     ` Steven Lee
2021-05-27  2:34       ` Steven Lee
2021-05-27  3:04       ` Andrew Jeffery
2021-05-27  3:04         ` Andrew Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c0670b1-269c-4aae-8639-c0866ac90dc9@www.fastmail.com \
    --to=andrew@aj.id.au \
    --cc=Hongweiz@ami.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=billy_tsai@aspeedtech.com \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=ryan_chen@aspeedtech.com \
    --cc=steven_lee@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.