* [PATCH] Stagingdriver cctree: Fix for checkpatch warning
@ 2017-06-30 4:32 ` bincy_k_philip
0 siblings, 0 replies; 11+ messages in thread
From: bincy_k_philip @ 2017-06-30 4:32 UTC (permalink / raw)
To: gilad, gregkh; +Cc: devel, driverdev-devel, linux-crypto, Bincy K Philip
From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
Trivial fix for Line over 80 characters
Moved the comment to top of the definition
Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
---
drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
index aaa56c8..a18e6c9 100644
--- a/drivers/staging/ccree/cc_hw_queue_defs.h
+++ b/drivers/staging/ccree/cc_hw_queue_defs.h
@@ -27,7 +27,8 @@
******************************************************************************/
#define HW_DESC_SIZE_WORDS 6
-#define HW_QUEUE_SLOTS_MAX 15 /* Max. available slots in HW queue */
+/* Define max. available slots in HW queue */
+#define HW_QUEUE_SLOTS_MAX 15
#define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
--
1.8.3.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] Stagingdriver cctree: Fix for checkpatch warning
@ 2017-06-30 4:32 ` bincy_k_philip
0 siblings, 0 replies; 11+ messages in thread
From: bincy_k_philip @ 2017-06-30 4:32 UTC (permalink / raw)
To: gilad, gregkh; +Cc: devel, driverdev-devel, linux-crypto, Bincy K Philip
From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
Trivial fix for Line over 80 characters
Moved the comment to top of the definition
Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
---
drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
index aaa56c8..a18e6c9 100644
--- a/drivers/staging/ccree/cc_hw_queue_defs.h
+++ b/drivers/staging/ccree/cc_hw_queue_defs.h
@@ -27,7 +27,8 @@
******************************************************************************/
#define HW_DESC_SIZE_WORDS 6
-#define HW_QUEUE_SLOTS_MAX 15 /* Max. available slots in HW queue */
+/* Define max. available slots in HW queue */
+#define HW_QUEUE_SLOTS_MAX 15
#define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
--
1.8.3.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning
2017-06-30 4:32 ` bincy_k_philip
@ 2017-07-11 11:46 ` Gilad Ben-Yossef
-1 siblings, 0 replies; 11+ messages in thread
From: Gilad Ben-Yossef @ 2017-07-11 11:46 UTC (permalink / raw)
To: bincy_k_philip; +Cc: devel, Greg Kroah-Hartman, driverdev-devel, linux-crypto
Hello Philip,
Thank your patch.
Your patch subject line is not descriptive and not formatted well.
A better subject would be something like:
staging: ccree: move comment to fit coding style
Thanks,
Gilad
On Fri, Jun 30, 2017 at 7:32 AM, <bincy_k_philip@yahoo.co.in> wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>
> Trivial fix for Line over 80 characters
>
> Moved the comment to top of the definition
>
> Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
> ---
> drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
> index aaa56c8..a18e6c9 100644
> --- a/drivers/staging/ccree/cc_hw_queue_defs.h
> +++ b/drivers/staging/ccree/cc_hw_queue_defs.h
> @@ -27,7 +27,8 @@
> ******************************************************************************/
>
> #define HW_DESC_SIZE_WORDS 6
> -#define HW_QUEUE_SLOTS_MAX 15 /* Max. available slots in HW queue */
> +/* Define max. available slots in HW queue */
> +#define HW_QUEUE_SLOTS_MAX 15
>
> #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
>
> --
> 1.8.3.1
>
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning
@ 2017-07-11 11:46 ` Gilad Ben-Yossef
0 siblings, 0 replies; 11+ messages in thread
From: Gilad Ben-Yossef @ 2017-07-11 11:46 UTC (permalink / raw)
To: bincy_k_philip; +Cc: devel, Greg Kroah-Hartman, driverdev-devel, linux-crypto
Hello Philip,
Thank your patch.
Your patch subject line is not descriptive and not formatted well.
A better subject would be something like:
staging: ccree: move comment to fit coding style
Thanks,
Gilad
On Fri, Jun 30, 2017 at 7:32 AM, <bincy_k_philip@yahoo.co.in> wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>
> Trivial fix for Line over 80 characters
>
> Moved the comment to top of the definition
>
> Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
> ---
> drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
> index aaa56c8..a18e6c9 100644
> --- a/drivers/staging/ccree/cc_hw_queue_defs.h
> +++ b/drivers/staging/ccree/cc_hw_queue_defs.h
> @@ -27,7 +27,8 @@
> ******************************************************************************/
>
> #define HW_DESC_SIZE_WORDS 6
> -#define HW_QUEUE_SLOTS_MAX 15 /* Max. available slots in HW queue */
> +/* Define max. available slots in HW queue */
> +#define HW_QUEUE_SLOTS_MAX 15
>
> #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
>
> --
> 1.8.3.1
>
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning
2017-07-11 11:46 ` Gilad Ben-Yossef
@ 2017-07-12 8:53 ` bincy
-1 siblings, 0 replies; 11+ messages in thread
From: bincy @ 2017-07-12 8:53 UTC (permalink / raw)
To: Gilad Ben-Yossef; +Cc: devel, Greg Kroah-Hartman, driverdev-devel, linux-crypto
Hi Gilad,
I have added your comments and resent the patch.Thanks
On 11/07/17 17:16, Gilad Ben-Yossef wrote:
> Hello Philip,
>
> Thank your patch.
>
> Your patch subject line is not descriptive and not formatted well.
>
> A better subject would be something like:
>
> staging: ccree: move comment to fit coding style
>
> Thanks,
> Gilad
>
> On Fri, Jun 30, 2017 at 7:32 AM, <bincy_k_philip@yahoo.co.in> wrote:
>> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>>
>> Trivial fix for Line over 80 characters
>>
>> Moved the comment to top of the definition
>>
>> Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>> ---
>> drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
>> index aaa56c8..a18e6c9 100644
>> --- a/drivers/staging/ccree/cc_hw_queue_defs.h
>> +++ b/drivers/staging/ccree/cc_hw_queue_defs.h
>> @@ -27,7 +27,8 @@
>> ******************************************************************************/
>>
>> #define HW_DESC_SIZE_WORDS 6
>> -#define HW_QUEUE_SLOTS_MAX 15 /* Max. available slots in HW queue */
>> +/* Define max. available slots in HW queue */
>> +#define HW_QUEUE_SLOTS_MAX 15
>>
>> #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
>>
>> --
>> 1.8.3.1
>>
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning
@ 2017-07-12 8:53 ` bincy
0 siblings, 0 replies; 11+ messages in thread
From: bincy @ 2017-07-12 8:53 UTC (permalink / raw)
To: Gilad Ben-Yossef; +Cc: Greg Kroah-Hartman, linux-crypto, driverdev-devel, devel
Hi Gilad,
I have added your comments and resent the patch.Thanks
On 11/07/17 17:16, Gilad Ben-Yossef wrote:
> Hello Philip,
>
> Thank your patch.
>
> Your patch subject line is not descriptive and not formatted well.
>
> A better subject would be something like:
>
> staging: ccree: move comment to fit coding style
>
> Thanks,
> Gilad
>
> On Fri, Jun 30, 2017 at 7:32 AM, <bincy_k_philip@yahoo.co.in> wrote:
>> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>>
>> Trivial fix for Line over 80 characters
>>
>> Moved the comment to top of the definition
>>
>> Signed-off-by: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>> ---
>> drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
>> index aaa56c8..a18e6c9 100644
>> --- a/drivers/staging/ccree/cc_hw_queue_defs.h
>> +++ b/drivers/staging/ccree/cc_hw_queue_defs.h
>> @@ -27,7 +27,8 @@
>> ******************************************************************************/
>>
>> #define HW_DESC_SIZE_WORDS 6
>> -#define HW_QUEUE_SLOTS_MAX 15 /* Max. available slots in HW queue */
>> +/* Define max. available slots in HW queue */
>> +#define HW_QUEUE_SLOTS_MAX 15
>>
>> #define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
>>
>> --
>> 1.8.3.1
>>
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] Stagingdriver cctree: Fix for checkpatch warning
@ 2017-06-27 6:17 ` bincy_k_philip
0 siblings, 0 replies; 11+ messages in thread
From: bincy_k_philip @ 2017-06-27 6:17 UTC (permalink / raw)
To: gilad, gregkh
Cc: devel, Bincy K Philip, driverdev-devel, linux-crypto, linux-kernel
From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
Trivial fix for Line over 80 characters
Moved the comment to top of the definition
---
drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
index aaa56c8..a18e6c9 100644
--- a/drivers/staging/ccree/cc_hw_queue_defs.h
+++ b/drivers/staging/ccree/cc_hw_queue_defs.h
@@ -27,7 +27,8 @@
******************************************************************************/
#define HW_DESC_SIZE_WORDS 6
-#define HW_QUEUE_SLOTS_MAX 15 /* Max. available slots in HW queue */
+/* Define max. available slots in HW queue */
+#define HW_QUEUE_SLOTS_MAX 15
#define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
--
1.8.3.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] Stagingdriver cctree: Fix for checkpatch warning
@ 2017-06-27 6:17 ` bincy_k_philip
0 siblings, 0 replies; 11+ messages in thread
From: bincy_k_philip @ 2017-06-27 6:17 UTC (permalink / raw)
To: gilad, gregkh
Cc: devel, Bincy K Philip, driverdev-devel, linux-crypto, linux-kernel
From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
Trivial fix for Line over 80 characters
Moved the comment to top of the definition
---
drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
index aaa56c8..a18e6c9 100644
--- a/drivers/staging/ccree/cc_hw_queue_defs.h
+++ b/drivers/staging/ccree/cc_hw_queue_defs.h
@@ -27,7 +27,8 @@
******************************************************************************/
#define HW_DESC_SIZE_WORDS 6
-#define HW_QUEUE_SLOTS_MAX 15 /* Max. available slots in HW queue */
+/* Define max. available slots in HW queue */
+#define HW_QUEUE_SLOTS_MAX 15
#define CC_REG_NAME(word, name) DX_DSCRPTR_QUEUE_WORD ## word ## _ ## name
--
1.8.3.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning
2017-06-27 6:17 ` bincy_k_philip
(?)
@ 2017-06-29 14:36 ` Greg KH
-1 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2017-06-29 14:36 UTC (permalink / raw)
To: bincy_k_philip; +Cc: devel, driverdev-devel, linux-crypto, linux-kernel
On Tue, Jun 27, 2017 at 11:47:56AM +0530, bincy_k_philip@yahoo.co.in wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>
> Trivial fix for Line over 80 characters
>
> Moved the comment to top of the definition
> ---
> drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Always use scripts/checkpatch.pl on your patch so you don't get a grumpy
maintaner telling you to run scripts/checkpatch.pl on your patch :(
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning
@ 2017-06-29 14:36 ` Greg KH
0 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2017-06-29 14:36 UTC (permalink / raw)
To: bincy_k_philip; +Cc: devel, driverdev-devel, linux-crypto, linux-kernel
On Tue, Jun 27, 2017 at 11:47:56AM +0530, bincy_k_philip@yahoo.co.in wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>
> Trivial fix for Line over 80 characters
>
> Moved the comment to top of the definition
> ---
> drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Always use scripts/checkpatch.pl on your patch so you don't get a grumpy
maintaner telling you to run scripts/checkpatch.pl on your patch :(
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Stagingdriver cctree: Fix for checkpatch warning
@ 2017-06-29 14:36 ` Greg KH
0 siblings, 0 replies; 11+ messages in thread
From: Greg KH @ 2017-06-29 14:36 UTC (permalink / raw)
To: bincy_k_philip; +Cc: gilad, devel, driverdev-devel, linux-crypto, linux-kernel
On Tue, Jun 27, 2017 at 11:47:56AM +0530, bincy_k_philip@yahoo.co.in wrote:
> From: Bincy K Philip <bincy_k_philip@yahoo.co.in>
>
> Trivial fix for Line over 80 characters
>
> Moved the comment to top of the definition
> ---
> drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Always use scripts/checkpatch.pl on your patch so you don't get a grumpy
maintaner telling you to run scripts/checkpatch.pl on your patch :(
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-07-12 8:53 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 4:32 [PATCH] Stagingdriver cctree: Fix for checkpatch warning bincy_k_philip
2017-06-30 4:32 ` bincy_k_philip
2017-07-11 11:46 ` Gilad Ben-Yossef
2017-07-11 11:46 ` Gilad Ben-Yossef
2017-07-12 8:53 ` bincy
2017-07-12 8:53 ` bincy
-- strict thread matches above, loose matches on Subject: below --
2017-06-27 6:17 bincy_k_philip
2017-06-27 6:17 ` bincy_k_philip
2017-06-29 14:36 ` Greg KH
2017-06-29 14:36 ` Greg KH
2017-06-29 14:36 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.