From: "Nambiar, Amritha" <amritha.nambiar@intel.com> To: Jamal Hadi Salim <jhs@mojatatu.com>, intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com Cc: alexander.h.duyck@intel.com, kiran.patil@intel.com, netdev@vger.kernel.org, mitch.a.williams@intel.com, alexander.duyck@gmail.com, neerav.parikh@intel.com, sridhar.samudrala@intel.com, carolyn.wyborny@intel.com, Or Gerlitz <gerlitz.or@gmail.com> Subject: Re: [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier Date: Wed, 2 Aug 2017 11:20:01 -0700 [thread overview] Message-ID: <62e2edac-521a-0e7b-4ca5-936d93c6a613@intel.com> (raw) In-Reply-To: <382b07c6-562b-9dc6-a4be-8f82819ab87a@mojatatu.com> On 8/2/2017 5:02 AM, Jamal Hadi Salim wrote: > On 17-08-01 10:13 PM, Nambiar, Amritha wrote: >> >> On 8/1/2017 3:56 AM, Jamal Hadi Salim wrote: >>> On 17-07-31 08:38 PM, Amritha Nambiar wrote: >>>> This patch enables tc-flower based hardware offloads. tc/flower >>>> filter provided by the kernel is configured as driver specific >>>> cloud filter. The patch implements functions and admin queue >>>> commands needed to support cloud filters in the driver and >>>> adds cloud filters to configure these tc-flower filters. >>>> >>>> The only action supported is to redirect packets to a traffic class >>>> on the same device. >>>> >>>> # tc qdisc add dev eth0 ingress >>>> # ethtool -K eth0 hw-tc-offload on >>>> >>>> # tc filter add dev eth0 protocol ip parent ffff:\ >>>> prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 skip_sw indev eth0\ >>>> action mirred ingress redirect dev eth0 tc 0 >>>> >>> >>> Out of curiosity - did you need to say "indev eth0" there? >> >> It looks like I don't need to specify "indev eth0". I will need to look >> up how this part is offloaded and probably validate in the driver when >> this is specified. >> >>> Also: Is it possible to add an skbmark? Example something like >>> these that directs two flows to the same queue but different >>> skb marks: >>> >>> # tc filter add dev eth0 protocol ip parent ffff: \ >>> prio 2 flower dst_ip 192.168.3.5/32 \ >>> ip_proto udp dst_port 2a skip_sw \ >>> action skbedit mark 11 \ >>> action mirred ingress redirect dev eth0 tcqueue 1 >>> >>> # tc filter add dev eth0 protocol ip parent ffff: \ >>> prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 skip_sw \ >>> action skbedit mark 12 \ >>> action mirred ingress redirect dev eth0 tcqueue 1 >>> >> >> It is possible to support the skbedit mark action for the first rule >> here (L3 and L4) which I can take up in a subsequent patch, but this >> cannot be supported on our device for L2 based match in the second rule. >> > > Ok, thanks. So the issue is one of hardware limitation? > Right. Our hardware does not have this support now. > cheers, > jamal >
WARNING: multiple messages have this Message-ID (diff)
From: Nambiar, Amritha <amritha.nambiar@intel.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier Date: Wed, 2 Aug 2017 11:20:01 -0700 [thread overview] Message-ID: <62e2edac-521a-0e7b-4ca5-936d93c6a613@intel.com> (raw) In-Reply-To: <382b07c6-562b-9dc6-a4be-8f82819ab87a@mojatatu.com> On 8/2/2017 5:02 AM, Jamal Hadi Salim wrote: > On 17-08-01 10:13 PM, Nambiar, Amritha wrote: >> >> On 8/1/2017 3:56 AM, Jamal Hadi Salim wrote: >>> On 17-07-31 08:38 PM, Amritha Nambiar wrote: >>>> This patch enables tc-flower based hardware offloads. tc/flower >>>> filter provided by the kernel is configured as driver specific >>>> cloud filter. The patch implements functions and admin queue >>>> commands needed to support cloud filters in the driver and >>>> adds cloud filters to configure these tc-flower filters. >>>> >>>> The only action supported is to redirect packets to a traffic class >>>> on the same device. >>>> >>>> # tc qdisc add dev eth0 ingress >>>> # ethtool -K eth0 hw-tc-offload on >>>> >>>> # tc filter add dev eth0 protocol ip parent ffff:\ >>>> prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 skip_sw indev eth0\ >>>> action mirred ingress redirect dev eth0 tc 0 >>>> >>> >>> Out of curiosity - did you need to say "indev eth0" there? >> >> It looks like I don't need to specify "indev eth0". I will need to look >> up how this part is offloaded and probably validate in the driver when >> this is specified. >> >>> Also: Is it possible to add an skbmark? Example something like >>> these that directs two flows to the same queue but different >>> skb marks: >>> >>> # tc filter add dev eth0 protocol ip parent ffff: \ >>> prio 2 flower dst_ip 192.168.3.5/32 \ >>> ip_proto udp dst_port 2a skip_sw \ >>> action skbedit mark 11 \ >>> action mirred ingress redirect dev eth0 tcqueue 1 >>> >>> # tc filter add dev eth0 protocol ip parent ffff: \ >>> prio 1 flower dst_mac 3c:fd:fe:a0:d6:70 skip_sw \ >>> action skbedit mark 12 \ >>> action mirred ingress redirect dev eth0 tcqueue 1 >>> >> >> It is possible to support the skbedit mark action for the first rule >> here (L3 and L4) which I can take up in a subsequent patch, but this >> cannot be supported on our device for L2 based match in the second rule. >> > > Ok, thanks. So the issue is one of hardware limitation? > Right. Our hardware does not have this support now. > cheers, > jamal >
next prev parent reply other threads:[~2017-08-02 18:20 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-01 0:36 [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier Amritha Nambiar 2017-08-01 0:36 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 0:37 ` [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class Amritha Nambiar 2017-08-01 0:37 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 10:22 ` Jamal Hadi Salim 2017-08-01 10:22 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 1:12 ` Nambiar, Amritha 2017-08-02 1:12 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-01 10:44 ` Jamal Hadi Salim 2017-08-01 10:44 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 1:42 ` Nambiar, Amritha 2017-08-02 1:42 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-01 11:12 ` Jiri Pirko 2017-08-01 11:12 ` [Intel-wired-lan] " Jiri Pirko 2017-08-02 2:20 ` Nambiar, Amritha 2017-08-02 2:20 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-01 0:37 ` [PATCH 2/6] [net-next]net: i40e: Maintain a mapping of TCs with the VSI seids Amritha Nambiar 2017-08-01 0:37 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 0:37 ` [PATCH 3/6] [net-next]net: i40e: Extend set switch config command to accept cloud filter mode Amritha Nambiar 2017-08-01 0:37 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 10:48 ` Jamal Hadi Salim 2017-08-01 10:48 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-01 0:37 ` [PATCH 4/6] [net-next]net: i40e: Admin queue definitions for cloud filters Amritha Nambiar 2017-08-01 0:37 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 19:16 ` Shannon Nelson 2017-08-01 19:16 ` Shannon Nelson 2017-08-14 18:59 ` Nambiar, Amritha 2017-08-14 18:59 ` Nambiar, Amritha 2017-08-01 0:38 ` [PATCH 5/6] [net-next]net: i40e: Clean up of " Amritha Nambiar 2017-08-01 0:38 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 19:16 ` Shannon Nelson 2017-08-01 19:16 ` Shannon Nelson 2017-08-14 19:06 ` Nambiar, Amritha 2017-08-14 19:06 ` Nambiar, Amritha 2017-08-01 0:38 ` [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier Amritha Nambiar 2017-08-01 0:38 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 10:56 ` Jamal Hadi Salim 2017-08-01 10:56 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 2:13 ` Nambiar, Amritha 2017-08-02 2:13 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-02 12:02 ` Jamal Hadi Salim 2017-08-02 12:02 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 18:20 ` Nambiar, Amritha [this message] 2017-08-02 18:20 ` Nambiar, Amritha 2017-08-01 19:16 ` Shannon Nelson 2017-08-01 19:16 ` Shannon Nelson 2017-08-14 19:21 ` Nambiar, Amritha 2017-08-14 19:21 ` Nambiar, Amritha 2017-08-01 10:15 ` [PATCH net-next RFC 0/6] Configure " Jamal Hadi Salim 2017-08-01 10:15 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 0:57 ` Nambiar, Amritha 2017-08-02 0:57 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-02 12:01 ` Jamal Hadi Salim 2017-08-02 12:01 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 18:17 ` Nambiar, Amritha 2017-08-02 18:17 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-01 19:16 ` Shannon Nelson 2017-08-01 19:16 ` Shannon Nelson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=62e2edac-521a-0e7b-4ca5-936d93c6a613@intel.com \ --to=amritha.nambiar@intel.com \ --cc=alexander.duyck@gmail.com \ --cc=alexander.h.duyck@intel.com \ --cc=carolyn.wyborny@intel.com \ --cc=gerlitz.or@gmail.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jeffrey.t.kirsher@intel.com \ --cc=jhs@mojatatu.com \ --cc=kiran.patil@intel.com \ --cc=mitch.a.williams@intel.com \ --cc=neerav.parikh@intel.com \ --cc=netdev@vger.kernel.org \ --cc=sridhar.samudrala@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.