From: "Nambiar, Amritha" <amritha.nambiar@intel.com> To: Jamal Hadi Salim <jhs@mojatatu.com>, intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com Cc: alexander.h.duyck@intel.com, kiran.patil@intel.com, netdev@vger.kernel.org, mitch.a.williams@intel.com, alexander.duyck@gmail.com, neerav.parikh@intel.com, sridhar.samudrala@intel.com, carolyn.wyborny@intel.com, Or Gerlitz <gerlitz.or@gmail.com> Subject: Re: [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier Date: Tue, 1 Aug 2017 17:57:06 -0700 [thread overview] Message-ID: <78fbc08d-f846-a3e4-ffbd-f0cba43780e3@intel.com> (raw) In-Reply-To: <2d833571-a5f3-41a6-0e6c-9d2c27b0a8c5@mojatatu.com> On 8/1/2017 3:15 AM, Jamal Hadi Salim wrote: > On 17-07-31 08:36 PM, Amritha Nambiar wrote: >> This patch series enables configuring cloud filters in i40e >> using the tc/flower classifier. The only tc-filter action >> supported is to redirect packets to a traffic class on the >> same device. The tc/mirred:redirect action is extended to >> accept a traffic class to achieve this. >> >> The cloud filters are added for a VSI and are cleaned up when >> the VSI is deleted. The filters that match on L4 ports needs >> enhanced admin queue functions with big buffer support for >> extended general fields in Add/Remove Cloud filters command. >> >> Example: >> # tc qdisc add dev eth0 ingress >> >> # ethtool -K eth0 hw-tc-offload on >> >> # tc filter add dev eth0 protocol ip parent ffff: prio 1 flower\ >> dst_ip 192.168.1.1/32 ip_proto udp dst_port 22\ >> skip_sw indev eth0 action mirred ingress redirect dev eth0 tc 1 >> > > I think "queue 1" sounds better than "tc 1". > "tc" is already a keyword in a few places (even within that declaration > above). The idea is to redirect to a traffic class that has queues assigned to it and not a single queue i.e. these are actually queue groups and not a single queue. So may be "qgroup 1" or "tcqgroup 1" fits better. > > cheers, > jamal >
WARNING: multiple messages have this Message-ID (diff)
From: Nambiar, Amritha <amritha.nambiar@intel.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier Date: Tue, 1 Aug 2017 17:57:06 -0700 [thread overview] Message-ID: <78fbc08d-f846-a3e4-ffbd-f0cba43780e3@intel.com> (raw) In-Reply-To: <2d833571-a5f3-41a6-0e6c-9d2c27b0a8c5@mojatatu.com> On 8/1/2017 3:15 AM, Jamal Hadi Salim wrote: > On 17-07-31 08:36 PM, Amritha Nambiar wrote: >> This patch series enables configuring cloud filters in i40e >> using the tc/flower classifier. The only tc-filter action >> supported is to redirect packets to a traffic class on the >> same device. The tc/mirred:redirect action is extended to >> accept a traffic class to achieve this. >> >> The cloud filters are added for a VSI and are cleaned up when >> the VSI is deleted. The filters that match on L4 ports needs >> enhanced admin queue functions with big buffer support for >> extended general fields in Add/Remove Cloud filters command. >> >> Example: >> # tc qdisc add dev eth0 ingress >> >> # ethtool -K eth0 hw-tc-offload on >> >> # tc filter add dev eth0 protocol ip parent ffff: prio 1 flower\ >> dst_ip 192.168.1.1/32 ip_proto udp dst_port 22\ >> skip_sw indev eth0 action mirred ingress redirect dev eth0 tc 1 >> > > I think "queue 1" sounds better than "tc 1". > "tc" is already a keyword in a few places (even within that declaration > above). The idea is to redirect to a traffic class that has queues assigned to it and not a single queue i.e. these are actually queue groups and not a single queue. So may be "qgroup 1" or "tcqgroup 1" fits better. > > cheers, > jamal >
next prev parent reply other threads:[~2017-08-02 0:57 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-01 0:36 [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier Amritha Nambiar 2017-08-01 0:36 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 0:37 ` [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class Amritha Nambiar 2017-08-01 0:37 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 10:22 ` Jamal Hadi Salim 2017-08-01 10:22 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 1:12 ` Nambiar, Amritha 2017-08-02 1:12 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-01 10:44 ` Jamal Hadi Salim 2017-08-01 10:44 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 1:42 ` Nambiar, Amritha 2017-08-02 1:42 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-01 11:12 ` Jiri Pirko 2017-08-01 11:12 ` [Intel-wired-lan] " Jiri Pirko 2017-08-02 2:20 ` Nambiar, Amritha 2017-08-02 2:20 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-01 0:37 ` [PATCH 2/6] [net-next]net: i40e: Maintain a mapping of TCs with the VSI seids Amritha Nambiar 2017-08-01 0:37 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 0:37 ` [PATCH 3/6] [net-next]net: i40e: Extend set switch config command to accept cloud filter mode Amritha Nambiar 2017-08-01 0:37 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 10:48 ` Jamal Hadi Salim 2017-08-01 10:48 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-01 0:37 ` [PATCH 4/6] [net-next]net: i40e: Admin queue definitions for cloud filters Amritha Nambiar 2017-08-01 0:37 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 19:16 ` Shannon Nelson 2017-08-01 19:16 ` Shannon Nelson 2017-08-14 18:59 ` Nambiar, Amritha 2017-08-14 18:59 ` Nambiar, Amritha 2017-08-01 0:38 ` [PATCH 5/6] [net-next]net: i40e: Clean up of " Amritha Nambiar 2017-08-01 0:38 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 19:16 ` Shannon Nelson 2017-08-01 19:16 ` Shannon Nelson 2017-08-14 19:06 ` Nambiar, Amritha 2017-08-14 19:06 ` Nambiar, Amritha 2017-08-01 0:38 ` [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier Amritha Nambiar 2017-08-01 0:38 ` [Intel-wired-lan] " Amritha Nambiar 2017-08-01 10:56 ` Jamal Hadi Salim 2017-08-01 10:56 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 2:13 ` Nambiar, Amritha 2017-08-02 2:13 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-02 12:02 ` Jamal Hadi Salim 2017-08-02 12:02 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 18:20 ` Nambiar, Amritha 2017-08-02 18:20 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-01 19:16 ` Shannon Nelson 2017-08-01 19:16 ` Shannon Nelson 2017-08-14 19:21 ` Nambiar, Amritha 2017-08-14 19:21 ` Nambiar, Amritha 2017-08-01 10:15 ` [PATCH net-next RFC 0/6] Configure " Jamal Hadi Salim 2017-08-01 10:15 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 0:57 ` Nambiar, Amritha [this message] 2017-08-02 0:57 ` Nambiar, Amritha 2017-08-02 12:01 ` Jamal Hadi Salim 2017-08-02 12:01 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-08-02 18:17 ` Nambiar, Amritha 2017-08-02 18:17 ` [Intel-wired-lan] " Nambiar, Amritha 2017-08-01 19:16 ` Shannon Nelson 2017-08-01 19:16 ` Shannon Nelson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=78fbc08d-f846-a3e4-ffbd-f0cba43780e3@intel.com \ --to=amritha.nambiar@intel.com \ --cc=alexander.duyck@gmail.com \ --cc=alexander.h.duyck@intel.com \ --cc=carolyn.wyborny@intel.com \ --cc=gerlitz.or@gmail.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jeffrey.t.kirsher@intel.com \ --cc=jhs@mojatatu.com \ --cc=kiran.patil@intel.com \ --cc=mitch.a.williams@intel.com \ --cc=neerav.parikh@intel.com \ --cc=netdev@vger.kernel.org \ --cc=sridhar.samudrala@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.