All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Nam Cao <namcaov@gmail.com>, lkp@intel.com
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 0/4] remove useless files
Date: Sat, 20 Aug 2022 14:17:12 +0200	[thread overview]
Message-ID: <63626444-a7ee-a0c4-ec0a-f44a810e25ea@redhat.com> (raw)
In-Reply-To: <cover.1660977535.git.namcaov@gmail.com>

Hi,

Patch 1/4 seems to be missing?

Also please squash patches 3 and 4:

   staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile
   staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c

together. Ion other words remove both the files and the Makefile
target in a single patch please.

Regards,

Hans


On 8/20/22 08:42, Nam Cao wrote:
> Delete odm_NoiseMonitor.c and odm_NoiseMonitor.h because they are
> useless. The first 2 commits are preparation, and the final commit is
> actual removal.
> 
> v2: Add new patch to remove the file from Makefile, otherwise there is
> build error as reported by kernel test bot.
> 
> Nam Cao (4):
>   staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor
>   staging: rtl8723bs: remove member noise_level from struct dm_odm_t
>   staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile
>   staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c
> 
>  drivers/staging/rtl8723bs/Makefile            |   1 -
>  drivers/staging/rtl8723bs/hal/odm.h           |   2 -
>  .../staging/rtl8723bs/hal/odm_NoiseMonitor.c  | 130 ------------------
>  .../staging/rtl8723bs/hal/odm_NoiseMonitor.h  |  39 ------
>  drivers/staging/rtl8723bs/hal/odm_precomp.h   |   1 -
>  5 files changed, 173 deletions(-)
>  delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c
>  delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h
> 


WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 0/4] remove useless files
Date: Sat, 20 Aug 2022 14:17:12 +0200	[thread overview]
Message-ID: <63626444-a7ee-a0c4-ec0a-f44a810e25ea@redhat.com> (raw)
In-Reply-To: <cover.1660977535.git.namcaov@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

Hi,

Patch 1/4 seems to be missing?

Also please squash patches 3 and 4:

   staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile
   staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c

together. Ion other words remove both the files and the Makefile
target in a single patch please.

Regards,

Hans


On 8/20/22 08:42, Nam Cao wrote:
> Delete odm_NoiseMonitor.c and odm_NoiseMonitor.h because they are
> useless. The first 2 commits are preparation, and the final commit is
> actual removal.
> 
> v2: Add new patch to remove the file from Makefile, otherwise there is
> build error as reported by kernel test bot.
> 
> Nam Cao (4):
>   staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor
>   staging: rtl8723bs: remove member noise_level from struct dm_odm_t
>   staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile
>   staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c
> 
>  drivers/staging/rtl8723bs/Makefile            |   1 -
>  drivers/staging/rtl8723bs/hal/odm.h           |   2 -
>  .../staging/rtl8723bs/hal/odm_NoiseMonitor.c  | 130 ------------------
>  .../staging/rtl8723bs/hal/odm_NoiseMonitor.h  |  39 ------
>  drivers/staging/rtl8723bs/hal/odm_precomp.h   |   1 -
>  5 files changed, 173 deletions(-)
>  delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c
>  delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h
> 

  parent reply	other threads:[~2022-08-20 12:17 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19  9:35 [PATCH 0/3] staging: rtl8723bs: remove useless files Nam Cao
2022-08-19  9:35 ` [PATCH 1/3] staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor Nam Cao
2022-08-19  9:35 ` [PATCH 2/3] staging: rtl8723bs: remove member noise_level from struct dm_odm_t Nam Cao
2022-08-19  9:35 ` [PATCH 3/3] staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c Nam Cao
2022-08-19 20:18   ` kernel test robot
2022-08-20  6:42     ` [PATCH v2 0/4] remove useless files Nam Cao
2022-08-20  6:42       ` Nam Cao
2022-08-20  6:42       ` [PATCH v2 1/4] staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor Nam Cao
2022-08-20  6:42         ` Nam Cao
2022-08-20  6:42       ` [PATCH v2 2/4] staging: rtl8723bs: remove member noise_level from struct dm_odm_t Nam Cao
2022-08-20  6:42         ` Nam Cao
2022-08-20  6:42       ` [PATCH v2 3/4] staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile Nam Cao
2022-08-20  6:42         ` Nam Cao
2022-08-20  6:42       ` [PATCH v2 4/4] staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c Nam Cao
2022-08-20  6:42         ` Nam Cao
2022-08-20 12:17       ` Hans de Goede [this message]
2022-08-20 12:17         ` [PATCH v2 0/4] remove useless files Hans de Goede
2022-08-20 14:35         ` Nam Cao
2022-08-20 14:35           ` Nam Cao
2022-08-20 14:59           ` Hans de Goede
2022-08-20 14:59             ` Hans de Goede
2022-08-20 18:00             ` [PATCH v3 0/3] " Nam Cao
2022-08-20 18:00               ` Nam Cao
2022-08-20 18:34               ` [PATCH v3 1/3] staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor Nam Cao
2022-08-20 18:34                 ` Nam Cao
2022-08-20 18:34                 ` [PATCH v3 2/3] staging: rtl8723bs: remove member noise_level from struct dm_odm_t Nam Cao
2022-08-20 18:34                   ` Nam Cao
2022-08-20 18:34                 ` [PATCH v3 3/3] staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c Nam Cao
2022-08-20 18:34                   ` Nam Cao
2022-08-20 19:14               ` [PATCH v3 0/3] remove useless files Hans de Goede
2022-08-20 19:14                 ` Hans de Goede
2022-08-20  2:50   ` [PATCH 3/3] staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c kernel test robot
2022-08-19  9:41 ` [PATCH 0/3] staging: rtl8723bs: remove useless files Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63626444-a7ee-a0c4-ec0a-f44a810e25ea@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=lkp@intel.com \
    --cc=namcaov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.