From: Nam Cao <namcaov@gmail.com> To: Hans de Goede <hdegoede@redhat.com> Cc: lkp@intel.com, Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2 0/4] remove useless files Date: Sat, 20 Aug 2022 16:35:50 +0200 [thread overview] Message-ID: <CA+sZ8B8ouMSMmArTVzbkqeWQx4Zqg2=gPaviTrkOFvBoswv_Jg@mail.gmail.com> (raw) In-Reply-To: <63626444-a7ee-a0c4-ec0a-f44a810e25ea@redhat.com> Hi On Sat, Aug 20, 2022 at 2:17 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi, > > Patch 1/4 seems to be missing? Patch 1/4 is there: https://lore.kernel.org/linux-staging/46d73e331bae2192a328f6691763f39ea6c18b08.1660977536.git.namcaov@gmail.com/ > > Also please squash patches 3 and 4: > > staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile > staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c > > together. Ion other words remove both the files and the Makefile > target in a single patch please. Sorry but I am not sure what I am supposed to do with kernel test bot. I agree that it makes sense to squash these 2 commits together. However, I separated them because I want to have 1 patch addressing the problem reported by the bot, so that I can put the "Reported-by" line to this patch. If I squash them, should I still put in the "Reported-by" line, despite the commit not exactly fixing the reported error. Or should I just leave it out? > > Regards, > > Hans > Thanks for spending time reviewing. Best regards, Nam
WARNING: multiple messages have this Message-ID (diff)
From: Nam Cao <namcaov@gmail.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 0/4] remove useless files Date: Sat, 20 Aug 2022 16:35:50 +0200 [thread overview] Message-ID: <CA+sZ8B8ouMSMmArTVzbkqeWQx4Zqg2=gPaviTrkOFvBoswv_Jg@mail.gmail.com> (raw) In-Reply-To: <63626444-a7ee-a0c4-ec0a-f44a810e25ea@redhat.com> [-- Attachment #1: Type: text/plain, Size: 1110 bytes --] Hi On Sat, Aug 20, 2022 at 2:17 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi, > > Patch 1/4 seems to be missing? Patch 1/4 is there: https://lore.kernel.org/linux-staging/46d73e331bae2192a328f6691763f39ea6c18b08.1660977536.git.namcaov(a)gmail.com/ > > Also please squash patches 3 and 4: > > staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile > staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c > > together. Ion other words remove both the files and the Makefile > target in a single patch please. Sorry but I am not sure what I am supposed to do with kernel test bot. I agree that it makes sense to squash these 2 commits together. However, I separated them because I want to have 1 patch addressing the problem reported by the bot, so that I can put the "Reported-by" line to this patch. If I squash them, should I still put in the "Reported-by" line, despite the commit not exactly fixing the reported error. Or should I just leave it out? > > Regards, > > Hans > Thanks for spending time reviewing. Best regards, Nam
next prev parent reply other threads:[~2022-08-20 14:36 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-19 9:35 [PATCH 0/3] staging: rtl8723bs: remove useless files Nam Cao 2022-08-19 9:35 ` [PATCH 1/3] staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor Nam Cao 2022-08-19 9:35 ` [PATCH 2/3] staging: rtl8723bs: remove member noise_level from struct dm_odm_t Nam Cao 2022-08-19 9:35 ` [PATCH 3/3] staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c Nam Cao 2022-08-19 20:18 ` kernel test robot 2022-08-20 6:42 ` [PATCH v2 0/4] remove useless files Nam Cao 2022-08-20 6:42 ` Nam Cao 2022-08-20 6:42 ` [PATCH v2 1/4] staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor Nam Cao 2022-08-20 6:42 ` Nam Cao 2022-08-20 6:42 ` [PATCH v2 2/4] staging: rtl8723bs: remove member noise_level from struct dm_odm_t Nam Cao 2022-08-20 6:42 ` Nam Cao 2022-08-20 6:42 ` [PATCH v2 3/4] staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile Nam Cao 2022-08-20 6:42 ` Nam Cao 2022-08-20 6:42 ` [PATCH v2 4/4] staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c Nam Cao 2022-08-20 6:42 ` Nam Cao 2022-08-20 12:17 ` [PATCH v2 0/4] remove useless files Hans de Goede 2022-08-20 12:17 ` Hans de Goede 2022-08-20 14:35 ` Nam Cao [this message] 2022-08-20 14:35 ` Nam Cao 2022-08-20 14:59 ` Hans de Goede 2022-08-20 14:59 ` Hans de Goede 2022-08-20 18:00 ` [PATCH v3 0/3] " Nam Cao 2022-08-20 18:00 ` Nam Cao 2022-08-20 18:34 ` [PATCH v3 1/3] staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor Nam Cao 2022-08-20 18:34 ` Nam Cao 2022-08-20 18:34 ` [PATCH v3 2/3] staging: rtl8723bs: remove member noise_level from struct dm_odm_t Nam Cao 2022-08-20 18:34 ` Nam Cao 2022-08-20 18:34 ` [PATCH v3 3/3] staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c Nam Cao 2022-08-20 18:34 ` Nam Cao 2022-08-20 19:14 ` [PATCH v3 0/3] remove useless files Hans de Goede 2022-08-20 19:14 ` Hans de Goede 2022-08-20 2:50 ` [PATCH 3/3] staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c kernel test robot 2022-08-19 9:41 ` [PATCH 0/3] staging: rtl8723bs: remove useless files Hans de Goede
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+sZ8B8ouMSMmArTVzbkqeWQx4Zqg2=gPaviTrkOFvBoswv_Jg@mail.gmail.com' \ --to=namcaov@gmail.com \ --cc=Larry.Finger@lwfinger.net \ --cc=gregkh@linuxfoundation.org \ --cc=hdegoede@redhat.com \ --cc=kbuild-all@lists.01.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-staging@lists.linux.dev \ --cc=lkp@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.