Re: [PATCH v3 0/3] remove useless files

From: Hans de Goede <hdegoede@redhat.com>
To: Nam Cao <namcaov@gmail.com>
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	linux-staging@lists.linux.dev, lkp@intel.com
Subject: Re: [PATCH v3 0/3] remove useless files
Date: Sat, 20 Aug 2022 21:14:47 +0200	[thread overview]
Message-ID: <a74584a3-fc47-b458-2d1f-8e03beba7d9c@redhat.com> (raw)
In-Reply-To: <cover.1661017377.git.namcaov@gmail.com>

Hi Nam,

On 8/20/22 20:00, Nam Cao wrote:
> Delete odm_NoiseMonitor.c and odm_NoiseMonitor.h because they are
> useless. The first 2 commits are preparation, and the final commit is
> actual removal.
> 
> v2: Add new patch to remove the file from Makefile, otherwise there is
>     build error as reported by kernel test bot.
> v3: Squash some commits together. The patchset functionally remains
>     the same.
> 
> Nam Cao (3):
>   staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor
>   staging: rtl8723bs: remove member noise_level from struct dm_odm_t
>   staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c
> 
>  drivers/staging/rtl8723bs/Makefile            |   1 -
>  drivers/staging/rtl8723bs/hal/odm.h           |   2 -
>  .../staging/rtl8723bs/hal/odm_NoiseMonitor.c  | 130 ------------------
>  .../staging/rtl8723bs/hal/odm_NoiseMonitor.h  |  39 ------
>  drivers/staging/rtl8723bs/hal/odm_precomp.h   |   1 -
>  5 files changed, 173 deletions(-)
>  delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c
>  delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h

Thank you for the new version, the entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans