* [PATCH 0/2] change command line for ddp
@ 2017-04-01 6:56 Beilei Xing
2017-04-01 6:56 ` [PATCH 1/2] app/testpmd: change command line of loading profile Beilei Xing
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Beilei Xing @ 2017-04-01 6:56 UTC (permalink / raw)
To: jingjing.wu; +Cc: dev
This patch set changes CLI for ddp to align with other
CLIs.
Beilei Xing (2):
app/testpmd: change command line of loading profile
app/testpmd: change command line of getting profile info
app/test-pmd/cmdline.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
--
2.5.5
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/2] app/testpmd: change command line of loading profile 2017-04-01 6:56 [PATCH 0/2] change command line for ddp Beilei Xing @ 2017-04-01 6:56 ` Beilei Xing 2017-04-01 6:56 ` [PATCH 2/2] app/testpmd: change command line of getting profile info Beilei Xing 2017-04-01 7:57 ` [PATCH v2 0/2] change command line for ddp Beilei Xing 2 siblings, 0 replies; 9+ messages in thread From: Beilei Xing @ 2017-04-01 6:56 UTC (permalink / raw) To: jingjing.wu; +Cc: dev This patch changes CLI of loading profile from "add ddp (port_id) (profile_path)" to "ddp add (port_id) (profile_path)" which is more consistent with other CLIs. Signed-off-by: Beilei Xing <beilei.xing@intel.com> --- app/test-pmd/cmdline.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index aac4efb..984db35 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -593,7 +593,7 @@ static void cmd_help_long_parsed(void *parsed_result, "E-tag set filter del e-tag-id (value) port (port_id)\n" " Delete an E-tag forwarding filter on a port\n\n" - "add ddp (port_id) (profile_path)\n" + "ddp add (port_id) (profile_path)\n" " Load a profile package on a port\n\n" , list_pkt_forwarding_modes() @@ -12747,16 +12747,16 @@ cmdline_parse_inst_t cmd_strict_link_prio = { /* Load dynamic device personalization*/ struct cmd_add_ddp_result { - cmdline_fixed_string_t add; cmdline_fixed_string_t ddp; + cmdline_fixed_string_t add; uint8_t port_id; char filepath[]; }; -cmdline_parse_token_string_t cmd_add_ddp_add = - TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, add, "add"); cmdline_parse_token_string_t cmd_add_ddp_ddp = TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, ddp, "ddp"); +cmdline_parse_token_string_t cmd_add_ddp_add = + TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, add, "add"); cmdline_parse_token_num_t cmd_add_ddp_port_id = TOKEN_NUM_INITIALIZER(struct cmd_add_ddp_result, port_id, UINT8); cmdline_parse_token_string_t cmd_add_ddp_filepath = @@ -12805,10 +12805,10 @@ cmd_add_ddp_parsed( cmdline_parse_inst_t cmd_add_ddp = { .f = cmd_add_ddp_parsed, .data = NULL, - .help_str = "add/remove ddp <port_id> <profile_path>", + .help_str = "ddp add <port_id> <profile_path>", .tokens = { - (void *)&cmd_add_ddp_add, (void *)&cmd_add_ddp_ddp, + (void *)&cmd_add_ddp_add, (void *)&cmd_add_ddp_port_id, (void *)&cmd_add_ddp_filepath, NULL, -- 2.5.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] app/testpmd: change command line of getting profile info 2017-04-01 6:56 [PATCH 0/2] change command line for ddp Beilei Xing 2017-04-01 6:56 ` [PATCH 1/2] app/testpmd: change command line of loading profile Beilei Xing @ 2017-04-01 6:56 ` Beilei Xing 2017-04-01 7:57 ` [PATCH v2 0/2] change command line for ddp Beilei Xing 2 siblings, 0 replies; 9+ messages in thread From: Beilei Xing @ 2017-04-01 6:56 UTC (permalink / raw) To: jingjing.wu; +Cc: dev This patch changes CLI of getting loaded profile info list from "get ddp list (port_id)" to "ddp get list (port_id)" which is more consistent with other CLIs. Signed-off-by: Beilei Xing <beilei.xing@intel.com> --- app/test-pmd/cmdline.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 984db35..274cc36 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -215,7 +215,7 @@ static void cmd_help_long_parsed(void *parsed_result, "read txd (port_id) (queue_id) (txd_id)\n" " Display a TX descriptor of a port TX queue.\n\n" - "get ddp list (port_id)\n" + "ddp get list (port_id)\n" " Get ddp profile info list\n\n" ); } @@ -12820,16 +12820,16 @@ cmdline_parse_inst_t cmd_add_ddp = { #define MAX_PROFILE_NUM 16 struct cmd_get_ddp_list_result { - cmdline_fixed_string_t get; cmdline_fixed_string_t ddp; + cmdline_fixed_string_t get; cmdline_fixed_string_t list; uint8_t port_id; }; -cmdline_parse_token_string_t cmd_get_ddp_list_get = - TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, get, "get"); cmdline_parse_token_string_t cmd_get_ddp_list_ddp = TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, ddp, "ddp"); +cmdline_parse_token_string_t cmd_get_ddp_list_get = + TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, get, "get"); cmdline_parse_token_string_t cmd_get_ddp_list_list = TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, list, "list"); cmdline_parse_token_num_t cmd_get_ddp_list_port_id = @@ -12893,10 +12893,10 @@ cmd_get_ddp_list_parsed( cmdline_parse_inst_t cmd_get_ddp_list = { .f = cmd_get_ddp_list_parsed, .data = NULL, - .help_str = "get ddp list <port_id>", + .help_str = "ddp get list <port_id>", .tokens = { - (void *)&cmd_get_ddp_list_get, (void *)&cmd_get_ddp_list_ddp, + (void *)&cmd_get_ddp_list_get, (void *)&cmd_get_ddp_list_list, (void *)&cmd_get_ddp_list_port_id, NULL, -- 2.5.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 0/2] change command line for ddp 2017-04-01 6:56 [PATCH 0/2] change command line for ddp Beilei Xing 2017-04-01 6:56 ` [PATCH 1/2] app/testpmd: change command line of loading profile Beilei Xing 2017-04-01 6:56 ` [PATCH 2/2] app/testpmd: change command line of getting profile info Beilei Xing @ 2017-04-01 7:57 ` Beilei Xing 2017-04-01 7:57 ` [PATCH v2 1/2] app/testpmd: change command line of loading profile Beilei Xing 2017-04-01 7:57 ` [PATCH v2 2/2] app/testpmd: change command line of getting profile info Beilei Xing 2 siblings, 2 replies; 9+ messages in thread From: Beilei Xing @ 2017-04-01 7:57 UTC (permalink / raw) To: jingjing.wu; +Cc: dev This patch set changes CLI for ddp to align with other CLIs. v2 changes: Change structure name and function name. Beilei Xing (2): app/testpmd: change command line of loading profile app/testpmd: change command line of getting profile info app/test-pmd/cmdline.c | 84 +++++++++++++++++++++++++------------------------- 1 file changed, 42 insertions(+), 42 deletions(-) -- 2.5.5 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/2] app/testpmd: change command line of loading profile 2017-04-01 7:57 ` [PATCH v2 0/2] change command line for ddp Beilei Xing @ 2017-04-01 7:57 ` Beilei Xing 2017-04-01 8:23 ` Lu, Wenzhuo 2017-04-03 12:30 ` Ferruh Yigit 2017-04-01 7:57 ` [PATCH v2 2/2] app/testpmd: change command line of getting profile info Beilei Xing 1 sibling, 2 replies; 9+ messages in thread From: Beilei Xing @ 2017-04-01 7:57 UTC (permalink / raw) To: jingjing.wu; +Cc: dev This patch changes CLI of loading profile from "add ddp (port_id) (profile_path)" to "ddp add (port_id) (profile_path)" which is more consistent with other CLIs. Signed-off-by: Beilei Xing <beilei.xing@intel.com> --- app/test-pmd/cmdline.c | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index aac4efb..3a448b3 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -593,7 +593,7 @@ static void cmd_help_long_parsed(void *parsed_result, "E-tag set filter del e-tag-id (value) port (port_id)\n" " Delete an E-tag forwarding filter on a port\n\n" - "add ddp (port_id) (profile_path)\n" + "ddp add (port_id) (profile_path)\n" " Load a profile package on a port\n\n" , list_pkt_forwarding_modes() @@ -12746,29 +12746,29 @@ cmdline_parse_inst_t cmd_strict_link_prio = { }; /* Load dynamic device personalization*/ -struct cmd_add_ddp_result { - cmdline_fixed_string_t add; +struct cmd_ddp_add_result { cmdline_fixed_string_t ddp; + cmdline_fixed_string_t add; uint8_t port_id; char filepath[]; }; -cmdline_parse_token_string_t cmd_add_ddp_add = - TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, add, "add"); -cmdline_parse_token_string_t cmd_add_ddp_ddp = - TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, ddp, "ddp"); -cmdline_parse_token_num_t cmd_add_ddp_port_id = - TOKEN_NUM_INITIALIZER(struct cmd_add_ddp_result, port_id, UINT8); -cmdline_parse_token_string_t cmd_add_ddp_filepath = - TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, filepath, NULL); +cmdline_parse_token_string_t cmd_ddp_add_ddp = + TOKEN_STRING_INITIALIZER(struct cmd_ddp_add_result, ddp, "ddp"); +cmdline_parse_token_string_t cmd_ddp_add_add = + TOKEN_STRING_INITIALIZER(struct cmd_ddp_add_result, add, "add"); +cmdline_parse_token_num_t cmd_ddp_add_port_id = + TOKEN_NUM_INITIALIZER(struct cmd_ddp_add_result, port_id, UINT8); +cmdline_parse_token_string_t cmd_ddp_add_filepath = + TOKEN_STRING_INITIALIZER(struct cmd_ddp_add_result, filepath, NULL); static void -cmd_add_ddp_parsed( +cmd_ddp_add_parsed( void *parsed_result, __attribute__((unused)) struct cmdline *cl, __attribute__((unused)) void *data) { - struct cmd_add_ddp_result *res = parsed_result; + struct cmd_ddp_add_result *res = parsed_result; uint8_t *buff; uint32_t size; int ret = -ENOTSUP; @@ -12802,15 +12802,15 @@ cmd_add_ddp_parsed( close_ddp_package_file(buff); } -cmdline_parse_inst_t cmd_add_ddp = { - .f = cmd_add_ddp_parsed, +cmdline_parse_inst_t cmd_ddp_add = { + .f = cmd_ddp_add_parsed, .data = NULL, - .help_str = "add/remove ddp <port_id> <profile_path>", + .help_str = "ddp add <port_id> <profile_path>", .tokens = { - (void *)&cmd_add_ddp_add, - (void *)&cmd_add_ddp_ddp, - (void *)&cmd_add_ddp_port_id, - (void *)&cmd_add_ddp_filepath, + (void *)&cmd_ddp_add_ddp, + (void *)&cmd_ddp_add_add, + (void *)&cmd_ddp_add_port_id, + (void *)&cmd_ddp_add_filepath, NULL, }, }; @@ -13081,7 +13081,7 @@ cmdline_parse_ctx_t main_ctx[] = { (cmdline_parse_inst_t *)&cmd_vf_tc_min_bw, (cmdline_parse_inst_t *)&cmd_vf_tc_max_bw, (cmdline_parse_inst_t *)&cmd_strict_link_prio, - (cmdline_parse_inst_t *)&cmd_add_ddp, + (cmdline_parse_inst_t *)&cmd_ddp_add, (cmdline_parse_inst_t *)&cmd_get_ddp_list, NULL, }; -- 2.5.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] app/testpmd: change command line of loading profile 2017-04-01 7:57 ` [PATCH v2 1/2] app/testpmd: change command line of loading profile Beilei Xing @ 2017-04-01 8:23 ` Lu, Wenzhuo 2017-04-03 12:30 ` Ferruh Yigit 1 sibling, 0 replies; 9+ messages in thread From: Lu, Wenzhuo @ 2017-04-01 8:23 UTC (permalink / raw) To: Xing, Beilei, Wu, Jingjing; +Cc: dev Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing > Sent: Saturday, April 1, 2017 3:57 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/2] app/testpmd: change command line of > loading profile > > This patch changes CLI of loading profile from "add ddp (port_id) > (profile_path)" to "ddp add > (port_id) (profile_path)" which is more consistent with other CLIs. > > Signed-off-by: Beilei Xing <beilei.xing@intel.com> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] app/testpmd: change command line of loading profile 2017-04-01 7:57 ` [PATCH v2 1/2] app/testpmd: change command line of loading profile Beilei Xing 2017-04-01 8:23 ` Lu, Wenzhuo @ 2017-04-03 12:30 ` Ferruh Yigit 1 sibling, 0 replies; 9+ messages in thread From: Ferruh Yigit @ 2017-04-03 12:30 UTC (permalink / raw) To: Beilei Xing, jingjing.wu; +Cc: dev On 4/1/2017 8:57 AM, Beilei Xing wrote: > This patch changes CLI of loading profile from > "add ddp (port_id) (profile_path)" to "ddp add > (port_id) (profile_path)" which is more consistent > with other CLIs. > > Signed-off-by: Beilei Xing <beilei.xing@intel.com> Series squashed into relevant commit in next-net, thanks. (Please double check updated commits.) ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] app/testpmd: change command line of getting profile info 2017-04-01 7:57 ` [PATCH v2 0/2] change command line for ddp Beilei Xing 2017-04-01 7:57 ` [PATCH v2 1/2] app/testpmd: change command line of loading profile Beilei Xing @ 2017-04-01 7:57 ` Beilei Xing 2017-04-01 8:23 ` Lu, Wenzhuo 1 sibling, 1 reply; 9+ messages in thread From: Beilei Xing @ 2017-04-01 7:57 UTC (permalink / raw) To: jingjing.wu; +Cc: dev This patch changes CLI of getting loaded profile info list from "get ddp list (port_id)" to "ddp get list (port_id)" which is more consistent with other CLIs. Signed-off-by: Beilei Xing <beilei.xing@intel.com> --- app/test-pmd/cmdline.c | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 3a448b3..66cd09a 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -215,7 +215,7 @@ static void cmd_help_long_parsed(void *parsed_result, "read txd (port_id) (queue_id) (txd_id)\n" " Display a TX descriptor of a port TX queue.\n\n" - "get ddp list (port_id)\n" + "ddp get list (port_id)\n" " Get ddp profile info list\n\n" ); } @@ -12819,29 +12819,29 @@ cmdline_parse_inst_t cmd_ddp_add = { #define PROFILE_INFO_SIZE 48 #define MAX_PROFILE_NUM 16 -struct cmd_get_ddp_list_result { - cmdline_fixed_string_t get; +struct cmd_ddp_get_list_result { cmdline_fixed_string_t ddp; + cmdline_fixed_string_t get; cmdline_fixed_string_t list; uint8_t port_id; }; -cmdline_parse_token_string_t cmd_get_ddp_list_get = - TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, get, "get"); -cmdline_parse_token_string_t cmd_get_ddp_list_ddp = - TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, ddp, "ddp"); -cmdline_parse_token_string_t cmd_get_ddp_list_list = - TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, list, "list"); -cmdline_parse_token_num_t cmd_get_ddp_list_port_id = - TOKEN_NUM_INITIALIZER(struct cmd_get_ddp_list_result, port_id, UINT8); +cmdline_parse_token_string_t cmd_ddp_get_list_ddp = + TOKEN_STRING_INITIALIZER(struct cmd_ddp_get_list_result, ddp, "ddp"); +cmdline_parse_token_string_t cmd_ddp_get_list_get = + TOKEN_STRING_INITIALIZER(struct cmd_ddp_get_list_result, get, "get"); +cmdline_parse_token_string_t cmd_ddp_get_list_list = + TOKEN_STRING_INITIALIZER(struct cmd_ddp_get_list_result, list, "list"); +cmdline_parse_token_num_t cmd_ddp_get_list_port_id = + TOKEN_NUM_INITIALIZER(struct cmd_ddp_get_list_result, port_id, UINT8); static void -cmd_get_ddp_list_parsed( +cmd_ddp_get_list_parsed( void *parsed_result, __attribute__((unused)) struct cmdline *cl, __attribute__((unused)) void *data) { - struct cmd_get_ddp_list_result *res = parsed_result; + struct cmd_ddp_get_list_result *res = parsed_result; #ifdef RTE_LIBRTE_I40E_PMD struct rte_pmd_i40e_profile_list *p_list; struct rte_pmd_i40e_profile_info *p_info; @@ -12890,15 +12890,15 @@ cmd_get_ddp_list_parsed( printf("Failed to get ddp list\n"); } -cmdline_parse_inst_t cmd_get_ddp_list = { - .f = cmd_get_ddp_list_parsed, +cmdline_parse_inst_t cmd_ddp_get_list = { + .f = cmd_ddp_get_list_parsed, .data = NULL, - .help_str = "get ddp list <port_id>", + .help_str = "ddp get list <port_id>", .tokens = { - (void *)&cmd_get_ddp_list_get, - (void *)&cmd_get_ddp_list_ddp, - (void *)&cmd_get_ddp_list_list, - (void *)&cmd_get_ddp_list_port_id, + (void *)&cmd_ddp_get_list_ddp, + (void *)&cmd_ddp_get_list_get, + (void *)&cmd_ddp_get_list_list, + (void *)&cmd_ddp_get_list_port_id, NULL, }, }; @@ -13082,7 +13082,7 @@ cmdline_parse_ctx_t main_ctx[] = { (cmdline_parse_inst_t *)&cmd_vf_tc_max_bw, (cmdline_parse_inst_t *)&cmd_strict_link_prio, (cmdline_parse_inst_t *)&cmd_ddp_add, - (cmdline_parse_inst_t *)&cmd_get_ddp_list, + (cmdline_parse_inst_t *)&cmd_ddp_get_list, NULL, }; -- 2.5.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] app/testpmd: change command line of getting profile info 2017-04-01 7:57 ` [PATCH v2 2/2] app/testpmd: change command line of getting profile info Beilei Xing @ 2017-04-01 8:23 ` Lu, Wenzhuo 0 siblings, 0 replies; 9+ messages in thread From: Lu, Wenzhuo @ 2017-04-01 8:23 UTC (permalink / raw) To: Xing, Beilei, Wu, Jingjing; +Cc: dev Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing > Sent: Saturday, April 1, 2017 3:57 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/2] app/testpmd: change command line of > getting profile info > > This patch changes CLI of getting loaded profile info list from "get ddp list > (port_id)" to "ddp get list (port_id)" which is more consistent with other CLIs. > > Signed-off-by: Beilei Xing <beilei.xing@intel.com> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-04-03 12:30 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-04-01 6:56 [PATCH 0/2] change command line for ddp Beilei Xing 2017-04-01 6:56 ` [PATCH 1/2] app/testpmd: change command line of loading profile Beilei Xing 2017-04-01 6:56 ` [PATCH 2/2] app/testpmd: change command line of getting profile info Beilei Xing 2017-04-01 7:57 ` [PATCH v2 0/2] change command line for ddp Beilei Xing 2017-04-01 7:57 ` [PATCH v2 1/2] app/testpmd: change command line of loading profile Beilei Xing 2017-04-01 8:23 ` Lu, Wenzhuo 2017-04-03 12:30 ` Ferruh Yigit 2017-04-01 7:57 ` [PATCH v2 2/2] app/testpmd: change command line of getting profile info Beilei Xing 2017-04-01 8:23 ` Lu, Wenzhuo
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.