All of lore.kernel.org
 help / color / mirror / Atom feed
From: dinghao.liu@zju.edu.cn
To: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
Cc: "Chen-Yu Tsai" <wens@csie.org>, "Kangjie Lu" <kjlu@umn.edu>,
	linux-rtc@vger.kernel.org,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Maxime Ripard" <mripard@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: Re: Re: [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init
Date: Sun, 18 Oct 2020 14:00:41 +0800 (GMT+08:00)	[thread overview]
Message-ID: <6ea00d70.3f76.1753a4bb59b.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <20201009205744.GA849573@piout.net>

> On 26/08/2020 16:55:14+0800, dinghao.liu@zju.edu.cn wrote:
> > > On Sun, Aug 23, 2020 at 3:59 PM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
> > > >
> > > > When clk_hw_register_fixed_rate_with_accuracy() fails,
> > > > clk_data should be freed. It's the same for the subsequent
> > > > error paths.
> > > 
> > > I suppose you should also unregister the already registered clocks
> > > in the latter two error paths?
> > > 
> > 
> > Sounds reasonable. But I find that the existing kernel code takes different
> > strategies for this case. of_sama5d4_sckc_setup() uses clk_hw_unregister() 
> > after clk_hw_register_fixed_rate_with_accuracy(), while _of_fixed_clk_setup()
> > uses clk_hw_unregister_fixed_rate(). But at91sam926x_pmc_setup() just does
> > nothing in this case.
> 
> I guess you should use clk_hw_unregister_fixed_rate after
> clk_hw_register_fixed_rate_with_accuracy. clk_hw_unregister will leak
> the struct clk_fixed_rate. It doesn't matter too much for
> of_sama5d4_sckc_setup and at91sam926x_pmc_setup because if th clock
> can't be registered, the platform will not boot.

Thank you for your advice! I will submit a new patch soon.

Regards,
Dinghao


WARNING: multiple messages have this Message-ID (diff)
From: dinghao.liu@zju.edu.cn
To: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Kangjie Lu <kjlu@umn.edu>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: Re: Re: [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init
Date: Sun, 18 Oct 2020 14:00:41 +0800 (GMT+08:00)	[thread overview]
Message-ID: <6ea00d70.3f76.1753a4bb59b.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <20201009205744.GA849573@piout.net>

> On 26/08/2020 16:55:14+0800, dinghao.liu@zju.edu.cn wrote:
> > > On Sun, Aug 23, 2020 at 3:59 PM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
> > > >
> > > > When clk_hw_register_fixed_rate_with_accuracy() fails,
> > > > clk_data should be freed. It's the same for the subsequent
> > > > error paths.
> > > 
> > > I suppose you should also unregister the already registered clocks
> > > in the latter two error paths?
> > > 
> > 
> > Sounds reasonable. But I find that the existing kernel code takes different
> > strategies for this case. of_sama5d4_sckc_setup() uses clk_hw_unregister() 
> > after clk_hw_register_fixed_rate_with_accuracy(), while _of_fixed_clk_setup()
> > uses clk_hw_unregister_fixed_rate(). But at91sam926x_pmc_setup() just does
> > nothing in this case.
> 
> I guess you should use clk_hw_unregister_fixed_rate after
> clk_hw_register_fixed_rate_with_accuracy. clk_hw_unregister will leak
> the struct clk_fixed_rate. It doesn't matter too much for
> of_sama5d4_sckc_setup and at91sam926x_pmc_setup because if th clock
> can't be registered, the platform will not boot.

Thank you for your advice! I will submit a new patch soon.

Regards,
Dinghao

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-10-18  6:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-23  7:58 [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init Dinghao Liu
2020-08-23  7:58 ` Dinghao Liu
2020-08-25 14:51 ` Chen-Yu Tsai
2020-08-25 14:51   ` Chen-Yu Tsai
2020-08-26  8:55   ` dinghao.liu
2020-08-26  8:55     ` dinghao.liu
2020-10-09 20:57     ` Alexandre Belloni
2020-10-09 20:57       ` Alexandre Belloni
2020-10-18  6:00       ` dinghao.liu [this message]
2020-10-18  6:00         ` dinghao.liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ea00d70.3f76.1753a4bb59b.Coremail.dinghao.liu@zju.edu.cn \
    --to=dinghao.liu@zju.edu.cn \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=kjlu@umn.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.